generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
4,861 Commits 1 Branch 0 Tags 108 MiB
C++ 76%
C 16%
Python 2.3%
Java 2.1%
Objective-C++ 1.5%
Other 1.9%
4723dc88b3
Go to file
kjellander@webrtc.org 4723dc88b3 Revert 5511 "Revert 5510 "Disable failing libjingle_p2p_unittest..." 
So, the test apparently failed right away at 

http://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/1224/steps/libjingle_p2p_unittest/logs/stdio


> Revert 5510 "Disable failing libjingle_p2p_unittest test on Linux"
> 
> According to https://code.google.com/p/webrtc/issues/detail?id=2907#c2
> r5505 was committed to resolve exactly these flakes.
> Let's revert the disabling and see.
> 
> BUG=2907
> TBR=mallinath@webrtc.org
> 
> > Disable failing libjingle_p2p_unittest test on Linux
> > 
> > I realize this diables 84 test cases and for all platforms, which
> > I'm not really comfortable with. I tried finding a better way but
> > couldn't without doing significant changes to the file.
> > I think the tests either needs to be fixed or otherwise refactored
> > in order to make more fine-grained disabling possible.
> > 
> > Another (too) large disabling was done by holmer@ in
> > https://webrtc-codereview.appspot.com/2227004 where he should only have
> > disabled them on Windows, if the failures in webrtc:2383 was all that
> > caused those flakes.
> > 
> > BUG=2907
> > TEST=Verified this ran 0 tests:
> > out/Release/libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest.TestNAT_ADDR_RESTRICTEDToNAT_PORT_RESTRICTEDAsGiceBothSharedUfragWithMinimumStepDelay
> > TBR=wu@webrtc.org
> > 
> > Review URL: https://webrtc-codereview.appspot.com/8309004
> 
> TBR=kjellander@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/8329004

TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8339004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5513 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-09 18:48:56 +00:00
data Enables robust delay validation in AEC delay logging. 2014-01-13 08:54:34 +00:00
resources Add trace-based delivery filter to BWE test framework. 2014-01-24 10:00:27 +00:00
samples/js Updated demos so they work on FF, the createOffer api cannot have null parameters according to spec. Same applies to createAnswer. 2014-02-07 19:08:38 +00:00
talk Revert 5511 "Revert 5510 "Disable failing libjingle_p2p_unittest..." 2014-02-09 18:48:56 +00:00
third_party Document updating gflags and remove code duplication. 2013-08-20 16:17:10 +00:00
tools Suppressions for libjingle_unittest after roll in r5502 2014-02-08 21:15:59 +00:00
webrtc Roll chromium_revision 245382:249215 2014-02-09 18:38:31 +00:00
.clang-format Style-option file for clang-format. 2013-11-25 15:30:37 +00:00
.gitignore gitignore: ignore webrtc android demo apps build artifacts, and sort list 2014-02-08 01:05:45 +00:00
all.gyp Complete rewrite of demo application. 2013-12-12 16:55:37 +00:00
android-webrtc.mk Changed a flag in ARM build for platform build. 2012-09-08 00:32:59 +00:00
Android.mk Added buildbot benchmarking in iSAC and APM into Android platform build. 2012-12-07 15:26:28 +00:00
AUTHORS Add Christophe Dumez to AUTHORS. 2014-01-06 19:43:21 +00:00
BUILD.gn Roll Chromium 238260 -> 243863 2014-01-14 17:48:34 +00:00
codereview.settings Add a root codereview.settings file. 2013-04-24 02:08:50 +00:00
COPYING Libjingle in webrtc needs updated AUTHORS, COPYING, LICENSE_THIRD_PARTY AND README. 2013-07-16 18:04:56 +00:00
DEPS Roll chromium_revision 245382:249215 2014-02-09 18:38:31 +00:00
drover.properties Add a drover.properties file for reference. 2013-05-30 18:15:54 +00:00
libvpx.mk Change android makefile to reflect recent file structure change 2011-07-13 17:49:49 +00:00
LICENSE Updated license path in LICENSE and LICENSE_THIRD_PARTY. 2012-11-22 12:06:21 +00:00
license_template.txt Update template to follow chromium copyright style 2013-04-24 01:01:28 +00:00
LICENSE_THIRD_PARTY Libjingle in webrtc needs updated AUTHORS, COPYING, LICENSE_THIRD_PARTY AND README. 2013-07-16 18:04:56 +00:00
OWNERS Android, OpenSlDemo: moved to webrtc/examples/android/opensl_loopback 2014-01-17 23:12:51 +00:00
PATENTS Add references to src/ copies for LICENSE etc. 2011-10-26 01:05:07 +00:00
PRESUBMIT.py Enable Android APK trybots by default. 2014-01-27 16:08:43 +00:00
WATCHLISTS Add qiang.lu@intel.com to WATCHLISTS. 2013-10-25 19:20:02 +00:00