generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
372ae83228
webrtc/talk/p2p/base
History
mallinath@webrtc.org 54fd70046d Remove ASSERT in TransportChannelProxy::SetImplementation, when 
proxy already set to same transport channel impl.

Since session can call SetImplementation multiple times with or without BUNDLE, there are cases when SetImplementation is called with same impl (OnRemoteCandidates/PushdownTransportDescription/SetupMux). Also variables in
cricket::TransportProxy like |connecting_| and |negotiated_| are accessed
both between worker thread and signaling threads (which calls for bigger change
on how session interacts with Transport and TransportChannelProxy). I have a created a separate bug to address later issue.

Also if single thread used as worker and signaling thread, we can end up
calling SetLocalDescription and OnRemoteCandidates in same call sequence, which
will end up calling SetImplementation twice.

R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12019007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5944 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-19 01:03:33 +00:00
..
asyncstuntcpsocket_unittest.cc Update talk to 61549749. 2014-02-14 00:56:12 +00:00
asyncstuntcpsocket.cc Remove std:: prefixes from C functions in talk/. 2014-03-07 15:22:04 +00:00
asyncstuntcpsocket.h Update talk to 61549749. 2014-02-14 00:56:12 +00:00
basicpacketsocketfactory.cc Update talk to 56619788 2013-11-13 22:48:52 +00:00
basicpacketsocketfactory.h Update talk to 56619788 2013-11-13 22:48:52 +00:00
candidate.h Remove std:: prefixes from C functions in talk/. 2014-03-07 15:22:04 +00:00
common.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
constants.cc Cleanups in libjingle to make it compile with chromium_code=1 2014-03-25 00:31:35 +00:00
constants.h Update talk to 51314459 2013-08-23 23:21:25 +00:00
dtlstransport.h Update libjingle to 59676287 2014-01-15 23:15:54 +00:00
dtlstransportchannel_unittest.cc Update talk to 61549749. 2014-02-14 00:56:12 +00:00
dtlstransportchannel.cc (Auto)update libjingle 64585415-> 64594651 2014-04-09 06:06:38 +00:00
dtlstransportchannel.h Update talk to 61549749. 2014-02-14 00:56:12 +00:00
fakesession.h Update talk to 61549749. 2014-02-14 00:56:12 +00:00
p2ptransport.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
p2ptransport.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
p2ptransportchannel_unittest.cc In shared socket mode, use udp port as default receiver even if 2014-04-15 01:10:58 +00:00
p2ptransportchannel.cc (Auto)update libjingle 63948945-> 64147530 2014-04-01 17:44:24 +00:00
p2ptransportchannel.h (Auto)update libjingle 63948945-> 64147530 2014-04-01 17:44:24 +00:00
packetsocketfactory.h Update talk to 56619788 2013-11-13 22:48:52 +00:00
parsing.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
parsing.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
port_unittest.cc (Auto)update libjingle 64709629-> 64813990 2014-04-14 16:06:21 +00:00
port.cc (Auto)update libjingle 64709629-> 64813990 2014-04-14 16:06:21 +00:00
port.h (Auto)update libjingle 64709629-> 64813990 2014-04-14 16:06:21 +00:00
portallocator.cc Update talk folder to revision=49952949 2013-07-26 19:17:59 +00:00
portallocator.h pRevert 5371 "Revert 5367 "Update talk to 59410372."" 2014-01-14 10:00:58 +00:00
portallocatorsessionproxy_unittest.cc Fix memory leak in portallocatorsessionproxy_unittest. 2013-08-20 21:14:39 +00:00
portallocatorsessionproxy.cc Update talk folder to revision=49713299. 2013-07-22 21:07:49 +00:00
portallocatorsessionproxy.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
portinterface.h Update talk to 61549749. 2014-02-14 00:56:12 +00:00
portproxy.cc Update talk to 61549749. 2014-02-14 00:56:12 +00:00
portproxy.h Update talk to 61549749. 2014-02-14 00:56:12 +00:00
pseudotcp_unittest.cc Update talk folder to revision=49952949 2013-07-26 19:17:59 +00:00
pseudotcp.cc Cleanups in libjingle to make it compile with chromium_code=1 2014-03-25 00:31:35 +00:00
pseudotcp.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
rawtransport.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
rawtransport.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
rawtransportchannel.cc Update talk to 61549749. 2014-02-14 00:56:12 +00:00
rawtransportchannel.h Update talk to 61549749. 2014-02-14 00:56:12 +00:00
relayport_unittest.cc Switching to NSS random number generator and adding init method to unittests. 2014-02-07 23:22:00 +00:00
relayport.cc (Auto)update libjingle 64709629-> 64813990 2014-04-14 16:06:21 +00:00
relayport.h Update talk to 61549749. 2014-02-14 00:56:12 +00:00
relayserver_unittest.cc Remove std:: prefixes from C functions in talk/. 2014-03-07 15:22:04 +00:00
relayserver.cc Remove std:: prefixes from C functions in talk/. 2014-03-07 15:22:04 +00:00
relayserver.h Update talk to 58127566 together with 2013-12-13 00:21:03 +00:00
session_unittest.cc (Auto)update libjingle 64247466-> 64326665 2014-04-04 18:39:07 +00:00
session.cc (Auto)update libjingle 64585415-> 64594651 2014-04-09 06:06:38 +00:00
session.h (Auto)update libjingle 64585415-> 64594651 2014-04-09 06:06:38 +00:00
sessionclient.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
sessiondescription.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
sessiondescription.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
sessionid.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
sessionmanager.cc Update talk to 52534915. 2013-09-19 05:49:50 +00:00
sessionmanager.h * Update libjingle to 50389769. 2013-08-05 20:36:57 +00:00
sessionmessages.cc Update talk to 51314459 2013-08-23 23:21:25 +00:00
sessionmessages.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
stun_unittest.cc (Auto)update libjingle 64247466-> 64326665 2014-04-04 18:39:07 +00:00
stun.cc Remove std:: prefixes from C functions in talk/. 2014-03-07 15:22:04 +00:00
stun.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
stunport_unittest.cc (Auto)update libjingle 64709629-> 64813990 2014-04-14 16:06:21 +00:00
stunport.cc (Auto)update libjingle 64709629-> 64813990 2014-04-14 16:06:21 +00:00
stunport.h Update talk to 61549749. 2014-02-14 00:56:12 +00:00
stunrequest_unittest.cc Switching to NSS random number generator and adding init method to unittests. 2014-02-07 23:22:00 +00:00
stunrequest.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
stunrequest.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
stunserver_unittest.cc Remove std:: prefixes from C functions in talk/. 2014-03-07 15:22:04 +00:00
stunserver.cc Update talk to 61549749. 2014-02-14 00:56:12 +00:00
stunserver.h Update talk to 58127566 together with 2013-12-13 00:21:03 +00:00
tcpport.cc (Auto)update libjingle 64709629-> 64813990 2014-04-14 16:06:21 +00:00
tcpport.h Update talk to 61549749. 2014-02-14 00:56:12 +00:00
testrelayserver.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
teststunserver.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
testturnserver.h Update libjingle to 55618622. 2013-10-25 21:18:33 +00:00
transport_unittest.cc (Auto)update libjingle 62713454-> 62865357 2014-03-10 15:53:12 +00:00
transport.cc Silence pointless LS_WARNING about port 0 for active-only candidates. 2014-03-28 18:13:34 +00:00
transport.h (Auto)update libjingle 62713454-> 62865357 2014-03-10 15:53:12 +00:00
transportchannel.cc Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
transportchannel.h Update talk to 61549749. 2014-02-14 00:56:12 +00:00
transportchannelimpl.h Update talk to 61549749. 2014-02-14 00:56:12 +00:00
transportchannelproxy.cc Remove ASSERT in TransportChannelProxy::SetImplementation, when 2014-04-19 01:03:33 +00:00
transportchannelproxy.h Update talk to 61549749. 2014-02-14 00:56:12 +00:00
transportdescription.cc Update talk to 54527154. 2013-10-13 17:18:27 +00:00
transportdescription.h Update talk to 54527154. 2013-10-13 17:18:27 +00:00
transportdescriptionfactory_unittest.cc Update talk to 54527154. 2013-10-13 17:18:27 +00:00
transportdescriptionfactory.cc Update talk to 54527154. 2013-10-13 17:18:27 +00:00
transportdescriptionfactory.h Update talk to 54527154. 2013-10-13 17:18:27 +00:00
transportinfo.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00
turnport_unittest.cc (Auto)update libjingle 65055925-> 65086785 2014-04-17 00:04:39 +00:00
turnport.cc (Auto)update libjingle 65152644-> 65219629 2014-04-19 00:00:31 +00:00
turnport.h (Auto)update libjingle 64709629-> 64813990 2014-04-14 16:06:21 +00:00
turnserver.cc (Auto)update libjingle 64247466-> 64326665 2014-04-04 18:39:07 +00:00
turnserver.h Update talk to 58127566 together with 2013-12-13 00:21:03 +00:00
udpport.h Adds trunk/talk folder of revision 359 from libjingles google code to 2013-07-10 00:45:36 +00:00