bf395c1fc0
If built-in Echo Cancellation is available on a device it is automatically enabled. The reason is that it in most cases performs better than the WebRTC software echo control for mobile. The drawback is that we can not develop, test and rollout the delay agnostic AEC (DA-AEC) on Android as for desktops. This CL includes - adding a media constraint to enable/disable DA-AEC. - automatically turning on echo cancellation if DA-AEC is enabled. - a fix in the AEC that enables delay estimation when DA-AEC is enabled, but delay metrics is disabled. - sets the Config struct ReportedDelay, which controls DA-AEC internally in the AEC. The test code to verify that it works in AppRTCDemo can be found here: https://webrtc-codereview.appspot.com/50479004/ BUG=4472 TESTED=locally on N7, N6, Android One R=glaznev@webrtc.org, perkj@webrtc.org Review URL: https://webrtc-codereview.appspot.com/48699004 Cr-Commit-Position: refs/heads/master@{#8861}
130 lines
5.2 KiB
C++
130 lines
5.2 KiB
C++
/*
|
|
* libjingle
|
|
* Copyright 2013 Google Inc.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright notice,
|
|
* this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright notice,
|
|
* this list of conditions and the following disclaimer in the documentation
|
|
* and/or other materials provided with the distribution.
|
|
* 3. The name of the author may not be used to endorse or promote products
|
|
* derived from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
|
|
* WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
|
|
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO
|
|
* EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
|
|
* PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
|
|
* OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
|
|
* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
|
|
* OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
|
|
* ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "talk/app/webrtc/localaudiosource.h"
|
|
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
#include "talk/app/webrtc/test/fakeconstraints.h"
|
|
#include "talk/media/base/fakemediaengine.h"
|
|
#include "talk/media/base/fakevideorenderer.h"
|
|
#include "talk/media/devices/fakedevicemanager.h"
|
|
#include "webrtc/base/gunit.h"
|
|
|
|
using webrtc::LocalAudioSource;
|
|
using webrtc::MediaConstraintsInterface;
|
|
using webrtc::MediaSourceInterface;
|
|
using webrtc::PeerConnectionFactoryInterface;
|
|
|
|
TEST(LocalAudioSourceTest, SetValidOptions) {
|
|
webrtc::FakeConstraints constraints;
|
|
constraints.AddMandatory(MediaConstraintsInterface::kEchoCancellation, false);
|
|
constraints.AddOptional(
|
|
MediaConstraintsInterface::kExperimentalEchoCancellation, true);
|
|
constraints.AddOptional(
|
|
MediaConstraintsInterface::kDAEchoCancellation, false);
|
|
constraints.AddOptional(MediaConstraintsInterface::kAutoGainControl, true);
|
|
constraints.AddOptional(
|
|
MediaConstraintsInterface::kExperimentalAutoGainControl, true);
|
|
constraints.AddMandatory(MediaConstraintsInterface::kNoiseSuppression, false);
|
|
constraints.AddOptional(MediaConstraintsInterface::kHighpassFilter, true);
|
|
|
|
rtc::scoped_refptr<LocalAudioSource> source =
|
|
LocalAudioSource::Create(PeerConnectionFactoryInterface::Options(),
|
|
&constraints);
|
|
|
|
bool value;
|
|
EXPECT_TRUE(source->options().echo_cancellation.Get(&value));
|
|
EXPECT_FALSE(value);
|
|
EXPECT_TRUE(source->options().experimental_aec.Get(&value));
|
|
EXPECT_TRUE(value);
|
|
EXPECT_TRUE(source->options().delay_agnostic_aec.Get(&value));
|
|
EXPECT_FALSE(value);
|
|
EXPECT_TRUE(source->options().auto_gain_control.Get(&value));
|
|
EXPECT_TRUE(value);
|
|
EXPECT_TRUE(source->options().experimental_agc.Get(&value));
|
|
EXPECT_TRUE(value);
|
|
EXPECT_TRUE(source->options().noise_suppression.Get(&value));
|
|
EXPECT_FALSE(value);
|
|
EXPECT_TRUE(source->options().highpass_filter.Get(&value));
|
|
EXPECT_TRUE(value);
|
|
}
|
|
|
|
TEST(LocalAudioSourceTest, OptionNotSet) {
|
|
webrtc::FakeConstraints constraints;
|
|
rtc::scoped_refptr<LocalAudioSource> source =
|
|
LocalAudioSource::Create(PeerConnectionFactoryInterface::Options(),
|
|
&constraints);
|
|
bool value;
|
|
EXPECT_FALSE(source->options().highpass_filter.Get(&value));
|
|
}
|
|
|
|
TEST(LocalAudioSourceTest, MandatoryOverridesOptional) {
|
|
webrtc::FakeConstraints constraints;
|
|
constraints.AddMandatory(MediaConstraintsInterface::kEchoCancellation, false);
|
|
constraints.AddOptional(MediaConstraintsInterface::kEchoCancellation, true);
|
|
|
|
rtc::scoped_refptr<LocalAudioSource> source =
|
|
LocalAudioSource::Create(PeerConnectionFactoryInterface::Options(),
|
|
&constraints);
|
|
|
|
bool value;
|
|
EXPECT_TRUE(source->options().echo_cancellation.Get(&value));
|
|
EXPECT_FALSE(value);
|
|
}
|
|
|
|
TEST(LocalAudioSourceTest, InvalidOptional) {
|
|
webrtc::FakeConstraints constraints;
|
|
constraints.AddOptional(MediaConstraintsInterface::kHighpassFilter, false);
|
|
constraints.AddOptional("invalidKey", false);
|
|
|
|
rtc::scoped_refptr<LocalAudioSource> source =
|
|
LocalAudioSource::Create(PeerConnectionFactoryInterface::Options(),
|
|
&constraints);
|
|
|
|
EXPECT_EQ(MediaSourceInterface::kLive, source->state());
|
|
bool value;
|
|
EXPECT_TRUE(source->options().highpass_filter.Get(&value));
|
|
EXPECT_FALSE(value);
|
|
}
|
|
|
|
TEST(LocalAudioSourceTest, InvalidMandatory) {
|
|
webrtc::FakeConstraints constraints;
|
|
constraints.AddMandatory(MediaConstraintsInterface::kHighpassFilter, false);
|
|
constraints.AddMandatory("invalidKey", false);
|
|
|
|
rtc::scoped_refptr<LocalAudioSource> source =
|
|
LocalAudioSource::Create(PeerConnectionFactoryInterface::Options(),
|
|
&constraints);
|
|
|
|
EXPECT_EQ(MediaSourceInterface::kLive, source->state());
|
|
bool value;
|
|
EXPECT_TRUE(source->options().highpass_filter.Get(&value));
|
|
EXPECT_FALSE(value);
|
|
}
|