Commit Graph

49 Commits

Author SHA1 Message Date
andrew@webrtc.org
114c790be7 Remove character limit in WriteText().
- vfprintf can be used directly here, removing the need for the interim
  buffer. This change allows us to remove the artificial character limit.
- Fix bugs with _text. It wasn't actually getting set earlier, and the
  check was wrong.
- Remove asserts that should use real error checks.

TEST=DataLog and VoECallReport (through voe_auto_test), the only users of WriteText().

Review URL: http://webrtc-codereview.appspot.com/323001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1156 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-10 02:33:33 +00:00
henrike@webrtc.org
2f47b5a70f Fixes a build error when disabling trace (which is done when building with chrome flag is set).
Review URL: http://webrtc-codereview.appspot.com/318006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1155 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-10 00:44:47 +00:00
henrike@webrtc.org
315282c01a Fixes a compiler warning related to dynamically allocated static memory. the fix is to leak the memory since the OS will clean it up anyways. This will not add noise to memory tools so it's ok. The issue is reported here: http://code.google.com/p/webrtc/issues/detail?id=147.
Review URL: http://webrtc-codereview.appspot.com/267023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1150 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 17:46:20 +00:00
mflodman@webrtc.org
b19582b7dc Add pointer constructor to CriticalSectionScoped.
Mainly added to simplyfy the code, e.g. when having critsect as scoped_ptr in classes.

Review URL: http://webrtc-codereview.appspot.com/302005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1144 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 10:02:16 +00:00
kma@webrtc.org
b59c031660 For Android ARMv7 platforms, added a feature of dynamically detecting the existence of Neon,
and when it's present, switch to some functions optimized for Neon at run time.
Review URL: http://webrtc-codereview.appspot.com/268002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1096 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-03 18:34:50 +00:00
henrike@webrtc.org
c2ac8953d5 Fixes Valgrind warnings in system wrappers unittest.
Review URL: http://webrtc-codereview.appspot.com/293006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1071 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 22:46:59 +00:00
henrike@webrtc.org
0bf2ca2eed Fixes broken unit test http://code.google.com/p/webrtc/issues/detail?id=154
Review URL: http://webrtc-codereview.appspot.com/292007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1053 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 18:21:46 +00:00
kjellander@webrtc.org
c625c1010a Updated system_wrappers_unittests to use the test_support_main target.
Review URL: http://webrtc-codereview.appspot.com/291012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1048 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 12:11:06 +00:00
henrike@webrtc.org
ce9d89d892 Fixes linux build error introduced in r980.
Review URL: http://webrtc-codereview.appspot.com/279012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@981 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-19 00:14:37 +00:00
henrike@webrtc.org
ad98a3eed0 Fixes TEST crash triggered by webrtc-codereview.appspot.com/268014.
Review URL: http://webrtc-codereview.appspot.com/280005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@980 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-18 23:55:12 +00:00
henrike@webrtc.org
3798ecb25b Made CPU initialization on Windows lazy to prevent long startup time.
Review URL: http://webrtc-codereview.appspot.com/268014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@977 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-18 16:25:54 +00:00
tommi@webrtc.org
cde1e7f42a Use a TraceNoop instance when tracing disabled (to be used in Chromium).
I'm also adding an empty implementation for static methods in the Trace
interface since the default implementation relies on TraceImpl.
Review URL: http://webrtc-codereview.appspot.com/267013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@946 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-15 12:23:36 +00:00
tommi@webrtc.org
ded85f14ef Enable WEBRTC_NO_TRACE for Chromium builds.
I'm also fixing WEBRTC_TRACE so that it won't break the build but on Linux I had to do something non traditional as is explained in the comments.
Review URL: http://webrtc-codereview.appspot.com/269012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@939 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-14 09:39:31 +00:00
kma@webrtc.org
b61c410347 Fixed a couple of Android makefiles to let voe and vie build properly.
Review URL: http://webrtc-codereview.appspot.com/278001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@928 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-10 18:10:25 +00:00
henrikg@webrtc.org
c58ef08da2 Removes system CPU measurement for Chrome build.
It does not work on Chrome Windows, and is anyway not needed for Chrome.
Review URL: http://webrtc-codereview.appspot.com/243006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@902 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-08 08:44:17 +00:00
andrew@webrtc.org
f1a45d77fb Add missing <stdlib.h> to data_log test.
BUG=
TEST=system_wrappers_unittests

Review URL: http://webrtc-codereview.appspot.com/256002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@851 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-31 21:44:54 +00:00
kjellander@webrtc.org
84736882ad Fixing system_wrappers unittests.
Not complete, but enough to include them in the build again.

Review URL: http://webrtc-codereview.appspot.com/241008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@848 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-31 20:44:24 +00:00
kjellander@webrtc.org
177bb523bd Fixing system_wrappers unittests.
Not complete, but enough to include them in the build again.

Review URL: http://webrtc-codereview.appspot.com/241008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@842 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-31 17:10:01 +00:00
henrike@webrtc.org
0d0037c2fd Return cached data instead of sleeping in CpuWrapperMac (shaves 2s off WebrtcMediaEngine creation time on Mac).
Review URL: http://webrtc-codereview.appspot.com/226005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@804 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-24 15:48:14 +00:00
phoglund@webrtc.org
c63f788e0f Added fake camera, rewrote one test to use it.
Wrote a "file capture device" which is a kind of fake capture device. It reads a YUV file from disk and pretends that it is what the "camera" is seeing. This makes is possible to run tests based on video input without having an actual physical camera. This is good because physical cameras are quite unreliable.

Rewrote the standard mirrored preview loopback test so it can use the new file capture device. The old "classic" test is preserved. I tried to minimize duplication between the classic test case and the new one, which turned out to be quite painful.

There are some rough edges left in in the code. Suggested improvements is to get rid of the error counting mechanism since the code seems to assume that TestError invocations cause hard asserts anyway. The code will segfault for certain errors if the hard asserts doesn't happen, which means the error counting mechanism is unnecessary. This, by the way, could be a problem for the new test since it doesn't cause hard asserts.

Fixed comments for the thread wrapper and the external capture device interface.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/224003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@801 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-24 13:20:09 +00:00
henrik.lundin@webrtc.org
5dedd0ee38 Handling of white-space in DataLog::Combine
The Combine method cannot handle white-space. Adding a comment to
the header file saying this, and modifying the unittests. Also,
adding a new unittest to test the method.

Review URL: http://webrtc-codereview.appspot.com/217001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@760 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-18 05:45:08 +00:00
henrike@webrtc.org
a0258defd4 Fixes test build errors (warnings treated as errors) in system_wrappers.
Review URL: http://webrtc-codereview.appspot.com/212003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@725 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-11 14:49:27 +00:00
henrik.lundin@webrtc.org
26c9ff983e Add dummy implementation of DataLog::Combine method
The dummy implementations of class methods are needed when
building without support for data logging (i.e., when
enable_data_logging != 1). The Combine method was missing
from data_log_dummy.cc.

Review URL: http://webrtc-codereview.appspot.com/220003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@724 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-11 14:43:41 +00:00
henrik.lundin@webrtc.org
1843664f2a DataLog: Changing from common_types to typedefs
The file common_types.h cannot be used in data_log_c.h, since
the latter is a pure C header file, and common_types.h is
not. Changing to typedefs.h instead.

Review URL: http://webrtc-codereview.appspot.com/216001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@719 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-10 09:56:52 +00:00
tommi@webrtc.org
c0b2250b20 Fix the Windows build.
Review URL: http://webrtc-codereview.appspot.com/213004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@717 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-10 08:43:33 +00:00
henrik.lundin@webrtc.org
d855bd4d6f C wrapper for DataLog class
A pure C wrapper for the DataLog class was created. Since templates
are not supported in C, the InsertCell method of the DataLog class
must be wrapped using one wrapper function for each data type. So far,
the wrapper includes int, float, double, Word32, UWord32, and Word64.

Unittests were created for the wrapper. A separate helper file was
included in the tests. This helper file was implemented as a C file,
in order to actually test the C linkage of the wrapper.
The unittests for DataLog were cloned to make versions that do the same
things but through the C wrapper interface. Restructured the code
so that the log file verification was not duplicated.

Review URL: http://webrtc-codereview.appspot.com/195003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@715 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-10 08:06:17 +00:00
henrike@webrtc.org
1a2933c71a Fixes a Valgrind warning triggering when the number of pending messages hit the limit.
Review URL: http://webrtc-codereview.appspot.com/200002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@705 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-06 17:55:56 +00:00
kjellander@webrtc.org
9e7774f163 Added compare methods for TickInterval class.
This is useful to be able to sort them using the STL algorithm library.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/173002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@639 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 11:33:31 +00:00
andrew@webrtc.org
a3c6d61c44 Integrate the built-in WASAPI AEC DMO to VoE.
Review URL: http://webrtc-codereview.appspot.com/108006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@592 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-13 17:17:49 +00:00
stefan@webrtc.org
3bbe41aad6 Add support for a numeric table id in DataLogs.
Useful when logging in modules which have multiple instances and the logs
should be separated into different tables.
Review URL: http://webrtc-codereview.appspot.com/132003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@555 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-07 15:31:03 +00:00
perkj@google.com
88a0da8fde Add ref_count.h to gyp file.
Review URL: http://webrtc-codereview.appspot.com/133013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@520 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 12:51:35 +00:00
perkj@google.com
9de5917776 Add an implementation of reference count to webrtc.
Used for instantiating objects of RefCountModule.
Review URL: http://webrtc-codereview.appspot.com/135009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@519 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 12:24:51 +00:00
stefan@webrtc.org
c9cff24ff0 Adding classes to be used for logging data within the engines and the
components for offline processing. Data logged with these classes can
conveniently be parsed and processed with e.g. Matlab.
Review URL: http://webrtc-codereview.appspot.com/95009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@477 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 07:39:02 +00:00
hellner@google.com
23a8065e36 Fixed broken build due to r453.
Review URL: http://webrtc-codereview.appspot.com/131004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@455 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-25 21:40:11 +00:00
zakkhoyt@google.com
59af6f1434 Porting Mac keypress detection from GIPS repository.
Mac keypress detection was added specifically for GTalk.
Review URL: http://webrtc-codereview.appspot.com/124001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@453 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-25 20:30:25 +00:00
wu@webrtc.org
ae53bf87d7 The variable ‘dummy’ set but not used being treated as errors in Fedora.
Review URL: http://webrtc-codereview.appspot.com/122004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@425 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 18:56:56 +00:00
hellner@google.com
aab69a4145 removed trailing whitespaces.
Review URL: http://webrtc-codereview.appspot.com/109010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@386 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-16 23:17:32 +00:00
hellner@google.com
064a8dfaa2 Minimal fixes to remove build warnings.
Review URL: http://webrtc-codereview.appspot.com/113004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@376 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-16 15:52:28 +00:00
wu@webrtc.org
3d48d5b107 Bug fix. When GetNumCores failed it will return -1, which is a huge number if cast to unsigned int.
Review URL: http://webrtc-codereview.appspot.com/116005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@371 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-16 00:03:36 +00:00
andrew@webrtc.org
8910f278c5 Switch to webrtc.org accounts (for those which exist).
Review URL: http://webrtc-codereview.appspot.com/97010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@342 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-10 05:16:31 +00:00
xians@google.com
8706256eac exclude the test target from building with chromiurm.
Review URL: http://webrtc-codereview.appspot.com/89016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@323 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-08 12:08:15 +00:00
leozwang@google.com
79835d1bd3 Clean up Android.mk
Review URL: http://webrtc-codereview.appspot.com/92014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@315 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-05 21:01:02 +00:00
ajm@google.com
ce7c2a231e Add SSE2 support for Windows.
The previous defines controlling SSE2 use assumed GCC. To fix this:
- Import a chunk of defines to typedefs.h from Chrome's build_config.h, primarily to get WEBRTC_ARCH_X86_FAMILY.
- Add a check derived from WebP to define WEBRTC_USE_SSE2.
- Modify cpu_features.cc to work with MSVC. This code is borrowed from chrome/src/base/cpu.cc.
- Change AEC defines to use WEBRTC_USE_SSE2.
- Remove disable_sse2 check from aec.gyp. This is handled by WEBRTC_USE_SSE2.

(Also remove a bit of unused code from aec_core.h)
Review URL: http://webrtc-codereview.appspot.com/95008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@299 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-04 01:50:00 +00:00
ajm@google.com
b5c49ff8af Rename all files/classes shared by Linux and Mac to Posix.
Besides being a good idea in general, this lets us use the good chromium_code==1 warning settings on Mac and Windows. Straight rename except for a change to use os_posix in the gyp files.
Review URL: http://webrtc-codereview.appspot.com/88011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@282 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-01 17:04:04 +00:00
leozwang@google.com
b352700ff7 Clean up ANDROID macro definitions [system_wrapper]
Review URL: http://webrtc-codereview.appspot.com/94001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@257 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-26 17:29:38 +00:00
ajm@google.com
825e063a78 Fixing some warnings in system_wrappers.
Review URL: http://webrtc-codereview.appspot.com/79001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@220 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-16 01:04:52 +00:00
hellner@google.com
fe176fa45a Removed DISALLOW_* macros from the system_wrappers interface files.
Review URL: http://webrtc-codereview.appspot.com/69003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@206 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-14 15:43:02 +00:00
hellner@google.com
52144776d9 Fixed valgrind warning in system wrappers unittest.
Review URL: http://webrtc-codereview.appspot.com/61006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@180 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-07 16:47:40 +00:00
niklase@google.com
470e71d364 git-svn-id: http://webrtc.googlecode.com/svn/trunk@156 4adac7df-926f-26a2-2b94-8c16560cd09d 2011-07-07 08:21:25 +00:00