Commit Graph

3 Commits

Author SHA1 Message Date
kjellander@webrtc.org
f8c16b8bf4 Disabling CondVarTest for TSan v2 (take 2)
This test goes into an eternal loop sometimes when run under
TSan v2, therefore I'm disabling it until this is resolved.
Doing that, the TSan v2 bot in our new WebRTC FYI waterfall at
http://build.chromium.org/p/client.webrtc.fyi/waterfall
will hopefully go green.

The define used only exists for TSan v2, so v1 should be
unaffected.

The suppression added in http://review.webrtc.org/2126005/
turns out actually has no effect, so I'm removing it again.
It's probably useless since TSan v2 obviously alters the code's
behavior, causing these errors. Since the errors are not TSan v2
failures, the suppression has no effect.

BUG=2259
TEST=test passing locally when run as described in 2259 (since
no tests are run).

R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2115005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4639 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-29 09:47:18 +00:00
kjellander@webrtc.org
5f8d05add2 Disabling CondVarTest for TSan v2.
This test goes into an eternal loop sometimes when run under
TSan v2, therefore I'm disabling it until this is resolved.
Doing that, our new WebRTC FYI waterfall with a TSan v2 bot will hopefully go green when deployed (see https://codereview.chromium.org/23231004)

The define used only exists for TSan v2, so v1 should be
unaffected.

BUG=2259
TEST=test passing locally when run as described in 2259 (since
no tests are run).

R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2126005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4635 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-28 19:54:33 +00:00
kjellander@webrtc.org
f3bf5e02c8 Add suppressions file for TSan v2
This is needed for our tests to pass when run under TSan v2.
More details on TSan v2 can be found at
http://www.chromium.org/developers/testing/threadsanitizer-tsan-v2

BUG=chromium:274414
TEST=ran tests locally standing in trunk/ using:
GYP_DEFINES=tsan=1 linux_use_tcmalloc=0 release_extra_cflags="-gline-tables-only" gclient runhooks
ninja -C out/Release
TSAN_OPTIONS=suppressions=tools/valgrind-webrtc/tsan_v2/suppressions.txt print_suppressions=1 report_signal_unsafe=0 report_thread_leaks=0 history_size=7 out/Release/testname
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2057004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4564 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-19 05:33:20 +00:00