Commit Graph

498 Commits

Author SHA1 Message Date
wu@webrtc.org
ff1b1bf094 When creating an answer, takes the codec preference from the offer.
This change is based on RFC3264:

"Although the answerer MAY list the formats in their desired order of preference, it is RECOMMENDED that unless there is a specific reason, the answerer list formats in the same relative order they were present in the offer."

BUG=2868
TEST=unit tests and manually with munge-sdp test
R=juberti@google.com

Review URL: https://webrtc-codereview.appspot.com/14589004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6514 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 20:57:42 +00:00
buildbot@webrtc.org
0d15159b04 (Auto)update libjingle 69634309-> 69640360
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6512 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 19:02:09 +00:00
jiayl@webrtc.org
b43c99de29 Limits the send and receive buffer by bytes, not by packets.
The new limit is 16MB for each buffer.
Also refactors the code to handle send failure more consistently.

BUG=3429
R=juberti@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/21559005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6511 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 17:11:14 +00:00
jiayl@webrtc.org
db397e5c6c Re-evalutes the ICE role on ICE restart.
Also unifies the logic of ICE restart.

BUG=1775
R=juberti@google.com, juberti@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20619004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6510 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 16:32:09 +00:00
buildbot@webrtc.org
bb2d65895b (Auto)update libjingle 69617317-> 69623266
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6508 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 14:58:56 +00:00
buildbot@webrtc.org
75ce92086c (Auto)update libjingle 69600065-> 69617317
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6507 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 12:30:24 +00:00
pbos@webrtc.org
83785d37d1 Remove unused ALLOCATE_DELAY constant.
Breaks linux_tsan2 compile [-Wunused-const-variable].

TBR=mallinath@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/20749004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6505 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 10:28:39 +00:00
buildbot@webrtc.org
4c25c67146 (Auto)update libjingle 69589535-> 69600065
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6504 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 04:42:34 +00:00
buildbot@webrtc.org
58e7c8660c (Auto)update libjingle 69588980-> 69589535
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6503 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 00:26:50 +00:00
buildbot@webrtc.org
0970dd8767 (Auto)update libjingle 69588608-> 69588980
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6502 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 00:18:36 +00:00
buildbot@webrtc.org
8563ef448a (Auto)update libjingle 69587333-> 69588608
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6501 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 00:13:01 +00:00
buildbot@webrtc.org
1ef789d455 (Auto)update libjingle 69568113-> 69587333
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6500 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-19 23:54:12 +00:00
buildbot@webrtc.org
df9bbbee56 (Auto)update libjingle 69567902-> 69568113
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6498 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-19 19:54:33 +00:00
buildbot@webrtc.org
fbd13286dc (Auto)update libjingle 69555283-> 69567902
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6497 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-19 19:50:55 +00:00
buildbot@webrtc.org
21794f9862 (Auto)update libjingle 69543894-> 69555283
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6496 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-19 17:14:19 +00:00
buildbot@webrtc.org
d27d9ae644 (Auto)update libjingle 69506154-> 69515138
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6488 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-19 01:56:46 +00:00
jiayl@webrtc.org
acede34aea Fix a memory leak in SctpDataMediaChannelTest.
BUG=3492
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/21699004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6486 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-18 23:36:16 +00:00
jiayl@webrtc.org
f8063d34de Properly shut down the SCTP stack.
TBR phoglund@webrtc.org for the tsan_v2/suppressions.txt change.
R=ldixon@webrtc.org, pthatcher@webrtc.org
TBR=phoglund@webrtc.org
BUG=2749

Review URL: https://webrtc-codereview.appspot.com/12739004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6484 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-18 21:30:40 +00:00
jiayl@webrtc.org
2eaac188bb Makes the sid of a closed DataChannel available to reuse per the spec.
BUG=2646
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16579004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6468 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-17 16:02:46 +00:00
phoglund@webrtc.org
ed3e0d8f0d Increasing tolerances quite a bit to fight flakes.
From these errors:

[----------] 3 tests from ProfilerTest
[ RUN      ] ProfilerTest.TestFunction
../../talk/base/profiler_unittest.cc:56: Failure
The difference between kWaitSec and event->mean() is 0.13612610600000002, which exceeds kTolerance, where
kWaitSec evaluates to 0.25,
event->mean() evaluates to 0.38612610600000002, and
kTolerance evaluates to 0.10000000000000001.
[  FAILED  ] ProfilerTest.TestFunction (655 ms)
[ RUN      ] ProfilerTest.TestScopedEvents
../../talk/base/profiler_unittest.cc:98: Failure
The difference between kEvent2WaitSec and event2->mean() is 0.33170768900000003, which exceeds kTolerance, where
kEvent2WaitSec evaluates to 0.14999999999999999,
event2->mean() evaluates to 0.48170768899999999, and
kTolerance evaluates to 0.10000000000000001.

I didn't spend time understanding why; I reckon the test had too tight
tolerances to start with so I'm just adjusting them a bit. That's
probably better than disabling the test, now it still has some value.

R=aluebs@webrtc.org
TBR=aluebs@webrtc.org
BUG=None

Review URL: https://webrtc-codereview.appspot.com/13729005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6464 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-17 11:09:00 +00:00
buildbot@webrtc.org
ae740dd94c (Auto)update libjingle 69359922-> 69365993
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6463 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-17 10:56:41 +00:00
buildbot@webrtc.org
44a317a698 (Auto)update libjingle 69337301-> 69359922
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6457 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-17 07:49:15 +00:00
buildbot@webrtc.org
53f57936c1 (Auto)update libjingle 69306183-> 69323802
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6454 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-16 21:08:51 +00:00
pbos@webrtc.org
587ef60056 Implement RTP extension support in WebRtcVideoEngine2.
BUG=1788
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20679004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6453 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-16 17:32:02 +00:00
buildbot@webrtc.org
d054bff3b9 (Auto)update libjingle 69292418-> 69293749
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6452 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-16 14:37:41 +00:00
buildbot@webrtc.org
88d9fa63df (Auto)update libjingle 69291002-> 69292418
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6450 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-16 14:11:32 +00:00
buildbot@webrtc.org
27626a6256 (Auto)update libjingle 69278008-> 69291002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6448 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-16 13:39:40 +00:00
buildbot@webrtc.org
0a1e7e0b00 (Auto)update libjingle 69276003-> 69278008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6442 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-16 08:34:09 +00:00
buildbot@webrtc.org
d159140965 (Auto)update libjingle 69260070-> 69276003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6439 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-16 07:49:00 +00:00
buildbot@webrtc.org
117afeec91 (Auto)update libjingle 69188577-> 69260070
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6437 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-16 07:11:01 +00:00
glaznev@webrtc.org
ab23d493e0 Add glaznev@ to OWNERS for webrtc/modules/video_capture and talk/app/webrtc.
Review URL: https://webrtc-codereview.appspot.com/20659004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6436 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-13 23:31:35 +00:00
glaznev@webrtc.org
c6c1dfd7ea Add extra logging and latency restriction to VP8 HW encoder.
- Do not allow encoder to accumulate more than 100 ms of
data in input buffers.
- Add optional extra logging (disabled by default) to track
encoder buffers timing.

BUG=
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/21659004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6435 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-13 22:59:08 +00:00
buildbot@webrtc.org
a6764ab869 (Auto)update libjingle 69144530-> 69164179
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6434 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-13 18:24:39 +00:00
buildbot@webrtc.org
db56390f7e (Auto)update libjingle 69143161-> 69144530
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6432 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-13 13:05:48 +00:00
pbos@webrtc.org
f99c2f2dbc Add NACK feedback parameter to WebRtcVideoEngine2.
Also fixing enabling/disabling of NACK. Previous implementation was made
under the assumption that NACK should always be enabled which caused
both missing NACK settings in SDP as well as broken interop between old
and new WebRtcVideoEngines.

BUG=1788
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16689004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6431 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-13 12:27:38 +00:00
pbos@webrtc.org
e322a175f6 Implement RTX tests+fixes in WebRtcVideoEngine2.
BUG=1788
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15759004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6430 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-13 11:47:28 +00:00
pbos@webrtc.org
9fbb717aca Remove engine_codecs_ cache from unittests.
Used interchangably with engine_.codecs() becomes confusing and it's not
really used that much.

BUG=1788
R=pthatcher@google.com, pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17689005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6429 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-13 09:34:13 +00:00
kjellander@webrtc.org
d54ec1256c Fix GYP DEPTH for libjingle isolate files
In https://review.webrtc.org/13679004/ the libjingle isolate
files in patch set #2 were not tested, which caused a failure when
6427 was committed. This fixes the talk/build/isolate.gypi with a
similar change.

BUG=343106
TEST=Successful local compile on Linux
TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14689004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6428 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-13 09:16:23 +00:00
kjellander@webrtc.org
a1bfc50a72 Pass GYP DEPTH variable to isolate.
Similar change to https://codereview.chromium.org/322403003/
This will make it possible to handle different
directory levels for special builds of WebRTC, without
breaking GYP when the .isolate files are processed and
their contents is verified.

Also update all our .isolate files to use the <(DEPTH)
variable.

BUG=343106
TEST=Successful compile+test on Linux using:
ninja -C out/Release
tools/swarming_client/isolate.py run -s out/Release/tools_unittests.isolated
Also trybots passing all tests.

R=pbos@webrtc.org
TBR=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/13679004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6427 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-13 09:02:15 +00:00
buildbot@webrtc.org
c800c1cc40 (Auto)update libjingle 69131548-> 69132244
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6426 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-13 07:56:17 +00:00
pbos@webrtc.org
1c8223c590 Initial owners file for talk/media/webrtc/.
Including pthatcher@webrtc.org (already root owner) and
mflodman@webrtc.org.

BUG=
R=juberti@google.com, juberti@webrtc.org
TBR=juberti@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15679008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6425 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-13 07:29:26 +00:00
buildbot@webrtc.org
7e71b77f8a (Auto)update libjingle 69102234-> 69116997
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6424 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-13 01:14:01 +00:00
jiayl@webrtc.org
1a6c6281ca Revert r6420 'Revert r6390 "Adds end to end DataChannel tests." Flaky on linux_memcheck'
Failing tests are disabled for memcheck.

TBR=wu@webrtc.org
BUG=2626

Review URL: https://webrtc-codereview.appspot.com/13699004

Review URL: https://webrtc-codereview.appspot.com/13699004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6422 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-12 21:59:29 +00:00
jiayl@webrtc.org
ddeec048c0 Revert r6390 "Adds end to end DataChannel tests." Flaky on linux_memcheck
This reverts commit c3272a942f04f9dd0db3f6bf0d201bcf47c3fa08.

TBR=wu@webrtc.org
BUG=2626

Review URL: https://webrtc-codereview.appspot.com/13689004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6420 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-12 21:42:46 +00:00
buildbot@webrtc.org
3f3f428d2b (Auto)update libjingle 69097619-> 69099564
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6419 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-12 21:36:26 +00:00
jiayl@webrtc.org
6c6f33b5bb Fix the flaky RTP DataChannel test.
BUG=2891
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/18519004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6418 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-12 21:05:19 +00:00
buildbot@webrtc.org
18dfa8d574 (Auto)update libjingle 69069003-> 69082899
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6417 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-12 18:11:02 +00:00
xians@webrtc.org
4cb012858f Fixed GetStats when local and remote track are using the same ssrc.
R=hta@chromium.org, kjellander@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20589004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6414 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-12 14:57:05 +00:00
buildbot@webrtc.org
b90619c07f (Auto)update libjingle 69049090-> 69054765
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6412 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-12 09:19:08 +00:00
buildbot@webrtc.org
d41eaeb7cd (Auto)update libjingle 69005149-> 69049090
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6408 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-12 07:13:26 +00:00