Commit Graph

2054 Commits

Author SHA1 Message Date
kjellander@webrtc.org
7401a1f393 Updating Chrome excludes to use the same as Chrome buildbots.
See the NEEDED_COMPONENTS constant of http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/master/factory/chromium_factory.py?view=markup for more details.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/513001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2099 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 18:59:40 +00:00
andrew@webrtc.org
4e423b3b1e Handle master/slave timestamp wrap.
BUG=issue410
TEST=neteq_unittests, audio_coding_module_test

Review URL: https://webrtc-codereview.appspot.com/506001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2098 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 18:59:00 +00:00
kjellander@webrtc.org
55e4fffa5b LCOV fix in addition to r2095.
https://webrtc-codereview.appspot.com/515002 was not properly tested.

BUG=None
TEST=Tested on local master and slave, verified fix working in twistd.log on master.
TBR=phoglund

Review URL: https://webrtc-codereview.appspot.com/513002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2097 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 18:22:20 +00:00
vikasmarwaha@webrtc.org
99ac3f7be5 Fixed trunacated trace problem in WebRTC. http://b.corp.google.com/issue?id=5607856
Review URL: https://webrtc-codereview.appspot.com/508004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2096 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 17:04:35 +00:00
kjellander@webrtc.org
f3794f8e5a Fixed normal LCOV case
BUG=None
TEST=Tested on local master, with and without a test failure.

Review URL: https://webrtc-codereview.appspot.com/515002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2095 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 15:42:56 +00:00
pwestin@webrtc.org
ddab60be56 Wire up pading.
Review URL: https://webrtc-codereview.appspot.com/509002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2094 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 14:52:15 +00:00
bjornv@webrtc.org
11654c2344 VAD refactoring: Local variable name changes
Changes tested with vad_unittests and audioproc_unittest

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/485004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2093 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 14:50:11 +00:00
mflodman@webrtc.org
5284d6e905 Minor change to trigger REMB packets in RTCP RR if there is no sending channel.
BUG=
TEST=video_engine_core_unittest

Review URL: https://webrtc-codereview.appspot.com/508007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2092 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 13:22:26 +00:00
hta@webrtc.org
bf9f469a13 Lifetime management for UdpSocketManager
Make tests use Create/Destroy *or* new/delete for UdpSocketManager.
Move responsibility for calling Destroy on UdpSocketManager from transport
destructor to transport Destroy function.

This all ends up in not leaking memory in InitializeSourcePorts test.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/512001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2091 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 13:19:30 +00:00
asapersson@webrtc.org
92591adc67 Fixes link issues in google3 (change by tomasl).
Review URL: https://webrtc-codereview.appspot.com/509001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2090 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 13:10:55 +00:00
asapersson@webrtc.org
83ed0a4359 Try to resend next packet in nack list even if previous packet is not found.
Review URL: https://webrtc-codereview.appspot.com/515001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2089 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 12:43:05 +00:00
phoglund@webrtc.org
f6cd33dd89 Implemented bloat calculation. This will measure the binary size of Chrome+WebRTC components each weekend.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/508005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2088 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 09:27:57 +00:00
kjellander@webrtc.org
39946f1380 Skipping code coverage HTML generation on failed builds.
BUG=None, except that the dashboard shows confusing stats.
TEST=Tested with local master and slave.

Review URL: https://webrtc-codereview.appspot.com/508002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2087 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 08:57:44 +00:00
pwestin@webrtc.org
fcbbe1f341 Removed unused callback code from video coding test.
Review URL: https://webrtc-codereview.appspot.com/504003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2086 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 08:33:18 +00:00
pwestin@webrtc.org
a2cd732139 Fix for calling OnNetworkChanged too often.
Review URL: https://webrtc-codereview.appspot.com/508006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2085 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 08:32:47 +00:00
marpan@webrtc.org
88ad06b999 VCM: Added condition(s) for setting FEC protection factor to zero at low bitrates.
Review URL: https://webrtc-codereview.appspot.com/494001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2084 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 16:05:24 +00:00
asapersson@webrtc.org
63a34f4f29 Fix in SendPadData. Do not increase sequence number if packet is "empty" and not sent.
Review URL: https://webrtc-codereview.appspot.com/508001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2083 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 13:20:27 +00:00
phoglund@webrtc.org
bb77000123 Added a virtual destructor to get the test to compile on all platforms.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/507003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2082 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 13:03:12 +00:00
phoglund@webrtc.org
b73f01e7fd Removed some obviously dead stuff from voe_auto_test.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/495001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2081 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 10:59:31 +00:00
hta@webrtc.org
bbd6b561cf Memory leak fix: Deleting a factory
Also expanded some documentation.
Bug found by Valgrind bot.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/507002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2080 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 09:51:26 +00:00
bjornv@webrtc.org
bcde776340 Changed Delay Estimator create call
Unit tests updated and runs.
Change made w.r.t. issue 441.

BUG=Issue441
TEST=None

Review URL: https://webrtc-codereview.appspot.com/498001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2079 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 09:35:20 +00:00
hta@webrtc.org
0abe535e16 Refactored udp_transport to take socket manager as dependency injection
This avoids having to deal with the socket manager in the unittest.

Extended tests to cover one case where sockets got allocated.

BUG=
TEST=unittest

Review URL: https://webrtc-codereview.appspot.com/496001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2078 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 08:23:16 +00:00
kjellander@webrtc.org
4e645ee783 Improved error message when capture device is missing.
With this patch the test stops when it doesn't find a camera instead of crashing with a large hard-to-read stack trace.

BUG=None
TEST=vie_auto_test --automated in Debug+Release on lin, mac, win

Review URL: https://webrtc-codereview.appspot.com/497003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2077 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 08:10:37 +00:00
andrew@webrtc.org
b61f1fa675 Reset slave when switching to a stereo codec.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/494003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2073 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 01:10:14 +00:00
leozwang@webrtc.org
00a8dbb0ec Change Watchlist
Review URL: https://webrtc-codereview.appspot.com/503001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2072 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 18:09:23 +00:00
tommi@webrtc.org
f4c80fc6cb Switch the other android build over to android_posix.cc and not android_linux.cc.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2070 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 15:41:33 +00:00
tommi@webrtc.org
9018c9f548 Fix androidndk build take two.
TBR=xians

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2069 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 15:38:10 +00:00
tommi@webrtc.org
3db5cb7438 Fix AndroidNDK build.
TBR=xians

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2068 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 15:29:08 +00:00
tommi@webrtc.org
3d48b09bb4 Fix android build.
TBR=kjellander

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2067 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 15:07:11 +00:00
kjellander@webrtc.org
0cac8be82c Fixing e-mail notification for buildbot master
BUG=None
TEST=None (same config works on try master)

Review URL: https://webrtc-codereview.appspot.com/501001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2066 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 15:05:53 +00:00
tommi@webrtc.org
e84373c38f Atomic32Wrapper -> Atomic32
This change does the following:

* Remove the Atomic32Wrapper and AtomicImpl classes and provide the Atomic32
  implementation directly via platform specific source files.
* Move/rename/delete all source files accordingly
* The atomic value itself is now volatile. Previously it was only the pointer to
  the memory that was volatile, but not the actual value.
* No additional heap allocations are now done for the atomic value.

In a follow up cl I plan to start using Atomic32 in the RefCount class in order
to fix issues reported by Coverity.
Review URL: https://webrtc-codereview.appspot.com/490004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2065 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 14:28:45 +00:00
pwestin@webrtc.org
1cd1162c7a Break out of send side bandwidth estimation and controll.
Review URL: https://webrtc-codereview.appspot.com/490010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2064 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 12:13:52 +00:00
pwestin@webrtc.org
b2bd1e05f8 Bugfix too many initialize for RTP module
Review URL: https://webrtc-codereview.appspot.com/497002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2063 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 12:01:47 +00:00
kjellander@webrtc.org
76643d7c62 Enabling fastbuild in GYP define.
The fastbuild flag means debug symbols are not generated. This has no
impact on our tests as long as we don't need to debug with the built
binaries, i.e. is perfect for the buildbots. Compilation is 30% faster
or more.

BUG=None
TEST=Tested on local master and linux, mac and win slaves.

Review URL: https://webrtc-codereview.appspot.com/499001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2062 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 07:30:39 +00:00
asapersson@webrtc.org
a768970bac Parse out ssrcs in REMB message (needed for ViCE) .
Review URL: https://webrtc-codereview.appspot.com/486003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2061 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 07:01:29 +00:00
tina.legrand@webrtc.org
faa0ab85d7 NetEQ stereo sync
This CL allows NetEQ to do expand at startup, to make master and slave always go in sync. Before it could happen that master did merge, while slave performed an expand, leading to sync-problems between the channels.

Updating DEPS for new reference files for unittest.

BUG=410
TEST=neteq_unittests

Review URL: https://webrtc-codereview.appspot.com/487005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2055 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 17:59:53 +00:00
leozwang@webrtc.org
22082e74cb Enable iSAC_FIX on android
BUG=
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/490009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2054 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 16:52:00 +00:00
leozwang@webrtc.org
16f6bb35b6 Fix a minor compilation error on android
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/479014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2053 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 16:49:06 +00:00
marpan@webrtc.org
efd01fd354 Removing unused code from QMVideoSettingsCallback.
This code is not needed as of the change in r1950.
Review URL: https://webrtc-codereview.appspot.com/492010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2052 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 15:56:34 +00:00
kjellander@webrtc.org
82d85aeb39 All errors are now printed to stderr instead of stdout.
This will make them easier to detect when running as a cron job.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/482005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2050 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 09:47:39 +00:00
bjornv@webrtc.org
4ade5506eb Delay Estimator Unit tests
This CL includes unit tests to verify correct behavior of the delay estimator used in AEC and AECM.

Tested with audioproc_unittest

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/491009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2049 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 09:42:16 +00:00
bjornv@webrtc.org
2e729762c7 New _CreateBinaryDelayEstimator() and removed _history_size()
Changed create function to match malloc() in functionality.
Removed unused function.

Tested with audioproc_unittest

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/491010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2048 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 08:30:29 +00:00
bjornv@webrtc.org
180f83f8e2 File name change to follow style
A unit test should end with *_unittest.* Otherwise the test itself will be evaluated for line coverage.

Tested with audioproc_unittest

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/493008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2045 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 07:01:10 +00:00
andrew@webrtc.org
1bc98bc873 Remove erroneous error trace.
It appears this trace is informational, not an error.
Discovered in a plugin log from a ChromeOS device. Just
decided to remove it.

BUG=http://code.google.com/p/chromium-os/issues/detail?id=29356
TEST=build on Linux

Review URL: https://webrtc-codereview.appspot.com/479012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2043 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 20:10:47 +00:00
tommi@webrtc.org
7ab51497a7 Remove usage of Atomic32Wrapper from a few places.
In these places, it doesn't make much sense to use an atomic variable we were using
Atomic32Wrapper::operator= anyway (which does not use atomic operations).
Review URL: https://webrtc-codereview.appspot.com/492005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2042 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 13:33:28 +00:00
hta@webrtc.org
52c0fec34c Added UDP socket factory function to UdpTransportImpl constructor
This is a refactoring in preparation for creating small unit tests for the
udp_transport module.

BUG=
TEST=unittest

Review URL: https://webrtc-codereview.appspot.com/482004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2041 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 12:39:04 +00:00
phoglund@webrtc.org
c3eb178a0d Will now filter chrome-triggered builds.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/492009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2040 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 11:23:35 +00:00
phoglund@webrtc.org
c440d56e92 Rewired the oath2 symlink and updated tgrid_parser to the new Build Bot version's tgrid syntax.
Added back the gviz_api to the tools deps - will remove it from the main project DEPS in a different patch. Rewired those symlinks too.

Made the build status loader algorithm more scalable. It read in the whole database on each load which is probably unsustainable in the long run. Also, it will now forget bots that have offline for more than ~5 revisions.

Fixed a bug in the coverage tracker.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/486002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2039 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 08:49:10 +00:00
andrew@webrtc.org
336d52d817 Roll Chromium 122775:132375 (current Canary).
Hijacking the gyp inside_chromium_build finally came back to bite us.
Chrome started using it to control the path to the gold linker, which
broke our build. This change removes use of inside_chromium_build from
WebRTC.

If peerconnection rolls past this point, libjingle.gyp will need to be updated.

BUG=
TEST=build on Linux, Mac, Win

Review URL: https://webrtc-codereview.appspot.com/493007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2038 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 01:19:27 +00:00
marpan@webrtc.org
3e2e7038e6 VPM: Allow for option to compute the content metrics every nth frame.
Review URL: https://webrtc-codereview.appspot.com/492006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2034 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 15:58:14 +00:00