generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
2,344 Commits 1 Branch 0 Tags 108 MiB
f388fcc67e
Commit Graph

2344 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
andrew@webrtc.org
aafa49bb85 Disable flaky VolumeTest.DefaultSpeakerVolumeIsAtMost255. 
This test failed on six CLs in a row recently.

TBR=xians@webrtc.org
BUG=issue367
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/595007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2317 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-29 22:05:15 +00:00
andrew@webrtc.org
5f23d64cf2 Set the stream delay to zero if too low. 
- Return a stream warning instead of an error.
- Add a few delay offset tests.

BUG=
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/607004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2316 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-29 21:14:06 +00:00
leozwang@webrtc.org
2fc6e388c0 Check return value of fwrite. [Video Module] 
Description:
On ChromeOS/ARM, compiler enforces to check return result of a function.
Currently, we don't check return result of fwrite, it causes building errors.

The following files need to patch. The patch should be similar, before I patch all
of them, I will start with 3 files, once we agree upon the solution, we will expand
it to all of them.

The question is should we do 
1. if (error) { return -1;} 
or 
2. if (error) { /*ignor the error*/ }

I took "return -1" in this patch, but I'm OK with either. Please let me know your
thoughts and I will upload a new patch.
Review URL: https://webrtc-codereview.appspot.com/583010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2315 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-29 17:33:13 +00:00
kjellander@webrtc.org
8a7a019b55 Syncing tests on try master with build master. 
Also adding video_codecs_test_framework_integrationtests since it's executing fast enough and catches a lot.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/605006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2314 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-29 14:49:39 +00:00
pwestin@webrtc.org
1eef9c16ff Bitrate bugfixes 
Review URL: https://webrtc-codereview.appspot.com/609005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2313 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-29 09:28:43 +00:00
stefan@webrtc.org
5abab0b1b5 Revert 2311 - Disable error concealment. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/609004

TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/604006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2312 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-29 09:04:40 +00:00
stefan@webrtc.org
3348b2990b Disable error concealment. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/609004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2311 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-29 08:44:00 +00:00
kjellander@webrtc.org
fe87f8ce08 Libvpx buildbot waterfall. 
I think I found a decent way to avoid duplicating the whole configuration for the libvpx waterfall. It's not perfect but it works. I still haven't figured out what the best way to manage the slaves would be however, since they will need to know which master to connect to, or they'll pick the default they're configured for in slaves.cfg, which is the WebRTC waterfall (can be overridden with the TESTING_MASTER property, but that's only to be used for development and testing.

BUG=None
TEST=Tested on local master and slaves.

Review URL: https://webrtc-codereview.appspot.com/595005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2310 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-29 06:23:42 +00:00
mflodman@webrtc.org
ca8d788362 Fix a bug where a RAII object was created for just one line instead of a block. 
Found by clang:

../../third_party/webrtc/video_engine/vie_render_manager.cc:157:3: error: expression result unused [-Werror,-Wunused-value]
  ViEManagerWriteScoped(*this);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Review URL: https://webrtc-codereview.appspot.com/599005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2309 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-28 18:56:20 +00:00
phoglund@webrtc.org
dbaa893525 Completed rewrite of APM extended test. 
Removed NS tests since they are already covered by audio_processing_test.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/603004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2308 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-28 14:36:59 +00:00
bjornv@webrtc.org
1747427861 VAD Refactoring: Replaced pointer operation with array index 
This CL contains a change of pointer nomenclature to array index. In addition, one place with two hard coded Gaussians has been generalized with a for loop.

Tested with trybots, vad_unittests, audioproc_unittest

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/592004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2307 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-28 12:50:05 +00:00
bjornv@webrtc.org
4e12d3065e VAD Refactoring: Removed assign calls 
These calls are not used anywhere in WebRTC and there is no plan on using them.
Removed them and updated corresponding unit tests.

Tested on trybots, vad_unittests, audioproc_unittest

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/608004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2306 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-28 12:25:07 +00:00
tina.legrand@webrtc.org
0de1ee3830 NetEQ: Remove an unnecessary condition, to fix a clang warning 
This is a duplicate of issue 606005: https://webrtc-codereview.appspot.com/606005/

BUG=
TEST=neteq_unittests

Review URL: https://webrtc-codereview.appspot.com/605005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2305 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-28 11:37:50 +00:00
kjellander@webrtc.org
b6e4cc776e Valgrind memcheck and TSAN script now uses Chrome+WebRTC suppression files. 
Skeleton suppression files for future WebRTC suppressions are added and are included in addition to the ones Chrome are using and maintaining when our wrapper script executes.

Also added tweaked PRESUBMIT checks based on the Chrome code, that verifies
that suppressions are added correctly. I tested that they work by adding an invalid
suppression.

BUG=544
TEST=Tested running tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan -t out/Debug/system_wrappers_unittests and it reports far less errors. Tested adding bad suppression and it was caught by the PRESUBMIT check.

Review URL: https://webrtc-codereview.appspot.com/601004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2304 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-27 20:59:35 +00:00
kma@webrtc.org
0d321da7e1 Refactored ARM specific code in Noise Suppression. Bit exact. 
Review URL: https://webrtc-codereview.appspot.com/459006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2303 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-26 01:05:27 +00:00
leozwang@webrtc.org
1755a57cbc Check return result of fwrite, [APM] 
Description:
This cl added checking return result of fwrite which makes it compile
on ChromeOS/ARM.

BUG=issue:541
TEST=Build on all platforms
Review URL: https://webrtc-codereview.appspot.com/583009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2302 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-25 19:20:35 +00:00
leozwang@webrtc.org
f14575fd8e Dynamically load codec list 
Description:
This cl adds a feature that can query video engine and voice engine and load code list in
gui settings. Currently, codec lists are fixed in resource file, it caused confusion and
problems.

TBR=ronghua
BUG=
TEST=test on android
Review URL: https://webrtc-codereview.appspot.com/583006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2301 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-25 16:47:56 +00:00
leozwang@webrtc.org
351fb6d3b4 Exclude code that don't work on android in voe_cmd_test 
Description:
Ths cl makes voe_cmd_test work on android by excluding some code
that are availabel on android today, some highlights
1. change maxnumofchannles
2. disable audio device selection
3. disable set/get volume

BUG=
TEST=test on try bots
Review URL: https://webrtc-codereview.appspot.com/584009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2300 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-25 16:47:35 +00:00
kjellander@webrtc.org
15cd04a314 Enabling vp8_integrationtests on all platforms 
BUG=None
TEST=Tested on Linux, Mac and Windows in Debug+Release

Review URL: https://webrtc-codereview.appspot.com/599004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2299 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-25 09:46:19 +00:00
kjellander@webrtc.org
21c5bda17c Enabling udp_transport_unittests for TSAN 
BUG=536
TEST=Tested running the test within TSAN on Linux.

Review URL: https://webrtc-codereview.appspot.com/591004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2298 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-25 09:45:33 +00:00
turaj@webrtc.org
10d3b5239b I haven't done any refactoring here. 
Resolve coverity warnings.

14305.

The warning is not really valid. The 'decode' function should be called with a 'mode' variable, where inside the function it is assumed that mode is either zero or one. If mode is taking other values some varibles are used uninitialized. However, this is an internal function and it is always called with either ZERO or ONE. Therefore, the code operates correctly. I made small changes as I beleive it is a bit nicer way. 

In ACM:
- Conditions on 'mode' is changed.


Tested with trybots.

BUG=None
TEST=None
Review URL: https://webrtc-codereview.appspot.com/564014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2297 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 21:20:25 +00:00
andrew@webrtc.org
f45d47ad7d Remove mixing tests from voe_extended_test.cc 
These have been moved to:
src/voice_engine/main/test/auto_test/standard/mixing_test.cc

BUG=
TEST=build voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/588005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2296 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 17:27:59 +00:00
andrew@webrtc.org
51b4f3e6a8 Try to fix MixingTest on the Win bots. 
- Relax the constraints on recording duration.
- Remove unneeded file deletes. (These files will be properly
  overwritten anyway).

TBR=henrike@webrtc.org
BUG=issue534
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/600006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2295 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 17:26:05 +00:00
stefan@webrtc.org
42e78ac087 Disable normal_async_test and rename tests to vp8_integrationtests. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/598004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2294 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 14:36:34 +00:00
mflodman@webrtc.org
6af9594d71 Added gyp variable to include/exclude all tests. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/597004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2292 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 13:23:35 +00:00
niklas.enbom@webrtc.org
ee646c37d4 I know this is ugly, but it helps a lot to quickly update webRTC in Chrome and libJingle. 
Review URL: https://webrtc-codereview.appspot.com/596004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2290 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 11:41:02 +00:00
pwestin@webrtc.org
2d1fc9bf17 Added critical section to prevent race. 
Review URL: https://webrtc-codereview.appspot.com/595004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2289 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 11:28:31 +00:00
pwestin@webrtc.org
5c3a400fae Re-added ChangeUniqueId temporary for chrome. 
Review URL: https://webrtc-codereview.appspot.com/594004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2287 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 09:52:19 +00:00
phoglund@webrtc.org
3c580bed4e Made fuzz tests and chrome bots FYI: e.g, they will warn instead of making the whole build red if they fail. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/589005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2286 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 09:31:49 +00:00
andrew@webrtc.org
7fbfc4ce79 Use correct variable in trace. 
TBR=leozwang@webrtc.org
TEST=build

Review URL: https://webrtc-codereview.appspot.com/593004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2284 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 22:22:36 +00:00
andrew@webrtc.org
f98b6cc10e Remove noise during build on Win32 
TBR=niklas.enbom@webrtc.org
BUG=chromium:126483

Review URL: https://webrtc-codereview.appspot.com/590006
Patch from Scott Graham <scottmg@chromium.org>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2283 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 18:49:47 +00:00
hta@webrtc.org
40300131dc No more TSAN errors on start_stop 
A very pedestrian approach to making TSAN stop complaining about the state variables: Wrap them in a critical section.
More creative approaches can be considered.

(not sure if diffbase works here, but...)
DIFFBASE=583008

BUG=webrtc:300
TEST=

Review URL: https://webrtc-codereview.appspot.com/584008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2282 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 15:49:48 +00:00
turaj@webrtc.org
ea0aa13aa8 I haven't done any refactoring here. 
Resolve coverity warnings.

14240, 14241.

In ACM:
- NULL pointer sanity checks corrected.

Tested with trybots.

BUG=None
TEST=None
Review URL: https://webrtc-codereview.appspot.com/571012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2281 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 15:43:51 +00:00
andrew@webrtc.org
9dc45dad1b Move trunk/test/data -> trunk/data 
BUG=
TEST=all trybot test failures passed locally

Review URL: https://webrtc-codereview.appspot.com/583007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2280 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 15:39:01 +00:00
hta@webrtc.org
1484ac07cb Replaced 2 time functions with thread-safe equivalents 
This does not fix bug 544, but changes where it reports issues.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/578008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2279 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 15:39:17 +00:00
andrew@webrtc.org
aa5f410db5 Add a README to e2e_quality. 
TBR=kjellander@webrtc.org
BUG=issue502
TEST=none

Review URL: https://webrtc-codereview.appspot.com/590004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2278 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 15:11:20 +00:00
stefan@webrtc.org
78d8d99180 Fixes the vp8_test on Linux. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/579015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2277 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 14:18:56 +00:00
bjornv@webrtc.org
cb0a86e913 VAD refactoring: Added function for repeated code. 
Added WeightedAverage() to calculate global mean. This removes hard coded Gaussian model size and repeated code.

Tested with vad_unittests, audioproc_unittest and trybots.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/571006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2275 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 07:56:51 +00:00
andrew@webrtc.org
2b004655b5 Add comparison to e2e and clean up. 
BUG=issue502
TEST=manual

Review URL: https://webrtc-codereview.appspot.com/577006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2274 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 02:47:58 +00:00
andrew@webrtc.org
a1a34d675f Avoid flakiness by skipping more output verification. 
- Add a SCOPED_TRACE in case it flakes out again.
- The test doesn't need to be very long, so shorten it to save the bots some time.

TBR=henrike@webrtc.org
BUG=
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/588006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2273 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 00:45:00 +00:00
hta@webrtc.org
6ed617be22 Fixing memory leak error in test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/571013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2272 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 16:55:16 +00:00
marpan@webrtc.org
747cd87da1 FEC: For multi-frame FEC, allow for the size of the code to be increased, 
under certain conditions. This generally improves the FEC recovery for 
     bursty loss under medium-high protection level.
Review URL: https://webrtc-codereview.appspot.com/566012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2271 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 16:50:00 +00:00
hta@webrtc.org
e1919f41b7 Unittest for thread_wrapper. 
Added an explanation of the state variables of posix, wrote a simple test.
This might help in fixing the TSAN issue with thread.

BUG=webrtc:300
TEST=

Review URL: https://webrtc-codereview.appspot.com/583008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2270 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 15:57:34 +00:00
pwestin@webrtc.org
0d71c1cfe0 Cleanup code. 
Review URL: https://webrtc-codereview.appspot.com/569021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2269 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 14:23:25 +00:00
astor@webrtc.org
e231c61ba7 Style guide reformatting of overuse_detector.{h,cc} 
Review URL: https://webrtc-codereview.appspot.com/575006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2268 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 12:24:00 +00:00
phoglund@webrtc.org
bd48e71058 Adjusted the bloat build's start time. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/566015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2267 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 09:17:28 +00:00
mflodman@webrtc.org
7597a85bc4 Changed merge-name. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/584007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2266 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 08:32:20 +00:00
andrew@webrtc.org
294be77c2e Permit mixing mono and stereo streams. 
Add mixing tests based on older ones from the extended tests.

BUG=issue534
TEST=manual, voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/576014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2265 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 03:28:41 +00:00
leozwang@webrtc.org
c832d8b586 Add google-gflags header files for linux/arm platform 
BUG=
TEST=build on chromeos/arm
Review URL: https://webrtc-codereview.appspot.com/588004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2264 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-21 18:07:28 +00:00
pwestin@webrtc.org
b2179c20f0 Bugfix issue 533. Client does not handle NACK or PLI requests received from far end if a RTCP report from it has not been processed when RFC 5506 is enabled. 
Review URL: https://webrtc-codereview.appspot.com/569020

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2263 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-21 12:00:49 +00:00