Commit Graph

3650 Commits

Author SHA1 Message Date
niklas.enbom@webrtc.org
c79505f95e Add warning comment
Review URL: https://webrtc-codereview.appspot.com/933012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3122 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-16 22:46:36 +00:00
andrew@webrtc.org
73814961a2 Add a variable for the libvpx path.
Review URL: https://webrtc-codereview.appspot.com/967007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3119 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-16 17:32:00 +00:00
tina.legrand@webrtc.org
d0acdf6e2b Fix ordered comparison warnings in the RTPtimeshift unit test
Original CL uploaded here: http://review.webrtc.org/933013/

Removing the checks if (argv[4/5] >= 0), they are not doing anything useful.

BUG=

Review URL: https://webrtc-codereview.appspot.com/933019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3118 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-16 15:34:32 +00:00
mflodman@webrtc.org
b2f474e8bb Adding ViE CallStats to keep track of call statistics. As a start, only rtt is handled.
This CL will be followed by another CL connecting the dots.

BUG=769
TEST=New unittest added.

Review URL: https://webrtc-codereview.appspot.com/968006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3117 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-16 13:57:26 +00:00
mflodman@webrtc.org
c289f9f209 Replaced remb unittest sleep with fake clock.
Review URL: https://webrtc-codereview.appspot.com/935015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3116 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-16 13:24:18 +00:00
tommi@webrtc.org
21b426d2da Revert 3111 (revert of a revert).
The trybots are succeeding and the modified code shouldn't
affect the test that failed so I suspect it was a fluke.
If this fails, I'll revert my revert so that we can
revert while we revert.
---
Revert 3105 - Don't crash the unit test host when tests fail.
Instead, just report the error, fail, and move on.

TEST=Run vie_auto_test, option=1.
    On my machine most of the tests fail for some reason
    that I'm still investigating, but the tests shouldn't
    be crashing the process which is what I'm fixing here.
Review URL: https://webrtc-codereview.appspot.com/929019

TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/936026

TBR=mikhal@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/966021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3115 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-16 09:37:08 +00:00
tommi@webrtc.org
12773eaa8c Minor cleanup of the videocapture code. No "real" code change :)
Remove declaration of a function that doesn't exist.
Remove call to GetProductId from video_capture_factory_windows that's not necessary.
This was the only dependency on device_info_windows.h outside of video_capture_windows.cc.

TEST=There's no code change, so no manual testing is required.
BUG=none
Review URL: https://webrtc-codereview.appspot.com/936025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3114 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-16 09:03:12 +00:00
marpan@webrtc.org
d14ff54de2 Removed unnecessary lines in one of the tests and changed one parameter.
Review URL: https://webrtc-codereview.appspot.com/933018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3113 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-16 01:17:00 +00:00
mikhal@webrtc.org
01c4b98f90 Revert 3105 - Don't crash the unit test host when tests fail.
Instead, just report the error, fail, and move on.

TEST=Run vie_auto_test, option=1.
    On my machine most of the tests fail for some reason
    that I'm still investigating, but the tests shouldn't
    be crashing the process which is what I'm fixing here.
Review URL: https://webrtc-codereview.appspot.com/929019

TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/936026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3111 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-15 23:38:27 +00:00
fischman@webrtc.org
37ff69d608 Point codereview.settings at the newly-created webrtc-reviews google group.
https://groups.google.com/a/webrtc.org/forum/?#!forum/webrtc-reviews

Review URL: https://webrtc-codereview.appspot.com/934016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3109 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-15 22:21:20 +00:00
andrew@webrtc.org
d72b3d6c81 Fix cpplint errors in audio_processing.h
TBR=leozwang@webrtc.org
BUG=1114

Review URL: https://webrtc-codereview.appspot.com/934015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3108 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-15 21:46:06 +00:00
leozwang@webrtc.org
f3adba499e Add Android include path so that header files can follow google style
BUG=1011
TEST=bot
Review URL: https://webrtc-codereview.appspot.com/930018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3107 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-15 18:17:40 +00:00
kjellander@webrtc.org
0f4185f8bb Making valgrind wrapper script work with test arguments
This is needed to be able to run memcheck/tsan/asan with command line arguments in the way the bots are executing the script (using --build_dir and --test arguments).

BUG=none
TEST=local execution

Review URL: https://webrtc-codereview.appspot.com/938015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3106 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-15 15:19:28 +00:00
tommi@webrtc.org
5ea70e619e Don't crash the unit test host when tests fail.
Instead, just report the error, fail, and move on.

TEST=Run vie_auto_test, option=1.
    On my machine most of the tests fail for some reason
    that I'm still investigating, but the tests shouldn't
    be crashing the process which is what I'm fixing here.
Review URL: https://webrtc-codereview.appspot.com/929019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3105 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-15 14:38:10 +00:00
tommi@webrtc.org
2d0b81b8af Fix sorting issues in video_capture.gypi.
No code change.

TBR=henrikg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/937022

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3104 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-15 10:30:57 +00:00
tina.legrand@webrtc.org
53a8be20f1 Wraparound distortion in Opus
This CL solves the wraparound distortion in Opus.

In the Opus decoder-wrapper we are downsampling the signal from 48 kHz to 32 kHz. This is done in two steps, using the following functions from the signal processing library:
WebRtcSpl_Resample48khzTo32khz() and WebRtcSpl_VectorBitShiftW32ToW16

The latter does not have a saturation check, and the signal can suffer from wraparound. I've added saturation control to the function.

BUG=issue1089

Review URL: https://webrtc-codereview.appspot.com/967004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3103 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-15 08:34:38 +00:00
andrew@webrtc.org
23ec30bdfc Clean up TraceCallback::Print.
Review URL: https://webrtc-codereview.appspot.com/936024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3102 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-15 05:33:25 +00:00
fbarchard@google.com
8123ed74dd libyuv roll to r481 for optimization of neon yuv to/from rgb
BUG=none
TEST=convert_test in libyuv
Review URL: https://webrtc-codereview.appspot.com/929016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3101 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-15 01:40:47 +00:00
wjia@webrtc.org
aea2510b8d Fix generate_asm_header.
In gyp, "inputs" always takes path relative to the gyp file.
The path in "action" is absolute since it can be included from a different directory.
Review URL: https://webrtc-codereview.appspot.com/965026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3100 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-15 00:13:07 +00:00
andrew@webrtc.org
50419b0777 Add libjingle-style stream-style logging.
Add a highly stripped-down version of libjingle's base/logging.h. It is
a thin wrapper around WEBRTC_TRACE, maintaining the libjingle log
semantics to ease a transition to that format.

Also add some helper macros for easy API and function failure logging.

Review URL: https://webrtc-codereview.appspot.com/931010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3099 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-14 19:07:54 +00:00
kma@webrtc.org
1786436eb2 Pure Neon assembly coding for WebRtcIsacfix_AutocorrNeon() in iSAC-Fix.
Review URL: https://webrtc-codereview.appspot.com/939018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3098 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-14 18:44:24 +00:00
mikhal@webrtc.org
9e9cc72b53 Relanding r3071 - updates for i420: Making sure that decoded frame is complete and buffer size is sufficient. Re-landing is possible following r3094 - which disabled a problematic test.
Review URL: https://webrtc-codereview.appspot.com/939019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3097 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-14 17:56:46 +00:00
brykt@google.com
71fd288b95 Fixed indentation and added the description of how to supply argument with specification of a name for the ouputfile where the contentMetrics etc. are logged.
Added description for argument to specify filename for output file where feature vectors are stored.

Fixed indentation

BUG=

Review URL: https://webrtc-codereview.appspot.com/966019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3096 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-14 14:46:52 +00:00
phoglund@webrtc.org
a36d75a03c Reformatted condition_variable* in system_wrappers.
BUG=
TEST=Ran trybots.

Review URL: https://webrtc-codereview.appspot.com/937017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3095 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-14 09:55:04 +00:00
phoglund@webrtc.org
12b828ac90 Fixed test memory leak + disabled base test.
BUG=

Review URL: https://webrtc-codereview.appspot.com/937019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3094 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-14 09:41:48 +00:00
andrew@webrtc.org
56a0076d66 Add myself to the all_webrtc watchlist.
Also fix documented_interface.

Review URL: https://webrtc-codereview.appspot.com/936022

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3093 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-14 01:27:31 +00:00
fischman@webrtc.org
cb7561c945 Adding myself to webrtc watchlist.
Review URL: https://webrtc-codereview.appspot.com/965023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3092 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-14 00:21:59 +00:00
leozwang@webrtc.org
6b9543b801 Add libpaced_sender to Android makefile
TBR=mflodman
Review URL: https://webrtc-codereview.appspot.com/965022

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3091 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-13 23:36:41 +00:00
leozwang@webrtc.org
d5fbdc8e52 Increase number of channels that can be supported on Android
BUG=
TEST=local
Review URL: https://webrtc-codereview.appspot.com/967005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3090 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-13 21:30:34 +00:00
pwestin@webrtc.org
571a1c035b Enable paced sender.
Review URL: https://webrtc-codereview.appspot.com/965016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3089 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-13 21:12:39 +00:00
stefan@webrtc.org
42aa10eba7 Clarifies the bandwidth estimation interfaces.
BUG=

Review URL: https://webrtc-codereview.appspot.com/965019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3087 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-13 15:02:13 +00:00
tina.legrand@webrtc.org
7577ddf27b Refactoring acm_generic_codec
First patch: updating comments.

BUG=1024

Review URL: https://webrtc-codereview.appspot.com/936019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3085 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-13 14:09:35 +00:00
asapersson@webrtc.org
1726661ca2 Update parsed non ref frame info.
Review URL: https://webrtc-codereview.appspot.com/932015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3084 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-13 13:39:51 +00:00
leozwang@webrtc.org
c734669dbf Re-create libvpx configuration files for Android
Message:
I decided to separate libvpx configuraton files for linux/arm and
Android/arm. I will continue maintaining linux/arm configuration files.

The reasons to change:
It will be two sets of configuration files for android, one is arm, the
other one is arm-neon. For "arm" configuration, I will enable
"cpu-auto-detection" which means that binary can run on any armv7 devices.
For "arm-neon" configuration, it will be used for "neon" enabled devices
only. "arm" configuration will be the default configuration which is as
same as what we have for webrtc.

Description:
This CL separates libvpx configuration files for linux/arm and
Android/arm. Configuration files for Android arm are added, also
"cpu-auto-detection" is enabled.

BUG=None
TEST=local
Review URL: https://webrtc-codereview.appspot.com/934013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3082 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-13 01:19:07 +00:00
stefan@webrtc.org
8d18526834 Fixes an incorrect if statement in vie_sync_module.cc.
BUG=1071

Review URL: https://webrtc-codereview.appspot.com/937018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3081 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-12 18:51:52 +00:00
thakis@chromium.org
6e470076ef mac: Fix a port leak in threading code.
Chromium got the same fix in https://codereview.chromium.org/9169016/ 10 months ago.
Review URL: https://webrtc-codereview.appspot.com/929015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3080 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-12 18:30:59 +00:00
fischman@webrtc.org
b900721472 Fix OpenGL rendering of WebRTCDemo by accounting for stride != width.
BUG=998

Review URL: https://webrtc-codereview.appspot.com/936021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3079 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-12 16:39:25 +00:00
henrik.lundin@webrtc.org
af49062a35 Revert 3071 - i420:verify image length
This CL breaks vie_auto_test, test case
ViEVideoVerificationTest.RunsBaseStandardTestWithoutErrors.

BUG=

Review URL: https://webrtc-codereview.appspot.com/930016

TBR=mikhal@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/933014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3078 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-12 09:16:08 +00:00
fischman@webrtc.org
cb76c3c3f7 Unbreak ninja/android build of webrtc.
Review URL: https://webrtc-codereview.appspot.com/932018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3076 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-10 22:39:37 +00:00
fischman@webrtc.org
6590ec3a62 Teach webrtc/codereview.settings how to point at svn rev's so rietveld issues get a useful URL.
Review URL: https://webrtc-codereview.appspot.com/928021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3075 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-10 22:38:10 +00:00
fischman@webrtc.org
f4b26178df Re-initialize enough state on "Stop Call" to be able to stop/start multiple calls in succession.
Review URL: https://webrtc-codereview.appspot.com/965015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3074 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-09 20:57:24 +00:00
pwestin@webrtc.org
b518017e71 Adding pacing module, will replace the transmission_bucket in the RTP module.
TESTED=unittest
Review URL: https://webrtc-codereview.appspot.com/930015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3073 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-09 20:56:23 +00:00
mikhal@webrtc.org
f875fd22c0 i420:verify image length
BUG=

Review URL: https://webrtc-codereview.appspot.com/930016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3071 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-09 18:48:30 +00:00
mikhal@webrtc.org
701567a864 Capture module: Fixing size computation for u and v planes
TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/932017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3070 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-09 18:45:12 +00:00
leozwang@webrtc.org
06d72d881f Add Android OWNER files
Message:
Add OWNER files so I can review and approve changes for Android.
I also should be owner for all .mk file, but it's OK for now,
please review.

BUG=None
TEST=None
Review URL: https://webrtc-codereview.appspot.com/932016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3069 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-09 17:51:55 +00:00
brykt@google.com
e8ef807a2d Added possibility to run quality modes test. Added possibility to input arguments to the test. The test will (for each frame) log the values in contentMetrics to a txt-file. The txt-file can optionally be saved in a specific place. Fixed an issue where video_coding_test crashed if there weren't any parameter submitted to an input argument.
BUG=

Review URL: https://webrtc-codereview.appspot.com/772005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3068 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-09 16:16:41 +00:00
phoglund@webrtc.org
9cb9fc17b1 Reformatted atomic32 files.
BUG=

Review URL: https://webrtc-codereview.appspot.com/937016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3067 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-09 08:57:25 +00:00
kma@webrtc.org
fa65c851fe Optimized function AllpassFilter2FixDec16() in isac fix for Android Neon platforms.
With an offline test, codec cycles were reduced by 4%.
Review URL: https://webrtc-codereview.appspot.com/936007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3066 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-09 00:39:45 +00:00
tommi@webrtc.org
b952a90038 Remove an unused Shutdown method from the ThreadWrapper interface.
The method was flagged by Chrome engineers as dubious since it uses
TerminateThread.  As it turns out, we don't use this method anywhere,
so we can simply remove it! :)

BUG=1066
Review URL: https://webrtc-codereview.appspot.com/938012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3065 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-08 13:40:59 +00:00
phoglund@webrtc.org
1401285fe7 Can now fully control custom calls from the command line.
Example:
out/Debug/vie_auto_test --auto_custom_call --override "Enter destination IP.=127.0.10.55,Enter video send port.=12345"

The above will launch a call directly and choose all default values except for the overridden ones specified above.

BUG=

Review URL: https://webrtc-codereview.appspot.com/920008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3064 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-08 12:18:19 +00:00