Commit Graph

97 Commits

Author SHA1 Message Date
andrew@webrtc.org
9dc45dad1b Move trunk/test/data -> trunk/data
BUG=
TEST=all trybot test failures passed locally

Review URL: https://webrtc-codereview.appspot.com/583007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2280 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-23 15:39:01 +00:00
andrew@webrtc.org
22f6f85fcc Remove redundant initialization.
TBR=xians@webrtc.org
BUG=6140661
TEST=build on Linux

Review URL: https://webrtc-codereview.appspot.com/576005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2197 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 17:18:28 +00:00
braveyao@webrtc.org
113f851cc3 Merge Chromium issue 95797 into WebRTC.
Bug = 450
Test = Manual test
Review URL: https://webrtc-codereview.appspot.com/551004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2192 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 09:28:39 +00:00
andrew@webrtc.org
589673f1cb Fix volume setting while not playing on PulseAudio.
We now only set the volume when starting playout if the user has called
SetSpeakerVolume while we weren't playing. This now also ensures it will
actually get set to what the user requested rather than being overridden
by a default value.

Add tests to voe_auto_test.

BUG=6140661
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/566006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2188 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-07 21:42:49 +00:00
leozwang@webrtc.org
e7ac5fde72 Minor changes to remove dead code in opensl es
BUG=
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/539004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2149 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-30 14:42:17 +00:00
vikasmarwaha@webrtc.org
99ac3f7be5 Fixed trunacated trace problem in WebRTC. http://b.corp.google.com/issue?id=5607856
Review URL: https://webrtc-codereview.appspot.com/508004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2096 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 17:04:35 +00:00
andrew@webrtc.org
1bc98bc873 Remove erroneous error trace.
It appears this trace is informational, not an error.
Discovered in a plugin log from a ChromeOS device. Just
decided to remove it.

BUG=http://code.google.com/p/chromium-os/issues/detail?id=29356
TEST=build on Linux

Review URL: https://webrtc-codereview.appspot.com/479012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2043 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 20:10:47 +00:00
tommi@webrtc.org
7ab51497a7 Remove usage of Atomic32Wrapper from a few places.
In these places, it doesn't make much sense to use an atomic variable we were using
Atomic32Wrapper::operator= anyway (which does not use atomic operations).
Review URL: https://webrtc-codereview.appspot.com/492005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2042 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 13:33:28 +00:00
mflodman@webrtc.org
a014ecc049 Changed CriticalSectionScoped constructor usage for ADM.
Only search and replace for the input to the constructor, no other changes.

BUG=184
TEST=Compiles on all platforms.

Review URL: https://webrtc-codereview.appspot.com/483001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2015 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 12:15:51 +00:00
leozwang@webrtc.org
91ed80e5c3 Correct wrong trace level
Review URL: https://webrtc-codereview.appspot.com/487002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2002 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-10 14:42:20 +00:00
andrew@webrtc.org
e713fd0eee Enable the "unused variable" warning on Windows.
- Break out direct_show_base_classes to its own gyp file to have it
  treated as third party code.
- Fix the resulting warnings (courtesy of Tommi).

BUG=
TEST=build on Windows (vie_auto_test currently failing at HEAD)

Review URL: https://webrtc-codereview.appspot.com/489001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2000 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-10 07:13:46 +00:00
xians@webrtc.org
010a4e8f0b Fix the converity warnings:
CID 10177: Array compared against 0 (NO_EFFECT)
Comparing an array to null is not useful: "this->_paServerVersion".
Review URL: https://webrtc-codereview.appspot.com/466001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1956 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-29 14:05:04 +00:00
leozwang@webrtc.org
3053702698 Remove -lasound and -lpulse linking flags
BUG=365
TEST=build on linux
Review URL: https://webrtc-codereview.appspot.com/446007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1898 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-15 18:34:13 +00:00
andrew@webrtc.org
62283c0ebf Quick fix to avoid non-causal AEC signals on PulseAudio.
BUG=340
TEST=manually with voe_cmd_test

Review URL: https://webrtc-codereview.appspot.com/451007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1884 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-13 19:43:47 +00:00
kjellander@webrtc.org
2050f84b98 audio_device_test_api failing cleaner failure for Linux without audio devices.
BUG=None
TEST=audio_device_test_api on Linux.

Review URL: https://webrtc-codereview.appspot.com/447002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1869 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-09 14:22:27 +00:00
henrika@webrtc.org
907bc55c19 Removes WebRtc_Word8 dependecy in the AudioDeviceModule.
This CL also modifies the ADM callback interface and introduces void* instead of WebRtc_Word8*
as pointer types for data buffers. This change also affects the VoiceEngine.
Review URL: https://webrtc-codereview.appspot.com/443001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1863 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-09 08:59:19 +00:00
kjellander@webrtc.org
67fdd70e1b Refactoring audio_device_test_api for gtest and execution on all platforms.
All the code that was previously in one single function is now broken up into 44 gtest tests. The creation of the Audio Device is done once (SetUpTestCase) and the audio device is initialized before each test (SetUp) and terminated after each test (TearDown). Doing this, the things that execute are basically the same since the test was structured as different sections separated by these calls:
TEST(audioDevice->Terminate() == 0);
TEST(audioDevice->Init() == 0);

I also cleaned up some unused helper functions and removed old test macros when replacing them by gtest macros.

The parts that are failing for Mac and Windows are excluded using #ifdef. Separate issues are filed for
this code to be fixed.

Formatting is updated to follow the WebRTC style guide.

BUG=None.
TEST=audio_device_test_api in Debug+Release on Linux, Mac and Windows. Test run audio_device_test_func on Linux.

Review URL: https://webrtc-codereview.appspot.com/437002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1861 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-09 08:11:04 +00:00
leozwang@webrtc.org
855ced7336 Further cleanup WebRtc_Word8
Review URL: https://webrtc-codereview.appspot.com/426008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1835 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-05 16:07:51 +00:00
leozwang@webrtc.org
3197d48407 Enable audio device test on android
Review URL: https://webrtc-codereview.appspot.com/428005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1829 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-02 17:12:14 +00:00
leozwang@webrtc.org
28f3913ca9 Correct WebRtc_Word8 in adm
Correct WebRtc_Word8 usage in adm

BUG=http://code.google.com/p/webrtc/issues/detail?id=311&sort=-id
TEST=buidl on all platforms

Review URL: https://webrtc-codereview.appspot.com/428001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1814 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-01 18:01:48 +00:00
leozwang@webrtc.org
3e9e0f0497 Change WebRtc_Word8 to char
Review URL: https://webrtc-codereview.appspot.com/405004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1776 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-27 19:17:38 +00:00
xians@webrtc.org
cf1b6aec30 iReduced the flakiness of the volume tests in linux pulseaudio
Review URL: https://webrtc-codereview.appspot.com/390013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1774 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-27 17:22:49 +00:00
henrike@webrtc.org
70efc3250d Factory method for the ADM in the interface file.
BUG=N/A
TEST=no

Review URL: https://webrtc-codereview.appspot.com/396017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1753 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-23 17:45:33 +00:00
xians@webrtc.org
6eb0ca2e75 Two problems are fixed:
#1, avoid leaving the lock without entering the lock.
#2, race problems in variables like _playError, _recError, _recWarning, _playWarning.
Review URL: https://webrtc-codereview.appspot.com/400006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1751 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-23 10:39:53 +00:00
leozwang@webrtc.org
4ad4c24092 Add android to audio device module
Review URL: https://webrtc-codereview.appspot.com/402001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1745 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-22 16:04:59 +00:00
xians@webrtc.org
20aabbb0be Remove the deprecated kTraceModuleCall trace from audio device module.
Review URL: https://webrtc-codereview.appspot.com/396011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1729 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-20 09:17:41 +00:00
braveyao@webrtc.org
590e5eb283 Convert audio layer to WAV on Vista RTM(without any Service Pack)
Review URL: https://webrtc-codereview.appspot.com/397001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1702 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-16 03:21:05 +00:00
xians@webrtc.org
3dbed8597e This CL makes the playout delay value thread safe.
With the patch, _sndCardPlayDelay is calculated in the DoRenderThread instead of capture thread, an capture thread only gets the _sndCardPlayDelay value.
And _sndCardPlayDelay and _sndCardRecDelay are only changed to be Atomic32 to make them to be accessed by multiple threads.


Test=None
Bug=256
Review URL: https://webrtc-codereview.appspot.com/394001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1653 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-09 13:50:48 +00:00
phoglund@webrtc.org
78088c2f36 Removed warnings on Windows and enabled warnings-as-errors on Windows.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/377004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1624 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 14:56:45 +00:00
mflodman@webrtc.org
c80d9d9361 Removed default cases causing clang errors, -Wcovered-switch-default.
BUG=
TEST=Bulid with clang version 3.1 (trunk 148911)

Review URL: https://webrtc-codereview.appspot.com/379008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1604 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 10:11:25 +00:00
phoglund@webrtc.org
d1a860b415 Fixed GCC 4.6 errors (mostly 'unused variable' errors and incorrect usage of EXPECT_EQ with booleans.
Fixed remaining compilation errors in release, etc.

Fixed errors from GCC 4.6 compilation.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/366008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1554 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-26 14:49:28 +00:00
braveyao@webrtc.org
5f9a7baaea Review URL: http://webrtc-codereview.appspot.com/347012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1423 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-13 10:22:44 +00:00
braveyao@webrtc.org
e3eaf44ccf one logical enhancement in CoreAudio error handler. It should never happen, but so far the only suspect to a rare crash report.
Review URL: http://webrtc-codereview.appspot.com/349002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1382 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 03:07:52 +00:00
pwestin@webrtc.org
c450a19669 Removed Version function from all modules.
TBR=henrik_a
Review URL: http://webrtc-codereview.appspot.com/329023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1330 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 15:00:12 +00:00
punyabrata@webrtc.org
8fa31bc4e5 Truncated messages, need a %S instead of $s for a double byte TCHAR
Review URL: http://webrtc-codereview.appspot.com/333002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1321 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 22:34:15 +00:00
xians@webrtc.org
0744ee563d Disable API tests on ALSA since the tests don't work for all the alsa devices.
Review URL: http://webrtc-codereview.appspot.com/317004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1147 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 14:05:29 +00:00
andrew@webrtc.org
b0be7aa7ae Remove deprecated OS X Core Audio APIs.
We no longer support the 10.4 SDK, so we can remove the weak-leaking
feature and exclusively use the added-in-10.5 APIs.

BUG=issue143
TEST=voe_auto_test

Review URL: http://webrtc-codereview.appspot.com/322001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1136 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 20:15:36 +00:00
xians@webrtc.org
eff3c8905f this patch fixes the valgrind warnings in the adm api test for pulseaudio in linux.
Review URL: http://webrtc-codereview.appspot.com/301012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1108 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-06 10:02:56 +00:00
punyabrata@webrtc.org
c1ed87602a Adding some error handling functionality in the windows audio core implementation to
stop rendering automatically and throw a playout-error callback when RequestPlayoutData
fails
Review URL: http://webrtc-codereview.appspot.com/300003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1080 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-01 17:55:35 +00:00
andrew@webrtc.org
587c844741 Query the capture volume immediately on Win Core.
This allows the capture volume to be queried immediately at capture
startup, rather than waiting the usual one second interval.

Review URL: http://webrtc-codereview.appspot.com/297003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1064 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 17:43:05 +00:00
punyabrata@webrtc.org
c9801465b6 Adding a check to ensure that the memcpy does not exceed bounds of the arrays.
Review URL: http://webrtc-codereview.appspot.com/290007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1055 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 18:49:54 +00:00
braveyao@webrtc.org
0a18522e1b Add support to 96kHz sampling rate to Windows CoreAudio interface.
Review URL: http://webrtc-codereview.appspot.com/295003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1018 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-25 02:45:39 +00:00
kjellander@webrtc.org
543c3eaa46 Fixing Release compilation errors
Review URL: http://webrtc-codereview.appspot.com/267026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1000 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-23 12:20:35 +00:00
braveyao@webrtc.org
7d3e9498bc This CL is to support certain audio devices which don't offer volume control. Try to be more compatible to those rare cases.
Review URL: http://webrtc-codereview.appspot.com/276011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@997 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-23 03:35:42 +00:00
andrew@webrtc.org
5a529395aa Make DMO init safe when not supported.
BUG=issue133
TEST=voe_auto_test

Review URL: http://webrtc-codereview.appspot.com/284001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@990 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-22 18:04:26 +00:00
braveyao@webrtc.org
f556b9d1f4 This modification is supposed to fix the webrtc issue 144/145. With this fix, people could set/get mic volume before StartSend().
Review URL: http://webrtc-codereview.appspot.com/277007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@971 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-18 02:17:28 +00:00
kjellander@webrtc.org
c05b56a38b Fixing compilation error
Review URL: http://webrtc-codereview.appspot.com/276010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@961 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 08:59:48 +00:00
kjellander@webrtc.org
0403ef419f Restructuring and adding unit test targets on project level instead of in common_audio.
Review URL: http://webrtc-codereview.appspot.com/280001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@959 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 08:35:47 +00:00
punyabrata@webrtc.org
81d4499dee Microphone volume on Mac not being printed properly due
to a mismatch in variable type. Additionally, now printing
a volume that will range from 0 - 255
Review URL: http://webrtc-codereview.appspot.com/267016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@951 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-16 02:06:49 +00:00
andrew@webrtc.org
6a85b17a0a Potential fix for crash after Mac sleep.
When a Mac goes to sleep, the OS pauses the IO threads. If a
subsequent StopSend/Playout happens, we time out waiting for the IO
threads, but didn't ensure they were shut down.

BUG=
TEST=voe_cmd_test, voe_auto_test

Review URL: http://webrtc-codereview.appspot.com/269013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@949 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-15 16:23:41 +00:00