Commit Graph

203 Commits

Author SHA1 Message Date
punyabrata@google.com
eba8c32840 Resolving a race condition issue related to using shared devices
(e.g. usb headsets) where we were not stopped the shared callback
until both StopPlayout() and StopRecording() are called. Google
internal bugid 4478351
Review URL: http://webrtc-codereview.appspot.com/130001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@489 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 14:32:22 +00:00
xians@google.com
e74a9ea303 AudioDeviceUtility::WaitForKey() pulls two characters if the first one is a newline, but discards the final value.
The current code assigns that second value to a local variable, which generates a set-but-unused warning on gcc 4.6.0. Instead, cast the result away.

I also refactor the code a bit by adding the right indentation and removing empty lines.

Bug=http://code.google.com/p/webrtc/issues/detail?id=53
Test=none
Review URL: http://webrtc-codereview.appspot.com/135005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@486 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 08:27:02 +00:00
xians@google.com
932096c84f Porting gtalk alsa impl from depot to webrtc
Review URL: http://webrtc-codereview.appspot.com/123002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@484 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 07:41:55 +00:00
mikhal@webrtc.org
46171cf546 video coding tests: Adding a Normal distribution to simulate packet arrival times
Review URL: http://webrtc-codereview.appspot.com/138003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@483 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 23:38:04 +00:00
henrik.lundin@webrtc.org
8571af7be6 Updating to new VP8 rtp format
The VP8 packetizer and tests have been updated to the new
RTP draft (http://tools.ietf.org/html/draft-ietf-payload-vp8-01).
The receive-side parser is also updated, and a new unit test
is implemented for it. Finally, some data traversing work to
get the parsed information into the decoder.
Review URL: http://webrtc-codereview.appspot.com/116011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@482 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 15:37:12 +00:00
hellner@google.com
09734086c6 Fixes build issue in http://code.google.com/p/webrtc/issues/detail?id=56.
Review URL: http://webrtc-codereview.appspot.com/131008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@481 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 14:10:01 +00:00
tina.legrand@webrtc.org
81fd2bfbba New ACM codec database, created at compile time.
Review URL: http://webrtc-codereview.appspot.com/127002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@480 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 11:18:44 +00:00
tina.legrand@webrtc.org
a41b4ce7da Changing iLBC to use the new improved SQRT, WebRtcSpl_SqrtFloor().
The bit-stream has not change with the new SQRT, but the output signal has. The change in output is small, and all test-files pass a subjective quality test.
New test-files will be committed to svn after this CL.
Review URL: http://webrtc-codereview.appspot.com/136001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@478 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 08:19:30 +00:00
tina.legrand@webrtc.org
2aa5d500af Issue reported in WebRTC. A variable is defined and set, but never used.
Review URL: http://webrtc-codereview.appspot.com/139001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@474 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 06:36:37 +00:00
henrik.lundin@webrtc.org
36450af2b3 Removing unsupported codecs from ptypes file
The file ptypes.txt tells test program NetEqRTPplay how to
map the RTP payload types in an RTP file. Now removing payload
types that are not supported in WebRTC.
Review URL: http://webrtc-codereview.appspot.com/119009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@473 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-27 01:25:35 +00:00
andrew@webrtc.org
bd4494cb20 Remove the divide-by-2 when mixing.
Review URL: http://webrtc-codereview.appspot.com/137007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@471 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 22:58:00 +00:00
mikhal@webrtc.org
b7ac56d92b video coding tests: updating quality tests following r466
Review URL: http://webrtc-codereview.appspot.com/131009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@470 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 21:18:35 +00:00
mikhal@webrtc.org
d24a97fae1 video coding test: deleting unused file(resampler_test.cc)
Review URL: http://webrtc-codereview.appspot.com/137008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@469 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 21:18:17 +00:00
mikhal@webrtc.org
2c3b1fb4f3 video_coding tests: removing unused functionality from test_util
Review URL: http://webrtc-codereview.appspot.com/137009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@468 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 21:18:04 +00:00
mikhal@webrtc.org
a057a9561c video_coding: Updating protection logic in media optimization utility:
1. Changing protection logic structure: Accepts only one method (not a list)
2. Removed unused code (unreferenced protection methods)
3. Removed inline constructors/destructors.  
Review URL: http://webrtc-codereview.appspot.com/120005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@467 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 21:17:34 +00:00
mikhal@webrtc.org
552f173979 video_coding: Moving video metrics computation to a designated file.
This is the first stage of a general clean-up to test_util. Will try to divide this clean-up to small changes, so it will be easier to review. 
Review URL: http://webrtc-codereview.appspot.com/120004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@466 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 17:38:09 +00:00
andrew@webrtc.org
e46d69f762 Fix gcc 4.6 set but unused warnings in AEC.
Review URL: http://webrtc-codereview.appspot.com/134003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@465 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 17:20:54 +00:00
andrew@webrtc.org
ffbe7a75fd Cast away the unused state argument value to silence gcc 4.6 warnings.
The WebRTC C wrapper for the G711 codec doesn't actually use the 'state' 
argument, but declares one anyway for API uniformity.

At the beginning of functions like WebRTCG711_EncodeA(), there's a stanza:

    // Set to avoid getting warnings
    state = NULL;

This might work around an unused parameter warning, but under gcc 4.6.0 
it ends up generating another warning, that state is set but not used.  

Casting the assignment to void silences the warning, restoring 
compilation under -Werror.

Reported as https://code.google.com/p/webrtc/issues/detail?id=50
Review URL: http://webrtc-codereview.appspot.com/135002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@463 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 17:16:30 +00:00
turajs@google.com
7f2bbbbefd To remove all calls involving scratch-memory
Review URL: http://webrtc-codereview.appspot.com/129001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@462 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 16:03:49 +00:00
turajs@google.com
ac55f7b33c Review URL: http://webrtc-codereview.appspot.com/115004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@461 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 16:02:16 +00:00
xians@webrtc.org
c57f9c38ad Using IAudioEndpointVolume in IsSpeakerMuteAvailable and IsMicrophoneMuteAvailable to be consistent with SpeakerMute and MicrophoneMute APIs.
Review URL: http://webrtc-codereview.appspot.com/112007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@458 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 12:28:33 +00:00
mflodman@webrtc.org
4fcb0caf78 Removing warning in video capture module for linux and auto test.
Review URL: http://webrtc-codereview.appspot.com/134002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@457 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 10:54:48 +00:00
mikhal@webrtc.org
ba9bd692ea video_coding_tests: Fix build error
Review URL: http://webrtc-codereview.appspot.com/132001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@452 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-25 20:12:03 +00:00
stefan@webrtc.org
44d356d6df Fix unused variable warning in spatial_resampler.cc
Issue 60: [Patch] Fix unused variable warning in spatial_resampler.cc
Review URL: http://webrtc-codereview.appspot.com/125003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@444 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-25 07:53:53 +00:00
turajs@google.com
5cc9c68e8d Fixing a warning discovered while compiling with clang.
Review URL: http://webrtc-codereview.appspot.com/120003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@441 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 21:20:33 +00:00
marpan@google.com
057efc8f98 Removed unused variables and unnecessary assert: causing build error in vpm_test.
Review URL: http://webrtc-codereview.appspot.com/128001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@440 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 20:53:15 +00:00
andrew@webrtc.org
4f390000dd Fix warnings on Ubuntu 11.04 (gcc 4.5)
http://code.google.com/p/webrtc/issues/detail?id=63
Review URL: http://webrtc-codereview.appspot.com/125004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@439 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 20:35:35 +00:00
wu@webrtc.org
37fd004c69 Remove the X11 headers we don't need.
Review URL: http://webrtc-codereview.appspot.com/123003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@438 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 17:06:38 +00:00
frkoenig@google.com
cf36b2aa9b Match new[] / delete []
Quiet valgrind warnings by correctly matching 
new[] with delete[].
Review URL: http://webrtc-codereview.appspot.com/126005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@437 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 15:48:47 +00:00
stefan@webrtc.org
49cbc512ae Fix unused variable warning in video_coding.
Issue 57: [Patch] Fix unused variable warnings in the video_coding module
Review URL: http://webrtc-codereview.appspot.com/126004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@435 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 08:51:08 +00:00
andrew@webrtc.org
7f593c1e62 Fix gcc 4.6 unused variable warnings in audio_processing.
Issues:
http://code.google.com/p/webrtc/issues/detail?id=54
http://code.google.com/p/webrtc/issues/detail?id=55
Review URL: http://webrtc-codereview.appspot.com/121003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@434 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 01:00:50 +00:00
mikhal@webrtc.org
6724cf8183 VP8: Adding a flag to indicate the libvpx version. When in Cayuga, additional API's will be used.
Review URL: http://webrtc-codereview.appspot.com/120006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@433 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 00:51:36 +00:00
wjia@google.com
4482b04207 revert r430 to keep webrtc always ready to roll in chromium.
r430 will be used when libvpx in chromium is rolled to Cayuga.
Review URL: http://webrtc-codereview.appspot.com/119008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@431 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 23:41:00 +00:00
wjia@google.com
f9f1deba8f Get ready for libvpx Cayuga (v0.9.7-p1).
When building with Chromium, on Windows, only header files are needed; otherwise, libvpx.gyp:libvpx is needed.

This patch is based on http://webrtc-codereview.appspot.com/91019/
Review URL: http://webrtc-codereview.appspot.com/122005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@430 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 23:08:30 +00:00
hellner@google.com
a386fc0a8b Fixes build warnings due to unused variables.
Code directly from http://code.google.com/p/webrtc/issues/detail?id=58.
Review URL: http://webrtc-codereview.appspot.com/119007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@428 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 21:26:09 +00:00
hellner@google.com
9aa9996a19 Different solution than the one suggested in http://code.google.com/p/webrtc/issues/detail?id=56 however, should solve the same problem.
Review URL: http://webrtc-codereview.appspot.com/126003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@427 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 21:25:55 +00:00
andrew@webrtc.org
ceb148ce59 Fix compile warnings in Release configuration.
Review URL: http://webrtc-codereview.appspot.com/119003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@424 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 17:53:54 +00:00
mikhal@webrtc.org
06ad81fd58 video_coding: changing the UpdateMethod function (protection settings).
Review URL: http://webrtc-codereview.appspot.com/126002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@423 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 16:03:59 +00:00
perkj@google.com
12f1fc4fe5 Fix initialization defect in constructor webrtc::ModuleRtpRtcpImpl::ModuleRtpRtcpImpl(WebRtc_Word32, bool) initialization list.
Review URL: http://webrtc-codereview.appspot.com/125002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@422 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 14:26:33 +00:00
perkj@google.com
a3fc1aac52 Fix Issue 59. Fix a constructor cast warning in video_X11_channel.cc.
http://code.google.com/p/webrtc/issues/detail?id=59.
Review URL: http://webrtc-codereview.appspot.com/122002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@421 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 13:38:14 +00:00
pwestin@webrtc.org
a070adbab2 Moved member RTPSender from private to protected.
Review URL: http://webrtc-codereview.appspot.com/119006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@420 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 11:17:03 +00:00
xians@webrtc.org
9d64705dea The method AudioDeviceWindowsWave::RecProc can use uninitialized variables t1 and t2.
This results in an exception in debug mode and unpredictable behavior in release mode.

The problem is at line 3514:

        // Calculate processing time
        consumedTime = (int)(t2.QuadPart-t1.QuadPart);

Bug=http://code.google.com/p/webrtc/issues/detail?id=42
Test=none
Review URL: http://webrtc-codereview.appspot.com/121002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@419 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 09:14:56 +00:00
punyabrata@webrtc.org
5895ea1573 Fixes volume problem controls, happening with some Logitech headsets. Originally submitted as gips p4 depot CL 38122.
Review URL: http://webrtc-codereview.appspot.com/116008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@418 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-22 22:46:38 +00:00
punyabrata@google.com
9695e75fbd Resolve a crash related to pulseAudio where we need to check if
pa_context_get_source_info_by_name/pa_context_get_sink_info_by_name 
has early failure and returns NULL,then to avoid WaitForOperationCompletion
from crashing, paOperation must be checked to ensure it is not NULL.

Please note that ::WaitForOperationCompletion( ) is a void function
therefore returning without any error code if paOperation is indeed NULL

Google internal bug id [4356730]
Review URL: http://webrtc-codereview.appspot.com/122003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@417 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-22 22:35:14 +00:00
cduvivier@google.com
288c8698cb Optimization of 'cftmdl':
* scalar optimization, vectorization.
* 1.7% AEC overall speedup for the straight C path.
* 9.2% AEC overall speedup for the SSE2 path.
Review URL: http://webrtc-codereview.appspot.com/109008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@416 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-22 21:55:33 +00:00
mikhal@webrtc.org
0e16b78ec9 VP8: Removing VP8Latest flag following the update to the Cayuga release
Review URL: http://webrtc-codereview.appspot.com/116012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@415 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-22 21:25:39 +00:00
mikhal@webrtc.org
d70b77d19f video_coding: Updating offline tests
1. Adding parameters to the  input arguments. 
2. Introducing delay in the RTPSend callback
3. Clean-up
Review URL: http://webrtc-codereview.appspot.com/116006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@414 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-22 21:08:15 +00:00
andrew@webrtc.org
f81f9f8c2a Add -Werror and -Wextra to the Linux build.
Includes all fixes required for -Wextra.
Review URL: http://webrtc-codereview.appspot.com/117006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@410 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-19 22:56:22 +00:00
frkoenig@google.com
9139fddf0e Optimize ssim_8x8 for SSE2.
Code was pulled from libvpx assembly and converted
to intrinsics.
Review URL: http://webrtc-codereview.appspot.com/122001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@409 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-19 22:33:08 +00:00
andrew@webrtc.org
6423509efc Fix Valgrind warnings in audio_processing.
Review URL: http://webrtc-codereview.appspot.com/119001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@408 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-19 21:22:08 +00:00