pwestin@webrtc.org
1cd1162c7a
Break out of send side bandwidth estimation and controll.
...
Review URL: https://webrtc-codereview.appspot.com/490010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2064 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 12:13:52 +00:00
asapersson@webrtc.org
a768970bac
Parse out ssrcs in REMB message (needed for ViCE) .
...
Review URL: https://webrtc-codereview.appspot.com/486003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2061 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 07:01:29 +00:00
tina.legrand@webrtc.org
faa0ab85d7
NetEQ stereo sync
...
This CL allows NetEQ to do expand at startup, to make master and slave always go in sync. Before it could happen that master did merge, while slave performed an expand, leading to sync-problems between the channels.
Updating DEPS for new reference files for unittest.
BUG=410
TEST=neteq_unittests
Review URL: https://webrtc-codereview.appspot.com/487005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2055 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 17:59:53 +00:00
leozwang@webrtc.org
16f6bb35b6
Fix a minor compilation error on android
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/479014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2053 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 16:49:06 +00:00
bjornv@webrtc.org
4ade5506eb
Delay Estimator Unit tests
...
This CL includes unit tests to verify correct behavior of the delay estimator used in AEC and AECM.
Tested with audioproc_unittest
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/491009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2049 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 09:42:16 +00:00
bjornv@webrtc.org
2e729762c7
New _CreateBinaryDelayEstimator() and removed _history_size()
...
Changed create function to match malloc() in functionality.
Removed unused function.
Tested with audioproc_unittest
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/491010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2048 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 08:30:29 +00:00
bjornv@webrtc.org
180f83f8e2
File name change to follow style
...
A unit test should end with *_unittest.* Otherwise the test itself will be evaluated for line coverage.
Tested with audioproc_unittest
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/493008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2045 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 07:01:10 +00:00
andrew@webrtc.org
1bc98bc873
Remove erroneous error trace.
...
It appears this trace is informational, not an error.
Discovered in a plugin log from a ChromeOS device. Just
decided to remove it.
BUG=http://code.google.com/p/chromium-os/issues/detail?id=29356
TEST=build on Linux
Review URL: https://webrtc-codereview.appspot.com/479012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2043 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 20:10:47 +00:00
tommi@webrtc.org
7ab51497a7
Remove usage of Atomic32Wrapper from a few places.
...
In these places, it doesn't make much sense to use an atomic variable we were using
Atomic32Wrapper::operator= anyway (which does not use atomic operations).
Review URL: https://webrtc-codereview.appspot.com/492005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2042 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 13:33:28 +00:00
hta@webrtc.org
52c0fec34c
Added UDP socket factory function to UdpTransportImpl constructor
...
This is a refactoring in preparation for creating small unit tests for the
udp_transport module.
BUG=
TEST=unittest
Review URL: https://webrtc-codereview.appspot.com/482004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2041 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 12:39:04 +00:00
marpan@webrtc.org
3e2e7038e6
VPM: Allow for option to compute the content metrics every nth frame.
...
Review URL: https://webrtc-codereview.appspot.com/492006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2034 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 15:58:14 +00:00
mflodman@webrtc.org
b1fbf016b5
Added timestamp logs, i.e. only tracing.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/482001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2030 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 12:58:49 +00:00
mflodman@webrtc.org
3c611fd4fd
Removed NetEQ Test compile error.
...
BUG=443
TEST=Compiles using clang version 3.1 (trunk 153589)
Review URL: https://webrtc-codereview.appspot.com/493005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2029 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 10:57:27 +00:00
xians@webrtc.org
aef0a61117
webrtc: OTHER_CPLUSPLUSFLAGS should be a list, not a string.
...
Review URL: https://webrtc-codereview.appspot.com/492007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2028 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 09:57:16 +00:00
bjornv@webrtc.org
bfda85f2ee
Safe handling of invalid inputs in delay_estimator.
...
The delay_estimator crash on invalid create inputs when running new unit tests. This can't occur on a higher level unless corresponding enum and defines are incorrectly changed.
The create and free functions are now more like malloc() and free() in design. The complete change to that will be done in a seperate CL.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/492003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2027 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 07:28:29 +00:00
mflodman@webrtc.org
a014ecc049
Changed CriticalSectionScoped constructor usage for ADM.
...
Only search and replace for the input to the constructor, no other changes.
BUG=184
TEST=Compiles on all platforms.
Review URL: https://webrtc-codereview.appspot.com/483001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2015 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 12:15:51 +00:00
bjornv@webrtc.org
7056908774
System delay unit tests
...
Added a system delay test class. Noticed I don't need the ApmTest class at all, which simplified the implementation.
Start at patch set 3. The others are not complete.
BUG=None
TEST=
Review URL: https://webrtc-codereview.appspot.com/475003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2014 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 12:13:50 +00:00
tina.legrand@webrtc.org
16b6b90a82
Split of stereo packets moved
...
In this CL I have rewritten the way we handle stereo packets in VoE.
Before this change we split the packets in the RTP module and added two packets to ACM, one for the left channel and one for the right. This lead to timing problems caused when a different thread called RecOut in between the two calls to add stereo packet to ACM. (RecOut is called to pull audio data, decode packets, on the receiving side).
While doing the change I also took the opportunity to changed some functions so that the data stream is uint8 everywhere.
The list of files in this CL is long, but should be fairly easy to review. It is difficult to see what has been changed in some of the tests, but I can explain offline.
Reviewers:
Björn - /src/modules/audio_coding
Patrik - /src/modules/rtp_rtcp
Patrik -/src/modules/utility
Henrik A - /src/voice_engine
BUG=410
TEST=voe_cmd_test
Review URL: https://webrtc-codereview.appspot.com/473003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2012 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 11:02:38 +00:00
pwestin@webrtc.org
ce33035dee
Cleanup encode call.
...
Review URL: https://webrtc-codereview.appspot.com/491003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2011 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 06:59:14 +00:00
stefan@webrtc.org
c35f5ced92
Enable multi-frame FEC by default for temporal layers <= 2. For two temporal layers we currently only protect the base layer.
...
This also introduces zero column insertion into packet masks when some sequence numbers deliberately haven't been given to the FEC generator.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/477001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2005 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-11 07:42:25 +00:00
cd@webrtc.org
85b4a1b715
Special version of 'bitrv2' when len is 128:
...
* 5.5% AEC overall speedup for the straight C path.
* 8.6% AEC overall speedup for the SSE2 path.
Review URL: https://webrtc-codereview.appspot.com/480001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2004 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-10 21:25:17 +00:00
leozwang@webrtc.org
91ed80e5c3
Correct wrong trace level
...
Review URL: https://webrtc-codereview.appspot.com/487002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2002 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-10 14:42:20 +00:00
tommi@webrtc.org
98ad0ff1b0
Move the COMPILE_ASSERT macro to its own header file.
...
TEST=n/a
BUG=none
Review URL: https://webrtc-codereview.appspot.com/492002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2001 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-10 11:53:07 +00:00
andrew@webrtc.org
e713fd0eee
Enable the "unused variable" warning on Windows.
...
- Break out direct_show_base_classes to its own gyp file to have it
treated as third party code.
- Fix the resulting warnings (courtesy of Tommi).
BUG=
TEST=build on Windows (vie_auto_test currently failing at HEAD)
Review URL: https://webrtc-codereview.appspot.com/489001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2000 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-10 07:13:46 +00:00
pwestin@webrtc.org
cac787842c
New attempt to cleanup TMMBR.
...
Review URL: https://webrtc-codereview.appspot.com/472007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1990 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-05 08:30:10 +00:00
cd@webrtc.org
70ed0a6f91
No casting and call lower precision trigonometric functions:
...
* 2.2% AEC overall speedup for the straight C path.
* 2.4% AEC overall speedup for the SSE2 path.
Review URL: https://webrtc-codereview.appspot.com/477002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1989 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-05 00:38:55 +00:00
leozwang@webrtc.org
f3dc22f7d1
Reformat android related code
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/472004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1988 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-04 17:15:42 +00:00
pwestin@webrtc.org
ae19720982
Fixed assert strings where string literals are used as booleans.
...
Review URL: https://webrtc-codereview.appspot.com/473002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1986 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-04 14:43:54 +00:00
leozwang@webrtc.org
0dc8efe6e6
Fix wrong data type in ReadWavHeader
...
BUG=409
TEST=media file unit test
Review URL: https://webrtc-codereview.appspot.com/474001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1980 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-03 15:11:01 +00:00
henrike@webrtc.org
0ad51862dc
Revert 1961 - Clean up TMMBR handling.
...
Review URL: https://webrtc-codereview.appspot.com/465001
TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/473001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1967 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-30 16:54:13 +00:00
marpan@webrtc.org
3a6080d4c0
FEC Decoding: Insert the received media packets directly into VCM without going
...
through the recovered packet list. Avoids an issue with very old re-transmitted packets.
Updated the receiver_fec unittest accordingly.
Review URL: https://webrtc-codereview.appspot.com/465003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1966 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-30 16:16:21 +00:00
pwestin@webrtc.org
20f4440c73
Clean up TMMBR handling.
...
Review URL: https://webrtc-codereview.appspot.com/465001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1961 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-30 11:40:15 +00:00
xians@webrtc.org
010a4e8f0b
Fix the converity warnings:
...
CID 10177: Array compared against 0 (NO_EFFECT)
Comparing an array to null is not useful: "this->_paServerVersion".
Review URL: https://webrtc-codereview.appspot.com/466001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1956 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-29 14:05:04 +00:00
andrew@webrtc.org
952f601405
Fix Linux-release errors and Valgrind errors.
...
BUG=
TEST=build on Linux release.
TBR=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/456008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1949 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-27 18:30:26 +00:00
andrew@webrtc.org
61b1b4b472
Fix neteq-rtpplay Linux build errors.
...
BUG=
TEST=build on Linux.
TBR=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/457007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1948 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-27 17:33:29 +00:00
andrew@webrtc.org
f589dfede4
Merge header-only neteq-rtpplay changes.
...
TEST=build
Review URL: https://webrtc-codereview.appspot.com/452003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1947 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-27 17:05:44 +00:00
mflodman@webrtc.org
534a435751
Removed RTP Keepalive from RTP module.
...
Review URL: https://webrtc-codereview.appspot.com/455007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1942 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-27 06:57:41 +00:00
stefan@webrtc.org
38f247d800
Fixes an issue in the FEC decoder where a big jump in sequence numbers may cause new packets to be discarded if there is a wrap around.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/455003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1934 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-23 22:34:14 +00:00
stefan@webrtc.org
af5ffd5bb9
Fixes for coverity warnings.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/461001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1933 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-23 16:01:15 +00:00
tina.legrand@webrtc.org
196e491c46
Adding init decode slave to celt
...
Minor rearanging of calls. Added a init function to the slave channel of CELT.
Review URL: https://webrtc-codereview.appspot.com/458005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1931 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-23 14:39:46 +00:00
tina.legrand@webrtc.org
c231e4cb03
Fixing bug in re-packing of stereo packets.
...
BUG=341
TEST=voe_cmd_test, run G.722. First modify /src/modules/audio_coding_main/source/acm_codec_database.cc
@@ -149,7 +149,7 @@ const CodecInst ACMCodecDB::database_[] = {
{kDynamicPayloadtypes[count_database++], "CELT", 32000, 320, 2, 64000},
#endif
#ifdef WEBRTC_CODEC_G722
- {9, "G722", 16000, 320, 1, 64000},
+ {9, "G722", 16000, 320, 2, 64000},
#endif
#ifdef WEBRTC_CODEC_G722_1
Review URL: https://webrtc-codereview.appspot.com/454001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1930 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-23 10:01:11 +00:00
pwestin@webrtc.org
1f569222b2
Clean up coverity warnings.
...
Review URL: https://webrtc-codereview.appspot.com/456003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1928 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-23 09:04:16 +00:00
phoglund@webrtc.org
4aa57b4150
Extracted a helper library from vie_auto_test.
...
This CL does not attempt to fix the style issues in the moved tb_ files, at least not yet. In general I've tried to avoid dependencies between the library and vie_auto_test: vie_auto_test depends on the library but not the other way around. I had to make some slight changes to achieve this. I had to remove some ViETest::Log statements in tb_interfaces.cc and I had to move knowledge of where to put output files to the library. I think it ended up being pretty clean in the end but let me know if I missed something. I tried to convert all paths I touched to src-relative paths, so look out if I missed something there.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/450004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1923 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-22 12:56:54 +00:00
stefan@webrtc.org
c8e4886774
Upgrade libvpx to 6b66c01 and enabling temporal denoising.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/448006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1921 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-21 16:52:03 +00:00
marpan@webrtc.org
6503ecdc39
Fix to windows test from commit 1914.
...
Review URL: https://webrtc-codereview.appspot.com/455002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1917 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-21 00:18:13 +00:00
marpan@webrtc.org
3fe3252cb3
Fix to windows build from commit 1914.
...
Review URL: https://webrtc-codereview.appspot.com/456002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1916 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-20 22:13:24 +00:00
stefan@webrtc.org
e0d6fa4c66
Adding classes for handling multi-frame FEC.
...
The FEC behavior is unchanged with this commit, we will still be
limited to FEC over one frame for now.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/450006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1915 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-20 22:10:56 +00:00
marpan@webrtc.org
e22d81ce4d
Updates to resolution adpatation:
...
-moved calculation of selected frame size & frame rate to qm_select class.
-various updates to qm_select class (switch to 1/2 from 2 stages of 3/4,
include native frame rate for going up temporal, favor spatial action for temporal layers,..).
-updates to unittest.
Review URL: https://webrtc-codereview.appspot.com/450008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1914 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-20 18:21:53 +00:00
leozwang@webrtc.org
ac9fd8af09
Change folder name from Android to android
...
Review URL: https://webrtc-codereview.appspot.com/447012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1912 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-19 21:09:42 +00:00
stefan@webrtc.org
b9c50b68bf
Revert commit 1908.
...
Review URL: https://webrtc-codereview.appspot.com/452009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1909 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-17 00:56:36 +00:00