generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
2,287 Commits 1 Branch 0 Tags 108 MiB
ddfdfed3b5
Commit Graph

1716 Commits

Author SHA1 Message Date
tina.legrand@webrtc.org
4517585db5 Adding separate payload types for stereo modes 
BUG=Issue 452
TEST=audio_coding_test, voe_auto_test, voe_cmd_test

Edit: adding Patrik to review:
src/modules/rtp_rtcp/source/rtp_receiver.cc
...and Shijing to review:
src/voice_engine/main/source/channel.cc
src/voice_engine/main/test/cmd_test/voe_cmd_test.cc

Review URL: https://webrtc-codereview.appspot.com/540004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2340 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-06-01 09:27:35 +00:00
pwestin@webrtc.org
c2722a0e68 Fixed compiler warning 
Review URL: https://webrtc-codereview.appspot.com/624005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2339 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-06-01 08:56:42 +00:00
stefan@webrtc.org
f5d934dfd8 Upgrade libvpx to cab6ac16 (v. 1.1.1 pre-point-release). 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/619004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2337 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-06-01 07:43:02 +00:00
andrew@webrtc.org
7d8c567982 Ignore return value of fwrites. 
The removed error return was of course failing in the void ProcessBlock.
Ignored the returns of the remaining fwrites as well for consistency.

TBR=leozwang@webrtc.org
BUG=none
TEST=run audioproc with debug enabled

Review URL: https://webrtc-codereview.appspot.com/623004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2336 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-06-01 02:41:14 +00:00
kjellander@webrtc.org
2e84c112f5 Updating bitrate controller tests to test naming conventions. 
The test is now named 'bitrate_controller_unittests'.
This CL also enables it on the bots. The test is excluded on ASAN since
it fails when compiled with projects generated with GYP_DEFINES='asan=1' (see issue 555).

BUG=None
TEST=bitrate_controller_unittests was tested in Debug+Release on Linux, Mac and Windows + TSAN and memcheck.

Review URL: https://webrtc-codereview.appspot.com/612004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2333 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-31 13:55:01 +00:00
phoglund@webrtc.org
baaf2434a7 Extracted a method for sending padded data. 
BUG=
TEST=Ran vie_auto_test and voe_auto_test standard tests.

Review URL: https://webrtc-codereview.appspot.com/605004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2332 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-31 10:47:35 +00:00
andrew@webrtc.org
36ccce4f58 Remove documentation folders. 
Review URL: https://webrtc-codereview.appspot.com/606007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2329 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-30 17:28:24 +00:00
andrew@webrtc.org
16fcb247b2 Disable flaky VolumeTests only on Linux. 
BUG=issue367
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/611005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2328 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-30 17:26:32 +00:00
leozwang@webrtc.org
e7e64e3468 Fix compilation errors on ChromeOS 
Description:
This cl fixes two compilation errors on ChromeOS/ARM, it could
also be reproduced by gcc 4.5+.

I also add comments about error message and how I solve them.

BUG=webrtc issue 554
TEST=try bots and build on chromeos arm
Review URL: https://webrtc-codereview.appspot.com/611006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2327 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-30 16:46:09 +00:00
niklas.enbom@webrtc.org
0cb79cc851 Fixing gyp bug in https://webrtc-codereview.appspot.com/599006 
Review URL: https://webrtc-codereview.appspot.com/609006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2325 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-30 14:32:42 +00:00
stefan@webrtc.org
dc257b5781 Add option to configure error concealment and disable by default. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/597005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2324 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-30 11:25:00 +00:00
mflodman@webrtc.org
327ada1cb0 Refactored IncomingVideoStream and VideoRenderFrame, to get code in better shape when hunting BUG=481. 
BUG=481
TEST=Compiles on all platformas and autotest passes.

Review URL: https://webrtc-codereview.appspot.com/608005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2323 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-30 10:45:18 +00:00
bjornv@webrtc.org
281b7983db Resolved Coverity warnings. 
This CL includes changes to resolve Coverity warnings 14086, 14110 and 14111.

Tested with trybots and audioproc_unittests.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/606004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2321 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-30 07:41:57 +00:00
leozwang@webrtc.org
b5ea03adbb Add print out stats summary to integrationtest.cc 
Stats summary prints out cpu usage.

BUG=
TEST=test on linux
Review URL: https://webrtc-codereview.appspot.com/602004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2320 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-30 00:34:50 +00:00
andrew@webrtc.org
459955f821 Move audio_frame_operations to the utility module. 
TBR=henrika@webrtc.org
BUG=issue551
TEST=voe_auto_test, webrtc_utility_unittest, trybots

Review URL: https://webrtc-codereview.appspot.com/599006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2318 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-29 22:13:14 +00:00
andrew@webrtc.org
aafa49bb85 Disable flaky VolumeTest.DefaultSpeakerVolumeIsAtMost255. 
This test failed on six CLs in a row recently.

TBR=xians@webrtc.org
BUG=issue367
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/595007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2317 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-29 22:05:15 +00:00
andrew@webrtc.org
5f23d64cf2 Set the stream delay to zero if too low. 
- Return a stream warning instead of an error.
- Add a few delay offset tests.

BUG=
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/607004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2316 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-29 21:14:06 +00:00
leozwang@webrtc.org
2fc6e388c0 Check return value of fwrite. [Video Module] 
Description:
On ChromeOS/ARM, compiler enforces to check return result of a function.
Currently, we don't check return result of fwrite, it causes building errors.

The following files need to patch. The patch should be similar, before I patch all
of them, I will start with 3 files, once we agree upon the solution, we will expand
it to all of them.

The question is should we do 
1. if (error) { return -1;} 
or 
2. if (error) { /*ignor the error*/ }

I took "return -1" in this patch, but I'm OK with either. Please let me know your
thoughts and I will upload a new patch.
Review URL: https://webrtc-codereview.appspot.com/583010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2315 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-29 17:33:13 +00:00
pwestin@webrtc.org
1eef9c16ff Bitrate bugfixes 
Review URL: https://webrtc-codereview.appspot.com/609005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2313 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-29 09:28:43 +00:00
stefan@webrtc.org
5abab0b1b5 Revert 2311 - Disable error concealment. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/609004

TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/604006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2312 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-29 09:04:40 +00:00
stefan@webrtc.org
3348b2990b Disable error concealment. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/609004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2311 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-29 08:44:00 +00:00
mflodman@webrtc.org
ca8d788362 Fix a bug where a RAII object was created for just one line instead of a block. 
Found by clang:

../../third_party/webrtc/video_engine/vie_render_manager.cc:157:3: error: expression result unused [-Werror,-Wunused-value]
  ViEManagerWriteScoped(*this);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Review URL: https://webrtc-codereview.appspot.com/599005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2309 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-28 18:56:20 +00:00
phoglund@webrtc.org
dbaa893525 Completed rewrite of APM extended test. 
Removed NS tests since they are already covered by audio_processing_test.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/603004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2308 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-28 14:36:59 +00:00
bjornv@webrtc.org
1747427861 VAD Refactoring: Replaced pointer operation with array index 
This CL contains a change of pointer nomenclature to array index. In addition, one place with two hard coded Gaussians has been generalized with a for loop.

Tested with trybots, vad_unittests, audioproc_unittest

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/592004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2307 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-28 12:50:05 +00:00
bjornv@webrtc.org
4e12d3065e VAD Refactoring: Removed assign calls 
These calls are not used anywhere in WebRTC and there is no plan on using them.
Removed them and updated corresponding unit tests.

Tested on trybots, vad_unittests, audioproc_unittest

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/608004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2306 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-28 12:25:07 +00:00
tina.legrand@webrtc.org
0de1ee3830 NetEQ: Remove an unnecessary condition, to fix a clang warning 
This is a duplicate of issue 606005: https://webrtc-codereview.appspot.com/606005/

BUG=
TEST=neteq_unittests

Review URL: https://webrtc-codereview.appspot.com/605005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2305 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-28 11:37:50 +00:00
kma@webrtc.org
0d321da7e1 Refactored ARM specific code in Noise Suppression. Bit exact. 
Review URL: https://webrtc-codereview.appspot.com/459006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2303 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-26 01:05:27 +00:00
leozwang@webrtc.org
1755a57cbc Check return result of fwrite, [APM] 
Description:
This cl added checking return result of fwrite which makes it compile
on ChromeOS/ARM.

BUG=issue:541
TEST=Build on all platforms
Review URL: https://webrtc-codereview.appspot.com/583009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2302 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-25 19:20:35 +00:00
leozwang@webrtc.org
f14575fd8e Dynamically load codec list 
Description:
This cl adds a feature that can query video engine and voice engine and load code list in
gui settings. Currently, codec lists are fixed in resource file, it caused confusion and
problems.

TBR=ronghua
BUG=
TEST=test on android
Review URL: https://webrtc-codereview.appspot.com/583006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2301 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-25 16:47:56 +00:00
leozwang@webrtc.org
351fb6d3b4 Exclude code that don't work on android in voe_cmd_test 
Description:
Ths cl makes voe_cmd_test work on android by excluding some code
that are availabel on android today, some highlights
1. change maxnumofchannles
2. disable audio device selection
3. disable set/get volume

BUG=
TEST=test on try bots
Review URL: https://webrtc-codereview.appspot.com/584009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2300 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-25 16:47:35 +00:00
turaj@webrtc.org
10d3b5239b I haven't done any refactoring here. 
Resolve coverity warnings.

14305.

The warning is not really valid. The 'decode' function should be called with a 'mode' variable, where inside the function it is assumed that mode is either zero or one. If mode is taking other values some varibles are used uninitialized. However, this is an internal function and it is always called with either ZERO or ONE. Therefore, the code operates correctly. I made small changes as I beleive it is a bit nicer way. 

In ACM:
- Conditions on 'mode' is changed.


Tested with trybots.

BUG=None
TEST=None
Review URL: https://webrtc-codereview.appspot.com/564014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2297 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 21:20:25 +00:00
andrew@webrtc.org
f45d47ad7d Remove mixing tests from voe_extended_test.cc 
These have been moved to:
src/voice_engine/main/test/auto_test/standard/mixing_test.cc

BUG=
TEST=build voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/588005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2296 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 17:27:59 +00:00
andrew@webrtc.org
51b4f3e6a8 Try to fix MixingTest on the Win bots. 
- Relax the constraints on recording duration.
- Remove unneeded file deletes. (These files will be properly
  overwritten anyway).

TBR=henrike@webrtc.org
BUG=issue534
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/600006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2295 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 17:26:05 +00:00
stefan@webrtc.org
42e78ac087 Disable normal_async_test and rename tests to vp8_integrationtests. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/598004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2294 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 14:36:34 +00:00
mflodman@webrtc.org
6af9594d71 Added gyp variable to include/exclude all tests. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/597004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2292 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 13:23:35 +00:00
niklas.enbom@webrtc.org
ee646c37d4 I know this is ugly, but it helps a lot to quickly update webRTC in Chrome and libJingle. 
Review URL: https://webrtc-codereview.appspot.com/596004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2290 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 11:41:02 +00:00
pwestin@webrtc.org
2d1fc9bf17 Added critical section to prevent race. 
Review URL: https://webrtc-codereview.appspot.com/595004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2289 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 11:28:31 +00:00
pwestin@webrtc.org
5c3a400fae Re-added ChangeUniqueId temporary for chrome. 
Review URL: https://webrtc-codereview.appspot.com/594004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2287 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 09:52:19 +00:00
andrew@webrtc.org
7fbfc4ce79 Use correct variable in trace. 
TBR=leozwang@webrtc.org
TEST=build

Review URL: https://webrtc-codereview.appspot.com/593004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2284 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 22:22:36 +00:00
andrew@webrtc.org
f98b6cc10e Remove noise during build on Win32 
TBR=niklas.enbom@webrtc.org
BUG=chromium:126483

Review URL: https://webrtc-codereview.appspot.com/590006
Patch from Scott Graham <scottmg@chromium.org>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2283 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 18:49:47 +00:00
hta@webrtc.org
40300131dc No more TSAN errors on start_stop 
A very pedestrian approach to making TSAN stop complaining about the state variables: Wrap them in a critical section.
More creative approaches can be considered.

(not sure if diffbase works here, but...)
DIFFBASE=583008

BUG=webrtc:300
TEST=

Review URL: https://webrtc-codereview.appspot.com/584008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2282 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 15:49:48 +00:00
turaj@webrtc.org
ea0aa13aa8 I haven't done any refactoring here. 
Resolve coverity warnings.

14240, 14241.

In ACM:
- NULL pointer sanity checks corrected.

Tested with trybots.

BUG=None
TEST=None
Review URL: https://webrtc-codereview.appspot.com/571012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2281 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 15:43:51 +00:00
andrew@webrtc.org
9dc45dad1b Move trunk/test/data -> trunk/data 
BUG=
TEST=all trybot test failures passed locally

Review URL: https://webrtc-codereview.appspot.com/583007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2280 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 15:39:01 +00:00
hta@webrtc.org
1484ac07cb Replaced 2 time functions with thread-safe equivalents 
This does not fix bug 544, but changes where it reports issues.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/578008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2279 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 15:39:17 +00:00
stefan@webrtc.org
78d8d99180 Fixes the vp8_test on Linux. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/579015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2277 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 14:18:56 +00:00
bjornv@webrtc.org
cb0a86e913 VAD refactoring: Added function for repeated code. 
Added WeightedAverage() to calculate global mean. This removes hard coded Gaussian model size and repeated code.

Tested with vad_unittests, audioproc_unittest and trybots.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/571006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2275 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 07:56:51 +00:00
andrew@webrtc.org
a1a34d675f Avoid flakiness by skipping more output verification. 
- Add a SCOPED_TRACE in case it flakes out again.
- The test doesn't need to be very long, so shorten it to save the bots some time.

TBR=henrike@webrtc.org
BUG=
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/588006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2273 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 00:45:00 +00:00
hta@webrtc.org
6ed617be22 Fixing memory leak error in test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/571013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2272 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 16:55:16 +00:00
marpan@webrtc.org
747cd87da1 FEC: For multi-frame FEC, allow for the size of the code to be increased, 
under certain conditions. This generally improves the FEC recovery for 
     bursty loss under medium-high protection level.
Review URL: https://webrtc-codereview.appspot.com/566012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2271 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 16:50:00 +00:00
hta@webrtc.org
e1919f41b7 Unittest for thread_wrapper. 
Added an explanation of the state variables of posix, wrote a simple test.
This might help in fixing the TSAN issue with thread.

BUG=webrtc:300
TEST=

Review URL: https://webrtc-codereview.appspot.com/583008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2270 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 15:57:34 +00:00
pwestin@webrtc.org
0d71c1cfe0 Cleanup code. 
Review URL: https://webrtc-codereview.appspot.com/569021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2269 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 14:23:25 +00:00
astor@webrtc.org
e231c61ba7 Style guide reformatting of overuse_detector.{h,cc} 
Review URL: https://webrtc-codereview.appspot.com/575006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2268 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 12:24:00 +00:00
mflodman@webrtc.org
7597a85bc4 Changed merge-name. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/584007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2266 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 08:32:20 +00:00
andrew@webrtc.org
294be77c2e Permit mixing mono and stereo streams. 
Add mixing tests based on older ones from the extended tests.

BUG=issue534
TEST=manual, voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/576014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2265 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 03:28:41 +00:00
pwestin@webrtc.org
b2179c20f0 Bugfix issue 533. Client does not handle NACK or PLI requests received from far end if a RTCP report from it has not been processed when RFC 5506 is enabled. 
Review URL: https://webrtc-codereview.appspot.com/569020

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2263 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-21 12:00:49 +00:00
stefan@webrtc.org
1bca6d2437 Fixes coverity warnings. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/566014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2262 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-21 07:42:12 +00:00
andrew@webrtc.org
b3bea2eb3e Fix build errors on OS X Lion. 
TBR=henrika@webrtc.org
TEST=build on Lion, trybots
Review URL: https://webrtc-codereview.appspot.com/583005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2261 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-18 19:02:42 +00:00
leozwang@webrtc.org
e3ba738ba3 Set OpenGL as the default renderer 
Description:
This cl sets OpenGL as the default renderer which is widely used and should
be test first

BUG=
TEST=test on android
Review URL: https://webrtc-codereview.appspot.com/573007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2260 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-18 17:07:49 +00:00
leozwang@webrtc.org
ada5db4e75 Enable aecm neon optimized code in android build 
Description:
This CL is a follow up of http://review.webrtc.org/575008/ and r2241.
Because of r2243, r2241 is messed up and reverted, I'm going to commit it again.
This is exact same to the last patch in 575008, just want to inform you and have
your double check before I commit it.

The original description
This cl enables cpu detection and aecm optimized code in android build.

BUG=
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/568006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2259 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-18 16:48:45 +00:00
phoglund@webrtc.org
1ad477de3e Added a bit flip fuzz test to the voice engine. 
Extracted encryption classes to a new test library.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/564009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2256 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-18 08:02:37 +00:00
leozwang@webrtc.org
00c07e66a7 Fix a random crash because of NULL point 
Description:
This cl fixes NULL point crash problem which was not detected runtime.
Also, small reformats are added too.

BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/579009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2254 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-16 16:57:28 +00:00
leozwang@webrtc.org
4d7d23cde4 Refactor OpenGL Code 
Description:
This CL refactored OpenGL java code. Most of code referenced sample code.
And bug-fix and reformats are added into this cl too.

BUG=
TEST=build and test on android
Review URL: https://webrtc-codereview.appspot.com/583004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2253 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-16 16:57:15 +00:00
hta@webrtc.org
3a698651d7 Coverity issue 14317 (uninitialized status may influence execution flow) 
Solution: restructure the flow when AquireSocket fails

BUG=coverity:14317
TEST=trybot

Review URL: https://webrtc-codereview.appspot.com/573006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2252 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-16 14:28:52 +00:00
kjellander@webrtc.org
7e4a72a78a Revert 2241 - Enable aecm neon optimized code in android build 
Description:
This cl enables cpu detection and aecm optimized code in android build.

BUG=
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/575008

TBR=leozwang@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/566013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2249 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-16 11:49:45 +00:00
kjellander@webrtc.org
0290a7a827 Revert 2243 - Re-enable embedding svn revision into code 
Description:
By using a python scription, this cl tries to get svn revision properly. It
current support git-svn and svn, if it fails, "n/a" will be defined as
svn revision.


BUG=500
TEST= test cases: w/o svn, w/o git-svn. test platforms, linux/windows. Passed all trybots.
Review URL: https://webrtc-codereview.appspot.com/564010

TBR=leozwang@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/577008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2248 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-16 11:39:14 +00:00
hta@webrtc.org
d429086f62 Deleted udp_socket_windows and all references to it. 
This fixes a couple of Coverity issues, and doesn't impact any tested
platforms.

BUG=Coverity:14423
TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/564012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2247 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-16 09:32:14 +00:00
tina.legrand@webrtc.org
86da94ea69 Remove functions for unregistering decoder 
This cl removes unused functions in the ACMGenericCodec class.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/568005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2245 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-16 07:11:53 +00:00
leozwang@webrtc.org
d2d54c72b6 Improve WebRTCDemo 
Description:
This cl basically bring video and audio alive and add couple features to
existing demo application,
1. Remove "stats" tab, add on screen stats display
2. Add a button to select surfaceview or opengl render
Also some reformat and minor bug-fixes are included

BUG=
TEST=build on android
Review URL: https://webrtc-codereview.appspot.com/579010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2244 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-16 03:18:23 +00:00
leozwang@webrtc.org
f6e27f5e03 Re-enable embedding svn revision into code 
Description:
By using a python scription, this cl tries to get svn revision properly. It
current support git-svn and svn, if it fails, "n/a" will be defined as
svn revision.


BUG=500
TEST= test cases: w/o svn, w/o git-svn. test platforms, linux/windows. Passed all trybots.
Review URL: https://webrtc-codereview.appspot.com/564010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2243 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-15 19:25:37 +00:00
kma@webrtc.org
f1ccdb9fb5 Aligned video buffer to 32 bytes boundary, when using vpx_img_alloc() in vp8. 
Review URL: https://webrtc-codereview.appspot.com/570009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2242 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-15 18:16:46 +00:00
leozwang@webrtc.org
fe742200d5 Enable aecm neon optimized code in android build 
Description:
This cl enables cpu detection and aecm optimized code in android build.

BUG=
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/575008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2241 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-15 16:11:24 +00:00
marpan@webrtc.org
cf2cd7e4c4 Enable VP8 deblocker. 
Review URL: https://webrtc-codereview.appspot.com/569011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2237 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-14 16:50:36 +00:00
hta@webrtc.org
93116ba4fc Added an unittest for udp_socket_wrapper. 
This involves checking what the reasonable call sequences for deleting a
socket is; documented the API for this by making the destructor protected.
Checked out that the behaviour of undeleted sockets is inconsistent across
platforms, and changed the udp_socket_manager_unittest accordingly.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/578007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2236 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-14 16:03:37 +00:00
kma@webrtc.org
4e7840d943 Revert 2233 - Aligned video buffer to 32 bytes boundary, when using vpx_img_alloc() in vp8. 
M    vp8.cc



TBR=kma@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/579013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2234 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-11 18:16:35 +00:00
kma@webrtc.org
6d47c08e14 Aligned video buffer to 32 bytes boundary, when using vpx_img_alloc() in vp8. 
M    vp8.cc



git-svn-id: http://webrtc.googlecode.com/svn/trunk@2233 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-11 17:29:59 +00:00
pwestin@webrtc.org
2853dde520 Refactor the internal API to the rtp/rtcp module. 
Combination of previous CLs in revisions 2211, 2212, 2214, 2215, 2216.
Review URL: https://webrtc-codereview.appspot.com/570008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2231 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-11 11:08:54 +00:00
phoglund@webrtc.org
5dbe568417 Disabled flaky tests. Standard tests will no longer run within extended tests. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/578006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2230 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-11 08:59:11 +00:00
bjornv@webrtc.org
61d0745e86 Resolve coverity warnings. 
14050, 14051, 14243, 14314

In APM:
- Uninitialized variable initialized.
- NULL pointer sanity checks corrected.

Tested with trybots and audioproc_unittest.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/571009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2229 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-11 07:51:44 +00:00
phoglund@webrtc.org
7eadad6d95 Fixed valgrind errors so the fuzz test can be run under valgrind. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/576008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2228 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-11 07:36:53 +00:00
turaj@webrtc.org
3c383abd27 Revert 2211 - Refactor the internal API to the rtp/rtcp module. 
Review URL: https://webrtc-codereview.appspot.com/568004

A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/563011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2226 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 23:01:04 +00:00
turaj@webrtc.org
980d6be535 Revert 2212 - Bug fix 
Review URL: https://webrtc-codereview.appspot.com/576009

A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/575009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2225 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 22:57:21 +00:00
turaj@webrtc.org
449b525453 Revert 2214 - Bugfix 
A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

TBR
Review URL: https://webrtc-codereview.appspot.com/570007

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/571010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2223 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 22:54:39 +00:00
turaj@webrtc.org
f02ee061ab Revert 2215 - Fixed destroy order. 
A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

TBR
Review URL: https://webrtc-codereview.appspot.com/564007

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/562008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2222 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 22:53:33 +00:00
turaj@webrtc.org
f448ccd16c Revert 2216 - Fix for receive only channels. 
A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

TBR
Review URL: https://webrtc-codereview.appspot.com/564008

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/579011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2221 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 22:52:19 +00:00
leozwang@webrtc.org
8aaf31d14f Create makefile for video engine 
Description:
This build.xml will enable video engine build on android by ant. As we discussed before,
in order to make video engine build based on current webrtc file structure which is not
normal, I created this customized build.xml which is based on build.xml in android SDK.

BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/571008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2219 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 18:16:27 +00:00
leozwang@webrtc.org
f29d3fa177 Fix vp8 complexity parameter on android 
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/575007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2217 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 18:12:01 +00:00
pwestin@webrtc.org
a69634aa92 Fix for receive only channels. 
TBR
Review URL: https://webrtc-codereview.appspot.com/564008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2216 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 16:17:05 +00:00
pwestin@webrtc.org
c309c7c52b Fixed destroy order. 
TBR
Review URL: https://webrtc-codereview.appspot.com/564007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2215 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 15:49:45 +00:00
pwestin@webrtc.org
fd3fef514b Bugfix 
TBR
Review URL: https://webrtc-codereview.appspot.com/570007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2214 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 15:14:41 +00:00
pwestin@webrtc.org
e1c97a2723 Bug fix 
Review URL: https://webrtc-codereview.appspot.com/576009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2212 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 13:55:23 +00:00
pwestin@webrtc.org
0774838f3d Refactor the internal API to the rtp/rtcp module. 
Review URL: https://webrtc-codereview.appspot.com/568004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2211 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 12:33:50 +00:00
bjornv@webrtc.org
cd54e56d72 Delay estimation performance test. 
Added a test to verify estimation performance. Tested with audioproc_unittest and trybots.

BUG=issue435
TEST=None

Review URL: https://webrtc-codereview.appspot.com/569006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2209 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 07:41:23 +00:00
andrew@webrtc.org
270e9db039 Clarify the impact of disabling VAD on DTX. 
TBR=henrika@webrtc.org
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/566009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2207 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-09 19:09:03 +00:00
leozwang@webrtc.org
b213cd55ef Remove bitmap implementation from surfaceview render 
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/571004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2205 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-09 18:24:39 +00:00
leozwang@webrtc.org
de6a6b40fa Rename ViEAndroidDemo to WebRTCDemo 
Desription:
This CL will change VideoEngine application name to ViEAndroidDemo. This
is the first step to refactor videoengine test application on android.

"ViE" is not a proper name because the app also supports audio. And it's good
to put WebRTC in application name.

BUG=
TEST=build on all trybots
Review URL: https://webrtc-codereview.appspot.com/576006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2204 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-09 15:23:52 +00:00
niklas.enbom@webrtc.org
f6edfeff63 Adding one parameter to typing detection tuning 
Review URL: https://webrtc-codereview.appspot.com/569009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2203 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-09 13:16:12 +00:00
leozwang@webrtc.org
9f49af9cea Add libbitrate_controller which is introduced recently 
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/571007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2202 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-09 04:46:24 +00:00
leozwang@webrtc.org
d63cf71413 Fix broken build because gyp doesn't filter out platform specific file with suffixes of .c 
BUG=
TEST=test on all trybots, failed only on win_rel for weird error.
Review URL: https://webrtc-codereview.appspot.com/563009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2200 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 21:33:04 +00:00
andrew@webrtc.org
710eac763a Update DEPS comment and remove tabs from common.gypi. 
TBR=wu@webrtc.org
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/575005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2198 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 18:00:57 +00:00
andrew@webrtc.org
22f6f85fcc Remove redundant initialization. 
TBR=xians@webrtc.org
BUG=6140661
TEST=build on Linux

Review URL: https://webrtc-codereview.appspot.com/576005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2197 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 17:18:28 +00:00
andrew@webrtc.org
e59a0aca6a Fix AudioFrame types. 
volume_ is not set anywhere so I'm removing it.

BUG=
TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/556004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2196 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 17:12:40 +00:00
leozwang@webrtc.org
f5fe1000de Enable cpu auto detection and ns optimized code on android 
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/547006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2195 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 15:20:02 +00:00
hta@webrtc.org
9cc186405f Removed CleanUp call in Windows, since I couldn't find a call to it. 
This solves Coverity issue 14424 by deleting the code.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/579005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2194 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 11:40:06 +00:00
mflodman@webrtc.org
e553031580 Refactore base, Capture, Codec and Custom Call parts of autotest. The CL doesn't contain any real functional changes, only style changes, cast changes and changing reference to pointer as input argument to functions. 
Custome call still doesn't pass cpplint, but I'll take that in another CL to not change the structure in the style change CL.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/523001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2193 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 10:38:36 +00:00
braveyao@webrtc.org
113f851cc3 Merge Chromium issue 95797 into WebRTC. 
Bug = 450
Test = Manual test
Review URL: https://webrtc-codereview.appspot.com/551004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2192 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 09:28:39 +00:00
pwestin@webrtc.org
7415f371ac Revert VP8 Deblocker. 
Review URL: https://webrtc-codereview.appspot.com/563007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2191 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 09:06:31 +00:00
pwestin@webrtc.org
5019c9583c Enable VP8 deblocker. 
Review URL: https://webrtc-codereview.appspot.com/578004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2190 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 08:40:28 +00:00
andrew@webrtc.org
589673f1cb Fix volume setting while not playing on PulseAudio. 
We now only set the volume when starting playout if the user has called
SetSpeakerVolume while we weren't playing. This now also ensures it will
actually get set to what the user requested rather than being overridden
by a default value.

Add tests to voe_auto_test.

BUG=6140661
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/566006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2188 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-07 21:42:49 +00:00
leozwang@webrtc.org
20a05cd778 Disable WEBRTC_SVNREVISION 
Description:
This CL will temporally define WEBRTC_SVNREVISION as "n/a" because it
could break Chromium if svn is not installed.
The long term solution is a have a script that could deal with it, and
have it support git-svn which is used by most developers.

BUG=496
TEST=build on Linux
Review URL: https://webrtc-codereview.appspot.com/569007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2187 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-07 21:16:33 +00:00
turaj@webrtc.org
fe4cfa7e5e Hi Tina, 
I have uploaded this patch for your review. I have done an extensive test to be sure that removing of tables does not create any problem. 

The test file, is called test_lpc.c which requires a hack to standard iSAC. The test computes LPC coefficients, then encodes and decodes with old and new (size-reduced) tables. It compares the results is all steps. I have ran the test over large set of files, more then 51 hours of audio, and there was no error. 

I tried to do no formatting so the review to be easier, but I know it can be a tricky CL. Hopefully, the test file helps you to be more confident on the CL. 

Thanks,... Turaj  

In this change list the LPC tables associated with mode 1 & 2 are remoded, and necessary cahnges are made to other files. 

The only model allowed is model number 0. Therefore, this CL breaks compatibility with iSAC released prior to 2.4.3. To avoid changing the bit-stream, we still keep the model number in the bit-stream. 

entropy_coding.c is cleaned up, especially encoding of LAR had KLT transform of LPC gains which are removed now. 
Review URL: https://webrtc-codereview.appspot.com/548004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2186 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-07 20:36:22 +00:00
leozwang@webrtc.org
d46fe7034b Two bug fixs in android surface render 
Descritption:
This CL addresses two issues in android surface view render,
1. Uninitlized class members _javaByteBufferObj and _directBuffer which
   could cause crash.
2. Using ConvertI420ToRGB565. We should use high level libyuv apis
   to help libyuv maintainer.

BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/566005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2185 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-07 20:29:43 +00:00
braveyao@webrtc.org
ba0f9fe10b Trival fix to voe_auto_test according to the main source codes 
BUG = NULL
TEST = voe_auto_test
Review URL: https://webrtc-codereview.appspot.com/554004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2184 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-07 10:06:43 +00:00
phoglund@webrtc.org
f5657efd31 Rolled back r2177 since it breaks vie_auto_test. 
I'm not sure what is the right thing to do here. That would probably be to call Release() the right amount of times and ensuring that the last call returns 0 (e.g. all references have been released), but I'll leave it up to the CL author to investigate that.

TBR=elham@webrtc.org
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/569005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2183 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-07 07:59:32 +00:00
andrew@webrtc.org
07bf9a07f5 Add test to verify identical input channels result in identical output channels. 
BUG=issue411
TEST=audioproc_unittest, trybots

Review URL: https://webrtc-codereview.appspot.com/553009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2182 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-05 00:32:00 +00:00
leozwang@webrtc.org
329fcbba29 Reduce PSNR because I420ToARGB888 return lowers number on windows 
TBR=stefan, marpan

BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/562005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2178 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-04 21:31:22 +00:00
elham@webrtc.org
c2f8832a32 Fix for FileTest failure in vie_auto_test 
Review URL: https://webrtc-codereview.appspot.com/570004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2177 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-04 21:17:30 +00:00
leozwang@webrtc.org
1ea25b4c3d Change PSNR for I420ToARGB888 and I420ToRGB565 
TBR=stefan, marpan

BUG=
TEST=test on linux
Review URL: https://webrtc-codereview.appspot.com/569004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2176 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-04 17:55:57 +00:00
leozwang@webrtc.org
83958dfe06 Add ARGB and RGB565 unit test 
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/563004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2175 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-04 17:07:45 +00:00
leozwang@webrtc.org
3ebff4c2e9 Add ConvertToARGB and enable RGB565 
Review URL: https://webrtc-codereview.appspot.com/566004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2174 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-04 17:07:30 +00:00
leozwang@webrtc.org
e62fec2285 Bug fix and refactor video capture code on android 
BUG=
TEST=test on android
Review URL: https://webrtc-codereview.appspot.com/541009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2173 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-04 17:06:32 +00:00
hta@webrtc.org
b6f2417f37 Renamed all _test.cc files to _unittest.cc, to conform to convention 
for webrtc.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/560004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2172 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-04 08:13:57 +00:00
leozwang@webrtc.org
8b6f749b0a Rewrite makefile to link with stl statically 
By doing this way, webrtc.so doesn't depend on stlport_shared

BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/546005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2170 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-03 16:07:15 +00:00
hta@webrtc.org
54536bb6d4 Refactoring of the TMMBRSet class, giving it a reasonably tight interface. 
The CL also fixes a number of line length and tab issues in touched files.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/553005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2168 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-03 14:07:23 +00:00
pwestin@webrtc.org
3bc38c86e8 Fix color enhancement test. 
Review URL: https://webrtc-codereview.appspot.com/553007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2167 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-03 13:15:35 +00:00
pwestin@webrtc.org
209442a560 Missing file 
Review URL: https://webrtc-codereview.appspot.com/556005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2166 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-03 11:36:06 +00:00
pwestin@webrtc.org
e9727cdbaa Fixed some memory leaks. 
Review URL: https://webrtc-codereview.appspot.com/558004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2165 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-03 11:32:25 +00:00
andrew@webrtc.org
63a509858d Rename AudioFrame members. 
BUG=
TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/542005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2164 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-02 23:56:37 +00:00
leozwang@webrtc.org
7fdb909339 Reformat and add more debug info into ViESurfaceRenderer 
BUG=
TEST=test on android
Review URL: https://webrtc-codereview.appspot.com/546004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2163 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-02 16:45:55 +00:00
bjornv@webrtc.org
b286bfb13e VAD refactoring: Replaced hard coded array sizes with enum. 
Further replaced hard coded calculations with a for loop for better understanding.

Tested with vad_unittests and audioproc_unittest.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/519002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2162 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-02 12:14:57 +00:00
hta@webrtc.org
404843e6e5 Timeout tests for TMMBR 
Added a test that injects 3 packets and then times out.

Rewrote the packet construction in test to use a builder format.
This makes tests a lot more readable.

Odd behaviour of timeout found; documented as test.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/553004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2161 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-02 09:56:45 +00:00
hta@webrtc.org
3c0df7d376 Fixed a build break: I'd forgotten to remove a DELETE statement. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/555004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2160 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-02 08:22:21 +00:00
hta@webrtc.org
47059b5dfb Adds unit tests for RTCP receiver, focusing on TMMBR handling. 
This is the first part of a plan:

- Get basic unit tests for rtcp_receiver.
- Get an unit test for some code inside rtcp_receiver
  that touches the TMMBRSet class in hard-to-decipher ways
  (rtcp_receiver_help, GetTMMBRSet function, use of memmove()).
- Refactor the TMMBRSet class.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/547005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2159 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-02 07:46:22 +00:00
phoglund@webrtc.org
719dba7e79 Further cleaned up voe_standard_test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/522003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2157 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-02 07:32:37 +00:00
andrew@webrtc.org
ecac9b721e Add tests for downmixing and no processing. 
BUG=issue419
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/532001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2154 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-02 00:04:10 +00:00
leozwang@webrtc.org
63ea5ef5da Regenerate jni files and bring audio alive 
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/550004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2153 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-01 22:13:49 +00:00
andrew@webrtc.org
d5548f5d04 Disable clang Chrome plugins on all platforms. 
(Will fix Linux-clang bot).

TBR=wu@webrtc.org
BUG=issue163
TEST=build on Linux-clang

Review URL: https://webrtc-codereview.appspot.com/545005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2152 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-01 21:39:34 +00:00
leozwang@webrtc.org
85b089a0ca Fix ConvertI420ToRGB565 bug 
BUG=
TEST=test on android
Review URL: https://webrtc-codereview.appspot.com/541005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2150 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-30 17:59:08 +00:00
leozwang@webrtc.org
e7ac5fde72 Minor changes to remove dead code in opensl es 
BUG=
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/539004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2149 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-30 14:42:17 +00:00
hta@webrtc.org
65a4e4ed56 Minor refactoring: RTCPReceiver::BoundingSet 
Remove ability to modify a pointer argument.

Added a test for transmitting a non-empty TMMBN

BUG=
TEST=unittest

Review URL: https://webrtc-codereview.appspot.com/542004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2148 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-30 11:23:41 +00:00
hta@webrtc.org
c2d985257b untabify 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2145 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-30 08:25:10 +00:00
hta@webrtc.org
9d54cd12ab TMMBN sender test passes, fixed receiver flag bug 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2144 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-30 08:24:55 +00:00
andrew@webrtc.org
5c0c18d823 Fix coverity issues in ACM. 
Fixes: Big parameter passed by value (PASS_BY_VALUE)
Passing parameter codec of size 52 bytes by value.

BUG=
TEST=audio_coding_module_tests, trybots

Review URL: https://webrtc-codereview.appspot.com/529002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2142 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-27 17:06:48 +00:00
andrew@webrtc.org
a88cb6fce0 Add HighPassFilter and StereoChannelSwapping tests. 
BUG=issue451
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/531001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2141 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-27 17:00:20 +00:00
marpan@webrtc.org
2d0223286b VPM: fix to coverity issues 10255-10258 (unintended sign extension). 
Review URL: https://webrtc-codereview.appspot.com/532002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2140 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-27 15:56:02 +00:00
phoglund@webrtc.org
ca08c41701 Replacing virtual camera on linux video bot: adaptings tests accordingly. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/537001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2139 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-27 12:38:17 +00:00
pwestin@webrtc.org
b1313aac7c Fix missing h file change. 
Review URL: https://webrtc-codereview.appspot.com/535001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2136 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-27 05:42:05 +00:00
pwestin@webrtc.org
49888ce428 Breaking out send side bitrate controll cont. 
Review URL: https://webrtc-codereview.appspot.com/475004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2135 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-27 05:25:53 +00:00
mallinath@webrtc.org
e611619f60 Fixing the header file path in gypi file. 
BUG=473
Review URL: https://webrtc-codereview.appspot.com/529001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2134 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-26 23:03:15 +00:00
andrew@webrtc.org
9c4f6a5ff9 Add an AudioFrameOperations unittest. 
Additionally, reformat audio_frame_operations to Goog style.

BUG=issue451
TEST=voice_engine_unittests

Review URL: https://webrtc-codereview.appspot.com/528001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2133 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-26 22:32:03 +00:00
tommi@webrtc.org
e49d908baf Fix how we were using TbInterfaces and disallow operator=() and the copy constructor. 
The reason is that this will cause a crash:

TbInterfaces foo = TbInterfaces("blah");


It relies on the generated copy constructor (or assignment operator), which copies the
pointer values from a temporary object.  After |foo| in this case has been initialized
with values from the temporary object, the temp goes out of scope and is deleted.
The result is that |foo| has been initialized with pointers do a deleted object.

Also fixing expectations for the return value of VoE Release() calls after I checked
in my change that makes the VoiceEngine per-object ref counted and not per-interface.
Review URL: https://webrtc-codereview.appspot.com/509005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2128 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-26 17:05:32 +00:00