pbos@webrtc.org
e07049f19f
Lock RTPSender statistics.
...
Suppressing these errors in TSan has become tedious. It's better to just
lock them.
BUG=2349
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2197004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4713 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-10 11:29:17 +00:00
pbos@webrtc.org
26b0d77baf
Suppress RTPSender race regardless of codec.
...
New test uses SendGeneric instead of SendVP8.
BUG=2349
TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2194004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4705 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-09 15:34:36 +00:00
andrew@webrtc.org
9080518a39
Restore severity precondition to logging.h.
...
I mistakenly ommitted the checks when logging.h was ported from
libjingle to webrtc. This caused a significant CPU cost for logs which
were later filtered out anyway.
Verified with LS_VERBOSE logging in neteq4, running:
$ out/Release/modules_unittests \
--gtest_filter=NetEqDecodingTest.TestBitExactness \
--gtest_repeat=50 > time.txt
$ grep "case ran" time.txt | grep "[0-9]* ms" -o | sort
Results on a MacBook Retina, averaged over 5 runs:
Verbose logs disabled: 666 ms
Exisiting implementation, verbose logs enabled: 944 ms (1.42x)
New implementation, verbose logs enabled: 673 ms (1.01x)
BUG=2314
R=henrik.lundin@webrtc.org , henrike@webrtc.org , kjellander@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2160005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4682 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-05 16:40:43 +00:00
mflodman@webrtc.org
be23b32727
Adding tsan suppression for BUG 2349.
...
TSAN found a read/write race for RTPSender::[packets_sent_/payload_bytes_sent)] between RTPSender::SendToNetwork and RTCPSender::SendRTCP.
BUG=2349
R=holmer@google.com
Review URL: https://webrtc-codereview.appspot.com/2168004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4676 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-04 13:36:52 +00:00
mflodman@webrtc.org
f5f5da0df1
Adding TSAN suppression for test posix udp transport.
...
This is race for reading a bool in the WebRTC test UDP transport and
not in any production code.
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2159006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4663 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-03 14:15:21 +00:00
kjellander@webrtc.org
5aedb295d5
Add TSan and Dr Memory suppressions for Windows
...
This works enables us to add add more memory tools bots to the
WebRTC FYI waterfall at
http://build.chromium.org/p/client.webrtc.fyi/waterfall
These suppressions will be needed to get the bots green initially.
This CL also updates the PRESUBMIT.py scripts for the previous
memcheck and TSan suppression directories with the trybots we
currently have. It also adds a PRESUBMIT.py script for the
Dr Memory suppressions.
BUG=1938,2319,2321,2322,2323,2324,2328,2329,2330,2333
TEST=Local execution of the tests passes when these suppressions
are used.
R=niklas.enbom@webrtc.org , phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2149004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4653 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-02 11:50:46 +00:00
henrike@webrtc.org
442709ea96
Disable broken test and add suppressions.
...
BUG=2299,1205
TBR=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2101004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4606 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-23 21:42:01 +00:00
henrike@webrtc.org
69a774fc42
Suppresses another tsan warning. Warning is reported here: http://chromegw/i/client.webrtc/builders/Linux%20Tsan/builds/460/steps/memory%20test%3A%20libjingle_peerconnection_unittest/logs/D5CAED6268DAACB7
...
TBR=wu@webrtc.org
BUG=N/A
Review URL: https://webrtc-codereview.appspot.com/2096004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4603 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-23 14:38:15 +00:00
henrike@webrtc.org
61b262c427
Disable tests according to issues: 1205,2272,2288,2290,2291
...
BUG=1205,2272,2288,2290,2291
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2069005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4596 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-22 20:27:49 +00:00
wu@webrtc.org
166991fa1f
Suppress tsan errors on libjingle_peerconnection_unittest.
...
TBR=mallinath
BUG=1205
Review URL: https://webrtc-codereview.appspot.com/2055004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4560 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-16 17:57:44 +00:00
wu@webrtc.org
a2e0901e54
Suppress tsan errors.
...
BUG=1205,2079
TBR=mallinath
Review URL: https://webrtc-codereview.appspot.com/2054004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4558 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-16 17:00:01 +00:00
wu@webrtc.org
4ebd8efc09
Supress libjingle_unittest fails on TSan.
...
BUG=2080
TBR=mallinath
Review URL: https://webrtc-codereview.appspot.com/1943005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4471 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-02 00:14:41 +00:00
wu@webrtc.org
6abb750993
Delete gtest_exclude for asan which doesn't have effect with how the bots are setup now
...
Add gtest_exclude for tsan to disable some flakey tests.
Change tsan suppression since the function name has been changed from DecodeWithErrors to DecodeErrorMode.
TBR=mallinath
Review URL: https://webrtc-codereview.appspot.com/1930004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4465 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-01 18:00:02 +00:00
wu@webrtc.org
27c0408a16
Suppressing tsan errors on libjingle_unittest and libjingle_peerconnection_unittest.
...
BUG=1205,2080
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1924004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4458 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-31 22:41:15 +00:00
wu@webrtc.org
d40b4d9685
Fix libjingle memory bots by suppressing some of the errors.
...
BUG=1205,2153
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1923004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4453 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-31 17:32:36 +00:00
wu@webrtc.org
9c9fc767b1
Fixing the memory check bots by suppressing some of the tests.
...
BUG=1205,2078,2080
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1913004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4438 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-30 22:54:08 +00:00
henrike@webrtc.org
5e44b8fac1
Add libjingle's valgrind suppressions
...
BUG=2104
R=kjellander@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1834004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4375 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-19 16:00:41 +00:00
kjellander@webrtc.org
14d1898bf9
Removing arena_thread_freeres suppression
...
It is no longer needed since we are now using a Chromium revision that
is newer than
http://src.chromium.org/viewvc/chrome?view=rev&revision=172313
In that revision, the arena_thread_freeres suppression was added to
ignore.txt.
BUG=300
TEST=tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan -t
out/Release/system_wrappers_unittests
and trybot execution on linux_tsan
Review URL: https://webrtc-codereview.appspot.com/1019010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3375 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-16 10:49:31 +00:00
phoglund@webrtc.org
171ac59426
Corrected TSAN suppression.
...
BUG=
Review URL: https://webrtc-codereview.appspot.com/1029007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3356 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-10 12:44:27 +00:00
phoglund@webrtc.org
bc9a959bd7
Generalized suppression for Trace::Add
...
BUG=1194
TEST=Local run
Review URL: https://webrtc-codereview.appspot.com/1023007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3340 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-07 13:01:46 +00:00
kjellander@webrtc.org
0240e8e90f
Wider TSAN suppression for issue 300
...
On some machines, this test has still been failing, so I'm widening the
suppression to resolve this.
BUG=300
TEST=passing linux_tsan trybot.
Review URL: https://webrtc-codereview.appspot.com/992004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3280 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-13 13:02:29 +00:00
kjellander@webrtc.org
d2bcde2e4e
Suppressing TSan warnings for system_wrappers_unittests
...
This CL makes system_wrappers_unittests pass on Lucid (it passed on Precise
without them for me).
BUG=300
TEST=Try job on linux_tsan
TBR=henrike
Review URL: https://webrtc-codereview.appspot.com/976007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3263 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-11 21:39:18 +00:00
turaj@webrtc.org
42259e7ebc
VoE Changes to enable dual_streaming.
...
TEST=added new unit-test
This CL depends on issue 933015 http://webrtc-codereview.appspot.com/933015/
which is under review. Should be committed after issue 933015 is committed.
Committed: https://code.google.com/p/webrtc/source/detail?r=3231
Review URL: https://webrtc-codereview.appspot.com/970005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3257 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-11 02:15:12 +00:00
kjellander@webrtc.org
1101278a17
Wider suppression filter for tz-warnings in TSAN
...
This catches the remaining warnings we see which it seems like the fun:__tz* suppression in Chromium's tools/valgrind/tsan/suppressions.txt file is aimed for.
BUG=884
Review URL: https://webrtc-codereview.appspot.com/841006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2845 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-09-28 15:30:58 +00:00
kjellander@webrtc.org
b6e4cc776e
Valgrind memcheck and TSAN script now uses Chrome+WebRTC suppression files.
...
Skeleton suppression files for future WebRTC suppressions are added and are included in addition to the ones Chrome are using and maintaining when our wrapper script executes.
Also added tweaked PRESUBMIT checks based on the Chrome code, that verifies
that suppressions are added correctly. I tested that they work by adding an invalid
suppression.
BUG=544
TEST=Tested running tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan -t out/Debug/system_wrappers_unittests and it reports far less errors. Tested adding bad suppression and it was caught by the PRESUBMIT check.
Review URL: https://webrtc-codereview.appspot.com/601004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2304 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-27 20:59:35 +00:00