generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
5,763 Commits 1 Branch 0 Tags 108 MiB
d980307197
Commit Graph

44 Commits

Author SHA1 Message Date
andrew@webrtc.org
222d8d3b1f Add a TSAN suppression for a benign TRACE_EVENT race. 
TBR=hclam
BUG=3409

Review URL: https://webrtc-codereview.appspot.com/15639004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6293 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-30 23:14:00 +00:00
stefan@webrtc.org
b60bfe4759 Suppress webrtc trace races detected by tsan. 
BUG=3372
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17579004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6226 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-23 07:29:37 +00:00
henrike@webrtc.org
f048872e91 Adds a modified copy of talk/base to webrtc/base. It is the first step in 
migrating talk/base to webrtc/base.

BUG=N/A
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17479005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-13 18:00:26 +00:00
perkj@webrtc.org
e9a604accd Revert 6107 "Adds a modified copy of talk/base to webrtc/base. I..." 
This breaks Chromium FYI builds and prevent roll of webrtc/libjingle to Chrome.

http://chromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win%20Builder/builds/457


> Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
> 
> BUG=N/A
> R=andrew@webrtc.org, wu@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/12199004

TBR=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14479004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6116 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-13 08:15:48 +00:00
henrike@webrtc.org
2c7d1b39b9 Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. 
BUG=N/A
R=andrew@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12199004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6107 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-12 18:03:09 +00:00
mflodman@webrtc.org
e3842897e2 Adding tsan suppression for error introduced in r5555, causing libjingle_unittest to fail on TSan bot. 
BUG=2931
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8779005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5559 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-17 15:09:39 +00:00
kjellander@webrtc.org
6f8acdc76f Suppressions for libjingle_unittest after roll in r5502 
New errors arrived when rolling libjingle in r5502.
These suppressions are needed to green up the Memcheck and
TSan bots.

BUG=1976,2080
TEST=local runs on Linux:
tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan -b out/Release -t libjingle_unittest
tools/valgrind-webrtc/webrtc_tests.sh --tool=memcheck -b out/Release -t libjingle_unittest
and trybot:
git try --bot=linux_memcheck,linux_tsan -t libjingle_unittest
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8299004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5509 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-08 21:15:59 +00:00
wu@webrtc.org
98aefcd8fe Update tsan suppressions for libjingle_media_unittest. 
TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/7559005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5428 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-24 18:32:43 +00:00
wu@webrtc.org
ca5ff9972e Re-enable webrtcvoice/videoengine unittests. 
TEST=try bots
BUG=
R=mallinath@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=5387

Review URL: https://webrtc-codereview.appspot.com/7149004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5427 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-24 17:37:46 +00:00
wu@webrtc.org
8f19cb9fbc Revert 5387 "Re-enable webrtcvoice/videoengine unittests." 
Missed the result from the last try bot.

> Re-enable webrtcvoice/videoengine unittests.
> 
> TEST=try bots
> BUG=
> R=mallinath@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/7149004

TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7179004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5388 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-14 22:31:11 +00:00
wu@webrtc.org
eda6823397 Re-enable webrtcvoice/videoengine unittests. 
TEST=try bots
BUG=
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7149004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5387 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-14 22:15:09 +00:00
wu@webrtc.org
e4e5683b41 Clean up tsan suppression file: 
1) remove suppressions that are already fixed.
2) merge duplicated suppressions.

TBR=mallinath
TEST=tsan try bot
BUG=1205,2078,2080

Review URL: https://webrtc-codereview.appspot.com/2949004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5033 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-25 16:29:33 +00:00
wu@webrtc.org
3c5d2b43ec Thread::Stop() must be called before any subclass's destructor completes. 
Update Thread documentation, fix all subclasses that had a problem.

This is to avoid a data racing between the destructor modifying the vtable, and
Thread::PreRun calling virtual method Run at the same time.

For example:
[ RUN      ] FileMediaEngineTest.TestGetCapabilities
==================
WARNING: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call) (pid=2967)
  Read of size 8 at 0x7d480000bd00 by thread T1:
    #0 talk_base::Thread::PreRun(void*) /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/base/thread.cc:353 (libjingle_media_unittest+0x000000234da8)

  Previous write of size 8 at 0x7d480000bd00 by main thread:
    #0 talk_base::Thread::~Thread() /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/base/thread.cc:158 (libjingle_media_unittest+0x00000023478c)
    #1 ~RtpSenderReceiver /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/media/base/filemediaengine.cc:122 (libjingle_media_unittest+0x0000001b551f)
    ...

RISK=P2
TESTED=try bots and tsan
BUG=2078,2080
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2428004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4999 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-18 16:27:26 +00:00
wu@webrtc.org
6342066974 Fix tsan failures in channel.cc regarding to the volume settings. 
BUG=2461
TEST=try bots
R=xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2377004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4992 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-17 18:28:55 +00:00
sprang@webrtc.org
603ed98bca Suppress race condition warn in CallTest_ReceivesAndRetransmitsNack_Test 
This test is the one most commonly triggering a race condition in the
event tracing macros. Pending a permanent fix in tracing code,
suppressing tsan warnings for this test.

BUG=2497
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2408004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4986 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-17 07:49:26 +00:00
wu@webrtc.org
54e729bb73 Remove tsan suppression for the failure that's already fixed. 
TEST=try bot
TBR=mallinath
BUG=1205,2079,2080

Review URL: https://webrtc-codereview.appspot.com/2408005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4985 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-16 23:19:54 +00:00
wu@webrtc.org
ff7b360314 * Remove suppressions that are fixed. 
* Remove duplicated suppression bug_1205_21.

TESTED=try with tsan
BUG=1205
TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/2368004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4942 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-08 17:32:39 +00:00
wu@webrtc.org
e0d55a0782 Removing suppressions that has been fixed, i.e. r4661. 
Rename suppressions to match the correct issue.

TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/2357004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4940 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-07 16:44:38 +00:00
wu@webrtc.org
6049787252 Add protection to few more methods of AudioDeviceLinuxALSA. Those methods can be called from 
a different thread.

One example is the _playWarning can be changed in AudioDeviceLinuxALSA::Init, which is called on the application's thread. At the same time it can be read via PlayoutWarning() on the VoE's process_thread.

RISK=P2
TESTED=try bots and tsan test:
tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan -t out/Debug/libjingle_peerconnection_unittest --gtest_filter=PeerConnectionFactoryTestInternal.CreatePCUsingInternalModules
BUG=1205
R=xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2315004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4866 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-27 18:19:25 +00:00
andrew@webrtc.org
c2ac5ed588 Add more TSAN suppressions for libjingle_media_unittest. 
BUG=2078
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2282004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4830 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-24 18:45:19 +00:00
pbos@webrtc.org
e07049f19f Lock RTPSender statistics. 
Suppressing these errors in TSan has become tedious. It's better to just
lock them.

BUG=2349
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2197004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4713 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-10 11:29:17 +00:00
pbos@webrtc.org
26b0d77baf Suppress RTPSender race regardless of codec. 
New test uses SendGeneric instead of SendVP8.

BUG=2349
TBR=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2194004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4705 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-09 15:34:36 +00:00
andrew@webrtc.org
9080518a39 Restore severity precondition to logging.h. 
I mistakenly ommitted the checks when logging.h was ported from
libjingle to webrtc. This caused a significant CPU cost for logs which
were later filtered out anyway.

Verified with LS_VERBOSE logging in neteq4, running:
$ out/Release/modules_unittests \
--gtest_filter=NetEqDecodingTest.TestBitExactness \
--gtest_repeat=50 > time.txt
$ grep "case ran" time.txt | grep "[0-9]* ms" -o | sort

Results on a MacBook Retina, averaged over 5 runs:
Verbose logs disabled:                          666 ms
Exisiting implementation, verbose logs enabled: 944 ms (1.42x)
New implementation, verbose logs enabled:       673 ms (1.01x)

BUG=2314
R=henrik.lundin@webrtc.org, henrike@webrtc.org, kjellander@webrtc.org, turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2160005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4682 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-05 16:40:43 +00:00
mflodman@webrtc.org
be23b32727 Adding tsan suppression for BUG 2349. 
TSAN found a read/write race for RTPSender::[packets_sent_/payload_bytes_sent)] between RTPSender::SendToNetwork and RTCPSender::SendRTCP.

BUG=2349
R=holmer@google.com

Review URL: https://webrtc-codereview.appspot.com/2168004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4676 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-04 13:36:52 +00:00
mflodman@webrtc.org
f5f5da0df1 Adding TSAN suppression for test posix udp transport. 
This is race for reading a bool in the WebRTC test UDP transport and
not in any production code.

R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2159006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4663 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-03 14:15:21 +00:00
henrike@webrtc.org
442709ea96 Disable broken test and add suppressions. 
BUG=2299,1205

TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2101004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4606 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-23 21:42:01 +00:00
henrike@webrtc.org
69a774fc42 Suppresses another tsan warning. Warning is reported here: http://chromegw/i/client.webrtc/builders/Linux%20Tsan/builds/460/steps/memory%20test%3A%20libjingle_peerconnection_unittest/logs/D5CAED6268DAACB7 
TBR=wu@webrtc.org

BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/2096004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4603 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-23 14:38:15 +00:00
henrike@webrtc.org
61b262c427 Disable tests according to issues: 1205,2272,2288,2290,2291 
BUG=1205,2272,2288,2290,2291
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2069005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4596 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-22 20:27:49 +00:00
wu@webrtc.org
166991fa1f Suppress tsan errors on libjingle_peerconnection_unittest. 
TBR=mallinath
BUG=1205

Review URL: https://webrtc-codereview.appspot.com/2055004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4560 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-16 17:57:44 +00:00
wu@webrtc.org
a2e0901e54 Suppress tsan errors. 
BUG=1205,2079
TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/2054004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4558 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-16 17:00:01 +00:00
wu@webrtc.org
4ebd8efc09 Supress libjingle_unittest fails on TSan. 
BUG=2080
TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/1943005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4471 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-02 00:14:41 +00:00
wu@webrtc.org
6abb750993 Delete gtest_exclude for asan which doesn't have effect with how the bots are setup now 
Add gtest_exclude for tsan to disable some flakey tests.
Change tsan suppression since the function name has been changed from DecodeWithErrors to DecodeErrorMode.

TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/1930004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4465 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-01 18:00:02 +00:00
wu@webrtc.org
27c0408a16 Suppressing tsan errors on libjingle_unittest and libjingle_peerconnection_unittest. 
BUG=1205,2080
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1924004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4458 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-31 22:41:15 +00:00
wu@webrtc.org
d40b4d9685 Fix libjingle memory bots by suppressing some of the errors. 
BUG=1205,2153
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1923004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4453 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-31 17:32:36 +00:00
wu@webrtc.org
9c9fc767b1 Fixing the memory check bots by suppressing some of the tests. 
BUG=1205,2078,2080
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1913004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4438 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-30 22:54:08 +00:00
henrike@webrtc.org
5e44b8fac1 Add libjingle's valgrind suppressions 
BUG=2104
R=kjellander@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1834004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4375 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-19 16:00:41 +00:00
kjellander@webrtc.org
14d1898bf9 Removing arena_thread_freeres suppression 
It is no longer needed since we are now using a Chromium revision that
is newer than
http://src.chromium.org/viewvc/chrome?view=rev&revision=172313
In that revision, the arena_thread_freeres suppression was added to
ignore.txt.

BUG=300
TEST=tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan -t
out/Release/system_wrappers_unittests
and trybot execution on linux_tsan

Review URL: https://webrtc-codereview.appspot.com/1019010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3375 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-01-16 10:49:31 +00:00
phoglund@webrtc.org
171ac59426 Corrected TSAN suppression. 
BUG=

Review URL: https://webrtc-codereview.appspot.com/1029007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3356 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-01-10 12:44:27 +00:00
phoglund@webrtc.org
bc9a959bd7 Generalized suppression for Trace::Add 
BUG=1194
TEST=Local run

Review URL: https://webrtc-codereview.appspot.com/1023007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3340 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-01-07 13:01:46 +00:00
kjellander@webrtc.org
0240e8e90f Wider TSAN suppression for issue 300 
On some machines, this test has still been failing, so I'm widening the
suppression to resolve this.

BUG=300
TEST=passing linux_tsan trybot.

Review URL: https://webrtc-codereview.appspot.com/992004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3280 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-12-13 13:02:29 +00:00
kjellander@webrtc.org
d2bcde2e4e Suppressing TSan warnings for system_wrappers_unittests 
This CL makes system_wrappers_unittests pass on Lucid (it passed on Precise
without them for me).

BUG=300
TEST=Try job on linux_tsan
TBR=henrike

Review URL: https://webrtc-codereview.appspot.com/976007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3263 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-12-11 21:39:18 +00:00
turaj@webrtc.org
42259e7ebc VoE Changes to enable dual_streaming. 
TEST=added new unit-test

This CL depends on issue 933015 http://webrtc-codereview.appspot.com/933015/
which is under review. Should be committed after issue 933015 is committed.
Committed: https://code.google.com/p/webrtc/source/detail?r=3231
Review URL: https://webrtc-codereview.appspot.com/970005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3257 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-12-11 02:15:12 +00:00
kjellander@webrtc.org
1101278a17 Wider suppression filter for tz-warnings in TSAN 
This catches the remaining warnings we see which it seems like the fun:__tz* suppression in Chromium's tools/valgrind/tsan/suppressions.txt file is aimed for.

BUG=884

Review URL: https://webrtc-codereview.appspot.com/841006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2845 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-09-28 15:30:58 +00:00
kjellander@webrtc.org
b6e4cc776e Valgrind memcheck and TSAN script now uses Chrome+WebRTC suppression files. 
Skeleton suppression files for future WebRTC suppressions are added and are included in addition to the ones Chrome are using and maintaining when our wrapper script executes.

Also added tweaked PRESUBMIT checks based on the Chrome code, that verifies
that suppressions are added correctly. I tested that they work by adding an invalid
suppression.

BUG=544
TEST=Tested running tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan -t out/Debug/system_wrappers_unittests and it reports far less errors. Tested adding bad suppression and it was caught by the PRESUBMIT check.

Review URL: https://webrtc-codereview.appspot.com/601004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2304 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-27 20:59:35 +00:00