Commit Graph

2413 Commits

Author SHA1 Message Date
phoglund@webrtc.org
5dbe568417 Disabled flaky tests. Standard tests will no longer run within extended tests.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/578006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2230 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-11 08:59:11 +00:00
bjornv@webrtc.org
61d0745e86 Resolve coverity warnings.
14050, 14051, 14243, 14314

In APM:
- Uninitialized variable initialized.
- NULL pointer sanity checks corrected.

Tested with trybots and audioproc_unittest.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/571009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2229 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-11 07:51:44 +00:00
phoglund@webrtc.org
7eadad6d95 Fixed valgrind errors so the fuzz test can be run under valgrind.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/576008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2228 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-11 07:36:53 +00:00
turaj@webrtc.org
799980fcaa Revert 2224 - Revert 2213 - Moved the fuzz test under valgrind and added valgrind support to the video bot.
CL 2213 did not need to be reverted. 

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/579008

TBR=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/569013

TBR=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/576010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2227 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-11 00:41:48 +00:00
turaj@webrtc.org
3c383abd27 Revert 2211 - Refactor the internal API to the rtp/rtcp module.
Review URL: https://webrtc-codereview.appspot.com/568004

A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/563011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2226 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 23:01:04 +00:00
turaj@webrtc.org
980d6be535 Revert 2212 - Bug fix
Review URL: https://webrtc-codereview.appspot.com/576009

A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/575009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2225 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 22:57:21 +00:00
turaj@webrtc.org
c2fe91256c Revert 2213 - Moved the fuzz test under valgrind and added valgrind support to the video bot.
A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/579008

TBR=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/569013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2224 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 22:55:57 +00:00
turaj@webrtc.org
449b525453 Revert 2214 - Bugfix
A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

TBR
Review URL: https://webrtc-codereview.appspot.com/570007

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/571010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2223 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 22:54:39 +00:00
turaj@webrtc.org
f02ee061ab Revert 2215 - Fixed destroy order.
A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

TBR
Review URL: https://webrtc-codereview.appspot.com/564007

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/562008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2222 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 22:53:33 +00:00
turaj@webrtc.org
f448ccd16c Revert 2216 - Fix for receive only channels.
A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

TBR
Review URL: https://webrtc-codereview.appspot.com/564008

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/579011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2221 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 22:52:19 +00:00
andrew@webrtc.org
b06db96840 Add a framework for audio end-to-end quality testing.
The quality comparison step is still to be done.

BUG=issue502
TEST=manual

Review URL: https://webrtc-codereview.appspot.com/577005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2220 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 18:45:11 +00:00
leozwang@webrtc.org
8aaf31d14f Create makefile for video engine
Description:
This build.xml will enable video engine build on android by ant. As we discussed before,
in order to make video engine build based on current webrtc file structure which is not
normal, I created this customized build.xml which is based on build.xml in android SDK.

BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/571008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2219 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 18:16:27 +00:00
leozwang@webrtc.org
6bd81f4962 Temporarily disable cpu detection in libvpx
CPU_DETECTION doesn't work in current build yet, it caused building errors
with neon build, disable it for now. Will discuss the future plan with the
team.

TBR=stefan
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/570006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2218 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 18:13:35 +00:00
leozwang@webrtc.org
f29d3fa177 Fix vp8 complexity parameter on android
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/575007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2217 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 18:12:01 +00:00
pwestin@webrtc.org
a69634aa92 Fix for receive only channels.
TBR
Review URL: https://webrtc-codereview.appspot.com/564008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2216 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 16:17:05 +00:00
pwestin@webrtc.org
c309c7c52b Fixed destroy order.
TBR
Review URL: https://webrtc-codereview.appspot.com/564007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2215 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 15:49:45 +00:00
pwestin@webrtc.org
fd3fef514b Bugfix
TBR
Review URL: https://webrtc-codereview.appspot.com/570007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2214 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 15:14:41 +00:00
phoglund@webrtc.org
80f7ac23b0 Moved the fuzz test under valgrind and added valgrind support to the video bot.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/579008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2213 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 14:43:10 +00:00
pwestin@webrtc.org
e1c97a2723 Bug fix
Review URL: https://webrtc-codereview.appspot.com/576009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2212 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 13:55:23 +00:00
pwestin@webrtc.org
0774838f3d Refactor the internal API to the rtp/rtcp module.
Review URL: https://webrtc-codereview.appspot.com/568004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2211 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 12:33:50 +00:00
phoglund@webrtc.org
00a186665c Added link to bloat builds.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/573004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2210 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 07:54:47 +00:00
bjornv@webrtc.org
cd54e56d72 Delay estimation performance test.
Added a test to verify estimation performance. Tested with audioproc_unittest and trybots.

BUG=issue435
TEST=None

Review URL: https://webrtc-codereview.appspot.com/569006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2209 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 07:41:23 +00:00
wu@webrtc.org
36b6331216 * Add gold as deps.
* Stop using the webrtc_deps as a workaround for a potential depot_tools bug
  where getting two DEPS file using File(...) was not handled properly.
  See crbug.com/127479 for detail.
Review URL: https://webrtc-codereview.appspot.com/579006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2208 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-09 23:22:30 +00:00
andrew@webrtc.org
270e9db039 Clarify the impact of disabling VAD on DTX.
TBR=henrika@webrtc.org
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/566009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2207 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-09 19:09:03 +00:00
leozwang@webrtc.org
b213cd55ef Remove bitmap implementation from surfaceview render
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/571004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2205 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-09 18:24:39 +00:00
leozwang@webrtc.org
de6a6b40fa Rename ViEAndroidDemo to WebRTCDemo
Desription:
This CL will change VideoEngine application name to ViEAndroidDemo. This
is the first step to refactor videoengine test application on android.

"ViE" is not a proper name because the app also supports audio. And it's good
to put WebRTC in application name.

BUG=
TEST=build on all trybots
Review URL: https://webrtc-codereview.appspot.com/576006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2204 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-09 15:23:52 +00:00
niklas.enbom@webrtc.org
f6edfeff63 Adding one parameter to typing detection tuning
Review URL: https://webrtc-codereview.appspot.com/569009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2203 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-09 13:16:12 +00:00
leozwang@webrtc.org
9f49af9cea Add libbitrate_controller which is introduced recently
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/571007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2202 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-09 04:46:24 +00:00
wu@webrtc.org
e6575050a9 Remove the third_party folder from peerconnection which we no longer need. Can't use gcl because gcl refuses to create a cl with no file in it.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2201 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 21:33:15 +00:00
leozwang@webrtc.org
d63cf71413 Fix broken build because gyp doesn't filter out platform specific file with suffixes of .c
BUG=
TEST=test on all trybots, failed only on win_rel for weird error.
Review URL: https://webrtc-codereview.appspot.com/563009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2200 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 21:33:04 +00:00
wu@webrtc.org
5f3b1cf99d Updated to chromium 134666.
Removed the need of the local libjingle.gyp and use the one from the chromium instead.
Review URL: https://webrtc-codereview.appspot.com/561004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2199 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 21:19:08 +00:00
andrew@webrtc.org
710eac763a Update DEPS comment and remove tabs from common.gypi.
TBR=wu@webrtc.org
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/575005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2198 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 18:00:57 +00:00
andrew@webrtc.org
22f6f85fcc Remove redundant initialization.
TBR=xians@webrtc.org
BUG=6140661
TEST=build on Linux

Review URL: https://webrtc-codereview.appspot.com/576005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2197 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 17:18:28 +00:00
andrew@webrtc.org
e59a0aca6a Fix AudioFrame types.
volume_ is not set anywhere so I'm removing it.

BUG=
TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/556004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2196 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 17:12:40 +00:00
leozwang@webrtc.org
f5fe1000de Enable cpu auto detection and ns optimized code on android
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/547006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2195 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 15:20:02 +00:00
hta@webrtc.org
9cc186405f Removed CleanUp call in Windows, since I couldn't find a call to it.
This solves Coverity issue 14424 by deleting the code.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/579005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2194 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 11:40:06 +00:00
mflodman@webrtc.org
e553031580 Refactore base, Capture, Codec and Custom Call parts of autotest. The CL doesn't contain any real functional changes, only style changes, cast changes and changing reference to pointer as input argument to functions.
Custome call still doesn't pass cpplint, but I'll take that in another CL to not change the structure in the style change CL.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/523001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2193 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 10:38:36 +00:00
braveyao@webrtc.org
113f851cc3 Merge Chromium issue 95797 into WebRTC.
Bug = 450
Test = Manual test
Review URL: https://webrtc-codereview.appspot.com/551004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2192 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 09:28:39 +00:00
pwestin@webrtc.org
7415f371ac Revert VP8 Deblocker.
Review URL: https://webrtc-codereview.appspot.com/563007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2191 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 09:06:31 +00:00
pwestin@webrtc.org
5019c9583c Enable VP8 deblocker.
Review URL: https://webrtc-codereview.appspot.com/578004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2190 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 08:40:28 +00:00
andrew@webrtc.org
589673f1cb Fix volume setting while not playing on PulseAudio.
We now only set the volume when starting playout if the user has called
SetSpeakerVolume while we weren't playing. This now also ensures it will
actually get set to what the user requested rather than being overridden
by a default value.

Add tests to voe_auto_test.

BUG=6140661
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/566006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2188 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-07 21:42:49 +00:00
leozwang@webrtc.org
20a05cd778 Disable WEBRTC_SVNREVISION
Description:
This CL will temporally define WEBRTC_SVNREVISION as "n/a" because it
could break Chromium if svn is not installed.
The long term solution is a have a script that could deal with it, and
have it support git-svn which is used by most developers.

BUG=496
TEST=build on Linux
Review URL: https://webrtc-codereview.appspot.com/569007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2187 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-07 21:16:33 +00:00
turaj@webrtc.org
fe4cfa7e5e Hi Tina,
I have uploaded this patch for your review. I have done an extensive test to be sure that removing of tables does not create any problem. 

The test file, is called test_lpc.c which requires a hack to standard iSAC. The test computes LPC coefficients, then encodes and decodes with old and new (size-reduced) tables. It compares the results is all steps. I have ran the test over large set of files, more then 51 hours of audio, and there was no error. 

I tried to do no formatting so the review to be easier, but I know it can be a tricky CL. Hopefully, the test file helps you to be more confident on the CL. 

Thanks,... Turaj  

In this change list the LPC tables associated with mode 1 & 2 are remoded, and necessary cahnges are made to other files. 

The only model allowed is model number 0. Therefore, this CL breaks compatibility with iSAC released prior to 2.4.3. To avoid changing the bit-stream, we still keep the model number in the bit-stream. 

entropy_coding.c is cleaned up, especially encoding of LAR had KLT transform of LPC gains which are removed now. 
Review URL: https://webrtc-codereview.appspot.com/548004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2186 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-07 20:36:22 +00:00
leozwang@webrtc.org
d46fe7034b Two bug fixs in android surface render
Descritption:
This CL addresses two issues in android surface view render,
1. Uninitlized class members _javaByteBufferObj and _directBuffer which
   could cause crash.
2. Using ConvertI420ToRGB565. We should use high level libyuv apis
   to help libyuv maintainer.

BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/566005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2185 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-07 20:29:43 +00:00
braveyao@webrtc.org
ba0f9fe10b Trival fix to voe_auto_test according to the main source codes
BUG = NULL
TEST = voe_auto_test
Review URL: https://webrtc-codereview.appspot.com/554004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2184 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-07 10:06:43 +00:00
phoglund@webrtc.org
f5657efd31 Rolled back r2177 since it breaks vie_auto_test.
I'm not sure what is the right thing to do here. That would probably be to call Release() the right amount of times and ensuring that the last call returns 0 (e.g. all references have been released), but I'll leave it up to the CL author to investigate that.

TBR=elham@webrtc.org
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/569005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2183 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-07 07:59:32 +00:00
andrew@webrtc.org
07bf9a07f5 Add test to verify identical input channels result in identical output channels.
BUG=issue411
TEST=audioproc_unittest, trybots

Review URL: https://webrtc-codereview.appspot.com/553009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2182 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-05 00:32:00 +00:00
leozwang@webrtc.org
329fcbba29 Reduce PSNR because I420ToARGB888 return lowers number on windows
TBR=stefan, marpan

BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/562005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2178 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-04 21:31:22 +00:00
elham@webrtc.org
c2f8832a32 Fix for FileTest failure in vie_auto_test
Review URL: https://webrtc-codereview.appspot.com/570004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2177 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-04 21:17:30 +00:00
leozwang@webrtc.org
1ea25b4c3d Change PSNR for I420ToARGB888 and I420ToRGB565
TBR=stefan, marpan

BUG=
TEST=test on linux
Review URL: https://webrtc-codereview.appspot.com/569004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2176 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-04 17:55:57 +00:00