Now we would get a failure if we do the same thing and the file would not be played out. Then GTalk/Hangout also reported this failure to us.
This CL is to restore the original function.
BUG = Issue 490
TEST = Manual test and voe_auto_test->FileBeforeStreamingTest
Review URL: https://webrtc-codereview.appspot.com/569016
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2347 4adac7df-926f-26a2-2b94-8c16560cd09d
Description:
On ChromeOS/ARM, compiler enforces to check return result of a function.
Currently, we don't check return result of fwrite, it causes building errors.
The following files need to patch. The patch should be similar, before I patch all
of them, I will start with 2 files, please take a quick look, if the patch is OK,
I will continue and upload a new patch that covers all of them.
it to all of them.
Review URL: https://webrtc-codereview.appspot.com/566016
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2345 4adac7df-926f-26a2-2b94-8c16560cd09d
Note that,
(1) The main change is a new function PitchFilter() replacing a couple of common code blocks. Next step will be the assembly coding of this function in ARM.
(2) Resulted code is not bit exact with the original. The only reason is replacing two saturation blocks (lines 197 and 208) for the case of "type == 2" with the general case (line 147 and 159). The change makes the code more consistent, and I think the original code might just be a bug. I raised the issue in an email to Turaj and Bjorn last week.
Listening test might be needed. I will send the resulted files to Turaj for this purpose.
(3) I used Astyle to make the code more stylish, but didn't try extra effort to correct all the code style details. Local code style consistency was considered for new code. So this is not a full and final refactor project (will leave that to future refactoring).
Review URL: https://webrtc-codereview.appspot.com/573009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2344 4adac7df-926f-26a2-2b94-8c16560cd09d
The test is now named 'bitrate_controller_unittests'.
This CL also enables it on the bots. The test is excluded on ASAN since
it fails when compiled with projects generated with GYP_DEFINES='asan=1' (see issue 555).
BUG=None
TEST=bitrate_controller_unittests was tested in Debug+Release on Linux, Mac and Windows + TSAN and memcheck.
Review URL: https://webrtc-codereview.appspot.com/612004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2333 4adac7df-926f-26a2-2b94-8c16560cd09d
Description:
This cl fixes two compilation errors on ChromeOS/ARM, it could
also be reproduced by gcc 4.5+.
I also add comments about error message and how I solve them.
BUG=webrtc issue 554
TEST=try bots and build on chromeos arm
Review URL: https://webrtc-codereview.appspot.com/611006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2327 4adac7df-926f-26a2-2b94-8c16560cd09d
Description:
On ChromeOS/ARM, compiler enforces to check return result of a function.
Currently, we don't check return result of fwrite, it causes building errors.
The following files need to patch. The patch should be similar, before I patch all
of them, I will start with 3 files, once we agree upon the solution, we will expand
it to all of them.
The question is should we do
1. if (error) { return -1;}
or
2. if (error) { /*ignor the error*/ }
I took "return -1" in this patch, but I'm OK with either. Please let me know your
thoughts and I will upload a new patch.
Review URL: https://webrtc-codereview.appspot.com/583010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2315 4adac7df-926f-26a2-2b94-8c16560cd09d
This CL contains a change of pointer nomenclature to array index. In addition, one place with two hard coded Gaussians has been generalized with a for loop.
Tested with trybots, vad_unittests, audioproc_unittest
BUG=None
TEST=None
Review URL: https://webrtc-codereview.appspot.com/592004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2307 4adac7df-926f-26a2-2b94-8c16560cd09d
These calls are not used anywhere in WebRTC and there is no plan on using them.
Removed them and updated corresponding unit tests.
Tested on trybots, vad_unittests, audioproc_unittest
BUG=None
TEST=None
Review URL: https://webrtc-codereview.appspot.com/608004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2306 4adac7df-926f-26a2-2b94-8c16560cd09d
Description:
This cl adds a feature that can query video engine and voice engine and load code list in
gui settings. Currently, codec lists are fixed in resource file, it caused confusion and
problems.
TBR=ronghua
BUG=
TEST=test on android
Review URL: https://webrtc-codereview.appspot.com/583006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2301 4adac7df-926f-26a2-2b94-8c16560cd09d
Description:
Ths cl makes voe_cmd_test work on android by excluding some code
that are availabel on android today, some highlights
1. change maxnumofchannles
2. disable audio device selection
3. disable set/get volume
BUG=
TEST=test on try bots
Review URL: https://webrtc-codereview.appspot.com/584009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2300 4adac7df-926f-26a2-2b94-8c16560cd09d
Resolve coverity warnings.
14305.
The warning is not really valid. The 'decode' function should be called with a 'mode' variable, where inside the function it is assumed that mode is either zero or one. If mode is taking other values some varibles are used uninitialized. However, this is an internal function and it is always called with either ZERO or ONE. Therefore, the code operates correctly. I made small changes as I beleive it is a bit nicer way.
In ACM:
- Conditions on 'mode' is changed.
Tested with trybots.
BUG=None
TEST=None
Review URL: https://webrtc-codereview.appspot.com/564014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2297 4adac7df-926f-26a2-2b94-8c16560cd09d
A very pedestrian approach to making TSAN stop complaining about the state variables: Wrap them in a critical section.
More creative approaches can be considered.
(not sure if diffbase works here, but...)
DIFFBASE=583008
BUG=webrtc:300
TEST=
Review URL: https://webrtc-codereview.appspot.com/584008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2282 4adac7df-926f-26a2-2b94-8c16560cd09d
