Commit Graph

5759 Commits

Author SHA1 Message Date
fischman@webrtc.org
130fa64d4c AppRTCDemo(android): remove HTML/regex hackery in favor of JSON struct.
BUG=3407
R=glaznev@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16619006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6345 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-05 20:31:41 +00:00
tina.legrand@webrtc.org
65d61c3924 Opus send rate overflows if over 65 kbps
The member holding the send rate for Opus had too low resolution for rates above ~65 kbps.

I've added a test that checks if the average rate in a Opus test is in the right range. The test fails before my fix, and now passes.

BUG=3267
R=henrik.lundin@webrtc.org, kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12579004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6344 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-05 13:42:51 +00:00
bjornv@webrtc.org
b51d3ea593 Revert 6341 "Fixes and enables SystemDelayTests."
> Fixes and enables SystemDelayTests.
> 
> The root cause for failure was that the delay handling of reported delays was bypassed on Android, whereas the tests assumes that part of AEC to be run.
> This CL checks if it is in use.
> 
> BUG=3445
> R=kwiberg@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/12689005

TBR=bjornv@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/13589004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6343 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-05 13:41:33 +00:00
kjellander@webrtc.org
681aaae71b Remove remaining samples (AppRTC) since moved to Github
In r5871 the samples directory was removed since they've now
moved to GitHub at https://github.com/GoogleChrome/webrtc

AppRTC needed to be kept in here (restored in r5873) since
automated tests in Chromium pulled AppRTC.
Now that a Chromium mirror has been setup for the GitHub repo
and that the automated tests have been updated, we can remove
this once and for all.

BUG=chromium:362483
TEST=None, but the automated tests have been verified syncing
the new location.

R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19639004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6342 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-05 13:09:59 +00:00
bjornv@webrtc.org
1f971b5788 Fixes and enables SystemDelayTests.
The root cause for failure was that the delay handling of reported delays was bypassed on Android, whereas the tests assumes that part of AEC to be run.
This CL checks if it is in use.

BUG=3445
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12689005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6341 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-05 10:58:55 +00:00
henrik.lundin@webrtc.org
2f816bbae7 NetEq: Add thread annotation to const scoped_ptrs
Since the objects pointed to are not const, only the pointer to them,
they too must be accessed under lock.

Move the crit_sect to above the variables it is protecting.

R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12679006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6340 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-05 10:37:13 +00:00
mflodman@webrtc.org
eae7924836 Adding back platform specific renderer to video loopback test.
BUG=3039
TEST=locally on Mac and Win, video_loopback test
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10689004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6339 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-05 09:32:51 +00:00
pbos@webrtc.org
0d523eea83 Remove static initializer from WebRtcVideoEngine2.
BUG=
R=pliard@google.com, pthatcher@webrtc.org, pliard@chromium.org

Review URL: https://webrtc-codereview.appspot.com/15679005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6338 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-05 09:10:55 +00:00
bjornv@webrtc.org
aafd7a88c5 The correct fix of workaround in r6261.
The CL also includes same changes to filterbanks.c in iSAC fix and aecm_core_c.c

BUG=3370,3395,3439
TESTED=trybots
R=fdegans@chromium.org, glaznev@webrtc.org, kwiberg@webrtc.org, tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14609004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6337 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-05 08:53:51 +00:00
bjornv@webrtc.org
edbe886a0b common_audio/signal_processing: Removed macro WEBRTC_SPL_MUL_16_16_RSFT_WITH_FIXROUND
This macro was only used at two places in fixed point iSAC, where it has been replaced with the operation.

BUG=3348,3353
TESTED=trybots
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15669004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6336 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-05 08:42:53 +00:00
stefan@webrtc.org
ef92755780 Have RTX be enabled by setting an RTX payload type instead of by setting an RTX SSRC.
This makes it easier to disable RTX by filtering out the RTX codec during call setup/signaling, and won't require that also the SSRCs are filtered out.

BUG=1811
R=mflodman@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15629005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6335 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-05 08:25:29 +00:00
henrik.lundin@webrtc.org
c578962006 Disable a test in libjingle_peerconnection_unittest for DrMemory
BUG=3453
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12689004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6334 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-05 07:38:31 +00:00
buildbot@webrtc.org
f1adbeedb4 (Auto)update libjingle 68562943-> 68571194
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6333 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-04 21:57:16 +00:00
henrike@webrtc.org
e6e139159f Android: cleanup gtest_target_type conditions.
Ever since crrev.com/133053 OS==android implies:
gtest_target_type=shared_library

Similar to Chromium's crrev.com/271222 where base.gyp's conditions are changed
(which the affected conditions in this cl comes from).

R=henrike@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/13539004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6332 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-04 20:46:50 +00:00
tkchin@webrtc.org
738df8913d Fix retain cycle in RTCEAGLVideoView.
CADisplayLink increases its target's refcount. In order to break retain cycle, we wrap CADisplayLink in a new RTCDisplayLinkTimer class and use that instead.

R=fischman@webrtc.org, noahric@chromium.org
BUG=3391

Review URL: https://webrtc-codereview.appspot.com/16599006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6331 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-04 20:19:39 +00:00
solenberg@webrtc.org
c6db88b0cf Make it possible to build webrtc for arm64.
- Bump revision of protobuf lib
- Remove -Wextra for arm64 gcc targets (warnings in stlport)
- Add MemoryBarrier implementation in single_rw_fifo.cc.
- [pending 15619004]: Bump revision of /deps/tools/android to get md5sum_bin for arm64.

BUG=chromium:354405,chromium:354539
R=andrew@webrtc.org, fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15629004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6330 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-04 17:15:42 +00:00
buildbot@webrtc.org
6f237769b3 (Auto)update libjingle 68507189-> 68543735
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6329 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-04 16:23:10 +00:00
buildbot@webrtc.org
40b45fc07a (Auto)update libjingle 68506654-> 68507189
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6328 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-04 14:48:33 +00:00
henrik.lundin@webrtc.org
d3dcebf6b4 Disable P2PTransportChannelMultihomedTest.TestFailover under Memcheck
BUG=3447
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15689004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6327 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-04 13:23:07 +00:00
bjornv@webrtc.org
147f4fe3c0 Disables SystemDelayTest.CorrectDelayDuringDrift on Android
Should have been part of https://webrtc-codereview.appspot.com/19629004/

BUG=3445
R=henrik.lundin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/21599004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6326 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-04 13:17:58 +00:00
bjornv@webrtc.org
b616e1211f Disables some modules_unittests on Android.
BUG=3445
R=henrik.lundin@webrtc.org, kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19629004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6325 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-04 12:12:58 +00:00
andresp@webrtc.org
4436b4436a Moved verbose logging in rtcp_receiver.cc to LS_VERBOSE.
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16619004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6324 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-04 09:05:30 +00:00
henrik.lundin@webrtc.org
2bdd3994e3 Suppress memcheck error in VideoProcessorIntegrationTest
BUG=3446
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19629005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6323 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-04 08:47:29 +00:00
mflodman@webrtc.org
19fc09efba Adding missing break in media_file_utility.cc.
There has been no reports of problems, but adding this to get it correct.

Review URL: https://webrtc-codereview.appspot.com/19599004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6322 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-04 05:21:56 +00:00
buildbot@webrtc.org
0cdcd23a03 (Auto)update libjingle 68501302-> 68506654
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6321 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-04 01:31:14 +00:00
buildbot@webrtc.org
af81b9bffd (Auto)update libjingle 68499439-> 68501302
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6320 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-04 00:08:54 +00:00
buildbot@webrtc.org
251fdf64cb (Auto)update libjingle 68495561-> 68499439
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6319 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-03 23:43:48 +00:00
henrike@webrtc.org
09a71cd9ce talk/ios: Fixes source after corrupt sync in r6305 (which corrupted r6291).
BUG=N/A
R=tkchin@webrtc.org
TBR=tkchin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/21589004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6318 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-03 22:46:23 +00:00
buildbot@webrtc.org
53217848b2 (Auto)update libjingle 68465410-> 68487517
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6317 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-03 21:09:11 +00:00
marpan@webrtc.org
4ef254f781 Enable videoprocessor_integrationtest tests on android.
R=kjellander@webrtc.org, stefan@webrtc.org
TBR=holmer@google.com

Review URL: https://webrtc-codereview.appspot.com/15599004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6316 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-03 16:42:03 +00:00
fischman@webrtc.org
83eb7dff5c PeerConnection(java): disable wait for flaky ICEConnection.COMPLETED.
This should be reverted when COMPLETED is delivered reliably.

BUG=3021
TESTED=without this patch the test fails in Debug mode after a handful of runs.  With this patch 100 runs passed in a row on my desktop.
R=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/13569004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6315 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-03 16:38:08 +00:00
turaj@webrtc.org
ddc6bc9347 Revert 6312 "Re-enable AudioCodingModuleMtTest"
An example of botbreakage is http://chromegw.corp.google.com/i/client.webrtc/builders/Linux%20Memcheck/builds/1807

> Re-enable AudioCodingModuleMtTest
> 
> Increase timeout and decrease test length. Also fixing a bug in the
> test, and make sure the test aborts if fatal failure occurrs.
> 
> BUG=3426
> R=kwiberg@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/13579005

TBR=henrik.lundin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19609004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6314 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-03 15:25:34 +00:00
pbos@webrtc.org
289a35c56d Add empty webrtcmediaengine.cc.
Should contain CreateWebRtcMediaEngine as soon as
libjingle/libjingle.gyp in Chromium builds this file. This file is added
ahead of time to get a smoother rolling process.

BUG=1788
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19599005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6313 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-03 14:51:34 +00:00
henrik.lundin@webrtc.org
8d13cd1956 Re-enable AudioCodingModuleMtTest
Increase timeout and decrease test length. Also fixing a bug in the
test, and make sure the test aborts if fatal failure occurrs.

BUG=3426
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/13579005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6312 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-03 12:53:21 +00:00
kwiberg@webrtc.org
8e4401b5a0 Reformat integer accessors to look like their float counterparts
The new format is at least as easy to read, and takes less space.

BUG=
R=aluebs@webrtc.org, bjornv@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16539004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6311 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-03 10:04:13 +00:00
kwiberg@webrtc.org
f2e4a99a39 Add kwiberg@webrtc.org to watchlist for audio_coding and audio_processing
BUG=
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/13559004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6310 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-03 10:01:39 +00:00
buildbot@webrtc.org
b525a9d790 (Auto)update libjingle 68379861-> 68445177
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6309 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-03 09:42:15 +00:00
pbos@webrtc.org
044bdacfef Remove kMaxWaitForStatsMs from tsanv2 compilation.
As some tests are #ifdef'd out on THREAD_SANITIZER this constant
triggers an unused-const-variable warning which breaks the build.

BUG=1205,3220
TBR=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/13579004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6308 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-03 09:40:01 +00:00
kwiberg@webrtc.org
c0035a67a1 Remove an optimization that's no longer worth the extra complexity it causes
The data_ optimization was a way to operate on the data directly
instead of copying it, applicable in the mono, non-float case. Since a
few audio_processing steps are already using floats (with more
hopefully to come), we don't end up benefiting from the optimization
anyway, so we might as well remove it.

BUG=
R=aluebs@webrtc.org, bjornv@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15539004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6307 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-03 09:10:06 +00:00
buildbot@webrtc.org
34a08b4fb8 (Auto)update libjingle 68275107-> 68379861
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6305 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-02 15:48:10 +00:00
solenberg@webrtc.org
a28c697d93 - Get rid of 'using' from .h
- Add parenthesis to make order of evaluation clearer.

BUG=
R=minyue@webrtc.org, tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12659004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6304 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-02 15:22:33 +00:00
kjellander@webrtc.org
2f7c7ce020 Remove old perf_expectations no longer used.
This has been replaced with the Chromium Perf
Dashboard web application a long time ago.

BUG=
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/21569004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6303 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-02 15:03:21 +00:00
henrik.lundin@webrtc.org
2bd032e11c Disable MouseCursorMonitorTest
Last attempt reverted. Trying again in a different way.

This CL effectively reverts r6300.

BUG=3245
TBR=sergeyu@chromium.org

Review URL: https://webrtc-codereview.appspot.com/20549004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6301 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-02 14:52:34 +00:00
henrik.lundin@webrtc.org
4ecae6e753 Disable MouseCursorMonitorTest.FromScreen
The test is flaky.

BUG=3245
TBR=sergeyu@chromium.org

Review URL: https://webrtc-codereview.appspot.com/21579004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6300 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-02 14:17:06 +00:00
henrik.lundin@webrtc.org
fe41a8f68d Adding thread annotations to parts of Audio Coding Module
Picking some low-hanging fruit. Add annotations for acm_crit_sect_ that
do not require lock changes. Also adding annotations for callbacks.

BUG=3401
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12579005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6299 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-02 11:45:26 +00:00
bjornv@webrtc.org
2812b59acd Re-enables CommonFormats test for Android.
It seems like this was a one time only and not a flaky test.

BUG=3376
TESTED=trybots
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15649005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6298 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-02 11:27:29 +00:00
pbos@webrtc.org
174a67439b Enable -Wall, -Wextra and -Wunused-variable for talk/ on clang.
Also removes one case of unused-variable.

BUG=3220
R=henrike@webrtc.org, kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15619005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6297 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-02 07:58:30 +00:00
jiayl@webrtc.org
8a09af3f67 Fix the build error from OpenSSLStreamAdapter::SSLVerifyCallback
TBR=pthatcher@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/17639004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6296 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-30 23:24:08 +00:00
fischman@webrtc.org
360507b12b VideoCaptureAndroid: don't synchronized on camera thread.
BUG=3421
R=glaznev@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12669004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6295 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-30 23:17:38 +00:00
jiayl@webrtc.org
0163674f99 Make OpenSSLStreamAdapter verify the leaf certificate digest for chained certificates.
It used to compre a parent certificate's digest against the SDP fingerprint and caused connection failure.

BUG=3383
R=bemasc@webrtc.org, juberti@webrtc.org, rsleevi@chromium.org

Review URL: https://webrtc-codereview.appspot.com/17589005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6294 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-30 23:14:08 +00:00