henrike@webrtc.org
d6d014ff12
Fixes memory leaks introduced in 1698.
...
Review URL: https://webrtc-codereview.appspot.com/387014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1701 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-16 02:18:09 +00:00
henrike@webrtc.org
f5da4da409
Removes a global non POD instance from the RTP_RTCP module that was introduced in https://code.google.com/p/webrtc/source/detail?r=1076 .
...
Review URL: https://webrtc-codereview.appspot.com/314001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1698 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-15 23:54:59 +00:00
mflodman@webrtc.org
d7d46887a6
Update receive only channels with RTT.
...
vie_autotest_loopback.cc will not be part of the commit, it's only to show the test.
TEST=temporary with attached loopback test.
Review URL: https://webrtc-codereview.appspot.com/390007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1678 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-14 12:49:59 +00:00
marpan@webrtc.org
567d507707
Fixes a bug when number of media packets in a frame is larger than maximum allowed for the generateFEC.
...
Review URL: https://webrtc-codereview.appspot.com/391003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1673 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-10 18:56:14 +00:00
mflodman@webrtc.org
8224e19dd9
Fixed incorrect packet loss reported to encoder.
...
BUG=275
Review URL: https://webrtc-codereview.appspot.com/394004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1669 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-10 12:41:57 +00:00
pwestin@webrtc.org
5e954814a8
Clanup handling of key frame requests and FIR.
...
Review URL: https://webrtc-codereview.appspot.com/387004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1667 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-10 12:13:12 +00:00
stefan@webrtc.org
4b377414f1
Fix release build errors.
...
TBR=mflodman
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/394005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1654 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-09 13:50:57 +00:00
stefan@webrtc.org
9c84b0dc9f
Fix build errors with GCC.
...
TBR=mflodman
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/389006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1652 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-09 13:14:04 +00:00
stefan@webrtc.org
7adab0922d
This removes the knowledge of frame completeness from the FEC decoder.
...
Therefore, with this change a recovered packet is only considered old,
and will be removed, if more than 48 recovered packets are stored.
Packets are immediately reconstructed and sent to the jitter
buffer. Before this CL packets were processed on a frame-by-frame
basis, and all packets belonging to a frame was sent to the
jitter buffer at the same time.
The number of FEC packets is also limited to 48. An FEC packet is
removed if all protected packets have been recovered or if the
FEC packet is considered old.
Lot's of tests added.
Patch-set 2:
- Fixed rtp_fec_unittest.cc to work with the new reconstruction.
- Added reference counting of Packet to be able to keep references to them from FecPacket between different reconstruction runs.
- Rewrote the packet search to use std::set_intersection.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/379005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1651 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-09 12:34:52 +00:00
henrike@webrtc.org
d5657c2f69
Refactored files according to google style since http://review.webrtc.org/314001/ is blocked on this and formatting changes should not be done with code changes.
...
Review URL: https://webrtc-codereview.appspot.com/387005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1648 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 23:41:49 +00:00
andrew@webrtc.org
68da6adafe
Remove WebRtc_ types.
...
Allows us to avoid the "cast to UWord32" Coverity coverup.
BUG=
TEST=test_fec
Review URL: https://webrtc-codereview.appspot.com/379002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1647 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 22:24:14 +00:00
tina.legrand@webrtc.org
df69775bfa
Adding support for full-stereo codec.
...
This is an experiment, letting Celt represent a full-stereo codec.
Review URL: https://webrtc-codereview.appspot.com/379013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1636 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 10:22:21 +00:00
phoglund@webrtc.org
78088c2f36
Removed warnings on Windows and enabled warnings-as-errors on Windows.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/377004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1624 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 14:56:45 +00:00
mflodman@webrtc.org
657b2a4965
Added return due to gcc complaints in r1604.
...
TBR=andrew
TEST=Bulid with clang version 3.1 (trunk 148911) and gcc.
Review URL: https://webrtc-codereview.appspot.com/384004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1606 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 11:06:01 +00:00
mflodman@webrtc.org
c80d9d9361
Removed default cases causing clang errors, -Wcovered-switch-default.
...
BUG=
TEST=Bulid with clang version 3.1 (trunk 148911)
Review URL: https://webrtc-codereview.appspot.com/379008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1604 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 10:11:25 +00:00
andrew@webrtc.org
4942832928
Fix "may be used uninitialized" warning.
...
TBR=marpan@webrtc.org
BUG=
TEST=build on Linux/Release and rtp_rtcp_unittests
Review URL: https://webrtc-codereview.appspot.com/381004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1602 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-04 05:23:51 +00:00
marpan@webrtc.org
b783a55df3
Unit test for forward_error_correction.
...
Review URL: https://webrtc-codereview.appspot.com/358006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1601 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-04 02:46:35 +00:00
marpan@webrtc.org
307c1ff20c
Fix for issue #254 : windows crash of test_fec.
...
Review URL: https://webrtc-codereview.appspot.com/379010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1600 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-04 02:45:22 +00:00
stefan@webrtc.org
07b45a5dc4
Added API for getting the send-side estimated bandwidth.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/372006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1591 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-02 08:37:48 +00:00
andrew@webrtc.org
7fe219f681
Add some additional checks for corrupt payload.
...
Investigation with corrupt payloads revealed a few places we could
be using stronger checks. These are not foolproof by any means, but
I figure the earlier we catch this the better.
BUG=242
TEST=loopback call with a hacked ViE to insert corrupt payloads, and vie_auto_test without the hacks.
Review URL: https://webrtc-codereview.appspot.com/369015
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1585 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 02:40:37 +00:00
marpan@webrtc.org
cdba1a836b
test_fec: Reduce execution time of test, and use testsupport/fileutils.h for path of randomSeedLog file.
...
Review URL: https://webrtc-codereview.appspot.com/373016
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1576 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 00:36:14 +00:00
pwestin@webrtc.org
5dad00be52
Coverty fix: FEC unintended signed extension and resource leaks.
...
Review URL: https://webrtc-codereview.appspot.com/368010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1569 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 13:05:29 +00:00
stefan@webrtc.org
2fd1e1e40d
Add unittests for ReceiverFec.
...
Also added mock for RtpReceiverVideo and did appropriate changes to
allow for mocking.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/367017
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1566 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 09:03:37 +00:00
pwestin@webrtc.org
04cf69a714
Coverty: cleanup CheckCSRC.
...
Review URL: https://webrtc-codereview.appspot.com/369014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1564 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 13:47:19 +00:00
phoglund@webrtc.org
d1a860b415
Fixed GCC 4.6 errors (mostly 'unused variable' errors and incorrect usage of EXPECT_EQ with booleans.
...
Fixed remaining compilation errors in release, etc.
Fixed errors from GCC 4.6 compilation.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/366008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1554 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-26 14:49:28 +00:00
henrike@webrtc.org
567b99be5f
Coverity report: fixes an issue where the returnvalue of a function is not checked.
...
Review URL: https://webrtc-codereview.appspot.com/347013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1542 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 23:43:54 +00:00
pwestin@webrtc.org
f6bb77a6f0
Cleaning up all use of RTP_PAYLOAD_NAME_SIZE and RTCP_CNAME_SIZE also fixed the char handing in trace.
...
Review URL: https://webrtc-codereview.appspot.com/358001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1535 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 17:16:59 +00:00
pwestin@webrtc.org
b73c3d1f5d
Bugfix android build.
...
Review URL: https://webrtc-codereview.appspot.com/374003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1532 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 15:25:30 +00:00
pwestin@webrtc.org
28a5cb29ab
Bugfix receive side only packet loss estimate with NACK.
...
Review URL: https://webrtc-codereview.appspot.com/373006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1529 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 14:34:58 +00:00
punyabrata@webrtc.org
6da8eeb946
Removing an assert for a case that can occur
...
when corrupt packets are injected into voice engine.
Review URL: https://webrtc-codereview.appspot.com/373004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1518 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 00:48:36 +00:00
leozwang@webrtc.org
376be6c904
Fix compilation error
...
Review URL: https://webrtc-codereview.appspot.com/358005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1508 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 16:46:38 +00:00
pwestin@webrtc.org
b30f0edce6
Bugfix buffer usage out of scope.
...
Review URL: https://webrtc-codereview.appspot.com/372001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1507 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 16:23:31 +00:00
pwestin@webrtc.org
56ee5d5d98
Bugfix 32 bit linux.
...
Review URL: https://webrtc-codereview.appspot.com/353010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1490 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 07:47:38 +00:00
pwestin@webrtc.org
95cf47932d
Remove list wrapper from FEC code.
...
Review URL: https://webrtc-codereview.appspot.com/350013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1489 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 06:59:06 +00:00
pwestin@webrtc.org
0074187436
Removed map_wrapper from rtp_sender
...
Review URL: https://webrtc-codereview.appspot.com/343014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1478 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 15:56:10 +00:00
pwestin@webrtc.org
3c9be1bc4d
Removed list wrapper fromr overuse detector.
...
Review URL: https://webrtc-codereview.appspot.com/353004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1477 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 15:55:54 +00:00
pwestin@webrtc.org
d4adc5b26f
removed unused include from remote rate control.
...
Review URL: https://webrtc-codereview.appspot.com/350015
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1476 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 15:55:30 +00:00
pwestin@webrtc.org
af6f15c1bf
Changed RTP reveivers to use stl map and list.
...
Review URL: https://webrtc-codereview.appspot.com/349010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1475 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 15:53:59 +00:00
pwestin@webrtc.org
38f4816737
Removed unused include from rtp sender audio.
...
Review URL: https://webrtc-codereview.appspot.com/348012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1474 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 15:53:33 +00:00
pwestin@webrtc.org
26f8d9c7f3
Removed list and map wrappers, for RTCP handling.
...
Review URL: https://webrtc-codereview.appspot.com/349011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1473 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 15:53:09 +00:00
pwestin@webrtc.org
1da2327473
Changing header extension to use stl map.
...
Review URL: https://webrtc-codereview.appspot.com/350014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1469 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 12:58:53 +00:00
andrew@webrtc.org
267ca3162b
Fix comparison-always-true warning with -Wextra.
...
TEST=build on Linux with -Wextra.
Review URL: https://webrtc-codereview.appspot.com/353005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1456 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-18 19:41:40 +00:00
henrik.lundin@webrtc.org
4407edc314
Bugfix in VP8 packetizer
...
Handle the case with no small partitions in Vp8PartitionAggregator.
Also added a new unit test for the packetizer to verify that the
bug is fixed.
TEST=RtpFormatVp8Test.TestAggregateModeTwoLargePartitions
TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/348011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1451 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-18 10:01:03 +00:00
henrik.lundin@webrtc.org
7f2c2a5db2
Adding optimized aggrgation to VP8 packetizer
...
This change introduces a new algorithm for aggregating small
partitions into packets. The algorithm is based on a tree-search
to find an optimal allocation of the packets, such that the
difference in size between packets is minimized.
The new method is used when partition aggregation is allowed and
balanced packets are requested. Otherwise, the old method is used.
The new method is implemented using the new classes
Vp8PartitionAggregator and PartitionTreeNode. Both classes have
dedicated unit tests.
In order to facilitate the new algorithm, the packetizer was
redesigned to calculate all packet sizes when the first packet is
extracted. The information about all packets is stored in a packet
queue structure, which is then popped for each packet extracted.
Finally, a bug in the old packetizer algorithm was fixed. The bug
caused a +/-1 error in packet sizes when balanced packets were
produced. The unit test were updated accordingly.
TEST=rtp_rtcp_unittests: PartitionTreeNode.* Vp8PartitionAggregator.* RtpFormatVp8Test.*
Review URL: https://webrtc-codereview.appspot.com/345008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1447 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-18 08:21:15 +00:00
pwestin@webrtc.org
5621057956
Removing unused code.
...
Review URL: https://webrtc-codereview.appspot.com/349008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1442 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-17 12:45:47 +00:00
pwestin@webrtc.org
df9bd9bdbd
Removed dead code.
...
Review URL: https://webrtc-codereview.appspot.com/352010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1437 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-17 11:42:02 +00:00
pwestin@webrtc.org
aafa5a331c
Coverty report: Unititialized members
...
Review URL: http://webrtc-codereview.appspot.com/349007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1436 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-17 07:07:37 +00:00
asapersson@webrtc.org
43b8fc5c0d
Review URL: http://webrtc-codereview.appspot.com/345011
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1435 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 13:49:04 +00:00
asapersson@webrtc.org
869ce2d441
Review URL: http://webrtc-codereview.appspot.com/353002
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1432 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 11:58:36 +00:00
asapersson@webrtc.org
0b3c35a258
Review URL: http://webrtc-codereview.appspot.com/321011
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1431 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 11:06:31 +00:00