Commit Graph

2852 Commits

Author SHA1 Message Date
tommi@webrtc.org
b952a90038 Remove an unused Shutdown method from the ThreadWrapper interface.
The method was flagged by Chrome engineers as dubious since it uses
TerminateThread.  As it turns out, we don't use this method anywhere,
so we can simply remove it! :)

BUG=1066
Review URL: https://webrtc-codereview.appspot.com/938012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3065 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-08 13:40:59 +00:00
phoglund@webrtc.org
1401285fe7 Can now fully control custom calls from the command line.
Example:
out/Debug/vie_auto_test --auto_custom_call --override "Enter destination IP.=127.0.10.55,Enter video send port.=12345"

The above will launch a call directly and choose all default values except for the overridden ones specified above.

BUG=

Review URL: https://webrtc-codereview.appspot.com/920008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3064 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-08 12:18:19 +00:00
wu@webrtc.org
2a749d3108 Verify output frame timestamp in VideoProcessingModuleTest.Resampler.
TEST=unit tests
BUG=1069

Review URL: https://webrtc-codereview.appspot.com/964014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3063 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-08 01:07:21 +00:00
wu@webrtc.org
206532e6e2 Fix a bug in spatial_resampler where we should set the timestamp after Scale.
TEST=try bots
BUG=1069

Review URL: https://webrtc-codereview.appspot.com/936018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3061 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-07 23:37:41 +00:00
kma@webrtc.org
12454028bc Fixed and enabled ARM assembly code in AECM and NS.
Review URL: https://webrtc-codereview.appspot.com/860005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3060 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-07 22:34:31 +00:00
kma@webrtc.org
31eae47444 Implemented a build system that generates offset header files for ARM assembly files, in Android.
The original CL was separated into two. Please refer to https://webrtc-codereview.appspot.com/860005 on how the build system and python script being used.
Review URL: https://webrtc-codereview.appspot.com/754005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3059 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-07 22:34:16 +00:00
mikhal@webrtc.org
055663be0a Updating vp8 tests
Review URL: https://webrtc-codereview.appspot.com/936017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3058 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-07 21:36:15 +00:00
andrew@webrtc.org
c862f49b2d Move capture level computation after all processing.
BUG=issue1065

Review URL: https://webrtc-codereview.appspot.com/930014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3057 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-07 19:08:03 +00:00
stefan@webrtc.org
7096fc0126 Break out unittest helpers for remote_bitrate_estimator.
BUG=

Review URL: https://webrtc-codereview.appspot.com/934012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3056 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-07 18:35:30 +00:00
mikhal@webrtc.org
ac993fef2c Adding codecType to OnIncomingCapturedEncodedFrame
partially reverting r3013.

Review URL: https://webrtc-codereview.appspot.com/965010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3055 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-07 17:18:04 +00:00
pwestin@webrtc.org
c66e8b3f31 pre-factor cleanup pre-work.
Review URL: https://webrtc-codereview.appspot.com/938010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3054 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-07 17:01:04 +00:00
phoglund@webrtc.org
4cebe6cded Made TickTime immutable, rewrote tick utils to be fakeable.
BUG=

Review URL: https://webrtc-codereview.appspot.com/798004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3053 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-07 13:37:19 +00:00
mflodman@webrtc.org
6e9890d1aa Removed ViEBaseObserver.
BUG=1037
TEST=Still compiles and ViE autotest passes.

Review URL: https://webrtc-codereview.appspot.com/929012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3052 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-07 10:48:40 +00:00
kjellander@webrtc.org
8d0cef3bd2 Updating opus in .gitignore
BUG=none
TEST=git status in a git-svn checkout.

Review URL: https://webrtc-codereview.appspot.com/965011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3051 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-07 08:22:10 +00:00
tina.legrand@webrtc.org
0ad3c1af0a Adding Opus stereo support to WebRTC
This CL adds support for sending and receiving stereo using the Opus codec.

BUG=issue1013

Review URL: https://webrtc-codereview.appspot.com/930008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3050 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-07 08:07:29 +00:00
vikasmarwaha@webrtc.org
6dddfe9c35 Fix for webrtc issue 1052 on windows with vie_auto_test.
Review URL: https://webrtc-codereview.appspot.com/929014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3049 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-06 21:19:52 +00:00
andrew@webrtc.org
ddcc9429e7 Check the channels in receive-side processing frames.
The number of channels must be set correctly before calling ProcessStream. This
was preventing stereo frames from being processed.

Also fix voe_cmd_test, which wasn't enabling rx NS properly.

BUG=issue713, 7375579

Review URL: https://webrtc-codereview.appspot.com/929013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3047 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-06 18:39:40 +00:00
asapersson@webrtc.org
e5b49a0472 Update timestamp offset for re-transmitted packets.
BUG=1059
Review URL: https://webrtc-codereview.appspot.com/930011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3046 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-06 13:09:39 +00:00
kjellander@webrtc.org
f17d7d1dde Using proper GYP references for Strmiids.lib on Windows
This makes it possible to link properly using Ninja on Windows.

Another issue exists due to the path containing spaces in webrtc/modules/video_capture/windows/direct_show_base_classes.gyp but that can be worked around by copying the baseclasses dir from the SDK into a path without spaces and then overriding the direct_show_dir variable with GYP_DEFINES.

Example:

set GYP_DEFINES=direct_show_dir=C:/WinSDKv7.1_directshow_baseclasses/
gclient runhooks
ninja -C out/Debug

Notice that the ending slash is needed for the direct_show_dir variable.

BUG=none
TEST=local compilation with the baseclasses copied from Windows SDK 7.1 into C:/WinSDKv7.1_directshow_baseclasses.

Review URL: https://webrtc-codereview.appspot.com/936014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3043 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-05 13:13:05 +00:00
tina.legrand@webrtc.org
f7fa6276e2 Reformating files in audio coding module.
This CL format the ramaining files on the audio coding module. No other changes are done, except for fixing a few long lines and TODOs without owner.

BUG=issue1024

Review URL: https://webrtc-codereview.appspot.com/928012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3042 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-05 09:35:51 +00:00
kjellander@webrtc.org
a56d759723 Removing use of raw buffers for I420PSNR and I420SSIM functions
BUG=none
TEST=metrics_unittest, video_codecs_test_framework_integrationtests in normal and memcheck mode.

Review URL: https://webrtc-codereview.appspot.com/937013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3041 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-02 22:36:14 +00:00
leozwang@webrtc.org
5f9970fb0b Refactor OpenSL audio driver
Message:
I want to start this review, the basica framework is almost done.

Description:
This implementation is similar to current one, but
1. followed the design doc at
https://docs.google.com/a/google.com/document/d/1g5q2SVtkFPl2OSjvSF3eeLb_S7sCnbINxiBUES6XLCM/edit
which uses two threads, playout thread and recording thread, uses large
audio buffer, etc.
2. google code style.

What are missing in this cl,
1. a better way to control schedule/thread priority.
2. java/jni interface to better support what cannot be done in OpenSL.

Please take a review, thanks.
Review URL: https://webrtc-codereview.appspot.com/902004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3040 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-02 16:48:03 +00:00
mikhal@webrtc.org
737ed3bfa5 libyuv wrapper: 1. Updating rotation settings - in case of 90 or 270 degree rotations, width and height should be updated accordingly. 2. Test clean-up.
TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/936008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3039 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-01 15:45:38 +00:00
mflodman@webrtc.org
1be46fc721 Change src/webrtc in WATCHLIST.
TEST=ViE people were auto-cc on this dummy cl http://review.webrtc.org/938007/

Review URL: https://webrtc-codereview.appspot.com/939010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3038 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-01 08:09:09 +00:00
kjellander@webrtc.org
f3ffcceaf8 Adding default trybot names to PRESUBMIT.py.
With this change, only the listed trybots will be the ones that a tryjob
is sent to. This works because there's a check in depot_tools/presubmit_support.py that looks for a function defined with the name 'GetPreferredTrySlaves'.

This makes it possible for us to add new trybots that will not receive jobs by default (only when the --bot flag is specified).

This CL is needed before we add the following try bots:
linux_memcheck
linux_tsan
linux_asan

BUG=none
TEST=submitting jobs to a local try server, with and without the --bot
flag.

Review URL: https://webrtc-codereview.appspot.com/939008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3031 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-31 14:52:21 +00:00
niklas.enbom@webrtc.org
ef629299e9 Landing http://review.webrtc.org/914006/
Review URL: https://webrtc-codereview.appspot.com/930007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3030 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-31 14:35:11 +00:00
stefan@webrtc.org
1a2a6dda26 Fixes a bitrate mismatch between sender and receiver.
TEST=trybots

BUG=

Review URL: https://webrtc-codereview.appspot.com/928014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3029 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-31 12:21:13 +00:00
andrew@webrtc.org
e034f21d8d Remove video_capture/test/android
Review URL: https://webrtc-codereview.appspot.com/937011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3028 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-31 05:36:50 +00:00
andrew@webrtc.org
9841d92b8d Reorganize modules/video_render.
The usual elimination of main/source etc.

Review URL: https://webrtc-codereview.appspot.com/929011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3027 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-31 05:22:11 +00:00
andrew@webrtc.org
3c01316d5a Fix Android build after video_capture reorg.
Review URL: https://webrtc-codereview.appspot.com/934011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3026 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-30 22:17:21 +00:00
andrew@webrtc.org
94caca7105 Reorganize modules/video_capture.
- The usual elimination of main/source etc.
- Fully qualify "public" includes.
- Use lowercase for all directory names.

Review URL: https://webrtc-codereview.appspot.com/933010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3025 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-30 21:58:00 +00:00
wu@webrtc.org
5ff091f16a Init capturePicture with GetCaptureDeviceSnapshot so that the SetRenderStartImage test won't depend on the previous test which may be disabled by the include_timing_dependent_tests flag. This is a fix for LinuxLargeTests.
TEST=try bots
BUG=1023

Review URL: https://webrtc-codereview.appspot.com/964007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3024 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-30 21:52:03 +00:00
mikhal@webrtc.org
91a0340a61 Adding stride alignment
TEST= common_video_unittests and video_capture_module_test

BUG=985

Review URL: https://webrtc-codereview.appspot.com/965005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3023 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-30 19:19:32 +00:00
leozwang@webrtc.org
6ab92ed42d Check if opus exists when build test app on Android
BUG=None
TEST=trybots
Review URL: https://webrtc-codereview.appspot.com/933011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3022 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-30 19:04:58 +00:00
mikhal@webrtc.org
c381a8487a Fix valgrind issue.
Code was removed by mistake in r2983.

BUG=1020

Review URL: https://webrtc-codereview.appspot.com/938006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3021 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-30 18:22:02 +00:00
wu@webrtc.org
f6a4a49ab8 Suppress the -Wno-address-of-array-temporary for linux clang.
BUG=1016
TBR=andrew
TEST=build using clang on linux
Review URL: https://webrtc-codereview.appspot.com/934010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3020 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-30 16:43:23 +00:00
pwestin@webrtc.org
2f476ed760 Fix uninitialzed memory and cleanup.
BUG=1022
Review URL: https://webrtc-codereview.appspot.com/966006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3019 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-30 16:21:52 +00:00
kma@webrtc.org
ff137edc53 Work around with issue 971 (signal_processing_unittests fails memcheck when compiled with GCC 4.6).
Review URL: https://webrtc-codereview.appspot.com/935008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3017 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-30 01:19:42 +00:00
stefan@webrtc.org
6dcef360f8 Follow-up CL for r3007.
Fixes an initialization issue introduced with r3007 and adds a test for
detecting problems with reordering. Also some cleanup for better code.

TEST=remote_bitrate_estimator_unittests

BUG=1009

Review URL: https://webrtc-codereview.appspot.com/937007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3014 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-29 16:06:08 +00:00
mikhal@webrtc.org
e83d3111d4 Removing codecType from capture API
Review URL: https://webrtc-codereview.appspot.com/964005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3013 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-29 15:59:40 +00:00
leozwang@webrtc.org
6f19b1b651 Enable Opus
BUG=webrtc issue 992
TEST=trybots
Review URL: https://webrtc-codereview.appspot.com/942004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3012 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-27 17:46:55 +00:00
andrew@webrtc.org
8186534111 Only reinitialize AudioProcessing when needed.
This takes away the burden from the user, resulting in cleaner code.

Review URL: https://webrtc-codereview.appspot.com/941005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3010 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-27 00:28:27 +00:00
mikhal@webrtc.org
e08adf0957 fix print out in mirror test
Review URL: https://webrtc-codereview.appspot.com/928010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3008 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-26 22:58:58 +00:00
mikhal@webrtc.org
8d2f5c59cd Fixing BWE estimation reordering issue
BUG=1009
TBR=stefan

Review URL: https://webrtc-codereview.appspot.com/936006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3007 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-26 22:53:21 +00:00
fbarchard@google.com
c9471474e4 Roll libyuv to r438 to get vs2012 cleanup, NV12 to/from I420 and NV21. Added Unaligned unittests.
BUG=none
TEST=libyuv unittests
Review URL: https://webrtc-codereview.appspot.com/922008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3004 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-26 20:31:23 +00:00
henrike@webrtc.org
e341fd6073 Fixes http://code.google.com/p/webrtc/issues/detail?id=1003
BUG=1003

Review URL: https://webrtc-codereview.appspot.com/941004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3003 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-25 22:02:50 +00:00
henrike@webrtc.org
bc48b8c803 Fixes http://code.google.com/p/webrtc/issues/detail?id=1002
BUG=1002

Review URL: https://webrtc-codereview.appspot.com/931006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3002 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-25 22:01:25 +00:00
mikhal@webrtc.org
a5d4c31735 Fixing IsZeroSize call
Review URL: https://webrtc-codereview.appspot.com/940004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3001 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-25 21:31:31 +00:00
andrew@webrtc.org
a3ae6dc846 Remove opus include path from opus.gypi.
It's now exported by opus.gyp.

Review URL: https://webrtc-codereview.appspot.com/928007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2997 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-25 17:51:09 +00:00
mikhal@webrtc.org
9169b51fe7 Fixing vpm valgrind issues introduced in r2893
Review URL: https://webrtc-codereview.appspot.com/933007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2996 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-25 15:23:11 +00:00