generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
2,852 Commits 1 Branch 0 Tags 108 MiB
d42e51ce7c
Commit Graph

9 Commits

Author SHA1 Message Date
kjellander@webrtc.org
f3ffcceaf8 Adding default trybot names to PRESUBMIT.py. 
With this change, only the listed trybots will be the ones that a tryjob
is sent to. This works because there's a check in depot_tools/presubmit_support.py that looks for a function defined with the name 'GetPreferredTrySlaves'.

This makes it possible for us to add new trybots that will not receive jobs by default (only when the --bot flag is specified).

This CL is needed before we add the following try bots:
linux_memcheck
linux_tsan
linux_asan

BUG=none
TEST=submitting jobs to a local try server, with and without the --bot
flag.

Review URL: https://webrtc-codereview.appspot.com/939008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3031 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-10-31 14:52:21 +00:00
kjellander@webrtc.org
6307dbf468 Updates the PRESUBMIT.py to allow years from 2011 to the current year. 
Since Chromium has moved to this policy, we should too.
Code is copied from /depot_tools/presubmit_canned_checks.py but modified for our purpose.

BUG=
TEST=Tested git cl presubmit with a modified .cc file with the 2011 header and one with the 2012.

Review URL: https://webrtc-codereview.appspot.com/770005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2691 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-08-31 07:07:11 +00:00
mflodman@webrtc.org
2a45209a6d Adde video_engine to cpplint check. 
BUG=627
TEST=Manual test with style violations in src/video_engine and in other folders.

Review URL: https://webrtc-codereview.appspot.com/399014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2474 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-07-01 05:55:23 +00:00
kjellander@webrtc.org
51198f1c68 More PRESUBMIT checks. 
Checks for:
- No iostream includes in headers
- No use of FRIEND_TEST for gtest
- Verifies that all C/C++ code passes cpplint.py check.
- Verifies that BUG= is present in commit message
- Verifies that TEST= is present in commit message

For more details, see Chrome's PRESUBMIT.py at
http://src.chromium.org/viewvc/chrome/trunk/src/PRESUBMIT.py?revision=113979&view=markup
and the canned checks at
http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/presubmit_canned_checks.py?view=markup

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/317011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1737 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-21 17:53:46 +00:00
andrew@webrtc.org
53df136240 Add upload and commit checks to a common function. 
Add HasDescription and HasNoStrayWhitespace checks.

BUG=none
TEST=uploaded a dummy CL with violations.

Review URL: https://webrtc-codereview.appspot.com/372004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1556 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-26 21:24:23 +00:00
andrew@webrtc.org
2442de1351 Clean up PRESUBMIT.py, and enable license check. 
Fix the license header based on the example in:
http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/presubmit_canned_checks.py?revision=107590&view=markup

BUG=None
TEST=Run presubmit checks on a dummy CL with Python and C code.

Review URL: https://webrtc-codereview.appspot.com/369002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1511 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 17:45:41 +00:00
mflodman@webrtc.org
9dddfaefdc Change copyright year. 
Review URL: https://webrtc-codereview.appspot.com/353009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1492 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-20 08:17:28 +00:00
niklase@google.com
1198db9dd6 Adding owners check in presubmit script. 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@62 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-06-09 07:07:24 +00:00
niklase@google.com
da159d6be6 git-svn-id: http://webrtc.googlecode.com/svn/trunk@11 4adac7df-926f-26a2-2b94-8c16560cd09d 2011-05-30 11:51:34 +00:00