generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
7,681 Commits 1 Branch 0 Tags 108 MiB
d3d3baaa8e
Commit Graph

434 Commits

Author SHA1 Message Date
henrike@webrtc.org
ee135f78b7 Memcheck suppression. Re-suppress 3478 suppression after namespace change from talk_base to rtc. 
BUG=3478
TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15079004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6819 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-08-04 15:35:14 +00:00
pbos@webrtc.org
ba92c52570 Disable GetStats on DrMemory. 
Flakes/fails on DrMemory Full just like the implementation in
webrtcvideoengine.cc.

BUG=3482
R=sprang@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20009004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6731 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-07-18 13:33:48 +00:00
pbos@webrtc.org
336e8e8f50 Fixing memcheck leak suppressions for XMPPClient tests. 
BUG=
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16049004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6665 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-07-11 13:44:45 +00:00
henrike@webrtc.org
ba93f9a986 drmemory flaky: EndToEndTest.RestartingSendStreamPreservesRtpState[WithRtx] suppressed on drMemory. 
BUG=3552
TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17899004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6614 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-07-07 16:52:19 +00:00
kjellander@webrtc.org
b25b08b302 Remove tools/resources 
The script to update the resources before we used the .sha1 files
was moved out in r4277 and later deleted in r5099.
This dir serves no purpose, so let's remove it.

BUG=
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17849004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6585 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-07-02 15:48:29 +00:00
pbos@webrtc.org
2be53a3b00 Disable CanSwitchToUseAllSsrcs on DrMemory. 
Test times out.

R=mflodman@webrtc.org
BUG=3159

Review URL: https://webrtc-codereview.appspot.com/13799004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6566 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-30 15:53:07 +00:00
aluebs@webrtc.org
f4d6d7c27e Add DrMemory suppression for AsyncWriteTest 
BUG=webrtc:3490
R=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/13779004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6553 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-27 13:55:36 +00:00
kjellander@webrtc.org
767d98ebff TSan: Move suppressions to source file. 
Chromium has deprecated text-file based suppressions for
TSan (v2) and is about to remove the support for it in the
test toolchain in https://codereview.chromium.org/357673002/

This CL moves our suppressions to a source file (based on the
Chromium copy).
It also moves the sanitizer_options.gyp into webrtc/build.

BUG=chromium:302040
TEST=Locally executing all the standalone tests under TSan v2.
R=niklas.enbom@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14759004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6552 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-27 09:18:51 +00:00
pbos@webrtc.org
994d0b7229 Refactor Call-based tests. 
Greatly reduces duplication of constants and setup code for tests based
on the new webrtc::Call APIs. It also makes it significantly easier to
convert sender-only to end-to-end tests as they share more code.

BUG=3035
R=kjellander@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17789004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6551 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-27 08:47:52 +00:00
henrike@webrtc.org
1da152d7f6 talk/base and webrtc/base suppression had the same names for their suppressions which is not allowed. Renamed the talk/base ones as they are going away. 
BUG=3379
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/13759004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6532 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-24 14:24:37 +00:00
aluebs@webrtc.org
05f1464df3 Exclude AsyncWriteTest.TestWrite from Win DrMemory Full bot and suppress the reported errors 
BUG=webrtc:3490
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/18569004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6530 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-24 11:08:51 +00:00
kjellander@webrtc.org
a36a259858 TSan v2 deadlock suppressions. 
After rolling chromium_revision in r6516 it seems
TSan v2 turned on deadlock detection by default.
This caused a collection of tests to start failing.
This CL suppresses these failures awaiting further
investigation.

TBR=pbos@webrtc.org
BUG=3509
TEST=Tests passing local execution on Linux using the
reproduction steps in the bug.

Review URL: https://webrtc-codereview.appspot.com/18609004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6519 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-22 08:01:42 +00:00
kjellander@webrtc.org
a97f6f34b2 Exclude flaky libjingle_peerconnection_unittest test for Memcheck. 
The PeerConnectionEndToEndTest.DataChannelIdAssignment test fails
flakily like this:
[----------] 1 test from PeerConnectionEndToEndTest
[ RUN      ] PeerConnectionEndToEndTest.DataChannelIdAssignment
WARNING: no real random source present!
../../talk/app/webrtc/test/peerconnectiontestwrapper.cc:216: Failure
Value of: CheckForConnection()
  Actual: false
Expected: true
[  FAILED  ] PeerConnectionEndToEndTest.DataChannelIdAssignment (13215 ms)
[----------] 1 test from PeerConnectionEndToEndTest (13223 ms total)

TBR=wu@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/20759004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6518 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-22 07:11:44 +00:00
jiayl@webrtc.org
6ce1d58613 Exclude flaky test PeerConnectionEndToEndTest.CreateDataChannelAfterNegotiate on memcheck. 
TBR=wu@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/17739004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6487 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-19 00:06:36 +00:00
jiayl@webrtc.org
85b19a1a12 Exclude SctpDataMediaChannelTest on Win DrMemory for third_party/usrsctp issues. 
TBR=wu@webrtc.org
BUG=3492

Review URL: https://webrtc-codereview.appspot.com/14719004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6485 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-18 23:34:18 +00:00
jiayl@webrtc.org
f8063d34de Properly shut down the SCTP stack. 
TBR phoglund@webrtc.org for the tsan_v2/suppressions.txt change.
R=ldixon@webrtc.org, pthatcher@webrtc.org
TBR=phoglund@webrtc.org
BUG=2749

Review URL: https://webrtc-codereview.appspot.com/12739004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6484 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-18 21:30:40 +00:00
asapersson@webrtc.org
249211eec6 Disable flaky test (WebRtcVideoMediaChannelTest.GetStats) on DrMemory Full. 
BUG=3482
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20649004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6440 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-16 07:56:17 +00:00
jiayl@webrtc.org
1a6c6281ca Revert r6420 'Revert r6390 "Adds end to end DataChannel tests." Flaky on linux_memcheck' 
Failing tests are disabled for memcheck.

TBR=wu@webrtc.org
BUG=2626

Review URL: https://webrtc-codereview.appspot.com/13699004

Review URL: https://webrtc-codereview.appspot.com/13699004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6422 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-12 21:59:29 +00:00
xians@webrtc.org
4cb012858f Fixed GetStats when local and remote track are using the same ssrc. 
R=hta@chromium.org, kjellander@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20589004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6414 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-12 14:57:05 +00:00
pbos@webrtc.org
276637b107 Disable flaky test on DrMemory Full. 
VideoSendStreamTest.RetransmitsNackOverRtxWithPacing fails
often on DrMemory Full.

BUG=3471
R=xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15729004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6409 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-12 08:46:21 +00:00
henrik.lundin@webrtc.org
c578962006 Disable a test in libjingle_peerconnection_unittest for DrMemory 
BUG=3453
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12689004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6334 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-05 07:38:31 +00:00
henrik.lundin@webrtc.org
d3dcebf6b4 Disable P2PTransportChannelMultihomedTest.TestFailover under Memcheck 
BUG=3447
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15689004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6327 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-04 13:23:07 +00:00
henrik.lundin@webrtc.org
2bdd3994e3 Suppress memcheck error in VideoProcessorIntegrationTest 
BUG=3446
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19629005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6323 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-04 08:47:29 +00:00
kjellander@webrtc.org
2f7c7ce020 Remove old perf_expectations no longer used. 
This has been replaced with the Chromium Perf
Dashboard web application a long time ago.

BUG=
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/21569004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6303 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-02 15:03:21 +00:00
andrew@webrtc.org
222d8d3b1f Add a TSAN suppression for a benign TRACE_EVENT race. 
TBR=hclam
BUG=3409

Review URL: https://webrtc-codereview.appspot.com/15639004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6293 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-30 23:14:00 +00:00
pbos@webrtc.org
6e98ef4b35 Fix deadlock in RegisterPreDecodeImageCallback. 
Fixes lock-order inversion between ViEChannel::callback_cs_ and
VideoReceiver::_receiveCritSect detected on DrMemory Full which
exhibited different timing behavior.

Also removes most of the suppressions on DrMemory Full as they're able
to run again without deadlocking.

BUG=3336,3375
TEST=Run DrMemory Full trybots.
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20499004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6228 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-23 09:41:07 +00:00
stefan@webrtc.org
b60bfe4759 Suppress webrtc trace races detected by tsan. 
BUG=3372
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17579004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6226 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-23 07:29:37 +00:00
stefan@webrtc.org
83599cba77 Reenable WebRtcVideoEngineTestFake.SendReceiveBitratesStats under DrMemory. 
The uninitialized read has been fixed. Suppressing CL: https://code.google.com/p/webrtc/source/detail?r=6073

BUG=11288120
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14529005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6199 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-20 13:16:35 +00:00
kjellander@webrtc.org
3147b97f8c LSan suppressions for libjingle tests (fix) 
Apparently wildcards are needed for templates
in the call stack for matching suppressions.

TBR=wu@webrtc.org
BUG=2528, 3345
TEST=None, since I cannot reproduce the leaks on the bot
in my local environment (and we don't have a trybot for this yet).

Review URL: https://webrtc-codereview.appspot.com/18459004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6156 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-14 18:05:15 +00:00
kjellander@webrtc.org
7c0f6e1b47 LSan suppressions for libjingle tests (more) 
Additional suppressions after a new test run was completed
after https://webrtc-codereview.appspot.com/18429006 was
submitted.

TBR=wu@webrtc.org
BUG=2528, 3345
TEST=None, since I cannot reproduce the leaks on the bot
in my local environment (and we don't have a trybot for this yet).

Review URL: https://webrtc-codereview.appspot.com/14509004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6155 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-14 17:46:23 +00:00
kjellander@webrtc.org
a70dff4427 LSan suppressions for libjingle tests. 
Adding a few more suppressions to make the tests pass
LSan as it's about to be enabled in the main waterfall
at the ASan bot.

TBR=wu@webrtc.org
BUG=2528, 3345
TEST=None, since I cannot reproduce the leaks on the bot
in my local environment (and we don't have a trybot for this yet).

Review URL: https://webrtc-codereview.appspot.com/18429006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6153 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-14 17:12:01 +00:00
kjellander@webrtc.org
01edf2e2af Updating LSan third party suppressions. 
Several new third party suppressions have been updated in
Chromium's suppressions file:
https://code.google.com/p/chromium/codesearch#chromium/src/tools/lsan/suppressions.txt
These will solve some of the errors we're seeing at
http://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20LSan%20%28and%20ASan%29/
which needs to be resolved before switching our
ASan bot to recipes (since the recipe ASan configuration
has LSan enabled by default).

BUG=2527,2528,3345,3346
TEST=Successfully ran the following tests under ASan+LSan locally:
libjingle_media_unittest
libjingle_p2p_unittest
libjingle_peerconnection_unittest
libjingle_unittest

R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14489005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6148 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-14 12:28:38 +00:00
henrike@webrtc.org
f048872e91 Adds a modified copy of talk/base to webrtc/base. It is the first step in 
migrating talk/base to webrtc/base.

BUG=N/A
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17479005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-13 18:00:26 +00:00
henrike@webrtc.org
c156174da8 Suppressing all tests for WebRtcVideoEngine2 for Win DrMemory Full. 
BUG=3336
TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20469004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6124 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-13 16:47:32 +00:00
perkj@webrtc.org
e9a604accd Revert 6107 "Adds a modified copy of talk/base to webrtc/base. I..." 
This breaks Chromium FYI builds and prevent roll of webrtc/libjingle to Chrome.

http://chromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win%20Builder/builds/457


> Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
> 
> BUG=N/A
> R=andrew@webrtc.org, wu@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/12199004

TBR=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14479004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6116 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-13 08:15:48 +00:00
henrike@webrtc.org
2c7d1b39b9 Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. 
BUG=N/A
R=andrew@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12199004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6107 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-12 18:03:09 +00:00
henrike@webrtc.org
f3a5e6afc4 Suppression for WebRtcVideoChannel2BaseTest.SetSendSsrc. 
BUG=3336
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15479005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6106 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-12 17:58:21 +00:00
henrike@webrtc.org
d886e4aaf7 Suppression for test failing on dr memory (in waterfall). 
BUG=3336
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15479004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6105 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-12 16:31:21 +00:00
pbos@webrtc.org
d266a2020f Initial wiring of new webrtc API in libjingle. 
BUG=1788
R=pthatcher@google.com, pthatcher@webrtc.org
TBR=juberti@webrtc.org, mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8549005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6104 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-12 14:32:01 +00:00
kjellander@webrtc.org
9e230eae82 DrMemory: Removing suppression as Dr Memory was fixed. 
According to
https://code.google.com/p/webrtc/issues/detail?id=3275
the issue is now fixed in the drmemory.DEPS of r267732.
Since we don't roll this DEPS (it's automatically updated
as it's a separate solution in the checkout for these bots)
we already have this update.

BUG=3275
TEST=Passing trybot: git try --bot=win_drmemory_light
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20429004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6077 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-08 12:24:17 +00:00
henrike@webrtc.org
25a344edc6 WebRtcVideoEngineTestFake.SendReceiveBitratesStats suppressed for "Win DrMemory Full" 
BUG=11288120
R=mikhal@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15439004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6073 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-07 16:41:02 +00:00
jiayl@webrtc.org
4220434d37 Implement the Windows screen capturer using the Magnification API. 
The original ScreenCapturerWin is renamed ScreenCapturerWinGdi.

BUG=2789
TESTED=full desktop cast and single monitor cast works on win7 and win8 desktop mode. Have to use GDI capturer on win8 metro mode. Changing display configuration work on the fly.
R=sergeyu@chromium.org, wez@chromium.org

Committed: https://code.google.com/p/webrtc/source/detail?r=6048

Review URL: https://webrtc-codereview.appspot.com/12149004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6053 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-05 16:08:47 +00:00
pbos@webrtc.org
f5433753b8 Suppress DrMemory allocator mismatch errors. 
Bot is flooded with these errors, suppressing them to get back to a
normal state, contacting DrMemory team.

R=kjellander@webrtc.org
BUG=3275
TEST=git try -b win_drmemory_light -r 6012

Review URL: https://webrtc-codereview.appspot.com/13419004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6013 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-29 12:24:45 +00:00
andrew@webrtc.org
db144429b2 Exclude the new AudioProcessingTest from some sanitizer bots. 
It takes too long.

TBR=kjellander

Review URL: https://webrtc-codereview.appspot.com/12359004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5963 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-23 04:16:24 +00:00
kjellander@webrtc.org
0a035c8924 Disable tests in common_video_unittests for Dr Memory. 
These tests takes about 1000 seconds to execute under
Dr Memory Full, causing them to be killed if taking more
than 1200 seconds.
* TestScaler.BiLinearScaleTest
* TestScaler.BoxScaleTest

BUG=3247
TBR=zhaoqin@google.com

Review URL: https://webrtc-codereview.appspot.com/12289004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5951 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-22 08:07:03 +00:00
kjellander@webrtc.org
940894d207 DrMemory: Excluding failing tests for Dr Memory Full 
PortAllocatorTest.TestEnableSharedSocketWithNat
fails in libjingle_p2p_unittest.
Example:
http://build.chromium.org/p/client.webrtc/builders/Win%20DrMemory%20Full/builds/2/steps/memory%20test%3A%20libjingle_p2p_unittest/logs/stdio
Previous experience tells me that disabling only this test
case will make another one in the same test suite fail,
so I'm blanked disabling the whole test.

TBR=phoglund
BUG=3158

Review URL: https://webrtc-codereview.appspot.com/11909004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5893 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-13 11:45:43 +00:00
kjellander@webrtc.org
ef79fd7965 DrMemory: Excluding failing tests for Dr Memory Full 
BUG=3158
TEST=None
TBR=kjellander,phoglund

Review URL: https://webrtc-codereview.appspot.com/11899004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5892 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-13 08:31:42 +00:00
kjellander@webrtc.org
41e8774113 DrMemory: Excluding failing tests for Dr Memory Full 
The PortTest.TestLocalToTurn of libjingle_p2p_unittest
and DtmfSenderTest.InsertDtmf of libjingle_peerconnection_unittest
failed in the first run on
http://build.chromium.org/p/client.webrtc/builders/Win%20DrMemory%20Full/
However, I cannot reproduce on my machine, so I'm disabling all
test cases of those tests, assuming the others might fail as well.

BUG=3158
TEST=None
TBR=phoglund

Review URL: https://webrtc-codereview.appspot.com/11889004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5891 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-12 19:53:06 +00:00
kjellander@webrtc.org
ffd242432d DrMemory: Suppress and exclude more tests to green up the full build. 
Exclude failing tests in libjingle tests and suppress
failures in modules_unittests.

Also exclude the following extremely slow tests to make it
possible to get a reasonable execution time for the bot:
* TestScaler.PointScaleTest (81573 ms)
* TestScaler.BiLinearScaleTest (1111554 ms)
* TestScaler.BoxScaleTest (1129625 ms)
* TestVp8Impl.BaseUnitTest (762598 ms)
* VideoProcessorIntegrationTest.ProcessNoLossChangeBitRate (342149 ms)

TBR=phoglund@webrtc.org
BUG=3158, 3183, 3184
TEST=Successful runs on local Windows box:
tools\valgrind-webrtc\webrtc_tests.bat --build-dir out --target Debug --test libjingle_p2p_unittest --tool drmemory_full
tools\valgrind-webrtc\webrtc_tests.bat --build-dir out --target Debug --test libjingle_peerconnection_unittest --tool drmemory_full
tools\valgrind-webrtc\webrtc_tests.bat --build-dir out --target Debug --test modules_unittests --tool drmemory_full

Review URL: https://webrtc-codereview.appspot.com/11819004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5888 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-11 14:16:27 +00:00
kjellander@webrtc.org
e8d1865408 Disable more tests for DrMemory to speed up execution. 
Disable a few more tests on Windows when running under
Dr Memory to get the build time down to a reasonable total.

BUG=None
TEST=None
TBR=phoglund

Review URL: https://webrtc-codereview.appspot.com/11299004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5852 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-07 09:00:12 +00:00
kjellander@webrtc.org
9f57404334 Excluding and suppressing Dr Memory test failures. 
With these tests excluded and failures suppressed
we should be able to bring Dr Memory Full into a
green state in
http://build.chromium.org/p/client.webrtc.fyi/waterfall
so we can move the bots into the main waterfall.

BUG=3158, 3159
TEST=Ran successful runs of the tests that never completed
using the reproduction steps in the issues listed above on
a local Windows box. The tests that just failed weren't tried,
since they cannot have been blocking other possibly failing
tests in the same binary.

R=pbos@webrtc.org
TBR=pbos

Review URL: https://webrtc-codereview.appspot.com/11209004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5850 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-07 08:01:06 +00:00
andrew@webrtc.org
b6dfbed1dc Exclude TwoStreamsSendAndFailUnsignalledRecvInOneToOne from TSAN. 
Example failure:
http://build.chromium.org/p/client.webrtc/builders/Linux%20Tsan/builds/1458

TBR=wu@webrtc.org
BUG=2380

Review URL: https://webrtc-codereview.appspot.com/10759004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5796 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-03-26 22:22:46 +00:00
andrew@webrtc.org
b70c8e9dfd Disable flaky WebRtcVideoMediaChannelTests on memcheck and tsan. 
BUG=3096
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10579004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5766 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-03-24 20:57:42 +00:00
kjellander@webrtc.org
08e2dd80a3 Exclude WebRtcVideoMediaChannelTest.AddRemoveCapturerMultipleSources for Valgrind on Mac 
This test seems to crash the bot running memcheck on Mac 10.6 at:
http://build.chromium.org/p/client.webrtc.fyi/builders/Mac%2010.6%20Memcheck
over and over again. I won't file a bug since it's unlikely this
will get fixed as long as Valgrind is not supported on newer OS X
releases.
I mainly wanted to make this bot work better so we can one day start
fixing the leaks it's reporting. One step at the time.

TBR=phoglund
BUG=

Review URL: https://webrtc-codereview.appspot.com/10159005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5719 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-03-18 21:37:28 +00:00
henrike@webrtc.org
26caf0eb53 Suppresses/disables tsan/memcheck issues due to sync of 63111035. 
BUG=3063
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10009004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5706 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-03-14 22:47:07 +00:00
kjellander@webrtc.org
4a47be0f52 Disable CallTest.ReceivesAndRetransmitsNack for TSan 
The test is failing with:
[ RUN      ] CallTest.ReceivesAndRetransmitsNack
../../webrtc/video/call_tests.cc:479: Failure
Value of: observer.Wait()
  Actual: 3
Expected: kEventSignaled
Which is: 1
[  FAILED  ] CallTest.ReceivesAndRetransmitsNack (122871 ms)

Example:
http://build.chromium.org/p/client.webrtc/builders/Linux%20Tsan/builds/1358/steps/memory%20test%3A%20video_engine_tests/logs/stdio

BUG=2908
R=sprang@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9649004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5669 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-03-10 12:50:29 +00:00
mallinath@webrtc.org
d3dc424fe5 Remove posting of ICE messages from WebRTCSession in PeerConnection to signaling thread. 
These callbacks are called from signal thread already. There is no point
in posting messages on the same thread again.

BUG=2922
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9219004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5626 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-03-01 00:05:52 +00:00
henrike@webrtc.org
b898ce9227 Revert of r5622 "disable unit tests" as it should be fixed in r5623. 
BUG=2981
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9269004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5624 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-28 23:18:44 +00:00
henrike@webrtc.org
eec3843596 TSAN only disable of two of libjingle's tests for atomic ops as they are failing for TSAN-bot. 
BUG=2981
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9239005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5622 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-28 18:06:42 +00:00
tina.legrand@webrtc.org
125a66adc2 Memory and Tsan tests: Turn off the new-ACM tests 
In this CL https://webrtc-codereview.appspot.com/8829004/, I splitted the tests so that new-ACM runs in separate tests. Almost all of these tests are too slow for the memory and tsan bots, and were already excluded from them. This CL turns off the new-ACM tests from these bots.

BUG=https://code.google.com/p/webrtc/issues/detail?id=2951
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8999004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5594 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-21 14:12:00 +00:00
mflodman@webrtc.org
e3842897e2 Adding tsan suppression for error introduced in r5555, causing libjingle_unittest to fail on TSan bot. 
BUG=2931
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8779005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5559 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-17 15:09:39 +00:00
stefan@webrtc.org
505f2a0348 Disabling WebRtcSessionTest.TestIceStatesBundle under memcheck. 
BUG=2924
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8699005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5552 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-14 12:38:06 +00:00
kjellander@webrtc.org
9cba2e4802 Exclude libjingle_p2p_unittest tests failing TSan Race verifier. 
These tests have been failing for a long time at
http://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20TsanRV
This bot runs a tool called TSan Race Verifier.
More info about Race Verifiers can be found at
https://code.google.com/p/data-race-test/wiki/RaceVerifier

By excluding the tests like this, they will also be disabled
for the normal TSan bot, where they currently pass. This shouldn't
be a problem since we have a TSan v2 bot running too (which uses
a different set of suppressions), so it should catch any newly
introduced race conditions. The TSan v2 bot will soon replace the
old TSan bot, as v1 is being deprecated.

TBR=mallinath@webrtc.org
BUG=2396
TEST=Passing run on Linux of:
GYP_DEFINES=build_with_tool=tsan gclient runhooks
ninja -C out/Release libjingle_p2p_unittest
tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan_rv -b out/Release -t libjingle_p2p_unittest

Review URL: https://webrtc-codereview.appspot.com/8329005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5515 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-10 12:43:40 +00:00
kjellander@webrtc.org
6f8acdc76f Suppressions for libjingle_unittest after roll in r5502 
New errors arrived when rolling libjingle in r5502.
These suppressions are needed to green up the Memcheck and
TSan bots.

BUG=1976,2080
TEST=local runs on Linux:
tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan -b out/Release -t libjingle_unittest
tools/valgrind-webrtc/webrtc_tests.sh --tool=memcheck -b out/Release -t libjingle_unittest
and trybot:
git try --bot=linux_memcheck,linux_tsan -t libjingle_unittest
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8299004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5509 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-08 21:15:59 +00:00
kjellander@webrtc.org
f7d4993940 Remove Coverity script. 
Chromium has decided to drop Coverity so
we don't have any reason for maintaining this code.

Personally, I think that from a quality perspective other tools,
like all the new compiler warnings that are constantly being added
to the Clang compiler is a better way to address dangers in the code.
The maintenance cost and overhead of such advanced tools like Coverity
is simply too high.

BUG=
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7669007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5500 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-07 13:50:40 +00:00
wu@webrtc.org
98aefcd8fe Update tsan suppressions for libjingle_media_unittest. 
TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/7559005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5428 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-24 18:32:43 +00:00
wu@webrtc.org
ca5ff9972e Re-enable webrtcvoice/videoengine unittests. 
TEST=try bots
BUG=
R=mallinath@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=5387

Review URL: https://webrtc-codereview.appspot.com/7149004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5427 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-24 17:37:46 +00:00
henrike@webrtc.org
7ef7df57d8 Removes script for generating supplement.gypi also adds git ignore for tools/gn. 
BUG=N/A
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7299004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5403 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-21 15:54:56 +00:00
wu@webrtc.org
8f19cb9fbc Revert 5387 "Re-enable webrtcvoice/videoengine unittests." 
Missed the result from the last try bot.

> Re-enable webrtcvoice/videoengine unittests.
> 
> TEST=try bots
> BUG=
> R=mallinath@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/7149004

TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7179004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5388 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-14 22:31:11 +00:00
wu@webrtc.org
eda6823397 Re-enable webrtcvoice/videoengine unittests. 
TEST=try bots
BUG=
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7149004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5387 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-14 22:15:09 +00:00
wjia@webrtc.org
03cfde2d10 Roll Chromium 238260 -> 243863 
R=andrew@webrtc.org, henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6939004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5385 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-14 17:48:34 +00:00
pbos@webrtc.org
1d096901ac Move realtime tests to webrtc_perf_tests. 
New binary not to be run on our VMs as they result in flaky tests. These
will instead be run on baremetal machines.

BUG=2710
R=kjellander@webrtc.org, mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5679004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5283 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-13 12:48:05 +00:00
kjellander@webrtc.org
59d5705385 Fix memory tools error introduced in roll @ r5260 
Turns out that the Chromium revision
https://src.chromium.org/viewvc/chrome?view=rev&revision=237238
introduced a new flag for the memory wrapper scripts.
Due to the way we reuse the chrome_tests.py for WebRTC purposes,
we need to add that flag too.

TEST=linux_tsan bot and locally running:
tools/valgrind-webrtc/webrtc_tests.sh --test test_support_unittests --tool tsan --target Release --build-dir out
from trunk/
BUG=none
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5589006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5262 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-11 14:16:53 +00:00
stefan@webrtc.org
7e9315b42e Adds support for sending redundant payloads over RTX. 
TEST=trybots
BUG=1812
R=mflodman@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/4169004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5209 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-04 10:24:26 +00:00
kjellander@webrtc.org
bd51d9324e LSan suppressions for libjingle_peerconnection_unittest 
Some more leaks have entered the code a while ago so
I'm suppressing them to green up the bot again.

BUG=2528
TEST=Successful execution of the test using the steps described in webrtc:2528.
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/4419004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5177 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-26 09:37:12 +00:00
fbarchard@google.com
b5bc098e20 Clear empty video frames in unittest so DrMemory will allow them to be read without an uninitialized read error. 
BUG=libyuv:263
TESTED=drmemory out\Debug\modules_unittests.exe --gtest_filter=*PreprocessorLogic
R=kjellander@webrtc.org, mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/4319004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5168 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-25 09:06:33 +00:00
wu@webrtc.org
364f204d16 Update talk to 56698267. 
TBR=sergeyu@chromium.org

Review URL: https://webrtc-codereview.appspot.com/4119004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5143 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-20 21:49:41 +00:00
pbos@webrtc.org
9c5fb76662 Exclude AV-sync test from Valgrind platforms. 
Test is performance-dependent and was observed to never sync on the
linux_memcheck bot.

BUG=
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/3999004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5131 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-18 16:22:50 +00:00
stefan@webrtc.org
b082ade3db Hook up audio/video sync to Call. 
Adds an end-to-end audio/video sync test.

BUG=2530, 2608
TEST=trybots
R=henrika@webrtc.org, mflodman@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/3699004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5128 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-18 11:45:11 +00:00
turaj@webrtc.org
55e1723713 Avoid a leak in AudioCodingModuleTest.TestIsac. The leak was caught by LSAN. 
BUG=2515
TEST=reproduced locally on linux and verified the fix resolves the issue.
R=henrik.lundin@webrtc.org, kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2499004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5048 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-29 04:40:09 +00:00
wu@webrtc.org
e4e5683b41 Clean up tsan suppression file: 
1) remove suppressions that are already fixed.
2) merge duplicated suppressions.

TBR=mallinath
TEST=tsan try bot
BUG=1205,2078,2080

Review URL: https://webrtc-codereview.appspot.com/2949004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5033 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-25 16:29:33 +00:00
wu@webrtc.org
d371a29227 Fix tsan failures for libjingle_unittest. 
1) Change AsyncSocket's SignalReadEvent and SignalWriteEvent's thread mode to multi_threaded_local as they can be accessed from different threads.
2) Protect NATServer::TransEntry::whitelist.
3) Protect PhysicalSocket:error_.

Detail failures can be seen from issue 2080, comment #5.

TBR=fischman@webrtc.org

RISK=P1
TEST=try bots and tsanv2
BUG=2080

Review URL: https://webrtc-codereview.appspot.com/2669005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5026 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-23 23:56:09 +00:00
wu@webrtc.org
8804a29951 Add CriticalSection to fakeaudiocapturemodule to protect the variables which will be accessed from process_thread_ and the main thread. 
TEST=try bots
BUG=1205
R=henrike@webrtc.org, kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2419004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5019 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-22 23:09:20 +00:00
wu@webrtc.org
4d7116be7a Fix tsan failures on filevideocapturer.cc. 
1) init start_time_ns_ before the file_read_thread_ is started to avoid data racing as the start_time_ns_ will also be read by the file_read_thread_.
2) add CriticalSection to protect |finished_| that is accessed by FileReadThread and the main thread

Also remove the suppression for filemediaengine.cc, which has already been fixed in other cl.

TBR=henrike@webrtc.org
TEST=try bots and manual tsan v2 test
BUG=2078

Review URL: https://webrtc-codereview.appspot.com/2509004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5018 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-22 18:41:17 +00:00
mallinath@webrtc.org
50bc553852 Reenable DTLS renegotiation unittest in libjingle. 
This test is failing on memcheck bots. After investigation problem per
say is not in this particular unittest and rather is in suite. So this test
is added to memcheck exclude list.

R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2689004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5011 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-21 17:58:35 +00:00
wu@webrtc.org
3c5d2b43ec Thread::Stop() must be called before any subclass's destructor completes. 
Update Thread documentation, fix all subclasses that had a problem.

This is to avoid a data racing between the destructor modifying the vtable, and
Thread::PreRun calling virtual method Run at the same time.

For example:
[ RUN      ] FileMediaEngineTest.TestGetCapabilities
==================
WARNING: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call) (pid=2967)
  Read of size 8 at 0x7d480000bd00 by thread T1:
    #0 talk_base::Thread::PreRun(void*) /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/base/thread.cc:353 (libjingle_media_unittest+0x000000234da8)

  Previous write of size 8 at 0x7d480000bd00 by main thread:
    #0 talk_base::Thread::~Thread() /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/base/thread.cc:158 (libjingle_media_unittest+0x00000023478c)
    #1 ~RtpSenderReceiver /mnt/data/b/build/slave/Linux_Tsan_v2/build/src/out/Release/../../talk/media/base/filemediaengine.cc:122 (libjingle_media_unittest+0x0000001b551f)
    ...

RISK=P2
TESTED=try bots and tsan
BUG=2078,2080
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2428004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4999 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-18 16:27:26 +00:00
kjellander@webrtc.org
6b426ba5c5 Final round of LSan suppressions (take 2) 
Turns out I was running libjingle_unittest
instead of libjingle_peerconnection_unittest
on the bot machine when I was verifying the
suppressions added in r4991 on the bot.
This will hopefully be the last round.

BUG=2528
TEST=running libjingle_unittest with these
suppressions applied locally on the bot.
TBR=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2426004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4993 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-17 19:26:27 +00:00
wu@webrtc.org
6342066974 Fix tsan failures in channel.cc regarding to the volume settings. 
BUG=2461
TEST=try bots
R=xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2377004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4992 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-17 18:28:55 +00:00
kjellander@webrtc.org
b22049b295 Final round of LSan suppressions. 
Since we don't have a trybot for LSan, this is the only
way to resolve errors only happening on the bots
(except running at the bot themselves).

I suspect some errors only occurs on the bots since
the compiler version differs (4.6 on bots, 4.6.3 on
my machine).

This last suppressions round was tested on an actual
Chrome infra VM as well, with no errors.

BUG=2528
TEST=ran successfully on the bot.
TBR=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2424004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4991 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-17 18:13:28 +00:00
kjellander@webrtc.org
8a7b89fd41 More libjingle LSan suppressions. 
The suppressions in r4988 were not enough to green
up the LSan+ASan bot.
Here's another round of suppressions to get the bot green
which I have tested multiple runs without any leaks reported.

BUG=2527,2528
TEST=
GYP_DEFINES='asan=1 lsan=1 linux_use_tcmalloc=0 release_extra_cflags="-gline-tables-only"' gclient runhooks
ninja -C out/Release libjingle_unittest
export ASAN_SYMBOLIZER_PATH=`(pwd)`/third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer
export ASAN_OPTIONS="detect_leaks=1 strict_memcmp=0"
export LSAN_OPTIONS="suppressions=tools/lsan/suppressions.txt"
out/Release/libjingle_peerconnection_unittest
out/Release/libjingle_unittest
TBR=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2422004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4990 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-17 17:15:24 +00:00
kjellander@webrtc.org
e61da8c391 Suppressions and PRESUBMIT.py for LSan 
The Leak Sanitizer will replace Valgrind
memcheck when it's related tool Memory Sanitizer is ready.
We should get our tests in shape so we can detect
new leaks, which is why I'm adding these suppressions.

More info at http://www.chromium.org/developers/testing/leaksanitizer
Buildbot at http://build.chromium.org/p/client.webrtc.fyi/waterfall

BUG=2515,2527,2528
TEST=Ran tests with the parameters described in webrtc:2527.
TBR=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2421004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4988 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-17 14:16:17 +00:00
sprang@webrtc.org
603ed98bca Suppress race condition warn in CallTest_ReceivesAndRetransmitsNack_Test 
This test is the one most commonly triggering a race condition in the
event tracing macros. Pending a permanent fix in tracing code,
suppressing tsan warnings for this test.

BUG=2497
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2408004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4986 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-17 07:49:26 +00:00
wu@webrtc.org
54e729bb73 Remove tsan suppression for the failure that's already fixed. 
TEST=try bot
TBR=mallinath
BUG=1205,2079,2080

Review URL: https://webrtc-codereview.appspot.com/2408005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4985 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-16 23:19:54 +00:00
wu@webrtc.org
853dd07890 Add issue links to the tsanv2 suppressions. 
BUG=2521,2484

TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2418004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4984 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-16 22:50:59 +00:00
kjellander@webrtc.org
83e9c89eeb Exclude more tests for TSan on Windows. 
Apparently more tests were also too slow for the bot
(but ran fine on my own machine). Adding a bunch now
so it should run fine from now on.

TEST=none
BUG=none
TBR=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2412004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4978 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-16 17:32:05 +00:00
kjellander@webrtc.org
d1cfa7149e TSan v2 suppressions and exclusions for libjingle tests. 
Add suppressions for libjingle tests so they pass under TSan v2.
Disable the following tests for TSan v2 (only) since they're failing:
* StunServerTest.TestGood
* JsepPeerConnectionP2PTestClient.*

See build logs at:
http://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20Tsan%20v2/
for more details.

BUG=1205,2078,2079,2080,2517
TEST=Ran a successful run of each test locally on Linux using:
GYP_DEFINES='tsan=1 linux_use_tcmalloc=0 release_extra_cflags="-gline-tables-only"' gclient runhooks
ninja -C out/Release
For each test, run standing in trunk/:
TSAN_OPTIONS="suppressions=tools/valgrind-webrtc/tsan_v2/suppressions.txt print_suppressions=1 report_signal_unsafe=0 report_thread_leaks=0 history_size=7" out/Release/[libjingle_testname]
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2411004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4977 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-16 16:51:52 +00:00
pbos@webrtc.org
9401524211 Run FullStack tests without render windows. 
Also disables test on valgrind platforms, it has no chance to keep up.

BUG=2278
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2159008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4972 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-16 11:05:37 +00:00
kjellander@webrtc.org
662b1c59c1 Add suppressions for DrMemory and TSan on Windows. 
BUG=2515,2516
TEST=locally running the test as described in the bug.
The TSan excluded test was verified to be the only remaining
test that is too slow for TSan on Windows.

R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2405004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4970 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-16 10:46:37 +00:00
kjellander@webrtc.org
fc89ba580b Fix build dir flag in webrtc_test.py as passed by runtests.py 
It seems we were hit by the changes in
https://codereview.chromium.org/26184003/
in how we roll with our own wrapper script for the
memory tools.
The build dir flag was changed from --build_dir to
--build-dir, which caused our script to break.

BUG=none
TEST=verified the exact command line executed by the bot succeeds
in my local checkout
TBR=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2394005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4959 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-14 18:05:52 +00:00
kjellander@webrtc.org
09418c3320 Add support for --target flag to webrtc_tests.py. 
In https://codereview.chromium.org/26190002 Chromium
started a cleanup of their wrapper script, by adding
the --target flag and start passing build dir similar
to how the bots are setting it (i.e. pass out and not
out/Release).
This CL adds --target support for our wrapper script,
without changing the existing behavior (I'll do a
larger update at a later stage).

BUG=none
TEST=Ran the following successfully:
tools/valgrind-webrtc/webrtc_tests.sh --build_dir out/Release --target Release --test test_support_unittests
tools/valgrind-webrtc/webrtc_tests.sh --build_dir out --target Release --test test_support_unittests
tools/valgrind-webrtc/webrtc_tests.sh --target Release --test  out/Release/test_support_unittests
TBR=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2396004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4957 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-14 17:34:38 +00:00