Fixed broken build.
Nit fix.
Fixed style issues.
Removed accidental comment-out.
Removed test that no longer makes sense.
Rewrote hardware-before-init and rtp-rtcp-before-streaming test code to gtest.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/320009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1162 4adac7df-926f-26a2-2b94-8c16560cd09d
- vfprintf can be used directly here, removing the need for the interim
buffer. This change allows us to remove the artificial character limit.
- Fix bugs with _text. It wasn't actually getting set earlier, and the
check was wrong.
- Remove asserts that should use real error checks.
TEST=DataLog and VoECallReport (through voe_auto_test), the only users of WriteText().
Review URL: http://webrtc-codereview.appspot.com/323001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1156 4adac7df-926f-26a2-2b94-8c16560cd09d
libjingle depends on ConvertFromI420. This was previously available
through vplib. libjingle still has access to the vplib header, but the
implementation is no longer built.
Fortunately, the libyuv wrapper can supply the implementation, if we
hack the signature to return to the unsigned int types. We'll remove
this once libjingle has been updated to use libyuv directly.
Also, roll libyuv to r100 which fixes a gyp warning on Windows.
TEST=build
Review URL: http://webrtc-codereview.appspot.com/323004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1151 4adac7df-926f-26a2-2b94-8c16560cd09d
Only style changes, ointers/references and functions will come in a later CL.
vie_capturer.cc and vie_file_player.cc are only changed du to inheriting protected members from ViEFrameProviderBase.
Review URL: http://webrtc-codereview.appspot.com/324001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1148 4adac7df-926f-26a2-2b94-8c16560cd09d
General Notes:
1. In general, API structure was not modified and is based on VPLIB.
2. Modification to API: Return values are based on libyuv, i.e. 0 if ok, a negative value in case of an error (instead of length).
3. All scaling (inteprolation) is now done via the scale interface. Crop/Pad is not being used.
4. VPLIB was completely removed. All tests are now part of the libyuv unit test (significantly more comprehensive and based on gtest).
5. JPEG is yet to be implemented in LibYuv and therefore existing implementation remains.
Review URL: http://webrtc-codereview.appspot.com/258001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1140 4adac7df-926f-26a2-2b94-8c16560cd09d
Started extracting methods out of the main test, which will hopefully make us able to make the tests independent.
Merge branch 'master' into voe_split_methods
Conflicts:
src/voice_engine/main/test/auto_test/voe_extended_test.cc
src/voice_engine/main/test/auto_test/voe_extended_test.h
src/voice_engine/main/test/auto_test/voe_standard_test.cc
src/voice_engine/main/test/auto_test/voe_standard_test.h
Extracted methods out of the standard test.
Added space before inheritance colons.
Rolled back some header file changes.
Fixed long lines.
Fixed long lines.
Fixed indentation. There is nothing but whitespace changes here, except for removing some extraneous semicolons in .h files and fixing a spelling error in a comment.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/313001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1131 4adac7df-926f-26a2-2b94-8c16560cd09d
Fixed unit tests so they don't use ASSERT_DEATH since that doesn't work with Valgrind.
Fixed all Valgrind warnings except the one caused by CriticalSectionWrapper in system_wrappers.
Reworked all includes and GYP include paths to use full directory paths.
Removed util.h for logging, since it rendered warnings in Valgrind because of gflags. Replaced it with a verbose flag and a new function in video_quality_measurement.cc
BUG=
TEST=Passed test_support_unittests and video_codecs_test_framework_unittests on Linux, Mac and Windows.
Review URL: http://webrtc-codereview.appspot.com/311001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1126 4adac7df-926f-26a2-2b94-8c16560cd09d
With some compiler settings, a warning was issued for NetEQ,
saying that pw16_randVec was accessed out of bounds.
This did never happen in practice, but this change makes the
compiler understand this.
Review URL: http://webrtc-codereview.appspot.com/309001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1121 4adac7df-926f-26a2-2b94-8c16560cd09d
A set of the packet masks (up 10x10 size) are modified for the following reasons:
1) have more even column and row degree (number of 1 bits), when possible.
2) if cases where the column degree cannot be constant across source packets, placed the extra 1 bit in the first packet column (so little more protection on 1st partition), as opposed to having some ~middle source packet have the extra bit.
3) in some cases, made the mask a little more sparse/reduced the overlap.
Overall the average recovery is a little better with these masks.
Mask sizes above 10 will be updated in future changelist.
Review URL: http://webrtc-codereview.appspot.com/305001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1113 4adac7df-926f-26a2-2b94-8c16560cd09d
