Commit Graph

1471 Commits

Author SHA1 Message Date
phoglund@webrtc.org
c4c56ed20b Rewrote vie_auto_test to use googletest macros.
Removed error counting entirely - that's completely managed by googletest now, except for custom call, loopback and simulcast call.

Rewrote remaining tests to use GTest asserts.

Rewrote more tests to use GTest macros. The External Codec module is now in the build by default.

Merge branch 'master' into macro_improvements

Rewrote some more code to use GTest asserts.

The manual standard tests now also go through gtest.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/287002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1004 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-23 15:23:11 +00:00
kjellander@webrtc.org
0c80c7fec8 Script for automatic download of resources.
Tested successfully on Linux, Mac and Windows (Python 2.6)

The script works executing from different working directories too (like project root vs. location of script).

Review URL: http://webrtc-codereview.appspot.com/280002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1003 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-23 14:11:16 +00:00
bjornv@webrtc.org
48b68c0c24 Added support for 96 kHz sampling frequency.
Updated resampler_unittests with the new valid combinations.
Verified audio quality on files.

TEST=resampler_unittests, voe_auto_test
BUILDTYPE=Debug, Release
PLATFORM=Linux
Review URL: http://webrtc-codereview.appspot.com/294001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1002 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-23 13:50:41 +00:00
henrik.lundin@webrtc.org
4257790d2d NetEQ-related bug in ACM
Fixing a bug when creating new NetEQ slave instances in ACM.
The old code called WebRtcNetEQ_GetCurrentDelay() for the
master instance to get a delay value for WebRtcNetEQ_SetExtraDelay().
This is wrong, since WebRtcNetEQ_GetCurrentDelay() reports on the
current total buffer length, while WebRtcNetEQ_SetExtraDelay() is
the extra delay that is desired to in order to sync with video.

The fix includes keeping the extra delay value in a member variable
in the ACMNetEQ class.

Review URL: http://webrtc-codereview.appspot.com/295001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1001 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-23 13:04:05 +00:00
kjellander@webrtc.org
543c3eaa46 Fixing Release compilation errors
Review URL: http://webrtc-codereview.appspot.com/267026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1000 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-23 12:20:35 +00:00
henrik.lundin@webrtc.org
89ab652250 Cleaning up NetEQ statistics
Removed struct MCUStats_t and all references to it.
Removed totalDiscardedPackets and totalFlushedPackets
from the PacketBuf_t struct.

Review URL: http://webrtc-codereview.appspot.com/293001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@999 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-23 11:06:05 +00:00
henrik.lundin@webrtc.org
df10de4b27 Removing statistics API from NetEQ
Removing WebRtcNetEQ_GetJitterStatistics(),
WebRtcNetEQ_ResetJitterStatistics(), and the associated
struct WebRtcNetEQ_JitterStatistics. The change ripples
through all the way to the VoiceEngine API.

Review URL: http://webrtc-codereview.appspot.com/285002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@998 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-23 09:36:23 +00:00
braveyao@webrtc.org
7d3e9498bc This CL is to support certain audio devices which don't offer volume control. Try to be more compatible to those rare cases.
Review URL: http://webrtc-codereview.appspot.com/276011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@997 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-23 03:35:42 +00:00
mikhal@webrtc.org
2b838b4121 video_coding: updating the session info unit test following recent changes
Review URL: http://webrtc-codereview.appspot.com/290002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@996 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-23 00:20:19 +00:00
mikhal@webrtc.org
425b377973 video_coding: Updating internal_defines to resolve latest build error. Refers to JB flush update.
Review URL: http://webrtc-codereview.appspot.com/289001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@995 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-22 23:41:29 +00:00
mikhal@webrtc.org
f13388f134 video_coding: Requesting a key frame after a JB flush
Review URL: http://webrtc-codereview.appspot.com/280006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@994 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-22 22:57:51 +00:00
mikhal@webrtc.org
6b9a7f8704 video_coding: Allowing for a decodable state independent of selective nacking
Review URL: http://webrtc-codereview.appspot.com/263001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@993 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-22 22:48:20 +00:00
andrew@webrtc.org
828af1b4b9 Add lookahead to the delay estimator.
TEST=audioproc_unittest

Review URL: http://webrtc-codereview.appspot.com/279014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@992 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-22 22:40:27 +00:00
andrew@webrtc.org
5a529395aa Make DMO init safe when not supported.
BUG=issue133
TEST=voe_auto_test

Review URL: http://webrtc-codereview.appspot.com/284001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@990 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-22 18:04:26 +00:00
henrikg@webrtc.org
91617ff948 Review URL: http://webrtc-codereview.appspot.com/269019
git-svn-id: http://webrtc.googlecode.com/svn/trunk@989 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-22 14:34:44 +00:00
mflodman@webrtc.org
dfe89e337e Move ViE main/test/AutoTest to test/auto_test.
Only paths in gyp and mk files are changed, source files are only moved.

Review URL: http://webrtc-codereview.appspot.com/267027

git-svn-id: http://webrtc.googlecode.com/svn/trunk@988 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-22 14:03:15 +00:00
andrew@webrtc.org
8594f7688b Add a gyp variable for AEC debug dumps.
TEST=process_test.cc

Review URL: http://webrtc-codereview.appspot.com/276012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@987 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-22 00:51:41 +00:00
kma@webrtc.org
a249f35203 Correct several makefile errors for Android build.
Review URL: http://webrtc-codereview.appspot.com/267024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@986 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-21 22:16:10 +00:00
mflodman@webrtc.org
6830bdd929 Fix xcode build.
Review URL: http://webrtc-codereview.appspot.com/280007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@985 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-21 15:53:15 +00:00
mflodman@webrtc.org
94ea32ef60 Move video_engine/source* to video_engine/. No code changes except paths in gyp-files.
Review URL: http://webrtc-codereview.appspot.com/283002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@984 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-21 14:49:31 +00:00
kjellander@webrtc.org
274c2efbc1 Adding empty test method required to get code coverage
Review URL: http://webrtc-codereview.appspot.com/279008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@983 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-21 09:36:28 +00:00
marpan@webrtc.org
3caa327af0 VP8 wrapper: Turn on some mild amount of deblocking in post-processing.
Review URL: http://webrtc-codereview.appspot.com/268015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@982 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-19 01:08:09 +00:00
henrike@webrtc.org
ce9d89d892 Fixes linux build error introduced in r980.
Review URL: http://webrtc-codereview.appspot.com/279012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@981 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-19 00:14:37 +00:00
henrike@webrtc.org
ad98a3eed0 Fixes TEST crash triggered by webrtc-codereview.appspot.com/268014.
Review URL: http://webrtc-codereview.appspot.com/280005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@980 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-18 23:55:12 +00:00
henrike@webrtc.org
31d30700d6 Addressed review comments from http://webrtc-codereview.appspot.com/256004/
Review URL: http://webrtc-codereview.appspot.com/256007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@979 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-18 19:59:32 +00:00
kma@webrtc.org
ced118636d Changed keyword __restrict__ to __restrict.
Review URL: http://webrtc-codereview.appspot.com/279011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@978 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-18 17:51:19 +00:00
henrike@webrtc.org
3798ecb25b Made CPU initialization on Windows lazy to prevent long startup time.
Review URL: http://webrtc-codereview.appspot.com/268014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@977 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-18 16:25:54 +00:00
kjellander@webrtc.org
543611a77a Reverting r972 due to compilation error on Windows Release build.
TBR=kma
Review URL: http://webrtc-codereview.appspot.com/282003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@976 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-18 13:25:13 +00:00
bjornv@webrtc.org
2f047ccede Removed unnecessary variable to avoid compiler error on Win.
Review URL: http://webrtc-codereview.appspot.com/267021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@975 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-18 12:03:25 +00:00
henrik.lundin@webrtc.org
ba74924043 Remove use of exceptions in NetEQ test code
Replaced the exceptions thrown when codec instance creation failed
with simple exit(EXIT_FAILURE). There is no point in continuing
if creating the codec fails.

Review URL: http://webrtc-codereview.appspot.com/282002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@974 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-18 09:55:01 +00:00
bjornv@webrtc.org
6a9835d59c Delay estimator structural changes.
Improved the way we handle different data types (float vs fixed) and reduced the complexity by nearly 50%.
We now have a generic struct for both float and fixed delay estimators and a core struct for the binary spectrum based delay estimator. All wrapper codes (for both fixed and float) are gathered in delay_estimator_wrappers.*.
Moved out the far end history buffer to AEC(M).
Added a union to handle difference types when create.
Review URL: http://webrtc-codereview.appspot.com/277004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@973 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-18 08:30:34 +00:00
kma@webrtc.org
fa9b016fb5 Optimized WebRtcIsacfix_AutocorrFix() function for iSAC fix.
(1) For generic platforms, code was changed to remove the shifting within loops.
Basically, it's just change a loop from
  for() {
    sum += (a*b) >> scale;
  }
to:
  for() {
    sum += (a*b);
  }
  sum >> scale;

Type int64_t is used for sum to make sure no information is not lost.
Performance is about the same as before the change. Bits are not exact,
although in theory the change should have preserved more information. The purpose
of this change is to make the generic code and ARM code bit exact, simpify the code,
while keep the speech quality at least not lower. (Some speech tests might be good.)

(2) For ARM platform, used assembly to optimize the performance. iSAC runs faster
with this change. (Reduced run time of an offline file test from 10.16ms to 8.81ms)
Review URL: http://webrtc-codereview.appspot.com/267014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@972 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-18 02:50:55 +00:00
braveyao@webrtc.org
f556b9d1f4 This modification is supposed to fix the webrtc issue 144/145. With this fix, people could set/get mic volume before StartSend().
Review URL: http://webrtc-codereview.appspot.com/277007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@971 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-18 02:17:28 +00:00
mikhal@webrtc.org
3041c62a56 Updating libvpx to revision bdd35c13: This revision includes a fix for frame rate adaptation - avoid resetting the frame rate to 30 on each update.
Review URL: http://webrtc-codereview.appspot.com/279009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@970 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-18 00:29:26 +00:00
amyfong@webrtc.org
917fa6b923 ViE Custom Call added SetImageScaleStatus toggle option and other changes.
1. added SetImageScaleStatus for testing purposes
2. added getting the codec information from the incoming/outgoing stream of a videochannel to print call information
3. fixed problem with toggling the one of the observers
4. did more clean up of the code style (mostly spacing)
5. renamed the GetVideo* functions properly to SetVideo* to reflect what the function does

Currently only tested on mac.  Need to test on win7 & linux before final commit.
Review URL: http://webrtc-codereview.appspot.com/267017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@969 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 21:29:39 +00:00
kjellander@webrtc.org
cd7b57ef9e Fixing release compilation error
Review URL: http://webrtc-codereview.appspot.com/279007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@968 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 14:26:21 +00:00
kjellander@webrtc.org
3f1cb8e546 Restructuring and adding dummy unit test target.
Empty test added to get code coverage recorded.

Review URL: http://webrtc-codereview.appspot.com/269018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@967 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 13:56:54 +00:00
kjellander@webrtc.org
cc2ecb3c2e Restructuring and adding dummy unit test target.
Empty test added to get code coverage recorded.

Review URL: http://webrtc-codereview.appspot.com/267019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@966 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 13:48:36 +00:00
kjellander@webrtc.org
b72268e147 Restructuring and adding dummy unit test target.
Empty test added to get code coverage recorded.

Review URL: http://webrtc-codereview.appspot.com/280004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@965 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 13:39:15 +00:00
kjellander@webrtc.org
64a897a772 Restructuring and adding dummy unit test target.
Empty test added to get code coverage recorded.

Review URL: http://webrtc-codereview.appspot.com/282001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@964 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 13:33:11 +00:00
kjellander@webrtc.org
1310e0b092 Adding third_party/cygwin to git ignore
Review URL: http://webrtc-codereview.appspot.com/280003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@963 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 11:35:59 +00:00
phoglund@webrtc.org
8f89f09626 Note: this patch may seem intimidating but it mostly moves code around and renames things. There are quite few actual changes.
Separated new-style tests from old-style tests. Abstracted code for reuse.

Fully separated the new automated tests from the old-style tests. We now have old-style tests running in manual mode, old-style tests running in automated mode and new-style tests that uses input files and make actual video comparisons.

Introduced a small "library" of helper functions in order to move a lot
of stuff out of the original base and codec tests, which have been made
dependent on the new "library" (which is a header file and a source
file). The new-style tests also depends on this "library".
The comparison test flags are now required only when the comparison tests actually runs.

Separated comparison tests into its own test since it seems we will be running classic vie_auto_test using a fake video driver on Linux.

Made tbInterfaces follow Google conventions.
Merge branch 'render_to_file' into vivi_driver

Resolution alignment testing is now optional behind a flag.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/269011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@962 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 10:46:59 +00:00
kjellander@webrtc.org
c05b56a38b Fixing compilation error
Review URL: http://webrtc-codereview.appspot.com/276010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@961 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 08:59:48 +00:00
perkj@webrtc.org
9f9af7df7b Remove Peerconnection Dev branch.
BUG= Issue 139:	libjingle gyp warning on Windows
TEST=

Review URL: http://webrtc-codereview.appspot.com/281001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@960 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 08:42:33 +00:00
kjellander@webrtc.org
0403ef419f Restructuring and adding unit test targets on project level instead of in common_audio.
Review URL: http://webrtc-codereview.appspot.com/280001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@959 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 08:35:47 +00:00
andrew@webrtc.org
7eba346d30 Remove module targets due to Linux-Release errors.
TBR=phoglund

Review URL: http://webrtc-codereview.appspot.com/277006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@958 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-16 19:03:38 +00:00
phoglund@webrtc.org
337dc68992 Included modules in webrtc.gyp and fixed build errors.
Removed TODO from webrtc.gyp since it is done.

Tabs -> spaces.

Tabs -> spaces.

Tabs -> spaces.

Fixed compilation on Windows.

Added missing file.

Merge branch 'master' into fix_mac_modules

Fixed compilation errors for the modules.gyp on Mac. This included some pretty large refactorings.

 Please enter the commit message for your changes. Lines starting

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/269005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@957 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-16 15:36:44 +00:00
niklas.enbom@webrtc.org
af26f64616 Inband DTMF stereo support
Review URL: http://webrtc-codereview.appspot.com/267011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@956 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-16 12:41:36 +00:00
niklas.enbom@webrtc.org
e33a102eee Resubmitting http://webrtc-codereview.appspot.com/269007/
Review URL: http://webrtc-codereview.appspot.com/268012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@955 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-16 10:33:53 +00:00
stefan@webrtc.org
fcf33eb7e0 Limit number of send-side BWE increases to one per second.
Also report 0 losses if not enough expected packets since
previous receiver report.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/270009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@954 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-16 07:58:31 +00:00