Commit Graph

187 Commits

Author SHA1 Message Date
jiayl@webrtc.org
14d80793a8 PeerConnectionClient needs to initialize SSL.
BUG=2911
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8499004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5531 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-12 00:41:59 +00:00
wjia@webrtc.org
dd82fa726c Revert 5516 "Thread annotation of talk_base::CriticalSection."
r5516 failed compilation on builds with enable_webrtc=0.

> Thread annotation of talk_base::CriticalSection.
> 
> Also enabling -Wthread-safety in talk/build/common.gypi for clang on
> Linux. Thread annotations are compile-time checks that for instance
> certain locks are held before accessing a value.
> 
> BUG=
> TEST=Local GUARDED_BY() annotations.
> R=andresp@webrtc.org, fischman@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/8189004

TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8409004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5523 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-10 23:20:15 +00:00
fischman@webrtc.org
82387e4608 Add ability to receive calls for iOS
BUG=2701
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7989005

Patch from Sajid Hussain <shussain@temasys.com.sg>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5518 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-10 18:47:11 +00:00
pbos@webrtc.org
0a7085ffc2 Thread annotation of talk_base::CriticalSection.
Also enabling -Wthread-safety in talk/build/common.gypi for clang on
Linux. Thread annotations are compile-time checks that for instance
certain locks are held before accessing a value.

BUG=
TEST=Local GUARDED_BY() annotations.
R=andresp@webrtc.org, fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8189004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5516 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-10 13:58:37 +00:00
kjellander@webrtc.org
4723dc88b3 Revert 5511 "Revert 5510 "Disable failing libjingle_p2p_unittest..."
So, the test apparently failed right away at 

http://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/1224/steps/libjingle_p2p_unittest/logs/stdio


> Revert 5510 "Disable failing libjingle_p2p_unittest test on Linux"
> 
> According to https://code.google.com/p/webrtc/issues/detail?id=2907#c2
> r5505 was committed to resolve exactly these flakes.
> Let's revert the disabling and see.
> 
> BUG=2907
> TBR=mallinath@webrtc.org
> 
> > Disable failing libjingle_p2p_unittest test on Linux
> > 
> > I realize this diables 84 test cases and for all platforms, which
> > I'm not really comfortable with. I tried finding a better way but
> > couldn't without doing significant changes to the file.
> > I think the tests either needs to be fixed or otherwise refactored
> > in order to make more fine-grained disabling possible.
> > 
> > Another (too) large disabling was done by holmer@ in
> > https://webrtc-codereview.appspot.com/2227004 where he should only have
> > disabled them on Windows, if the failures in webrtc:2383 was all that
> > caused those flakes.
> > 
> > BUG=2907
> > TEST=Verified this ran 0 tests:
> > out/Release/libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest.TestNAT_ADDR_RESTRICTEDToNAT_PORT_RESTRICTEDAsGiceBothSharedUfragWithMinimumStepDelay
> > TBR=wu@webrtc.org
> > 
> > Review URL: https://webrtc-codereview.appspot.com/8309004
> 
> TBR=kjellander@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/8329004

TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8339004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5513 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-09 18:48:56 +00:00
kjellander@webrtc.org
607c805b87 Roll chromium_revision 245382:249215
The find_depot_tools.py is needed to workaround the import
error we get from gyp_chromium when importing it in
webrtc/build/gyp_webrtc (to avoid code duplication).
gyp_chromium introduced a dependency on it in
http://crrev.com/245412 but as we cannot sync all of Chrome's
src/tools (it's quite big), we'll work around this by
adding an empty find_depot_tools module.

The removal of the Cygwin relates to
http://crrev.com/248802 which is a step on the way to remove
Cygwin in Chromium. We seem to already be able to remove it
entirely for WebRTC though.

Changes in the isolate framework required us to update our
copies of the isolate.gypi files.

BUG=none
TEST=trybots passing on all platforms
R=andrew@webrtc.org, fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8099004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5512 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-09 18:38:31 +00:00
kjellander@webrtc.org
ce2b44532e Revert 5510 "Disable failing libjingle_p2p_unittest test on Linux"
According to https://code.google.com/p/webrtc/issues/detail?id=2907#c2
r5505 was committed to resolve exactly these flakes.
Let's revert the disabling and see.

BUG=2907
TBR=mallinath@webrtc.org

> Disable failing libjingle_p2p_unittest test on Linux
> 
> I realize this diables 84 test cases and for all platforms, which
> I'm not really comfortable with. I tried finding a better way but
> couldn't without doing significant changes to the file.
> I think the tests either needs to be fixed or otherwise refactored
> in order to make more fine-grained disabling possible.
> 
> Another (too) large disabling was done by holmer@ in
> https://webrtc-codereview.appspot.com/2227004 where he should only have
> disabled them on Windows, if the failures in webrtc:2383 was all that
> caused those flakes.
> 
> BUG=2907
> TEST=Verified this ran 0 tests:
> out/Release/libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest.TestNAT_ADDR_RESTRICTEDToNAT_PORT_RESTRICTEDAsGiceBothSharedUfragWithMinimumStepDelay
> TBR=wu@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/8309004

TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8329004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5511 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-09 18:21:00 +00:00
kjellander@webrtc.org
8d2ddd00f1 Disable failing libjingle_p2p_unittest test on Linux
I realize this diables 84 test cases and for all platforms, which
I'm not really comfortable with. I tried finding a better way but
couldn't without doing significant changes to the file.
I think the tests either needs to be fixed or otherwise refactored
in order to make more fine-grained disabling possible.

Another (too) large disabling was done by holmer@ in
https://webrtc-codereview.appspot.com/2227004 where he should only have
disabled them on Windows, if the failures in webrtc:2383 was all that
caused those flakes.

BUG=2907
TEST=Verified this ran 0 tests:
out/Release/libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest.TestNAT_ADDR_RESTRICTEDToNAT_PORT_RESTRICTEDAsGiceBothSharedUfragWithMinimumStepDelay
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8309004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5510 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-08 21:35:20 +00:00
sergeyu@chromium.org
cc685acbdf Disable AsyncInvokeTest.CancelInvoker test
Test is flaky.

BUG=b/12944358
TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8289004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5508 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-08 19:59:00 +00:00
sergeyu@chromium.org
0178810659 Don't use LOG() in callback.h
Because chromium is compiled with a different version of logging macros
defined in logging.h that header cannot be used in headers that can
also included from chromium code. Removed LOG_F(LS_WARNING) from
callback.h . That issue would block this code from being rolled in
chromium.

R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8279004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5507 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-08 03:18:03 +00:00
mallinath@webrtc.org
5a59ccbb6d Switching to NSS random number generator and adding init method to unittests.
R=jiayl@webrtc.org, sergeuy@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8259004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5505 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-07 23:22:00 +00:00
sergeyu@chromium.org
9cf037b831 Update libjingle to 61168196
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8139004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5502 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-07 19:03:26 +00:00
pbos@webrtc.org
ea1c5ad58f Fix gunit compilation on VS2012.
In VS2012 compiling gunit or its dependencies triggers a lot of
"'std::tuple' : too many template arguments" warnings. The workaround
for this, done for gtest already, is to define _VARIADIC_MAX=10.

BUG=2616
R=perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8089004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5493 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-06 13:17:20 +00:00
fischman@webrtc.org
6e08228525 PeerConnectionTest(java): remove the obsolete magical names of streams & tracks.
BUG=1253
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7929005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5478 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-03 19:15:44 +00:00
fischman@webrtc.org
a06ebab1e1 PeerConnectionTest(java): test SCTP DataChannels.
BUG=1408,2253,2626
R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7929004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5477 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-03 19:11:29 +00:00
mallinath@webrtc.org
ecd622eec3 Updating libjingle.gyp after addition new files yuvframescapturer.cc.
TBR=pbos@webrc.org

Review URL: https://webrtc-codereview.appspot.com/7919006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5476 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-03 17:17:05 +00:00
mallinath@webrtc.org
67ee6b9a62 Update talk to 60923971
Review URL: https://webrtc-codereview.appspot.com/7909004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5475 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-03 16:57:16 +00:00
jiayl@webrtc.org
808b99b111 Disable a test assert which fails due to usrsctp not cleaned up in SctpDataEngine.cc
BUG=2749
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7739005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5460 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-29 19:44:40 +00:00
jiayl@webrtc.org
a576faf82a Enable SCTP and use OPENSSL on Anroid and NSS on other platforms.
It includes unit test fixes to properly initialize SSL if DTLS or SSL random number generator is used in the tests.
The private key and certificate constant strings used in some tests are updated to be compatible with NSS.
A few potentially overflow type conversions caused compiling warning on Windows and they are fixed by importing and using Chromium's checked_cast, which aborts the program if overflow occurs.
It also fixes a leak in nssstreamadapter.cc by releasing the PRFileDesc* in StreamClose.

BUG=2253
R=fischman@webrtc.org, juberti@google.com, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/4679005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5459 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-29 17:45:53 +00:00
mallinath@webrtc.org
7433a088d2 Revert 5444 "Revert 5421 "Fix deadlock on register/unregister ob..."
We reverted the r5421 to allow us roll webrtc to chrome without any modifications
to libjingle. Since webrtc is rolled with r5444, we can add back the original CL
and changes to libjingle will be upstreamed in the next roll.

TBR=andresp@webrtc.org

> Revert 5421 "Fix deadlock on register/unregister observer while ..."
> 
> Failure to compile on Chromium Internal bots, because of API changes.
> 
> http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Mac/builds/2805/steps/compile/logs/stdio
> 
> You need to follow the steps mentioned in 
> https://docs.google.com/a/google.com/document/d/1aHrmXECnu3-Jovc2-zYI267EaQCYz-IclYyBp9iA9Fc/edit that of a API changer.
> 
> Since I will be rolling the libjingle this week, I can push your changes along with libjingle roll, if you prepare the CLs
> as mentioned in the doc.
> 
> > Fix deadlock on register/unregister observer while there is a an going callback.
> > 
> > BUG=2835
> > R=mallinath@webrtc.org
> > 
> > Review URL: https://webrtc-codereview.appspot.com/7119005
> 
> TBR=andresp@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/7679004

TBR=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7729005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5453 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-29 00:56:02 +00:00
mallinath@webrtc.org
0dac5378e5 Revert 5447 "Update talk to 60420316."
> Update talk to 60420316.
> 
> TBR=wu@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/7719005

TBR=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7729004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5448 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-28 06:58:42 +00:00
mallinath@webrtc.org
752a017809 Update talk to 60420316.
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7719005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5447 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-28 06:45:52 +00:00
mallinath@webrtc.org
18586d38bc Revert 5421 "Fix deadlock on register/unregister observer while ..."
Failure to compile on Chromium Internal bots, because of API changes.

http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Mac/builds/2805/steps/compile/logs/stdio

You need to follow the steps mentioned in 
https://docs.google.com/a/google.com/document/d/1aHrmXECnu3-Jovc2-zYI267EaQCYz-IclYyBp9iA9Fc/edit that of a API changer.

Since I will be rolling the libjingle this week, I can push your changes along with libjingle roll, if you prepare the CLs
as mentioned in the doc.

> Fix deadlock on register/unregister observer while there is a an going callback.
> 
> BUG=2835
> R=mallinath@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/7119005

TBR=andresp@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7679004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5444 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-27 22:00:57 +00:00
wu@webrtc.org
256d0ada35 Remove the check for audio codec num in WebRtcVoiceEngineTest.HasCorrectCodecs.
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7589004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5430 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-24 18:58:51 +00:00
wu@webrtc.org
ca5ff9972e Re-enable webrtcvoice/videoengine unittests.
TEST=try bots
BUG=
R=mallinath@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=5387

Review URL: https://webrtc-codereview.appspot.com/7149004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5427 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-24 17:37:46 +00:00
andresp@webrtc.org
8d375c95b7 Fix deadlock on register/unregister observer while there is a an going callback.
BUG=2835
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7119005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5421 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-23 23:09:25 +00:00
wu@webrtc.org
a8910d2f88 Update talk to 60094938.
Review URL: https://webrtc-codereview.appspot.com/7489005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5420 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-23 22:12:45 +00:00
mallinath@webrtc.org
0d92ef67c4 Libjingle source code has some spelling mistakes and one of them is "renegotation", which should be "renegotiation".
This CL is attempting to correct those.

BUG=2810
TBR=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7439004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5411 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-22 02:21:22 +00:00
mallinath@webrtc.org
68cbd01216 enabling disabled data channels tests on win32. The real culprit was that ice candidates not included in SDP when there were failure causing transport channels never becoming writable.
BUG=2799
R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7369004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5410 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-22 00:16:46 +00:00
henrike@webrtc.org
28da47c52f Android example apps: fixes issue where useful failure information was suppressed.
BUG=2808
R=andrew@webrtc.org, fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7309004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5408 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-21 19:03:51 +00:00
henrike@webrtc.org
2ce9a64b75 Talk: Removes deprecated example apps and moves the server apps to trunk/talk/examples.
BUG=12545067
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7159004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5397 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-16 16:49:53 +00:00
sergeyu@chromium.org
4b26e2eee3 Update libjingle to 59676287
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7229004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5390 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-15 23:15:54 +00:00
wu@webrtc.org
8f19cb9fbc Revert 5387 "Re-enable webrtcvoice/videoengine unittests."
Missed the result from the last try bot.

> Re-enable webrtcvoice/videoengine unittests.
> 
> TEST=try bots
> BUG=
> R=mallinath@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/7149004

TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7179004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5388 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-14 22:31:11 +00:00
wu@webrtc.org
eda6823397 Re-enable webrtcvoice/videoengine unittests.
TEST=try bots
BUG=
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7149004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5387 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-14 22:15:09 +00:00
wjia@webrtc.org
03cfde2d10 Roll Chromium 238260 -> 243863
R=andrew@webrtc.org, henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6939004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5385 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-14 17:48:34 +00:00
henrika@webrtc.org
aebb1ade9d pRevert 5371 "Revert 5367 "Update talk to 59410372.""
> Revert 5367 "Update talk to 59410372."
> 
> > Update talk to 59410372.
> > 
> > R=jiayl@webrtc.org, wu@webrtc.org
> > 
> > Review URL: https://webrtc-codereview.appspot.com/6929004
> 
> TBR=mallinath@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/6999004

TBR=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7109004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5381 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-14 10:00:58 +00:00
fischman@webrtc.org
d7568a08c3 PeerConnection(java): Add OnRenegotiationNeeded support
Also:
- Make PeerConnectionObserver::OnRenegotiationNeeded() pure virtual to avoid
  this sort of mistake in the future.
- Sprinkle @Override annotations on some callback definitions that were missing
  them.
- Fix a JNI method-signature-lookup typo (s/(V)V/()V/) in PCOJava::OnError()
- Add an explicit ScopedLocalFrameRef to PCOJava::OnError() to match all other
  C++-fired callbacks, for consistency.

BUG=2771
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6829004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5376 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-13 22:04:12 +00:00
henrika@webrtc.org
44461fa5cb Revert 5367 "Update talk to 59410372."
> Update talk to 59410372.
> 
> R=jiayl@webrtc.org, wu@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/6929004

TBR=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6999004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5371 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-13 09:35:02 +00:00
mallinath@webrtc.org
0f3356e20b Update talk to 59410372.
R=jiayl@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6929004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5367 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-11 01:26:23 +00:00
sergeyu@chromium.org
4625df3e3e Fix NaCl compilation
nethelpers.cc was using LOG() but didn't include logging.h

R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6829005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5360 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-09 21:26:50 +00:00
fischman@webrtc.org
4177615e87 PeerConnection(java): replace ScopedLocalRef with ScopedLocalRefFrame and fix a local reference leak in OnMessage.
Hopefully the approach of pushing/popping frames will be easier to avoid messing up than remembering to annotate every single local reference with a ScopedLocalRef.

BUG=2761
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6729004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5355 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-09 00:31:17 +00:00
fischman@webrtc.org
1794693ec8 AppRTCDemo(android): close() the throw-away DataChannel.
Otherwise, the PeerConnection remembers the channel enough to include an
m=application line in its offer SDP, causing connection to chrome to fail, since
apprtc.appspot.com doesn't include an RtpDataChannels:true constraint in its
RTCPeerConnection constructor call.

R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6729005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5354 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-08 18:29:34 +00:00
wu@webrtc.org
e00265ed49 Fix a compile error on Android on sctpdataengine.cc.
TEST=try bots
BUG=
R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6719004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5350 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-07 19:32:40 +00:00
wu@webrtc.org
f6d6ed0c66 Update talk to 59039880.
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6569004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5339 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-03 22:08:47 +00:00
fischman@webrtc.org
000dde99c8 Android build: make it quiet on success and not overly noisy on failure.
- OpenSLDemo and WebRTCDemo get the sauce that AppRTCDemo got in r5271
- libjingle_peerconnection_jar is now silent on success
- Fix a bug introduced by r5271 which caused ant logs to be emitted to a subdir of talk/examples instead of in the gyp output directory.

R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6199005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5332 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-20 22:49:35 +00:00
fischman@webrtc.org
af320fd2f7 The designated initializer method declaration in the Objective-C headers for RTCICEServer does't match its implementation.
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6019004

Patch from Rafael Lopez Diez <rafalopezdiez@gmail.com>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5309 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-17 21:33:27 +00:00
fischman@webrtc.org
5b3c67ef25 objc/README: Remove outdated advice about target_os.
BUG=chromium:248168
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5979005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5302 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-16 17:15:19 +00:00
wu@webrtc.org
24301a67c6 Update talk to 58174641 together with http://review.webrtc.org/4319005/.
R=turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5809004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5287 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 19:17:43 +00:00
mallinath@webrtc.org
62451dcba0 Update talk to 58157731.
R=wu@webrtc.org

TBR=wu@webrc.org

Review URL: https://webrtc-codereview.appspot.com/5339005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5282 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 12:29:34 +00:00
wu@webrtc.org
a9890800e0 Update talk to 58127566 together with
https://webrtc-codereview.appspot.com/5309005/.

R=mallinath@webrtc.org, niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/5719004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5277 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 00:21:03 +00:00