Commit Graph

94 Commits

Author SHA1 Message Date
hta@webrtc.org
6ed617be22 Fixing memory leak error in test.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/571013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2272 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-22 16:55:16 +00:00
hta@webrtc.org
e1919f41b7 Unittest for thread_wrapper.
Added an explanation of the state variables of posix, wrote a simple test.
This might help in fixing the TSAN issue with thread.

BUG=webrtc:300
TEST=

Review URL: https://webrtc-codereview.appspot.com/583008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2270 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-22 15:57:34 +00:00
leozwang@webrtc.org
d63cf71413 Fix broken build because gyp doesn't filter out platform specific file with suffixes of .c
BUG=
TEST=test on all trybots, failed only on win_rel for weird error.
Review URL: https://webrtc-codereview.appspot.com/563009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2200 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 21:33:04 +00:00
leozwang@webrtc.org
f5fe1000de Enable cpu auto detection and ns optimized code on android
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/547006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2195 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 15:20:02 +00:00
tommi@webrtc.org
f4c80fc6cb Switch the other android build over to android_posix.cc and not android_linux.cc.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2070 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 15:41:33 +00:00
tommi@webrtc.org
9018c9f548 Fix androidndk build take two.
TBR=xians

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2069 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 15:38:10 +00:00
tommi@webrtc.org
3db5cb7438 Fix AndroidNDK build.
TBR=xians

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2068 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 15:29:08 +00:00
tommi@webrtc.org
3d48b09bb4 Fix android build.
TBR=kjellander

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2067 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 15:07:11 +00:00
tommi@webrtc.org
e84373c38f Atomic32Wrapper -> Atomic32
This change does the following:

* Remove the Atomic32Wrapper and AtomicImpl classes and provide the Atomic32
  implementation directly via platform specific source files.
* Move/rename/delete all source files accordingly
* The atomic value itself is now volatile. Previously it was only the pointer to
  the memory that was volatile, but not the actual value.
* No additional heap allocations are now done for the atomic value.

In a follow up cl I plan to start using Atomic32 in the RefCount class in order
to fix issues reported by Coverity.
Review URL: https://webrtc-codereview.appspot.com/490004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2065 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 14:28:45 +00:00
tommi@webrtc.org
98ad0ff1b0 Move the COMPILE_ASSERT macro to its own header file.
TEST=n/a
BUG=none
Review URL: https://webrtc-codereview.appspot.com/492002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2001 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-10 11:53:07 +00:00
andrew@webrtc.org
e713fd0eee Enable the "unused variable" warning on Windows.
- Break out direct_show_base_classes to its own gyp file to have it
  treated as third party code.
- Fix the resulting warnings (courtesy of Tommi).

BUG=
TEST=build on Windows (vie_auto_test currently failing at HEAD)

Review URL: https://webrtc-codereview.appspot.com/489001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2000 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-10 07:13:46 +00:00
tommi@webrtc.org
851becd00c Remove public virtual voe::SharedData inheritance.
This is a fix for coverity issues: 10446, 10445, 10444, 10443.

Although the cl is rather big, there aren't many code changes:

* Instead of an implicit vtable pointer, there is now an explicit |_data| member to access the shared data.
* We don't access the member variables of SharedData directly.  There are accessors instead.
* SharedData setters that set values that must be freed, automatically free the previous value and 'addref' if required the new one.
* Lots and lots of 'rewrapping' due to search/replace after the above changes.

BUG=10446, 10445, 10444, 10443
TEST=Run all tests for VoE.
Review URL: https://webrtc-codereview.appspot.com/472009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1987 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-04 14:57:19 +00:00
pwestin@webrtc.org
27fe1b702e Added compile time support for direct tracing.
Review URL: https://webrtc-codereview.appspot.com/469006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1985 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-04 08:08:30 +00:00
wu@webrtc.org
60c8b39ede Fix the WebRtc_Word8 and char mismatch for the chromium build.
Review URL: https://webrtc-codereview.appspot.com/446005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1882 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-12 23:59:11 +00:00
wu@webrtc.org
6e6ea04f9b Implement the TickTime::Now for mac using mach_absolute_time which is consistent even the user changes the system time.
Review URL: https://webrtc-codereview.appspot.com/431004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1879 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-12 19:42:22 +00:00
leozwang@webrtc.org
785db5a2a5 Enable rw_lock_posix on andorid
Review URL: https://webrtc-codereview.appspot.com/404002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1789 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-28 23:10:03 +00:00
punyabrata@webrtc.org
c29280d767 webrtc::CpuWindows::ProcessImpl() nullref crash resolution [6061101]
Review URL: https://webrtc-codereview.appspot.com/410004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1766 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-24 19:17:25 +00:00
henrike@webrtc.org
f3760dc8e9 Fixes coverity warning that I missed in system wrappers.
BUG=Coverity
TEST=N/A

Review URL: https://webrtc-codereview.appspot.com/395005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1717 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-17 16:27:25 +00:00
leozwang@webrtc.org
0a272eb44b Disable SetAffinity on android
CPU_ macros are only available in android source tree, not in NDK. Disable it for now. 
Review URL: https://webrtc-codereview.appspot.com/392008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1697 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-15 22:35:29 +00:00
andrew@webrtc.org
8bd6f19abe Disable flaky CpuTest.Usage on Windows.
TBR=turaj@webrtc.org
BUG=290
TEST=system_wrapper_unittests

Review URL: https://webrtc-codereview.appspot.com/396005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1689 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-15 01:47:51 +00:00
wu@webrtc.org
454a27c13d The pthread_t is non-pointer type.
TBR=henrike
Review URL: https://webrtc-codereview.appspot.com/392004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1646 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 20:36:23 +00:00
henrike@webrtc.org
143abd95a3 Fixes coverity warnings in system_wrappers.
Review URL: https://webrtc-codereview.appspot.com/389003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1645 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 19:39:38 +00:00
henrike@webrtc.org
0e7c060256 Linux logs were not displaying time at ms resolution.
Review URL: https://webrtc-codereview.appspot.com/267012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1644 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 18:53:50 +00:00
phoglund@webrtc.org
9d9ad88ba5 Fixed remaining warnings.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/393001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1626 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 16:16:52 +00:00
henrike@webrtc.org
2660460b89 Fixes flakyness in CPU unittest
Review URL: https://webrtc-codereview.appspot.com/377005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1616 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 23:33:54 +00:00
mflodman@webrtc.org
657b2a4965 Added return due to gcc complaints in r1604.
TBR=andrew

TEST=Bulid with clang version 3.1 (trunk 148911) and gcc.

Review URL: https://webrtc-codereview.appspot.com/384004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1606 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 11:06:01 +00:00
mflodman@webrtc.org
c80d9d9361 Removed default cases causing clang errors, -Wcovered-switch-default.
BUG=
TEST=Bulid with clang version 3.1 (trunk 148911)

Review URL: https://webrtc-codereview.appspot.com/379008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1604 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 10:11:25 +00:00
pwestin@webrtc.org
f6bb77a6f0 Cleaning up all use of RTP_PAYLOAD_NAME_SIZE and RTCP_CNAME_SIZE also fixed the char handing in trace.
Review URL: https://webrtc-codereview.appspot.com/358001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1535 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 17:16:59 +00:00
mflodman@webrtc.org
67cdc22e7e CpuLinux file handle leak.
BUG=crbug.com/110165

Review URL: http://webrtc-codereview.appspot.com/353001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1429 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 09:31:39 +00:00
kjellander@webrtc.org
7f3c724e12 Renaming 47 files from .cpp to .cc
In addition to our naming guidelines, this will cause these files to get parsed by Sonar, and to make searching/grepping the source using file extensions easier in the future.

BUG=
TEST=Compiling on Linux.

Review URL: http://webrtc-codereview.appspot.com/348005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1405 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 10:23:41 +00:00
pwestin@webrtc.org
df9866fedb Bugfix mac pid_t
Review URL: http://webrtc-codereview.appspot.com/350004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1384 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 08:57:47 +00:00
pwestin@webrtc.org
b54d72778c Changed thread Id handling in trace.
Review URL: http://webrtc-codereview.appspot.com/331020

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1383 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 08:28:04 +00:00
leozwang@webrtc.org
bccac66885 Use a more common macro to get thread id
Review URL: http://webrtc-codereview.appspot.com/342004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1349 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-06 00:32:00 +00:00
pwestin@webrtc.org
43761beb47 Bugfix get thread ID for linux.
Review URL: http://webrtc-codereview.appspot.com/331015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1282 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-22 09:40:28 +00:00
henrike@webrtc.org
4158c35820 Removed the WEBRTC_NO_TRACE macro since the style guide wants us to stear clear of macros and this one doesn't seem to have a purpose at this point.
Review URL: http://webrtc-codereview.appspot.com/315006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1233 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-19 17:28:25 +00:00
andrew@webrtc.org
04f5cba069 Switch to new critsect interface for DataLog.
The introduction of the new interface broke DataLog in a release build
(with enable_data_logging=1).

TBR=henrike@webrtc.org
TEST=build Linux/Release with enable_data_logging=1

Review URL: http://webrtc-codereview.appspot.com/334001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1212 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 21:33:11 +00:00
andrew@webrtc.org
986fab1496 Clean up file wrapper a bit further.
- Make error handling in Read, Write and WriteText consistent.
- Improve the interface comments a bit.

TEST=voe_auto_test, vie_auto_test

Review URL: http://webrtc-codereview.appspot.com/321012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1210 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 19:11:41 +00:00
henrike@webrtc.org
bfa80ce95e Removed usage of the deprecated critical section constructor in system_wrappers.
Review URL: http://webrtc-codereview.appspot.com/322004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1208 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 17:59:58 +00:00
leozwang@webrtc.org
e0e07bbaa0 Change file name because of r1199
Review URL: http://webrtc-codereview.appspot.com/320013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1201 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 00:51:45 +00:00
andrew@webrtc.org
59ccd5c71f Rename _windows.h -> _win.h in system_wrappers.
- Also rename _dummy -> no_op which states its purpose more clearly.
- Always use exclusion lists (i.e. sources! instead of sources)

TEST=builds and passes system_wrapper_unittest on Linux, Mac, Win

Review URL: http://webrtc-codereview.appspot.com/317007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1199 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 00:17:43 +00:00
andrew@webrtc.org
7e5ddf5aa3 Restore behavior to FileWrapper::Read.
- Returning the number of bytes read was mistakenly removed in r1175 in
  an overzealous attempt to unify the interface.
- Now both Read and WriteText return the number of bytes/characters
  processed. Write unfortunately cannot be easily changed due to the
  inheritance from OutStream.
- Improve the interface comments.

TBR=henrika@webrtc.org
BUG=issue196, issue198
TEST=voe_auto_test passes at last...

Review URL: http://webrtc-codereview.appspot.com/326001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1188 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 18:02:02 +00:00
andrew@webrtc.org
6d609b59f3 Fix crashes due to static_instance.
- Initialize a needed critsect in the constructor of
  UdpSocket2ManagerWindows.
- Don't return NULL when creating a static instance.

TEST=voe_auto_test on Windows.

Review URL: http://webrtc-codereview.appspot.com/324008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1177 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 02:36:33 +00:00
andrew@webrtc.org
5a9c6f26ab Fix max size and read-only errors in Write().
- A size of zero is now correctly interpreted as unlimited.
- The read-only flag is correctly checked.

TBR=henrika@webrtc.org
TEST=vie_auto_test (for real this time...)

Review URL: http://webrtc-codereview.appspot.com/315007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1176 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 00:53:30 +00:00
andrew@webrtc.org
5ae19de3ec Fix error in RtpDump::Start due to r1156.
- r1156 fixed a check on the _text member of FileWrapper. Turns out this
  was incompatibile with the RTP dumps, which want to write both binary
  and text data. Writing text data to a file open as "b" isn't actually
  an error, so I simply removed the check.
- Also cleans up the interface, most notably removing all WebRtc types.

TEST=vie_auto_test

Review URL: http://webrtc-codereview.appspot.com/317005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1175 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 22:59:33 +00:00
wjia@webrtc.org
c28e7980ef exclude trace_windows.cc and trace_posix.cc when building with Chromium.
BUG=none
TEST=compiles
Review URL: http://webrtc-codereview.appspot.com/324004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1165 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 02:16:11 +00:00
andrew@webrtc.org
114c790be7 Remove character limit in WriteText().
- vfprintf can be used directly here, removing the need for the interim
  buffer. This change allows us to remove the artificial character limit.
- Fix bugs with _text. It wasn't actually getting set earlier, and the
  check was wrong.
- Remove asserts that should use real error checks.

TEST=DataLog and VoECallReport (through voe_auto_test), the only users of WriteText().

Review URL: http://webrtc-codereview.appspot.com/323001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1156 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-10 02:33:33 +00:00
henrike@webrtc.org
2f47b5a70f Fixes a build error when disabling trace (which is done when building with chrome flag is set).
Review URL: http://webrtc-codereview.appspot.com/318006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1155 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-10 00:44:47 +00:00
henrike@webrtc.org
315282c01a Fixes a compiler warning related to dynamically allocated static memory. the fix is to leak the memory since the OS will clean it up anyways. This will not add noise to memory tools so it's ok. The issue is reported here: http://code.google.com/p/webrtc/issues/detail?id=147.
Review URL: http://webrtc-codereview.appspot.com/267023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1150 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 17:46:20 +00:00
mflodman@webrtc.org
b19582b7dc Add pointer constructor to CriticalSectionScoped.
Mainly added to simplyfy the code, e.g. when having critsect as scoped_ptr in classes.

Review URL: http://webrtc-codereview.appspot.com/302005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1144 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 10:02:16 +00:00
kma@webrtc.org
b59c031660 For Android ARMv7 platforms, added a feature of dynamically detecting the existence of Neon,
and when it's present, switch to some functions optimized for Neon at run time.
Review URL: http://webrtc-codereview.appspot.com/268002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1096 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-03 18:34:50 +00:00