perkj@webrtc.org
38ca4f2953
Fix code review comments.
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1086 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 09:34:10 +00:00
perkj@webrtc.org
d3eac4158c
Fixed webrtc::perm variable.
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1085 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 09:34:01 +00:00
perkj@webrtc.org
1b72fcd27b
Fix symbol RTPFILE_VERSION.
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1084 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 09:33:51 +00:00
stefan@webrtc.org
772d70bcd2
Fix release build error.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/304005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1083 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 09:18:49 +00:00
stefan@webrtc.org
a4a88f90c4
Implemented NACK based reference picture selection.
...
This CL implements NACK based reference picture selection for VP8. A separate
class is used for keeping track of the references and managing the VP8 encode
flags. Appropriate tests have also been added.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/284002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1082 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 08:34:05 +00:00
henrike@webrtc.org
4b00560a6e
Fixes build error in rtp_rtc module introduced in r1076.
...
Review URL: http://webrtc-codereview.appspot.com/301005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1081 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 00:32:24 +00:00
punyabrata@webrtc.org
c1ed87602a
Adding some error handling functionality in the windows audio core implementation to
...
stop rendering automatically and throw a playout-error callback when RequestPlayoutData
fails
Review URL: http://webrtc-codereview.appspot.com/300003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1080 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-01 17:55:35 +00:00
mflodman@webrtc.org
c6182915a3
Fix vie_encoder.cc.
...
TBR=ajm
Review URL: http://webrtc-codereview.appspot.com/301004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1079 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-01 17:45:28 +00:00
mflodman@webrtc.org
84d17838ac
Refactored ViEEncoder.
...
Style changes + QT Metrics class from h-file to cc-file, type changes will be in another CL.
Review URL: http://webrtc-codereview.appspot.com/303001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1078 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-01 17:02:23 +00:00
kjellander@webrtc.org
5f4f69ac57
Removing sleeps from vp8_test.
...
These sleeps were remains from earlier tests that required them to work with some codecs. Removing these sleep calls cut the execution time from 90s to 30s on my machine.
Review URL: http://webrtc-codereview.appspot.com/304004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1077 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-01 15:50:04 +00:00
pwestin@webrtc.org
0644b1dc35
Introduce a mockable RtpRtcpClock interface replacing ModuleRTPUtility time functions
...
A new RtpRtcpClock interface has been added to rtp_rtcp_defines.h
and provides time facilities used by an RTP/RTCP module. Also,
NTP constants have been made public in the
webrtc::ModuleRTPUtility namespace to make implementation of
external clocks easier.
An overloaded version of CreateRtpRtcp() accepts a clock argument. By
default, if no clock is provided, the module uses the system clock
(old ModuleRTPUtility implementation).
Throughout the RTP/RTCP module code, calls to TickTime and
ModuleRTPUtility time functions have been replaced with calls to time
methods on a clock object.
The following classes take a clock object in their constructor and
hold a _clock field (either directly, or inherited from a parent):
Bitrate
ModuleRtpRtcpImpl
RTCPReceiver
RTCPSender
RTPReceiver
RTPSender
RTPSenderAudio
RTPSenderVideo
Methods from other classes that do not derive any of those and
require a time take an additional nowMS parameter, that should be
the result of calling GetTimeInMS() on a clock object.
Review URL: http://webrtc-codereview.appspot.com/268017
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1076 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-01 15:42:31 +00:00
bjornv@webrtc.org
132feb1270
Made tables static.
...
In this CL global tables have been moved to where they are actually used. If for some reason they need to be available in a larger scope we can add them again at that point.
Review URL: http://webrtc-codereview.appspot.com/303002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1075 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-01 15:40:50 +00:00
kjellander@webrtc.org
4c4b7f500f
Converting vp8_test to use fileutils and gtest
...
Review URL: http://webrtc-codereview.appspot.com/289012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1074 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-01 15:24:36 +00:00
tina.legrand@webrtc.org
f64162c335
Adding const to a number of constant tables. Setting some tables to static.
...
Patch set 2: Renaming static const tables. They no longer need the prefix WebRtc_Isac...
Review URL: http://webrtc-codereview.appspot.com/301001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1073 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-01 13:01:39 +00:00
bjornv@webrtc.org
bedabb25bf
Added const on const tables.
...
Builds on Linux.
Tommi: Can you try on Windows?
Review URL: http://webrtc-codereview.appspot.com/300002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1072 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-01 07:44:32 +00:00
henrike@webrtc.org
c2ac8953d5
Fixes Valgrind warnings in system wrappers unittest.
...
Review URL: http://webrtc-codereview.appspot.com/293006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1071 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 22:46:59 +00:00
zakkhoyt@webrtc.org
a7e70b43e2
When entering fullscreen mode, the CocoaRenderView is attached as a subview to a new full screen window.
...
When the class is torn down, the view was not being attached back to it's original NSView. I added a
new class variable to remember the original superview and then reattach it at the appropriate time.
Review URL: http://webrtc-codereview.appspot.com/290009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1070 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 22:30:50 +00:00
mikhal@webrtc.org
b9db43e1b6
video_coding/jitter buffer: Reduce delay on a complete frame: No need for the next frame when current frame is already complete.
...
Review URL: http://webrtc-codereview.appspot.com/289007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1069 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 18:38:01 +00:00
mflodman@webrtc.org
511f82eee9
Refactored ViESyncModule.
...
Only style changes, will follow up with references/ptrs.
Review URL: http://webrtc-codereview.appspot.com/291007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1068 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 18:31:36 +00:00
perkj@webrtc.org
68f2168978
Remove global voe::Channel::numSocketThreads.
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1067 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 18:11:23 +00:00
mflodman@webrtc.org
27a82a65ca
Refactored ViEBaseImpl.
...
Only style changes, will follow up with references/ptrs.
Review URL: http://webrtc-codereview.appspot.com/290008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1066 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 18:04:26 +00:00
andrew@webrtc.org
a98124542a
Add third_party/libyuv to .gitignore.
...
Review URL: http://webrtc-codereview.appspot.com/290010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1065 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 18:03:35 +00:00
andrew@webrtc.org
587c844741
Query the capture volume immediately on Win Core.
...
This allows the capture volume to be queried immediately at capture
startup, rather than waiting the usual one second interval.
Review URL: http://webrtc-codereview.appspot.com/297003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1064 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 17:43:05 +00:00
henrik.lundin@webrtc.org
524eb48081
Removing deprecated NetEQ APIs
...
Removing WebRtcNetEQ_GetPreferredBufferSize and
WebRtcNetEQ_GetCurrentDelay and all dependent APIs.
Review URL: http://webrtc-codereview.appspot.com/289006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1063 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 16:21:22 +00:00
xians@webrtc.org
0dffc6449a
To be able to get webrtc into chrome, we need to reduce the size of the binary and the usage of memory.
...
This patch disbale some codecs which are not considered necessary.
Review URL: http://webrtc-codereview.appspot.com/299001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1062 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 15:35:44 +00:00
stefan@webrtc.org
0c2adf0b75
Fix bug introduced when enabling VP8 frame dropping.
...
Also fixes two unit test mismatches.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/299002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1061 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 14:41:58 +00:00
stefan@webrtc.org
ac2c677bf6
Make all video_coding tests use the resources and output directories.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/298001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1060 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 14:23:39 +00:00
andrew@webrtc.org
d2daa5c13e
Use clang by default on Mac.
...
But disable Chrome clang plugins for the time being.
TEST=build
Review URL: http://webrtc-codereview.appspot.com/297005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1059 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 01:16:06 +00:00
andrew@webrtc.org
268257475b
Fix one more Objective-C clang error.
...
(Analogous to r1056).
BUG=issue78
Review URL: http://webrtc-codereview.appspot.com/297004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1058 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 00:54:04 +00:00
zakkhoyt@webrtc.org
2687b261d5
Since the CocoaRenderView is forward declared with @class instead of imported,
...
instance must be cast to NSView* when passed to NSView's addSubView method.
Review URL: http://webrtc-codereview.appspot.com/288001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1056 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 23:55:19 +00:00
punyabrata@webrtc.org
c9801465b6
Adding a check to ensure that the memcpy does not exceed bounds of the arrays.
...
Review URL: http://webrtc-codereview.appspot.com/290007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1055 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 18:49:54 +00:00
andrew@webrtc.org
1e91693fe2
Move stream_delay check to ProcessStream().
...
- was_stream_delay_set_ was being incorrectly reset in
AnalyzeReverseStream().
- Added tests to catch this case.
BUG=
TEST=audioproc_unittest
Review URL: http://webrtc-codereview.appspot.com/291011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1054 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 18:28:57 +00:00
henrike@webrtc.org
0bf2ca2eed
Fixes broken unit test http://code.google.com/p/webrtc/issues/detail?id=154
...
Review URL: http://webrtc-codereview.appspot.com/292007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1053 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 18:21:46 +00:00
mikhal@webrtc.org
5fef05b529
libyuv: Updating paths for test files
...
Review URL: http://webrtc-codereview.appspot.com/289010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1052 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 17:50:07 +00:00
mflodman@webrtc.org
ffabb59f6e
Refactored ViERefCount.
...
In a coming CL: Use ref count in system_wrappers instead of this class.
Review URL: http://webrtc-codereview.appspot.com/291010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1051 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 17:31:21 +00:00
henrik.lundin@webrtc.org
fc9b903fbe
Enable NetEQ statistics unit testing
...
Adding test target NetEqDecodingTest::TestNetworkStatistics.
Update neteq_unittest to get files from resources folder.
Update DEPS file to get resources revision 2.
Review URL: http://webrtc-codereview.appspot.com/291013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1050 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 15:38:27 +00:00
henrik.lundin@webrtc.org
2d8125dd1a
Testing NetEQ network statistics
...
Implementing helper function for new unit test
NetEqDecodingTest::TestNetworkStatistics. The test itself
remains to be defined. (Will be added in a coming CL.)
This change required some refactoring of the test code
to avoid excessive code duplication.
Review URL: http://webrtc-codereview.appspot.com/295009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1049 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 14:30:28 +00:00
kjellander@webrtc.org
c625c1010a
Updated system_wrappers_unittests to use the test_support_main target.
...
Review URL: http://webrtc-codereview.appspot.com/291012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1048 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 12:11:06 +00:00
stefan@webrtc.org
932ab18d32
Default to always NACKing residual losses when having both FEC and NACK.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/296002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1047 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 11:33:31 +00:00
bjornv@webrtc.org
4b80eb4fcd
Name change resampler.c/h to aec_resampler.c/h.
...
To avoid possible conflict with resampler in common_audio.
Review URL: http://webrtc-codereview.appspot.com/296006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1046 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 08:44:01 +00:00
mflodman@webrtc.org
611e4c3253
Refactored ViEPerformanceMonitor.
...
Only style changes, will follow up with references/ptrs.
Review URL: http://webrtc-codereview.appspot.com/289009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1045 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 02:39:28 +00:00
mikhal@webrtc.org
a85590d383
libyuv: Adding Android.mk
...
Review URL: http://webrtc-codereview.appspot.com/291009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1044 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 01:42:57 +00:00
mflodman@webrtc.org
ad4ee3659e
Refactored ViEReceiver.
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1043 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-28 22:39:24 +00:00
marpan@webrtc.org
9d8bec6f76
FEC: Fix to valgrind warning.
...
Review URL: http://webrtc-codereview.appspot.com/292009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1042 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-28 22:10:05 +00:00
andrew@webrtc.org
400ad6928e
Fix compile warning in NS.
...
BUG=issue151
TEST=audioproc_unittest
Review URL: http://webrtc-codereview.appspot.com/290005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1041 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-28 21:33:42 +00:00
marpan@webrtc.org
d1b7932adf
VP8: Setting non-zero (conservative) threshold for frame dropper.
...
Review URL: http://webrtc-codereview.appspot.com/291001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1040 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-28 19:20:31 +00:00
mikhal@webrtc.org
2cdb2d3833
Adding Libyuv to Webrtc:
...
- Adding library to DEPS file
- Adding Wrapper implementation and tests.
This is an interim state, as these files are not being linked at this stage.
Review URL: http://webrtc-codereview.appspot.com/259005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1039 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-28 18:09:41 +00:00
xians@webrtc.org
e07247af8d
Valgrind reports a racing condition on _sending because it is accessed by
...
both TransmitMixer::PrepareDemux() and StartSend()/StopSend().
Put a lock to resolve it.
Review URL: http://webrtc-codereview.appspot.com/293005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1038 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-28 16:31:28 +00:00
andrew@webrtc.org
1e39bc80dc
Handle debug files from multiple AEC instances.
...
Review URL: http://webrtc-codereview.appspot.com/295006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1036 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-27 23:46:23 +00:00
andrew@webrtc.org
a919d3a643
Don't return a zero delay with insufficient data.
...
For estimating a delay over a long segment (e.g. a file) this can
throw off the estimate. Better not to add values to the AEC's histogram
until they're reliable.
BUG=
TEST=audiproc, audioproc_unittest
Review URL: http://webrtc-codereview.appspot.com/292004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1035 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-27 23:40:58 +00:00