Commit Graph

87 Commits

Author SHA1 Message Date
jiayl@webrtc.org
46fb331bc5 Add support of multiple STUN servers in UDPPort.
Now UDPPort signals PortComplete or PortError when the Bind requests for all STUN servers are responded or failed. If any STUN bind is successful, PortComplete is signaled; otherwise, PortError is signaled.

I discovered a bug in SocketAddress while working on this. It didn't consider two addresses unequal if they have unresolved IP and different hosts. It's fixed now.

BUG=3310
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/13879004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6707 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-16 20:55:31 +00:00
tommi@webrtc.org
b5348c64bb Minor refactoring of the session classes.
Make member variables that never change and are touched on multiple threads, const.
Move implementations of setters/getters of variables that can change, into the cc file in preparation of adding thread correctness checks.

This is a relanding of a cl already reviewed but got reverted by mistake.

TBR=xians@google.com

Review URL: https://webrtc-codereview.appspot.com/12979004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6676 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-14 20:11:49 +00:00
mallinath@webrtc.org
a70be68f65 Disabling shared socket mode for TURN ports. This is done as currently when
TURN server also used as STUN server, binding responses will be handed over
to TURN port, which simply discard these messages, as requests are originated
from StunPort.

Until we find the right solution for this problem, it's better we disable this
feature.

BUG=https://code.google.com/p/webrtc/issues/detail?id=3537
R=jiayl@webrtc.org, juberti@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19889004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6618 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-07 20:47:24 +00:00
jiayl@webrtc.org
974bbbb352 Fix uninitialized value in DtlsTransport and TransportDescription.
BUG=crbug/390304
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/21779004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6577 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-01 18:33:07 +00:00
jiayl@webrtc.org
db397e5c6c Re-evalutes the ICE role on ICE restart.
Also unifies the logic of ICE restart.

BUG=1775
R=juberti@google.com, juberti@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20619004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6510 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 16:32:09 +00:00
jiayl@webrtc.org
e3cdd9959e Revert "Fix the "Failed unprotect audio RTP packet" error when SCTP is bundled with audio."
This reverts commit 56631a14bdae24aa0bfaceeb2b57df729fee1227.

TBR=henrike@webrtc.org
BUG=3235

Review URL: https://webrtc-codereview.appspot.com/19669004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6363 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-06 22:32:57 +00:00
jiayl@webrtc.org
745a39cced Fix the "Failed unprotect audio RTP packet" error when SCTP is bundled with audio.
BUG=3235
R=juberti@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16609004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6356 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-06 19:24:02 +00:00
buildbot@webrtc.org
34a08b4fb8 (Auto)update libjingle 68275107-> 68379861
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6305 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-02 15:48:10 +00:00
phoglund@webrtc.org
f666ecc60d Disabling flaky libjingle tests after fixit week.
BUG=webrtc:3316,webrtc:3317,webrtc:3318
TBR=fischman@google.com

Review URL: https://webrtc-codereview.appspot.com/12569004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6250 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-27 08:08:00 +00:00
buildbot@webrtc.org
7aa1a4767f (Auto)update libjingle 67848628-> 67848776
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6237 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-23 17:33:05 +00:00
mallinath@webrtc.org
bb6201ae4b TCP remote socket address should have both server hostname and IP address.
Hostname is necessary when we are creating TLS based socket, for certificate
verification.

BUG=https://code.google.com/p/chromium/issues/detail?id=306285
R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19489004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6165 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 22:43:05 +00:00
buildbot@webrtc.org
cd846dd374 (Auto)update libjingle 66924241-> 66927231
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6134 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 22:58:27 +00:00
buildbot@webrtc.org
8a54844333 (Auto)update libjingle 66624678-> 66643715
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6095 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-09 18:10:55 +00:00
buildbot@webrtc.org
1cd14a4502 (Auto)update libjingle 66556498-> 66624678
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6093 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-09 15:01:40 +00:00
jiayl@webrtc.org
53d82350c5 Ignore identical remote fingerprint in DtlsTransportChannelWrapper::SetRemoteFingerprint.
Trying to set the same remote fingerprint could happen during renegotiation and should not fail.

BUG=crbug/362431
R=juberti@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12449005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6035 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-01 00:00:19 +00:00
buildbot@webrtc.org
658a94595d (Auto)update libjingle 65619249-> 65622932
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5984 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-25 22:03:30 +00:00
buildbot@webrtc.org
ff90ed6e96 (Auto)update libjingle 65561104-> 65619249
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5983 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-25 21:12:10 +00:00
buildbot@webrtc.org
3f1aa24078 (Auto)update libjingle 65469804-> 65484212
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5967 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-24 00:00:12 +00:00
jiayl@webrtc.org
0d915ff603 Fix the return value of DtlsTransportChannelWrapper::SendPacket in the case of invalid RTP packet.
R=juberti@webrtc.org, mallinath@webrtc.org

BUG=3244

Review URL: https://webrtc-codereview.appspot.com/12299006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5966 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-23 20:46:29 +00:00
mallinath@webrtc.org
54fd70046d Remove ASSERT in TransportChannelProxy::SetImplementation, when
proxy already set to same transport channel impl.

Since session can call SetImplementation multiple times with or without BUNDLE, there are cases when SetImplementation is called with same impl (OnRemoteCandidates/PushdownTransportDescription/SetupMux). Also variables in
cricket::TransportProxy like |connecting_| and |negotiated_| are accessed
both between worker thread and signaling threads (which calls for bigger change
on how session interacts with Transport and TransportChannelProxy). I have a created a separate bug to address later issue.

Also if single thread used as worker and signaling thread, we can end up
calling SetLocalDescription and OnRemoteCandidates in same call sequence, which
will end up calling SetImplementation twice.

R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12019007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5944 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-19 01:03:33 +00:00
buildbot@webrtc.org
8e5ec52e76 (Auto)update libjingle 65152644-> 65219629
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5941 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-19 00:00:31 +00:00
buildbot@webrtc.org
1a87f529a2 (Auto)update libjingle 65151416-> 65151642
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5934 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-17 22:41:30 +00:00
buildbot@webrtc.org
39b868bad3 (Auto)update libjingle 65055925-> 65086785
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5921 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-17 00:04:39 +00:00
mallinath@webrtc.org
ad4440a64e In shared socket mode, use udp port as default receiver even if
stun server address is not set.

This can happen in a loopback scenarios where clients do not need
to provide any server information.

R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12009004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5906 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-15 01:10:58 +00:00
buildbot@webrtc.org
f875f15afb (Auto)update libjingle 64709629-> 64813990
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5897 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-14 16:06:21 +00:00
buildbot@webrtc.org
61c1b8ea32 (Auto)update libjingle 64585415-> 64594651
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5870 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-09 06:06:38 +00:00
henrike@webrtc.org
f5bebd40f3 (Auto)update libjingle 64247466-> 64326665
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5845 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-04 18:39:07 +00:00
wu@webrtc.org
148149138d (Auto)update libjingle 64147530-> 64247466
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5835 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-02 23:25:15 +00:00
wu@webrtc.org
05e7b44b83 (Auto)update libjingle 63948945-> 64147530
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5825 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-01 17:44:24 +00:00
fischman@webrtc.org
4f2bd68744 Silence pointless LS_WARNING about port 0 for active-only candidates.
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10899004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5808 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-28 18:13:34 +00:00
sergeyu@chromium.org
e42b8ab129 Cleanups in libjingle to make it compile with chromium_code=1
Fixed all warnings that show up when compiling libjingle
in chromium with compiling with chromium_code=1.
chromium_code=1 enables various warnings that are off by
default. Most changes are for unused variables and consts.

R=pthatcher@google.com, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9699004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5769 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-25 00:31:35 +00:00
henrike@webrtc.org
10bd88e2b5 (Auto)update libjingle 62871616-> 62948689
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5683 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-11 21:07:25 +00:00
henrike@webrtc.org
0537634154 (Auto)update libjingle 62713454-> 62865357
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5670 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-10 15:53:12 +00:00
pbos@webrtc.org
371243dfa3 Remove std:: prefixes from C functions in talk/.
std::memcpy -> memcpy for instance. This change was motivated by a
compile report complaining that std::rand() was used instead of rand(),
probably with a stdlib.h include instead of cstdlib. Use of C functions
without the std:: prefix is a lot more common, so removing std:: to
address this.

BUG=
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9559004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5657 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-07 15:22:04 +00:00
pbos@webrtc.org
f714e7faea Remove abs() use in PseudoTcp::process.
Squelches a clang 3.5 compile error for using abs() with a long instead
of labs(). Updated affected code to use uint32:s to match the sign of
m_rx_srtt.

BUG=
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9409004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5651 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-06 18:31:08 +00:00
henrike@webrtc.org
704bf9ebec (Auto)update libjingle 62063505-> 62278774
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5617 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-27 17:52:04 +00:00
mallinath@webrtc.org
385857dfd4 Update talk to 61549749.
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8709004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5549 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-14 00:56:12 +00:00
wu@webrtc.org
b9a088b920 Update talk to 61538839.
TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/8669005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5548 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-13 23:18:49 +00:00
wu@webrtc.org
0de29504ab Revert 5545 "Update libjingle to 61514460"
> Update libjingle to 61514460
> 
> TBR=tommi@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/8649004

TBR=xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8669004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5547 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-13 19:54:28 +00:00
xians@webrtc.org
e749c9ebdb Update libjingle to 61514460
TBR=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8649004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5545 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-13 15:09:40 +00:00
kjellander@webrtc.org
4723dc88b3 Revert 5511 "Revert 5510 "Disable failing libjingle_p2p_unittest..."
So, the test apparently failed right away at 

http://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/1224/steps/libjingle_p2p_unittest/logs/stdio


> Revert 5510 "Disable failing libjingle_p2p_unittest test on Linux"
> 
> According to https://code.google.com/p/webrtc/issues/detail?id=2907#c2
> r5505 was committed to resolve exactly these flakes.
> Let's revert the disabling and see.
> 
> BUG=2907
> TBR=mallinath@webrtc.org
> 
> > Disable failing libjingle_p2p_unittest test on Linux
> > 
> > I realize this diables 84 test cases and for all platforms, which
> > I'm not really comfortable with. I tried finding a better way but
> > couldn't without doing significant changes to the file.
> > I think the tests either needs to be fixed or otherwise refactored
> > in order to make more fine-grained disabling possible.
> > 
> > Another (too) large disabling was done by holmer@ in
> > https://webrtc-codereview.appspot.com/2227004 where he should only have
> > disabled them on Windows, if the failures in webrtc:2383 was all that
> > caused those flakes.
> > 
> > BUG=2907
> > TEST=Verified this ran 0 tests:
> > out/Release/libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest.TestNAT_ADDR_RESTRICTEDToNAT_PORT_RESTRICTEDAsGiceBothSharedUfragWithMinimumStepDelay
> > TBR=wu@webrtc.org
> > 
> > Review URL: https://webrtc-codereview.appspot.com/8309004
> 
> TBR=kjellander@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/8329004

TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8339004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5513 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-09 18:48:56 +00:00
kjellander@webrtc.org
ce2b44532e Revert 5510 "Disable failing libjingle_p2p_unittest test on Linux"
According to https://code.google.com/p/webrtc/issues/detail?id=2907#c2
r5505 was committed to resolve exactly these flakes.
Let's revert the disabling and see.

BUG=2907
TBR=mallinath@webrtc.org

> Disable failing libjingle_p2p_unittest test on Linux
> 
> I realize this diables 84 test cases and for all platforms, which
> I'm not really comfortable with. I tried finding a better way but
> couldn't without doing significant changes to the file.
> I think the tests either needs to be fixed or otherwise refactored
> in order to make more fine-grained disabling possible.
> 
> Another (too) large disabling was done by holmer@ in
> https://webrtc-codereview.appspot.com/2227004 where he should only have
> disabled them on Windows, if the failures in webrtc:2383 was all that
> caused those flakes.
> 
> BUG=2907
> TEST=Verified this ran 0 tests:
> out/Release/libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest.TestNAT_ADDR_RESTRICTEDToNAT_PORT_RESTRICTEDAsGiceBothSharedUfragWithMinimumStepDelay
> TBR=wu@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/8309004

TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8329004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5511 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-09 18:21:00 +00:00
kjellander@webrtc.org
8d2ddd00f1 Disable failing libjingle_p2p_unittest test on Linux
I realize this diables 84 test cases and for all platforms, which
I'm not really comfortable with. I tried finding a better way but
couldn't without doing significant changes to the file.
I think the tests either needs to be fixed or otherwise refactored
in order to make more fine-grained disabling possible.

Another (too) large disabling was done by holmer@ in
https://webrtc-codereview.appspot.com/2227004 where he should only have
disabled them on Windows, if the failures in webrtc:2383 was all that
caused those flakes.

BUG=2907
TEST=Verified this ran 0 tests:
out/Release/libjingle_p2p_unittest --gtest_filter=P2PTransportChannelTest.TestNAT_ADDR_RESTRICTEDToNAT_PORT_RESTRICTEDAsGiceBothSharedUfragWithMinimumStepDelay
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8309004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5510 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-08 21:35:20 +00:00
mallinath@webrtc.org
5a59ccbb6d Switching to NSS random number generator and adding init method to unittests.
R=jiayl@webrtc.org, sergeuy@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8259004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5505 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-07 23:22:00 +00:00
sergeyu@chromium.org
9cf037b831 Update libjingle to 61168196
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8139004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5502 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-07 19:03:26 +00:00
mallinath@webrtc.org
67ee6b9a62 Update talk to 60923971
Review URL: https://webrtc-codereview.appspot.com/7909004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5475 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-03 16:57:16 +00:00
wu@webrtc.org
a8910d2f88 Update talk to 60094938.
Review URL: https://webrtc-codereview.appspot.com/7489005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5420 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-23 22:12:45 +00:00
henrike@webrtc.org
2ce9a64b75 Talk: Removes deprecated example apps and moves the server apps to trunk/talk/examples.
BUG=12545067
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7159004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5397 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-16 16:49:53 +00:00
sergeyu@chromium.org
4b26e2eee3 Update libjingle to 59676287
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7229004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5390 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-15 23:15:54 +00:00
henrika@webrtc.org
aebb1ade9d pRevert 5371 "Revert 5367 "Update talk to 59410372.""
> Revert 5367 "Update talk to 59410372."
> 
> > Update talk to 59410372.
> > 
> > R=jiayl@webrtc.org, wu@webrtc.org
> > 
> > Review URL: https://webrtc-codereview.appspot.com/6929004
> 
> TBR=mallinath@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/6999004

TBR=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7109004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5381 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-14 10:00:58 +00:00