Commit Graph

720 Commits

Author SHA1 Message Date
buildbot@webrtc.org
ea77334c30 (Auto)update libjingle 75302540-> 75327856
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7160 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 21:52:48 +00:00
henrike@webrtc.org
1d8f780779 Stop building talk/sound since it is no longer used.
BUG=N/A
R=pbos@webrtc.org
TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/26459004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7156 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 17:16:56 +00:00
glaznev@webrtc.org
1d53f64b0f Disabling initializeAndroidGlobals when built with WEBRTC_CHROMIUM_BUILD.
webrtc::VideoEngine::SetAndroidObjects and webrtc::VoiceEngine::SetAndroidObjects
are not compatible with WEBRTC_CHROMIUM_BUILD. Since neither VoiceEngine nor VideoEngine
are needed at the time it's better to disable it completely.

BUG=https://crbug.com/412276
R=glaznev@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24509004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7155 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 16:58:25 +00:00
henrikg@webrtc.org
307d3dbdee Revert 7114 "Expose VideoEncoders with webrtc/video_encoder.h."
Speculative revert, seems to be reason for flaky Win FYI bot compile break.

> Expose VideoEncoders with webrtc/video_encoder.h.
> 
> Exposes VideoEncoders as part of the public API and provides a factory
> method for creating them.
> 
> BUG=3070
> R=mflodman@webrtc.org, stefan@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/21929004

TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19329004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7151 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 09:48:30 +00:00
sprang@webrtc.org
c665dcb205 Revert 7145 "Stop building talk/sound since it is no longer used."
> Stop building talk/sound since it is no longer used.
> 
> BUG=N/A
> R=pbos@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/22319004

TBR=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/22619004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7148 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 08:29:53 +00:00
henrik.lundin@webrtc.org
1972ff8a6e Mark all virtual overrides in the hierarchy of Module as virtual and OVERRIDE.
This will make a subsequent change I intend to do safer, where I'll change the
return type of one of the base Module functions, by breaking the compile if I
miss any overrides.

This also highlighted a number of unused functions (in many cases apparently
virtual "overrides" of no-longer-existent base functions).  I've removed some of
these.

This also highlighted several cases where "virtual" was used unnecessarily to
mark a function that was only defined in one class.  Removed "virtual" in those
cases.

BUG=none
TEST=none
R=andrew@webrtc.org, henrik.lundin@webrtc.org, mallinath@webrtc.org, mflodman@webrtc.org, stefan@webrtc.org, turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24419004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7146 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 06:20:28 +00:00
henrike@webrtc.org
4c876453c8 Stop building talk/sound since it is no longer used.
BUG=N/A
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/22319004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7145 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 22:18:04 +00:00
glaznev@webrtc.org
3472dcd7b0 Fix frame rate selection for Android camera.
- Android camera supports multiple fps values for a single video
resolution - change video source default video format selection
to pick up best available fps.
- Change fps range calculation to better match target fps value.

BUG=2622
R=tkchin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15339004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7142 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 19:24:57 +00:00
henrike@webrtc.org
b2efb6771c Put base tests in webrtc_tests.gyp
BUG=N/A
R=andrew@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14249004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7140 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 17:28:19 +00:00
jiayl@webrtc.org
b6d69282f5 Enable shared socket for TurnPort.
In AllocationSequence::OnReadPacket, we now hand the packet to both the TurnPort and StunPort if the remote address matches the server address.

TESTED=AppRtc loopback call generates both turn and stun candidates.

BUG=1746
R=juberti@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19189004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7138 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 16:31:34 +00:00
buildbot@webrtc.org
5d639b3ef3 (Auto)update libjingle 75141932-> 75179475
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 07:57:12 +00:00
jiayl@webrtc.org
7d4891d3f1 Fixes two issues in how we handle OfferToReceiveX for CreateOffer:
1. the options set in the first CreateOffer call should not affect the result of a second CreateOffer call, if SetLocalDescription is not called after the first CreateOffer. So the member var options_ of MediaStreamSignaling is removed to make each CreateOffer independent.
Instead, MediaSession is responsible to make sure that an m-line in the current local description is never removed from the newly created offer.

2. OfferToReceiveAudio used to default to true, i.e. always having m=audio line even if no audio track. This is changed so that by default m=audio is only added if there are any audio tracks.

BUG=2108
R=pthatcher@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=7068

Review URL: https://webrtc-codereview.appspot.com/16309004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7124 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-09 21:43:15 +00:00
fbarchard@google.com
54cf1505e2 ValidateFrame, When dumping the first 4 samples of a frame, first copy it to a temporary buffer that is zero padded, them use that.
BUG=3789
TESTED=drmemory out\Debug\libjingle_media_unittest.exe --gtest_catch_exceptions=0 --gtest_filter=*Validate*
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24499004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7121 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-09 18:34:53 +00:00
jiayl@webrtc.org
22406fcc9b TurnPort should retry allocation with a new address on error STUN_ERROR_ALLOCATION_MISMATCH.
BUG=3570
R=juberti@webrtc.org, mallinath@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=7070

Review URL: https://webrtc-codereview.appspot.com/20999004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7120 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-09 15:44:05 +00:00
mallinath@webrtc.org
3d81b1b22a Relanding https://code.google.com/p/webrtc/source/detail?r=7093, after it got
reverted due to some internal compile failures.

In this CL changes are done in portallocator_unittest.cc, in particular to EXPECT_EQ checking in new tests.

Original patch committed in https://code.google.com/p/webrtc/source/detail?r=7093

TBR=juberti@webrtc.org
BUG=1179

Review URL: https://webrtc-codereview.appspot.com/22329004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7118 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-09 14:38:10 +00:00
andresp@webrtc.org
4d19e05ab2 Peerconnection_jni to use webrtc/base/checks.h instead of implementing its own.
This needs to happen sooner or later as if webrtc/base/checks.h happens to be included transitively here it would collide.

R=glaznev@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19259004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7115 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-09 11:45:44 +00:00
pbos@webrtc.org
b420191743 Expose VideoEncoders with webrtc/video_encoder.h.
Exposes VideoEncoders as part of the public API and provides a factory
method for creating them.

BUG=3070
R=mflodman@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/21929004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7114 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-09 10:40:56 +00:00
henrike@webrtc.org
8b0b21161a Revert 7093: "Implementing ICE Transports type handling in libjingle transport."
TBR=mallinath@webrtc.org
BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/28419004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7112 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-08 22:46:28 +00:00
pbos@webrtc.org
7118e61669 Finish work queue in SctpDataMediaChannelTest.
Always finishing the work queue prevents memory leak detected in
LeakSanitizer (packet is deleted on the receiver side).

R=jiayl@webrtc.org
BUG=3608,chromium:375154

Review URL: https://webrtc-codereview.appspot.com/28399004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7110 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-08 21:44:07 +00:00
jiayl@webrtc.org
0e52772aa9 Fix a bot-breaking memory leak from early returning in ParseMediaDescription.
BUG=3791
R=henrike@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/22589004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7109 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-08 21:43:43 +00:00
jiayl@webrtc.org
c172320bd2 Revert "Fixes two issues in how we handle OfferToReceiveX for CreateOffer:" because it broke content_browsertests on Android.
This reverts commit r7068.

TBR=kjellander@webrtc.org
BUG=2108

Review URL: https://webrtc-codereview.appspot.com/23539004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7108 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-08 20:44:36 +00:00
buildbot@webrtc.org
fd42f9dd6f (Auto)update libjingle 74955991-> 75042522
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7106 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-08 19:45:36 +00:00
mallinath@webrtc.org
7256d31d28 Implementing ICE Transports type handling in libjingle transport.
BUG=1179
R=juberti@webrtc.org, bemasc@webrtc.org, jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/22219004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7093 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-07 04:08:44 +00:00
thorcarpenter@google.com
cc060563f3 Remove unnecessary include from testutils.cc.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7090 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 21:19:00 +00:00
buildbot@webrtc.org
992febb997 (Auto)update libjingle 74873066-> 74873164
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7089 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 16:39:08 +00:00
thorcarpenter@google.com
a3344cfda4 Fix webrtcvideoframe tests.
R=fbarchard@google.com, harryjin@google.com, henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24429004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7088 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 16:34:13 +00:00
jiayl@webrtc.org
ddb85ab85b Updated SCTP SDP attributes according to draft-ietf-mmusic-sctp-sdp-07
- SDP sctpmap attribute replaced with fmtp attribute
- SDP sctp-port attribute is newly added

BUG=3592
R=jiayl@webrtc.org, juberti@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16169004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7087 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 16:31:56 +00:00
buildbot@webrtc.org
af5fa95258 (Auto)update libjingle 74857067-> 74860820
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7084 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 13:03:50 +00:00
buildbot@webrtc.org
7e3bd3d7de (Auto)update libjingle 74851128-> 74857067
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7083 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 11:45:42 +00:00
buildbot@webrtc.org
bc6fa1876e (Auto)update libjingle 74825992-> 74851128
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7082 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 11:08:01 +00:00
buildbot@webrtc.org
818b7b3ac9 (Auto)update libjingle 74825084-> 74825992
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7074 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 00:14:03 +00:00
jiayl@webrtc.org
dfbcf8161e Fix an issue in MediaStreamSignaling that a remotely create DataChannel is added to the list twice.
BUG=3778
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24459004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7073 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 00:01:12 +00:00
henrike@webrtc.org
f1427c6731 Revert 7070 "TurnPort should retry allocation with a new address on error
STUN_ERROR_ALLOCATION_MISMATCH."

TBR=jiayl@webrtc.org
BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/15359004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7072 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-04 22:21:33 +00:00
glaznev@webrtc.org
4b234044d5 Reduce maximum video resolution for Android.
HW video encoder and decoder can not be initialized
with 3840x2160 resolution.

BUG=3757,3738
R=juberti@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/25379004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7071 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-04 19:50:07 +00:00
jiayl@webrtc.org
574f2f60fe TurnPort should retry allocation with a new address on error STUN_ERROR_ALLOCATION_MISMATCH.
BUG=3570
R=juberti@webrtc.org, mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20999004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7070 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-04 19:11:34 +00:00
jiayl@webrtc.org
52055a276d Fixes two issues in how we handle OfferToReceiveX for CreateOffer:
1. the options set in the first CreateOffer call should not affect the result of a second CreateOffer call, if SetLocalDescription is not called after the first CreateOffer. So the member var options_ of MediaStreamSignaling is removed to make each CreateOffer independent.
Instead, MediaSession is responsible to make sure that an m-line in the current local description is never removed from the newly created offer.

2. OfferToReceiveAudio used to default to true, i.e. always having m=audio line even if no audio track. This is changed so that by default m=audio is only added if there are any audio tracks.

BUG=2108
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16309004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7068 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-04 17:12:25 +00:00
pbos@webrtc.org
ceb956b29d Abort Negotiate() if DoCreateOffer() fails.
Addressing crash in test.

R=jiayl@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/19239004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7066 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-04 15:27:49 +00:00
pbos@webrtc.org
bcb6bcfe6c Remove HybridVideoEngine.
This is currently unused dead code.

R=pthatcher@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/24409004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7055 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-04 07:32:26 +00:00
thorcarpenter@google.com
95c2458766 * Move test data assests required by video frame tests to be in libjingle instead of elsewhere and co-located with other libjingle test data files.
"gcl try" fails to upload these large files so adding them independently.

R=andrew@webrtc.org, harryjin@google.com, henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14319004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7050 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 23:17:36 +00:00
buildbot@webrtc.org
609f987488 (Auto)update libjingle 74696326-> 74723281
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7047 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 21:50:32 +00:00
buildbot@webrtc.org
fa4535b270 (Auto)update libjingle 74694022-> 74696326
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7045 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 16:49:04 +00:00
pbos@webrtc.org
26c0c41a06 Network up/down signaling in Call.
BUG=2429
R=mflodman@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/13109005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7044 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 16:17:12 +00:00
pbos@webrtc.org
ebee401230 Remove flake in SendsLowerResolutionOnSmallerFrames.
Speculative fix for break on Linux64 Release. It looks like the second
frame is being dropped which is likely because the two frames are sent
too close to eachother. Adding a delay of 33ms in between them to make
sure the second one isn't dropped.

R=minyue@webrtc.org
TBR=pthatcher@webrtc.org
BUG=1788

Review URL: https://webrtc-codereview.appspot.com/22289004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7043 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 15:52:02 +00:00
pbos@webrtc.org
c4175b9fdf Set resolution based on incoming VideoFrames.
R=pthatcher@webrtc.org
BUG=1788

Review URL: https://webrtc-codereview.appspot.com/17269004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7042 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 15:25:49 +00:00
buildbot@webrtc.org
72e448559d (Auto)update libjingle 74628537-> 74648573
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7033 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 00:43:48 +00:00
tkchin@webrtc.org
90750482fa Remove deprecated RTCVideoRenderer constructor.
Removes -[RTCVideoRenderer initWithView]. Also, fix potential issue where we hold on to a video frame longer than the lifetime of its associated track.

BUG=3341
R=glaznev@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16099004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7032 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-02 20:50:00 +00:00
pbos@webrtc.org
9f341283f6 Remove WebRtcVideoEngine::default_codec_format().
R=pthatcher@webrtc.org
BUG=1788

Review URL: https://webrtc-codereview.appspot.com/24399004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7029 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-02 16:33:09 +00:00
pbos@webrtc.org
03655143db Remove files from talk/PRESUBMIT.py.
BUG=
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/23429005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7028 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-02 16:17:36 +00:00
thakis@chromium.org
44010f3e52 win: Replace custom assert() macro with regular assert.h
The current code got added in libjingle r103; I don't see a good reason for it.
Things still build with plain old assert.h.

The custom assert was wrong: __debugbreak() is documented to return void,
so doing `cond ? true : __debugbreak()` shouldn't build (and it doesn't in
clang-cl). It's possible to make it build by writing
`cond ? true : (__debugbreak(), true)`, but just using the regular header
seems like a much better fix.

BUG=chromium:82385
Review URL: https://webrtc-codereview.appspot.com/19139004/


git-svn-id: http://webrtc.googlecode.com/svn/trunk@7007 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-29 03:00:15 +00:00
jiayl@webrtc.org
bc3f333905 Add jiayl to talk OWNERS.
BUG=
R=juberti@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/23379004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7006 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-28 23:24:36 +00:00