Commit Graph

27 Commits

Author SHA1 Message Date
henrik.lundin@webrtc.org
7d8c72e2db Re-implement dependency injection of TickTime into VCM and tests
This change basicly re-enables the change of r1220, which was
reverted in r1235 due to Clang issues.

The difference from r1220 is that the TickTimeInterface was
renamed to TickTimeClass, and no longer inherits from TickTime.

Review URL: http://webrtc-codereview.appspot.com/335006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1267 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-21 15:24:01 +00:00
mikhal@webrtc.org
0e7d9d862a Adding layer info consideration when applying FEC protection. In this first version, we hard code protection zero for non-base layer frames. As a future enhancement, an array should be passed from mediaOpt to set the protection per layer. A TODO was added in MediaOpt.
Review URL: http://webrtc-codereview.appspot.com/330005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1238 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-19 19:04:49 +00:00
henrik.lundin@webrtc.org
303158588b Revert "Inject TickTimeInterface into VCM and tests"
This CL reverts r1220.

Review URL: http://webrtc-codereview.appspot.com/336002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1235 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-19 17:55:45 +00:00
henrik.lundin@webrtc.org
a70f945086 Inject TickTimeInterface into VCM and tests
The purpose of this change is to introduce dependency injection
of the timer into the video coding module.

Review URL: http://webrtc-codereview.appspot.com/332003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1220 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 14:40:05 +00:00
stefan@webrtc.org
932ab18d32 Default to always NACKing residual losses when having both FEC and NACK.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/296002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1047 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 11:33:31 +00:00
mikhal@webrtc.org
ee3dfa6f43 Review URL: http://webrtc-codereview.appspot.com/241007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@789 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-21 00:46:09 +00:00
mikhal@webrtc.org
d0752c370d video_coding: Update to hybrid mode: Set FEC values for zero below a threshold.
Review URL: http://webrtc-codereview.appspot.com/245001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@773 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-19 15:48:30 +00:00
mikhal@webrtc.org
ae7a0522c5 video_coding robustness: Updating hybrid mode's settings
1. Disabling adjustment factor - temporary update. 
2. Enabling a windowed filtered loss for the hybrid mode.  
Review URL: http://webrtc-codereview.appspot.com/192003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@684 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 22:54:34 +00:00
marpan@google.com
f1f3fb33b5 Update to rate-mismatch factor in media_opt_util.
Review URL: http://webrtc-codereview.appspot.com/193003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@678 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 19:09:45 +00:00
marpan@google.com
3f28061f3a media_opt_util: Modification to correction factor in FEC overhead.
Review URL: http://webrtc-codereview.appspot.com/133019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@573 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-09 16:39:40 +00:00
andrew@webrtc.org
413b993166 Put some table size information in one place.
Motivated by fixing an unused variable warning in release mode.
Review URL: http://webrtc-codereview.appspot.com/132007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@523 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 22:03:56 +00:00
marpan@google.com
243db12616 media_opt_util: Fixed an assert and some code cleanup for AvgRecoveryFEC function.
Review URL: http://webrtc-codereview.appspot.com/139007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@502 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-31 22:14:52 +00:00
mikhal@webrtc.org
a057a9561c video_coding: Updating protection logic in media optimization utility:
1. Changing protection logic structure: Accepts only one method (not a list)
2. Removed unused code (unreferenced protection methods)
3. Removed inline constructors/destructors.  
Review URL: http://webrtc-codereview.appspot.com/120005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@467 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 21:17:34 +00:00
mikhal@webrtc.org
06ad81fd58 video_coding: changing the UpdateMethod function (protection settings).
Review URL: http://webrtc-codereview.appspot.com/126002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@423 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 16:03:59 +00:00
marpan@google.com
771ca422df Fixed assert error in media_opt_util that may have caused index for look-up table to be out of range.
Review URL: http://webrtc-codereview.appspot.com/112005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@385 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-16 20:51:04 +00:00
mikhal@google.com
320813c2d5 media_opt: Adding UEP to the hybrid mode
Review URL: http://webrtc-codereview.appspot.com/89013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@295 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-03 20:47:50 +00:00
mikhal@google.com
679450f4a6 media_opt_util: Update robustness settings for Hybrid mode. Updated table for the computation of the adjustment factor.
Review URL: http://webrtc-codereview.appspot.com/93013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@286 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-01 22:14:58 +00:00
marpan@google.com
191b780741 Added a correction factor to FEC overhead in media_opt_util.
This is too handle cases of rate-mismatch (at low rates/low packet number) between estimate in mediaOpt and actual FEC generated in RTP.
Review URL: http://webrtc-codereview.appspot.com/93012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@284 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-01 19:59:57 +00:00
mikhal@google.com
b29d940db7 VCM: Updating Media Opt:
1. Removed protection method specific code from SetTargetRates
2. Updated encoding rate following protection settings
3. Removing RTT max threshold from NACK, as it is not used in the receiver side.
4. Two bug fixes: FEC conversion function fix (line #133) and residual loss calculation (line #94) 
5. Removing compiler warnings
6.. Removed unused code and general clean-up. 
Review URL: http://webrtc-codereview.appspot.com/96002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@281 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-01 16:39:20 +00:00
ajm@google.com
b0d9f3e6a3 Fix an ambiguous call to pow() error.
Switch to powf() and explicitly define the second parameter as float.
Review URL: http://webrtc-codereview.appspot.com/89006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@269 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-28 18:43:18 +00:00
marpan@google.com
11d986a68c Update to media_opt_util:
(1) update to off-line table for fec 
(2) corresponding update and some code-cleanup for  
    FecProtectionFactor()
Review URL: http://webrtc-codereview.appspot.com/93006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@267 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-28 17:42:57 +00:00
marpan@google.com
13955743b0 Code cleanup for residual packet loss function in media_opt_util.cc.
Review URL: http://webrtc-codereview.appspot.com/89004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@256 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-26 16:47:11 +00:00
mikhal@google.com
7740888ad6 VCM: Adding the fecMethod as a member of the hybrid NACK/FEC class.
Review URL: http://webrtc-codereview.appspot.com/93002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@247 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-22 22:05:25 +00:00
mikhal@google.com
022716b3af VCM/Media Opt Util: 1. Updating hybrid protection settings 2. Removing score 3. adding Fec as suffix to _residualPacketLoss for clarity. 4. Some clean up.
Review URL: http://webrtc-codereview.appspot.com/88001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@238 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-20 23:12:57 +00:00
marpan@google.com
59fd0f12e6 Change to return no adjustment (default) if content_metrics=NULL,
and return true (default) for UEP flag if content_metrics=NULL.
Also parameter name change and get function for UEP in media_opt_util.
Review URL: http://webrtc-codereview.appspot.com/70002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@199 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-13 17:19:49 +00:00
marpan@google.com
86548c62e9 Modified media_opt and qm_select to allow for robustness settings
based on the content metrics. Re-organized the class structure in qm_select
into a resolution class and robustness settings class, both derived from
a main (qm/content analysis) class.
Review URL: http://webrtc-codereview.appspot.com/55006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@188 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-12 17:12:57 +00:00
niklase@google.com
470e71d364 git-svn-id: http://webrtc.googlecode.com/svn/trunk@156 4adac7df-926f-26a2-2b94-8c16560cd09d 2011-07-07 08:21:25 +00:00