generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
2,146 Commits 1 Branch 0 Tags 108 MiB
b5ea03adbb
Commit Graph

74 Commits

Author SHA1 Message Date
bjornv@webrtc.org
1747427861 VAD Refactoring: Replaced pointer operation with array index 
This CL contains a change of pointer nomenclature to array index. In addition, one place with two hard coded Gaussians has been generalized with a for loop.

Tested with trybots, vad_unittests, audioproc_unittest

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/592004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2307 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-28 12:50:05 +00:00
bjornv@webrtc.org
4e12d3065e VAD Refactoring: Removed assign calls 
These calls are not used anywhere in WebRTC and there is no plan on using them.
Removed them and updated corresponding unit tests.

Tested on trybots, vad_unittests, audioproc_unittest

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/608004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2306 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-28 12:25:07 +00:00
mflodman@webrtc.org
6af9594d71 Added gyp variable to include/exclude all tests. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/597004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2292 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 13:23:35 +00:00
andrew@webrtc.org
f98b6cc10e Remove noise during build on Win32 
TBR=niklas.enbom@webrtc.org
BUG=chromium:126483

Review URL: https://webrtc-codereview.appspot.com/590006
Patch from Scott Graham <scottmg@chromium.org>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2283 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 18:49:47 +00:00
bjornv@webrtc.org
cb0a86e913 VAD refactoring: Added function for repeated code. 
Added WeightedAverage() to calculate global mean. This removes hard coded Gaussian model size and repeated code.

Tested with vad_unittests, audioproc_unittest and trybots.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/571006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2275 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 07:56:51 +00:00
bjornv@webrtc.org
b286bfb13e VAD refactoring: Replaced hard coded array sizes with enum. 
Further replaced hard coded calculations with a for loop for better understanding.

Tested with vad_unittests and audioproc_unittest.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/519002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2162 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-02 12:14:57 +00:00
bjornv@webrtc.org
11654c2344 VAD refactoring: Local variable name changes 
Changes tested with vad_unittests and audioproc_unittest

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/485004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2093 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-23 14:50:11 +00:00
kma@webrtc.org
33ced9cc99 Same code change from issue 428004, with uint corrected to uint32_t in WebRtcSpl_MaxAbsValueW32, for a MAC compiler error. 
Review URL: https://webrtc-codereview.appspot.com/472006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2008 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-11 17:40:40 +00:00
andrew@webrtc.org
231f5d0d25 Remove missing VAD file from source list. 
BUG=
TEST=gyp run on Windows and build.
TBR=bjornv@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/479003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1993 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-06 01:00:06 +00:00
bjornv@webrtc.org
2273f325b2 VAD refactoring: Code style changes of local function. 
Changes applied to local GmmProbability():
* Replaced shift macros with shift operations
* Indentation and braces
* Removed redundant code
* Removed unnecessary type casts
* Name changes
* Adjusted comments

Tested with vad_unittests and audioproc_unittest

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/475002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1991 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-05 10:22:02 +00:00
henrika@webrtc.org
afedb637df Revert 1974 - Optimizations on several SPL min max operations in ARM, and refactoring in C. 
Touched C and assembly functions are tested with a new unit test which is not in the code base yet.
Review URL: https://webrtc-codereview.appspot.com/428004

TBR=kma@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/475001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1975 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-02 07:12:08 +00:00
kma@webrtc.org
95c3d408f5 Optimizations on several SPL min max operations in ARM, and refactoring in C. 
Touched C and assembly functions are tested with a new unit test which is not in the code base yet.
Review URL: https://webrtc-codereview.appspot.com/428004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1974 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-02 03:55:20 +00:00
bjornv@webrtc.org
ac2ea030fc VAD Refactoring: Repalced WebRtc_ types with stdint 
BUG=
TEST=vad_unittests,audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/460009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1954 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-29 12:09:44 +00:00
bjornv@webrtc.org
78f0cdc191 VAD refactoring 
* Added TODO comment
* Updated unit test
* Code style changes and added comments to set_mode()

BUG=
TEST=vad_unittests, audioproc_unittest, voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/460006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1943 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-27 11:06:29 +00:00
bjornv@webrtc.org
a496b03c78 VAD refactoring: Removed macro file. 
In this CL we've replaced the VAD macros with static const or enum.

Priority=low

BUG=
TEST=vad_unittest

Review URL: https://webrtc-codereview.appspot.com/453004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1913 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-20 12:53:06 +00:00
kma@webrtc.org
bb966ca835 Optimized function WebRtcSpl_ScaleAndAddVectorsWithRound() for ARM-NEON platforms, and refactor it for generic C. 
We removed it out of ilbc_specific_functions.c, since it's used not only in iLBC.

Passed the unit test.
Review URL: https://webrtc-codereview.appspot.com/426009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1904 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-16 16:29:37 +00:00
bjornv@webrtc.org
ed700db014 VAD refactor: Assign functions. Mostly style changes. 
Includes
- parameter order
- type changes
- variable name changes
- comment changes
- indentations
- test changes

In addition made minor style changes.
Review URL: https://webrtc-codereview.appspot.com/384001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1874 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-12 12:17:26 +00:00
andrew@webrtc.org
d62d7301f4 Remove TARGET_PC and cruft from typedefs.h. 
Additionally remove all TARGET defines (e.g. TARGET_MAC), which weren't used anyway.

BUG=
TEST=build on Linux, Mac, Win

Review URL: https://webrtc-codereview.appspot.com/432001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1822 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 21:39:57 +00:00
kma@webrtc.org
beb1851c2a Refactored and further optimized WebRtcSpl_MaxAbsValueW16() function in splib. 
Review URL: https://webrtc-codereview.appspot.com/395008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1820 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 20:03:26 +00:00
kma@webrtc.org
bfa7f96d1e Optimized WebRtcSpl_ComplexBitReverse() for general ARM platforms and generic C. 
In ARMv5, the cycles were reduced by 88% (weight in VoE reduced from 3.554% to 0.432%). The tradeoff is a memory increase of 704 bytes.
Review URL: https://webrtc-codereview.appspot.com/388003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1757 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-23 22:38:56 +00:00
kma@webrtc.org
551fcc04ec Optimized function WebRtcSpl_DownsampleFast for ARM-NEON platform. 
Review URL: https://webrtc-codereview.appspot.com/371001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1629 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 18:03:11 +00:00
kma@webrtc.org
59f16ec993 Introduced ARM version of WebRtcSpl_SqrtFloor(). Function cycles reduced by ~ 30% in a real time VOE test in an android device (Nexus-S, ARMv7a). 
// Fritz, I added you as a reviewer for the assembly files, just as a warm-up for future storms. :-) The assembly code was from public domain and there's little to touch.
Review URL: https://webrtc-codereview.appspot.com/369017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1627 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 17:15:15 +00:00
phoglund@webrtc.org
78088c2f36 Removed warnings on Windows and enabled warnings-as-errors on Windows. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/377004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1624 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 14:56:45 +00:00
bjornv@webrtc.org
530963925e Solves buffer overrun crash on Windows [issue 258]. 
Removed function calls not tested. Added a TODO on activating them when refactoring signal_processing.
Review URL: https://webrtc-codereview.appspot.com/379012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1620 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 08:10:46 +00:00
bjornv@webrtc.org
26e8a58130 VAD refactor: Create() and Free() 
Style and return value changes. No impact externally, since audio_processing, audio_conference_mixer and audio_coding either already assumes 'int' as return value, assumes nothing or doesn't take care of the return value.

TESTS=vad_unittests, audioproc_unittest
Review URL: https://webrtc-codereview.appspot.com/374006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1581 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-31 14:42:50 +00:00
bjornv@webrtc.org
0c6f931420 Removed versions in module/audio_processing and common_audio/vad. 
Affected vad_unittest only.
In addition changed to correct header guards.
Review URL: https://webrtc-codereview.appspot.com/367019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1567 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-30 09:39:08 +00:00
bjornv@webrtc.org
f4b77fd722 VAD refactor: Mode changed to "int". 
As part of style this CL includes changing the input aggressiveness mode from int16_t to int. No other style changes made.
Impact on:
- Audio Processing: Changed return value on MapSetting().
- Function test in audio_conference_mixer already uses int. No action.
- NetEq: Function pointer changes and input parameter changes in SetVADMode() and SetVADModeInternal().
- Audio Coding: Uses enum ACMVADMode which is type independent.
- VAD: Two unit tests.

TESTS=vad_unittests, neteq_unittests, audioproc_unittest
Review URL: https://webrtc-codereview.appspot.com/373001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1544 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 12:40:00 +00:00
bjornv@webrtc.org
2a4dcd7d15 VAD refactor: WebRtcVad_InitCore(). 
Impact only locally.
- Replaced for loops with memset().
- Added guard against NULL pointer.
- Removed mode as input parameter (never really used).
- Updated unit tests.
- Made struct member init_flag "int".
- Updated function description.
- Updated Copyright notes with 2012.
- Removed some lint warnings.

TESTS=vad_unittests, audioproc_unitest
Review URL: https://webrtc-codereview.appspot.com/369005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1543 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 12:18:12 +00:00
kma@webrtc.org
4bc24c4afa Optimized function WebRtcSpl_FilterARFastQ12 for ARM platform. 
Speed close to doubled for an offline test in NetEq.
Bit exact.
Review URL: https://webrtc-codereview.appspot.com/346001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1520 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 02:12:49 +00:00
bjornv@webrtc.org
152c34cf11 VAD-refactor. Changed to int as return value for WebRtcVad_set_mode(). 
Impact on NetEq function pointers. Other components already treat the output as int. These are:
* audio_processing
* funtion test in audio_conference_mixer
* audio_coding

TEST=vad_unittests, neteq_unittests
Review URL: https://webrtc-codereview.appspot.com/367003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1503 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 12:36:46 +00:00
bjornv@webrtc.org
6748087467 Incorrect pointer inputs in filter test. 
Two filter functions were called wrongly, which made us read from uninitialized values.
Added short comment.
No style changes. The tests will be revisited and extended during an upcoming refactor.

signal_processing_unittests now pass Valgrind.

TEST=signal_processing_unittests
Review URL: https://webrtc-codereview.appspot.com/344015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1466 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 10:41:39 +00:00
bjornv@webrtc.org
ab2bb82ac9 VAD refactor: int return value for Init. 
For consistency and as part of style, the return value of WebRtcVad_Init() has been changed to int.

Impact:
 1) audio_processing, audio_coding, a test in CNG, functionTest in audio_conference_mixer, a test in net_eq all used int values. Hence, unaffected.
 2) Function pointers in net_eq changed.
 3) The VADInit in neteq/dsp.c boiled down to typecast into int anyhow, which now is removed.

TEST=vad_unittests, neteq_unittests
Review URL: https://webrtc-codereview.appspot.com/355003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1453 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-18 14:51:02 +00:00
bjornv@webrtc.org
4259fd725c Refactor VAD: Code restructure 
- Tests added for vad_core.
- Replaced two macros with constants.
- Made an internal function static.
- Replaced replicated code with function call.
Review URL: https://webrtc-codereview.appspot.com/354001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1444 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-17 14:37:59 +00:00
bjornv@webrtc.org
40ea5106f6 Refactoring vad_filterbank 
Made internal function LogOfEnergy() more efficient.
Includes
- Name change "vector" -> "data"
- Complete refactor of LogOfEnergy()
- Removed lint warning

Major changes:
* Removed unnecessary variables
* Reduced number of shifts
* Removed one norm calculation


TEST=vad_unittests, audioproc_unittest
Review URL: http://webrtc-codereview.appspot.com/347004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1407 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-12 12:47:42 +00:00
bjornv@webrtc.org
d1f148da77 Refactor vad_filterbank: Some restructuring. 
- Removed unnecessary type casting.
- Added comments.
- Removed shift macros.
- Name change of _get_features() to _CalculateFeatures(). Affects vad_core.c and vad_filterbank_unittest.cc.
Review URL: http://webrtc-codereview.appspot.com/343002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1371 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-10 13:48:09 +00:00
bjornv@webrtc.org
d9c87b2146 Refactor vad_filterbank: Local functions made static. 
Review URL: http://webrtc-codereview.appspot.com/342002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1357 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-09 13:11:29 +00:00
bjornv@webrtc.org
e6471ba8d2 VAD unittest updates. 
Split the local function tests into separate files.
Review URL: http://webrtc-codereview.appspot.com/330031

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1352 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-09 09:54:07 +00:00
kma@webrtc.org
b0abbd353d Optimized spl function WebRtcSpl_CrossCorrelation for ARM Neon platforms. 
When used in Neteq, Neteq performance improved from 13 to 33% with different
test configurations.
Output is not bit-exact with generic C code in file cross_correlation.c, 
due to reduction of shift operations from using Neon registers, although in
theory now the result is more accurate than before.
Review URL: http://webrtc-codereview.appspot.com/333013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1350 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-06 19:50:20 +00:00
bjornv@webrtc.org
8f4a4ce13b Refactoring vad_filterbank: Style changes. 
Consists of:
- variable names.
- variable initialization.
- ordered input/output parameters.

TEST=vad_unittest, audioproc_unittest
Review URL: http://webrtc-codereview.appspot.com/339004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1345 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-05 08:42:39 +00:00
bjornv@webrtc.org
226c5a1a95 Refactoring of vad_sp.[h/c] 
- define guard name change
- changed to stdint
- added unit test
- removed shift macros
- style changes
- comments
Review URL: http://webrtc-codereview.appspot.com/336004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1326 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-04 09:15:12 +00:00
bjornv@webrtc.org
f175125e96 Refactoring vad_filterbank: Style changes. 
Includes:
- Correct header guard
- Indentations and white spaces
- Changed to stdint
Review URL: http://webrtc-codereview.appspot.com/330030

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1315 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-03 15:07:42 +00:00
tina.legrand@webrtc.org
5c43b1b861 Updated resampler unit test with stereo. 
I needed to run valgrind on this particular test, to exclude from valgrind warnings in ACM. Test passes valgrind without problems.
Review URL: http://webrtc-codereview.appspot.com/332010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1278 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-22 08:28:05 +00:00
bjornv@webrtc.org
c68f80a70a Refactoring vad_gmm.[c/h]. 
- Changed to stdint.
- Replaced SHIFT macros.
- Variable name changes.
- Style changes.
- Comments updates.
- Added a unit test.
Review URL: http://webrtc-codereview.appspot.com/323011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1249 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-20 14:08:34 +00:00
bjornv@webrtc.org
0edb25dcc9 Removed valgrind warnings in resampler_unittest. 
Valgrind complained on uninitialized values in resampler_unittest. Added initialization of the member variable data_in_ in the tests.
Review URL: http://webrtc-codereview.appspot.com/322006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1167 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-13 09:06:54 +00:00
bjornv@webrtc.org
132feb1270 Made tables static. 
In this CL global tables have been moved to where they are actually used. If for some reason they need to be available in a larger scope we can add them again at that point.
Review URL: http://webrtc-codereview.appspot.com/303002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1075 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-01 15:40:50 +00:00
bjornv@webrtc.org
bedabb25bf Added const on const tables. 
Builds on Linux.

Tommi: Can you try on Windows?
Review URL: http://webrtc-codereview.appspot.com/300002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1072 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-01 07:44:32 +00:00
bjornv@webrtc.org
48b68c0c24 Added support for 96 kHz sampling frequency. 
Updated resampler_unittests with the new valid combinations.
Verified audio quality on files.

TEST=resampler_unittests, voe_auto_test
BUILDTYPE=Debug, Release
PLATFORM=Linux
Review URL: http://webrtc-codereview.appspot.com/294001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1002 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-11-23 13:50:41 +00:00
kjellander@webrtc.org
0403ef419f Restructuring and adding unit test targets on project level instead of in common_audio. 
Review URL: http://webrtc-codereview.appspot.com/280001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@959 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-11-17 08:35:47 +00:00
kjellander@webrtc.org
20a370e875 Changing the namespace of TestSuite to webrtc::test. 
Adding gmock initialization into main test runner class

Review URL: http://webrtc-codereview.appspot.com/254004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@885 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-11-04 01:19:16 +00:00
bjornv@webrtc.org
250cd6f41b Added a VAD unit test to common_audio. At this stage it runs through the API calls, but should later be complemented with tests on a file. 
Review URL: http://webrtc-codereview.appspot.com/243002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@832 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-10-28 12:45:58 +00:00