Commit Graph

317 Commits

Author SHA1 Message Date
buildbot@webrtc.org
a42a3ade54 (Auto)update libjingle 75390072-> 75428737
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7174 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-13 01:09:18 +00:00
fbarchard@google.com
7e31197cb2 Revert 7170 "Revert 7121 "ValidateFrame, When dumping the first ..."
BUG=3789
TESTED=drmemory out\Debug\libjingle_media_unittest.exe --gtest_catch_exceptions=0 --gtest_filter=*Validate*

> Revert 7121 "ValidateFrame, When dumping the first 4 samples of a frame, first copy it to a temporary buffer that is zero padded, them use that."
> 
> Breaks other repos.
> 
> TBR=fbarchard@google.com
> BUG=N/A
> 
> Review URL: https://webrtc-codereview.appspot.com/23639004

TBR=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/27479004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7173 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-13 00:52:42 +00:00
henrike@webrtc.org
3decd9b776 Revert 7121 "ValidateFrame, When dumping the first 4 samples of a frame, first copy it to a temporary buffer that is zero padded, them use that."
Breaks other repos.

TBR=fbarchard@google.com
BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/23639004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7170 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-12 16:31:29 +00:00
henrikg@webrtc.org
307d3dbdee Revert 7114 "Expose VideoEncoders with webrtc/video_encoder.h."
Speculative revert, seems to be reason for flaky Win FYI bot compile break.

> Expose VideoEncoders with webrtc/video_encoder.h.
> 
> Exposes VideoEncoders as part of the public API and provides a factory
> method for creating them.
> 
> BUG=3070
> R=mflodman@webrtc.org, stefan@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/21929004

TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19329004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7151 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 09:48:30 +00:00
henrik.lundin@webrtc.org
1972ff8a6e Mark all virtual overrides in the hierarchy of Module as virtual and OVERRIDE.
This will make a subsequent change I intend to do safer, where I'll change the
return type of one of the base Module functions, by breaking the compile if I
miss any overrides.

This also highlighted a number of unused functions (in many cases apparently
virtual "overrides" of no-longer-existent base functions).  I've removed some of
these.

This also highlighted several cases where "virtual" was used unnecessarily to
mark a function that was only defined in one class.  Removed "virtual" in those
cases.

BUG=none
TEST=none
R=andrew@webrtc.org, henrik.lundin@webrtc.org, mallinath@webrtc.org, mflodman@webrtc.org, stefan@webrtc.org, turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24419004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7146 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 06:20:28 +00:00
buildbot@webrtc.org
5d639b3ef3 (Auto)update libjingle 75141932-> 75179475
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 07:57:12 +00:00
fbarchard@google.com
54cf1505e2 ValidateFrame, When dumping the first 4 samples of a frame, first copy it to a temporary buffer that is zero padded, them use that.
BUG=3789
TESTED=drmemory out\Debug\libjingle_media_unittest.exe --gtest_catch_exceptions=0 --gtest_filter=*Validate*
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24499004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7121 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-09 18:34:53 +00:00
pbos@webrtc.org
b420191743 Expose VideoEncoders with webrtc/video_encoder.h.
Exposes VideoEncoders as part of the public API and provides a factory
method for creating them.

BUG=3070
R=mflodman@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/21929004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7114 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-09 10:40:56 +00:00
pbos@webrtc.org
7118e61669 Finish work queue in SctpDataMediaChannelTest.
Always finishing the work queue prevents memory leak detected in
LeakSanitizer (packet is deleted on the receiver side).

R=jiayl@webrtc.org
BUG=3608,chromium:375154

Review URL: https://webrtc-codereview.appspot.com/28399004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7110 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-08 21:44:07 +00:00
buildbot@webrtc.org
fd42f9dd6f (Auto)update libjingle 74955991-> 75042522
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7106 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-08 19:45:36 +00:00
thorcarpenter@google.com
cc060563f3 Remove unnecessary include from testutils.cc.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7090 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 21:19:00 +00:00
buildbot@webrtc.org
992febb997 (Auto)update libjingle 74873066-> 74873164
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7089 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 16:39:08 +00:00
thorcarpenter@google.com
a3344cfda4 Fix webrtcvideoframe tests.
R=fbarchard@google.com, harryjin@google.com, henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24429004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7088 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 16:34:13 +00:00
buildbot@webrtc.org
af5fa95258 (Auto)update libjingle 74857067-> 74860820
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7084 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 13:03:50 +00:00
buildbot@webrtc.org
7e3bd3d7de (Auto)update libjingle 74851128-> 74857067
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7083 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 11:45:42 +00:00
buildbot@webrtc.org
bc6fa1876e (Auto)update libjingle 74825992-> 74851128
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7082 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 11:08:01 +00:00
buildbot@webrtc.org
818b7b3ac9 (Auto)update libjingle 74825084-> 74825992
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7074 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-05 00:14:03 +00:00
pbos@webrtc.org
bcb6bcfe6c Remove HybridVideoEngine.
This is currently unused dead code.

R=pthatcher@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/24409004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7055 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-04 07:32:26 +00:00
thorcarpenter@google.com
95c2458766 * Move test data assests required by video frame tests to be in libjingle instead of elsewhere and co-located with other libjingle test data files.
"gcl try" fails to upload these large files so adding them independently.

R=andrew@webrtc.org, harryjin@google.com, henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14319004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7050 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 23:17:36 +00:00
buildbot@webrtc.org
609f987488 (Auto)update libjingle 74696326-> 74723281
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7047 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 21:50:32 +00:00
pbos@webrtc.org
26c0c41a06 Network up/down signaling in Call.
BUG=2429
R=mflodman@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/13109005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7044 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 16:17:12 +00:00
pbos@webrtc.org
ebee401230 Remove flake in SendsLowerResolutionOnSmallerFrames.
Speculative fix for break on Linux64 Release. It looks like the second
frame is being dropped which is likely because the two frames are sent
too close to eachother. Adding a delay of 33ms in between them to make
sure the second one isn't dropped.

R=minyue@webrtc.org
TBR=pthatcher@webrtc.org
BUG=1788

Review URL: https://webrtc-codereview.appspot.com/22289004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7043 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 15:52:02 +00:00
pbos@webrtc.org
c4175b9fdf Set resolution based on incoming VideoFrames.
R=pthatcher@webrtc.org
BUG=1788

Review URL: https://webrtc-codereview.appspot.com/17269004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7042 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 15:25:49 +00:00
buildbot@webrtc.org
72e448559d (Auto)update libjingle 74628537-> 74648573
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7033 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-03 00:43:48 +00:00
pbos@webrtc.org
9f341283f6 Remove WebRtcVideoEngine::default_codec_format().
R=pthatcher@webrtc.org
BUG=1788

Review URL: https://webrtc-codereview.appspot.com/24399004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7029 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-02 16:33:09 +00:00
buildbot@webrtc.org
1f8a23757a (Auto)update libjingle 74235596-> 74297316
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6997 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-28 10:52:44 +00:00
pbos@webrtc.org
75c3ec1763 Fix data races during VideoAdapterTest tear-down.
Explicitly disconnect the VideoCapturer to avoid frames being
delivered during listener destruction. This manifested only on DrMemory
Full on Windows which I was able to repro locally.

BUG=3671
R=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15289004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6991 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-27 18:16:13 +00:00
buildbot@webrtc.org
573a1eef3d (Auto)update libjingle 74202294-> 74230205
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6990 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-27 17:21:19 +00:00
buildbot@webrtc.org
3533bfcb94 (Auto)update libjingle 74132319-> 74133664
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6983 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-26 15:50:23 +00:00
buildbot@webrtc.org
4470d78c9b (Auto)update libjingle 74128148-> 74132319
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6982 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-26 15:24:54 +00:00
pbos@webrtc.org
f21ac1fd46 Fix Win64 compile of videoadapter_unittest.cc.
Missed an typecast in videoadapter_unittest.cc in r6979 due to
tryservers being clogged and me waiting for a windows, linux, mac and
tsanv2 bot to finish was not enough. Committing fix straight away to
un-break tree.

TBR=tommi@webrtc.org
BUG=3671

Review URL: https://webrtc-codereview.appspot.com/18279004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6980 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-26 12:46:57 +00:00
pbos@webrtc.org
c9b3f77e65 Fix data races in VideoAdapterTest.
Adressing clear races between the test thread and capturer thread shown
as heap-use-after-free in vpx_codec_destroy in
WebRtcVideoMediaChannelTest.SetSend (way later in the rest run).

When capturing a frame the test copied it to a separate frame that would
then be read by the test without synchronization, if the test didn't
manage to examine the frame in between captures the adapted frame would
be overwritten by the following frame during accesses to it.

The actual races are suppressed by race:webrtc/base/messagequeue.cc and
race:webrtc/base/thread.cc. These fixes reduce the suppression count
locally from around 3000 to 30 for VideoAdapterTest.*.

Also removing tsan suppressions for talk/base as it's been moved to
webrtc/base.

R=tommi@webrtc.org
BUG=3671

Review URL: https://webrtc-codereview.appspot.com/22169004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6979 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-26 12:33:18 +00:00
pbos@webrtc.org
b648b9d85c Remove test constructor in WebRtcVideoEngine2.
Removes the need for ::Construct().

BUG=1788
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15279004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6977 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-26 11:08:06 +00:00
kjellander@webrtc.org
b96ea2aab5 Remove former team members from OWNERS and WATCHLISTS
Remove the following (CCed) former team members from all
OWNERS files and the WATCHLISTS file:
* fischman@
* leozwang@
* mikhal@
* pwestin@
* wu@

BUG=
R=henrike@webrtc.org, niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/22509004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6973 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-26 06:12:08 +00:00
buildbot@webrtc.org
204cd56007 (Auto)update libjingle 74064646-> 74072040
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6972 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-25 21:10:18 +00:00
buildbot@webrtc.org
857130fd5b (Auto)update libjingle 74039473-> 74044292
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6970 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-25 16:07:12 +00:00
buildbot@webrtc.org
b4c7b09c13 (Auto)update libjingle 73927775-> 74032598
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6965 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-25 12:11:58 +00:00
buildbot@webrtc.org
3740d74106 (Auto)update libjingle 73927658-> 73927775
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6958 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-22 22:27:04 +00:00
buildbot@webrtc.org
309a611670 (Auto)update libjingle 73891518-> 73927658
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6957 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-22 22:24:54 +00:00
buildbot@webrtc.org
2b0554f0e7 (Auto)update libjingle 73794259-> 73891518
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6955 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-22 14:08:15 +00:00
pbos@webrtc.org
97fdeb8329 Remove static initializer in WebRtcVideoEngine2.
Blocks import into chromium.

R=tommi@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/18249004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6954 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-22 10:36:23 +00:00
buildbot@webrtc.org
95bbd18696 (Auto)update libjingle 73627179-> 73695227
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6933 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-20 07:49:30 +00:00
buildbot@webrtc.org
5a60aed80f (Auto)update libjingle 73626701-> 73627179
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6930 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-19 15:11:45 +00:00
buildbot@webrtc.org
84532e59dd (Auto)update libjingle 73626167-> 73626701
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6929 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-19 15:05:18 +00:00
henrike@webrtc.org
0481f15f02 (Auto)update libjingle 73399579-> 73626167
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6928 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-19 14:56:59 +00:00
buildbot@webrtc.org
c3df61e351 (Auto)update libjingle 73256845-> 73260148
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6898 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-13 23:57:23 +00:00
buildbot@webrtc.org
449ad98aeb (Auto)update libjingle 73248599-> 73249894
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6896 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-13 21:55:18 +00:00
pbos@webrtc.org
ef8bb8d9b0 Make sure that muting muted streams succeeds.
We don't want to report an error here, and PeerConnection relies on
being able to mute already-muted streams (I hit an assert when testing
manually).

BUG=1788
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14139004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6895 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-13 21:36:18 +00:00
pbos@webrtc.org
432893a100 Remove TODO saying to remove WebRtcVideoFrame.
Comment was added prematurely, there's no decision to get rid of this
type.

BUG=1788
R=pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19049004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6894 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-13 21:17:22 +00:00
buildbot@webrtc.org
a09a99950e (Auto)update libjingle 73222930-> 73226398
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6891 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-13 17:26:08 +00:00