Commit Graph

11 Commits

Author SHA1 Message Date
kjellander@webrtc.org
3147b97f8c LSan suppressions for libjingle tests (fix)
Apparently wildcards are needed for templates
in the call stack for matching suppressions.

TBR=wu@webrtc.org
BUG=2528, 3345
TEST=None, since I cannot reproduce the leaks on the bot
in my local environment (and we don't have a trybot for this yet).

Review URL: https://webrtc-codereview.appspot.com/18459004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6156 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 18:05:15 +00:00
kjellander@webrtc.org
7c0f6e1b47 LSan suppressions for libjingle tests (more)
Additional suppressions after a new test run was completed
after https://webrtc-codereview.appspot.com/18429006 was
submitted.

TBR=wu@webrtc.org
BUG=2528, 3345
TEST=None, since I cannot reproduce the leaks on the bot
in my local environment (and we don't have a trybot for this yet).

Review URL: https://webrtc-codereview.appspot.com/14509004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6155 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 17:46:23 +00:00
kjellander@webrtc.org
a70dff4427 LSan suppressions for libjingle tests.
Adding a few more suppressions to make the tests pass
LSan as it's about to be enabled in the main waterfall
at the ASan bot.

TBR=wu@webrtc.org
BUG=2528, 3345
TEST=None, since I cannot reproduce the leaks on the bot
in my local environment (and we don't have a trybot for this yet).

Review URL: https://webrtc-codereview.appspot.com/18429006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6153 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 17:12:01 +00:00
kjellander@webrtc.org
01edf2e2af Updating LSan third party suppressions.
Several new third party suppressions have been updated in
Chromium's suppressions file:
https://code.google.com/p/chromium/codesearch#chromium/src/tools/lsan/suppressions.txt
These will solve some of the errors we're seeing at
http://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20LSan%20%28and%20ASan%29/
which needs to be resolved before switching our
ASan bot to recipes (since the recipe ASan configuration
has LSan enabled by default).

BUG=2527,2528,3345,3346
TEST=Successfully ran the following tests under ASan+LSan locally:
libjingle_media_unittest
libjingle_p2p_unittest
libjingle_peerconnection_unittest
libjingle_unittest

R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14489005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6148 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 12:28:38 +00:00
kjellander@webrtc.org
bd51d9324e LSan suppressions for libjingle_peerconnection_unittest
Some more leaks have entered the code a while ago so
I'm suppressing them to green up the bot again.

BUG=2528
TEST=Successful execution of the test using the steps described in webrtc:2528.
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/4419004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5177 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-26 09:37:12 +00:00
turaj@webrtc.org
55e1723713 Avoid a leak in AudioCodingModuleTest.TestIsac. The leak was caught by LSAN.
BUG=2515
TEST=reproduced locally on linux and verified the fix resolves the issue.
R=henrik.lundin@webrtc.org, kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2499004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5048 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-29 04:40:09 +00:00
kjellander@webrtc.org
6b426ba5c5 Final round of LSan suppressions (take 2)
Turns out I was running libjingle_unittest
instead of libjingle_peerconnection_unittest
on the bot machine when I was verifying the
suppressions added in r4991 on the bot.
This will hopefully be the last round.

BUG=2528
TEST=running libjingle_unittest with these
suppressions applied locally on the bot.
TBR=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2426004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4993 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-17 19:26:27 +00:00
kjellander@webrtc.org
b22049b295 Final round of LSan suppressions.
Since we don't have a trybot for LSan, this is the only
way to resolve errors only happening on the bots
(except running at the bot themselves).

I suspect some errors only occurs on the bots since
the compiler version differs (4.6 on bots, 4.6.3 on
my machine).

This last suppressions round was tested on an actual
Chrome infra VM as well, with no errors.

BUG=2528
TEST=ran successfully on the bot.
TBR=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2424004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4991 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-17 18:13:28 +00:00
kjellander@webrtc.org
8a7b89fd41 More libjingle LSan suppressions.
The suppressions in r4988 were not enough to green
up the LSan+ASan bot.
Here's another round of suppressions to get the bot green
which I have tested multiple runs without any leaks reported.

BUG=2527,2528
TEST=
GYP_DEFINES='asan=1 lsan=1 linux_use_tcmalloc=0 release_extra_cflags="-gline-tables-only"' gclient runhooks
ninja -C out/Release libjingle_unittest
export ASAN_SYMBOLIZER_PATH=`(pwd)`/third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer
export ASAN_OPTIONS="detect_leaks=1 strict_memcmp=0"
export LSAN_OPTIONS="suppressions=tools/lsan/suppressions.txt"
out/Release/libjingle_peerconnection_unittest
out/Release/libjingle_unittest
TBR=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2422004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4990 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-17 17:15:24 +00:00
kjellander@webrtc.org
e61da8c391 Suppressions and PRESUBMIT.py for LSan
The Leak Sanitizer will replace Valgrind
memcheck when it's related tool Memory Sanitizer is ready.
We should get our tests in shape so we can detect
new leaks, which is why I'm adding these suppressions.

More info at http://www.chromium.org/developers/testing/leaksanitizer
Buildbot at http://build.chromium.org/p/client.webrtc.fyi/waterfall

BUG=2515,2527,2528
TEST=Ran tests with the parameters described in webrtc:2527.
TBR=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2421004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4988 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-17 14:16:17 +00:00
kjellander@webrtc.org
8ae641edfb Add suppressions file for Leak Sanitizer.
Add a suppressions file that must exist in order for the Leak Sanitizer
(LSan) bot to be able to run with the default configuration.
This bot is located in the new WebRTC FYI waterfall at:
http://build.chromium.org/p/client.webrtc.fyi/waterfall

More info about LSan on http://www.chromium.org/developers/testing/leaksanitizer

BUG=none
TEST=Running a local master+slave passes fine with this file added locally.
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2135004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4636 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-28 20:29:35 +00:00