pbos@webrtc.org
1fb5d1204b
Initialize restored_packet in nack_rtx_unittest.cc.
...
This is to get the DrMemory Full bots to go green, this was previously
suppressed. This fix is likely hiding a real bug that should be
investigated, but it's not a regression from before. The issue should
not be closed before we figure out why this is the case and revert this
"fix".
TBR=stefan@webrtc.org
BUG=3183
Review URL: https://webrtc-codereview.appspot.com/30369004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7169 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-12 16:16:00 +00:00
henrike@webrtc.org
c3c9015bc6
linux: remove stray libcrypto dependency
...
Followup to CL 20049004, which looks like it added an unneeded -lcrypto
on linux.
BUG=3625
R=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/28459004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7168 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-12 16:11:38 +00:00
henrike@webrtc.org
78b2d56ac6
Disable MethodNotAllowedOnDifferentThreadInDebug.
...
BUG=3803
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19339004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7167 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-12 15:57:08 +00:00
andresp@webrtc.org
d2cf48de1a
Fix mac video_render implementation on cocoa.
...
Hit this while playing around with all compile possibilities for issue 3770.
BUG=3770
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/23629004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7166 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-12 13:57:47 +00:00
andresp@webrtc.org
f7e5f22f98
Fix stack limit exceeded in http client.
...
R=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/23419004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7165 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-12 13:35:05 +00:00
pbos@webrtc.org
a0d7827b16
Add ability to downscale content to improve quality.
...
BUG=3712
R=marpan@google.com , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/18169004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7164 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-12 11:51:47 +00:00
pbos@webrtc.org
b5e6bfc76a
Make RTPSender/RTPReceiver generic.
...
Changes include,
1) Introduce class RtpPacketizerGeneric & RtpDePacketizerGeneric.
2) Introduce class RtpDepacketizerVp8.
3) Make RTPSenderVideo::SendH264 generic and used by all packetizers.
4) Move codec specific functions from RTPSenderVideo/RTPReceiverVideo to
RtpPacketizer/RtpDePacketizer sub-classes.
R=pbos@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/26399004
Patch from Changbin Shao <changbin.shao@intel.com>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7163 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-12 11:05:55 +00:00
stefan@webrtc.org
6071b0636d
Mark all virtual overrides in the hierarchy of RtpData and RtpReceiver as such.
...
This will make further changes to these classes safer by ensuring that the
compile breaks if the base class changes and not all overrides are fixed.
This also highlighted a number of unused functions which I've removed.
-- This is was reviewed in https://webrtc-codereview.appspot.com/19309004/ , but
-- a new cl was needed to resolve a small conflict before committing.
BUG=none
TEST=none
TBR=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/22359004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7162 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-12 07:42:33 +00:00
henrike@webrtc.org
cc774a69cb
Mark all virtual overrides in the hierarchies of RtpDump and
...
VCMPacketizationCallback as such.
This will make further changes to these classes safer by ensuring that the
compile breaks if the base class changes and not all overrides are fixed.
This also marks all other such overrides in the affected files.
BUG=none
TEST=none
R=henrike@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19319004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7161 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 22:45:54 +00:00
buildbot@webrtc.org
ea77334c30
(Auto)update libjingle 75302540-> 75327856
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7160 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 21:52:48 +00:00
henrike@webrtc.org
31c285b333
Update AUTHORS file.
...
BUG=N/A
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/25509004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7159 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 21:12:59 +00:00
jiayl@webrtc.org
89959966a9
Fix window capturing on Windows when the window is minimized.
...
BUG=crbug/410290
R=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/20319004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7158 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 19:33:58 +00:00
pbos@webrtc.org
f520ea5eed
Skip dlclose() on AddressSanitizer.
...
AddressSanitizer can't symbolize parts of the stack that contains
dlclose()d modules. This makes some LSan suppressions not kick in and
blocks launching the LSan bot for WebRTC.
This "fix" excludes dlclose() in
webrtc/modules/audio_device/linux/latebindingsymboltable_linux.cc which
resolves this on the bot.
R=xians@webrtc.org
BUG=3402,chromium:375154
Review URL: https://webrtc-codereview.appspot.com/25499004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7157 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 17:29:11 +00:00
henrike@webrtc.org
1d8f780779
Stop building talk/sound since it is no longer used.
...
BUG=N/A
R=pbos@webrtc.org
TBR=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/26459004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7156 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 17:16:56 +00:00
glaznev@webrtc.org
1d53f64b0f
Disabling initializeAndroidGlobals when built with WEBRTC_CHROMIUM_BUILD.
...
webrtc::VideoEngine::SetAndroidObjects and webrtc::VoiceEngine::SetAndroidObjects
are not compatible with WEBRTC_CHROMIUM_BUILD. Since neither VoiceEngine nor VideoEngine
are needed at the time it's better to disable it completely.
BUG=https://crbug.com/412276
R=glaznev@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24509004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7155 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 16:58:25 +00:00
pbos@webrtc.org
b9906743da
Split suppressons of thread.cc and messagequeue.cc.
...
Most calls have either of these in the stack, meaning that pretty much
all races are suppressed.
BUG=
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17349004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7154 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 14:59:06 +00:00
aluebs@webrtc.org
4b049fcabe
Remove developing code in ns_core
...
This defines were hardcoded and the code inside of the ifdefs was never used.
BUG=webrtc:3763
R=bjornv@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24559004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7153 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 11:19:56 +00:00
aluebs@webrtc.org
f5bdd54ac3
Add myself to common_audio and audio_processing watchlists
...
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/22609004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7152 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 10:11:43 +00:00
henrikg@webrtc.org
307d3dbdee
Revert 7114 "Expose VideoEncoders with webrtc/video_encoder.h."
...
Speculative revert, seems to be reason for flaky Win FYI bot compile break.
> Expose VideoEncoders with webrtc/video_encoder.h.
>
> Exposes VideoEncoders as part of the public API and provides a factory
> method for creating them.
>
> BUG=3070
> R=mflodman@webrtc.org , stefan@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/21929004
TBR=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19329004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7151 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 09:48:30 +00:00
kjellander@webrtc.org
665d861115
Restore webrtc_base target until r7140 is rolled into Chromium.
...
In r7140 the webrtc_base target was renamed to rtc_base. This
breaks our FYI bots for rolling WebRTC in Chromium's DEPS.
By re-adding a None target named webrtc_base, this transition
should be smoother.
TBR=henrikg@webrtc.org ,
TESTED=Passed build/gyp_chromium on a Chromium checkout with src/third_party/webrtc replaced by a mount like this:
cd /path/to/chromium/src
sudo mount --bind /path/to/webrtc/trunk/webrtc third_party/webrtc
Review URL: https://webrtc-codereview.appspot.com/23589004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7150 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 09:22:13 +00:00
bjornv@webrtc.org
8dd60cc855
audio_processing_unittests: Enabled ApmTest.Process for all platforms but Android
...
During porting some neon optimizations to sse2 the ApmTest.Process failed despite bit exact outputs. The reason is that with float data between component, as to previously truncating to int, we get small deviations in logged metrics. This affected a noise probability to a small fraction, which is not a particular bug.
This CL change the comparison from EXPECT_EQ() to EXPECT_NEAR() which then as a result makes the test run on Mac and Windows as well.
For int values a deviation of 1 is acceptable, which would include any rounding errors.
For float values a deviation of 0.0005 is chosen by looking at current test stats for the affected platforms/optimizations.
BUG=114
TESTED=locally on linux with and without sse2 optimizations and trybots
R=aluebs@webrtc.org , andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/20289004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7149 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 08:36:35 +00:00
sprang@webrtc.org
c665dcb205
Revert 7145 "Stop building talk/sound since it is no longer used."
...
> Stop building talk/sound since it is no longer used.
>
> BUG=N/A
> R=pbos@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/22319004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/22619004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7148 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 08:29:53 +00:00
minyue@webrtc.org
2b58a4433f
Calculating round-trip-time in send-only channel in VoE.
...
TESTS=built chromium and tested with 1:1 hangout call
BUG=
R=stefan@webrtc.org , xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/23489004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7147 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 07:51:53 +00:00
henrik.lundin@webrtc.org
1972ff8a6e
Mark all virtual overrides in the hierarchy of Module as virtual and OVERRIDE.
...
This will make a subsequent change I intend to do safer, where I'll change the
return type of one of the base Module functions, by breaking the compile if I
miss any overrides.
This also highlighted a number of unused functions (in many cases apparently
virtual "overrides" of no-longer-existent base functions). I've removed some of
these.
This also highlighted several cases where "virtual" was used unnecessarily to
mark a function that was only defined in one class. Removed "virtual" in those
cases.
BUG=none
TEST=none
R=andrew@webrtc.org , henrik.lundin@webrtc.org , mallinath@webrtc.org , mflodman@webrtc.org , stefan@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24419004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7146 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 06:20:28 +00:00
henrike@webrtc.org
4c876453c8
Stop building talk/sound since it is no longer used.
...
BUG=N/A
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/22319004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7145 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 22:18:04 +00:00
henrike@webrtc.org
47658f1269
Mark all virtual overrides in the hierarchy of AudioPacketizationCallback,
...
RTPStream, and NetEq as such. Also mark all other virtual overrides in the same
files.
This will make further changes to these classes safer by ensuring that the
compile breaks if the base class changes and not all overrides are fixed.
This also deletes ACMTest.cc, which existed solely to define ~ACMTest(), which
was marked pure virtual in the header. (Pure virtual destructors still need a
definition.) Because there is another pure virtual method in this class, the
class is already abstract, so there's no benefit to making the desturctor pure.
Making it non-pure allows removing the separate source file.
BUG=none
TEST=none
R=henrik.lundin@webrtc.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29389004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7144 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 22:14:59 +00:00
henrike@webrtc.org
1711104b8a
Fix MSVC warnings about value truncations, webrtc/base/ edition.
...
BUG=chromium:81439
TEST=none
R=henrike@webrtc.org , marpan@google.com
Review URL: https://webrtc-codereview.appspot.com/20249004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7143 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 22:10:24 +00:00
glaznev@webrtc.org
3472dcd7b0
Fix frame rate selection for Android camera.
...
- Android camera supports multiple fps values for a single video
resolution - change video source default video format selection
to pick up best available fps.
- Change fps range calculation to better match target fps value.
BUG=2622
R=tkchin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15339004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7142 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 19:24:57 +00:00
tpsiaki@google.com
67eabc0938
Add schannel webrtc_base build using a new use_schannel gyp variable.
...
R=henrike@webrtc.org , thorcarpenter@google.com
Review URL: https://webrtc-codereview.appspot.com/28409004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7141 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 18:06:47 +00:00
henrike@webrtc.org
b2efb6771c
Put base tests in webrtc_tests.gyp
...
BUG=N/A
R=andrew@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14249004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7140 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 17:28:19 +00:00
kjellander@webrtc.org
a8d2ee7f3b
Roll chromium_revision ea769fd..6455c69 (re-land)
...
Mainly to pick up https://codereview.chromium.org/552013004
Summary of changes (git diff ea769fd..6455c69 DEPS):
* third_party/libvpx ceebbcc0..d95585f
* third_party/swarming e7d8b98..14b5fd82
* tools/gyp 1972:1973
TBR=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/22349004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7139 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 16:51:37 +00:00
jiayl@webrtc.org
b6d69282f5
Enable shared socket for TurnPort.
...
In AllocationSequence::OnReadPacket, we now hand the packet to both the TurnPort and StunPort if the remote address matches the server address.
TESTED=AppRtc loopback call generates both turn and stun candidates.
BUG=1746
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19189004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7138 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 16:31:34 +00:00
brettw@chromium.org
0867f69cc6
Convert GN visibility to be lists.
...
This is a followup to my previous patch that missed this case.
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24529004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7137 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 16:24:11 +00:00
pbos@webrtc.org
5c20bb27a0
Remove suppressions for VideoFrame::Validate.
...
BUG=3789
R=sprang@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24549004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7136 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 14:59:09 +00:00
andresp@webrtc.org
33aa095896
Simplify gyp rules on video_render_module.
...
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/28439004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7135 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 14:48:48 +00:00
houssainy@google.com
e0761d06b0
Fix printing of error stack in rtcbot when a test fails via test.fail().
...
R=andresp@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/28449004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7134 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 14:35:35 +00:00
kjellander@webrtc.org
49fa212bcd
Fix compile error on JDK 1.7.
...
JDK 1.7 gives an error like this:
warning: [static] static method should be qualified by type name
R=pbos@webrtc.org
TBR=henrike@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/29399004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7133 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 12:35:59 +00:00
pbos@webrtc.org
0fa04755af
Roll gtest-parallel.
...
Brings in change that eliminates Queues which shows significant speed
improvement for huge work lists.
R=andrew@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/26409004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7132 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 09:29:12 +00:00
henrik.lundin@webrtc.org
23a5e3c3b0
Remove DestructEncoderInst and its codec-specific implementations.
...
This method is seemingly never called.
BUG=none
TEST=none
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24539004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7131 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 08:52:26 +00:00
kjellander@webrtc.org
a2e6a52563
Revert 7128 "Roll chromium_revision ea769fd..6455c69"
...
> Roll chromium_revision ea769fd..6455c69
>
> Mainly to pick up https://codereview.chromium.org/552013004
>
> Summary of changes (git diff ea769fd..6455c69 DEPS):
> * third_party/libvpx ceebbcc0..d95585f
> * third_party/swarming e7d8b98..14b5fd82
> * tools/gyp 1972:1973
>
> R=pbos@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/29379004
TBR=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27419004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7130 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 08:38:27 +00:00
buildbot@webrtc.org
5d639b3ef3
(Auto)update libjingle 75141932-> 75179475
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 07:57:12 +00:00
kjellander@webrtc.org
fdba9ee64a
Roll chromium_revision ea769fd..6455c69
...
Mainly to pick up https://codereview.chromium.org/552013004
Summary of changes (git diff ea769fd..6455c69 DEPS):
* third_party/libvpx ceebbcc0..d95585f
* third_party/swarming e7d8b98..14b5fd82
* tools/gyp 1972:1973
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29379004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7128 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 07:42:55 +00:00
andrew@webrtc.org
4ca66d691e
include cstdlib for free() and abort()
...
This previous CL added uses of free() and abort() without including cstdlib:
https://webrtc-codereview.appspot.com/22449004
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/23559004
Patch from Mostyn Bramley-Moore <mostynb@opera.com>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7127 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 03:24:36 +00:00
guoweis@webrtc.org
fa603981f2
Add a new class InterfaceAddress inherited from IPAddress to keep track of IPv6 Address flags.
...
Skeleton put in place in Network::GetFilterIPs() which will be used to
filter addresses
BUG=3773
R=jiayl@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/23439004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7126 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-09 23:42:40 +00:00
brettw@chromium.org
87ff9c8efa
Fix up configs applying to GN build.
...
The audio_processing target didn't have the build configs applying to it which led to some logging errors.
TBR=kjellander
Review URL: https://webrtc-codereview.appspot.com/22339004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7125 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-09 23:34:56 +00:00
jiayl@webrtc.org
7d4891d3f1
Fixes two issues in how we handle OfferToReceiveX for CreateOffer:
...
1. the options set in the first CreateOffer call should not affect the result of a second CreateOffer call, if SetLocalDescription is not called after the first CreateOffer. So the member var options_ of MediaStreamSignaling is removed to make each CreateOffer independent.
Instead, MediaSession is responsible to make sure that an m-line in the current local description is never removed from the newly created offer.
2. OfferToReceiveAudio used to default to true, i.e. always having m=audio line even if no audio track. This is changed so that by default m=audio is only added if there are any audio tracks.
BUG=2108
R=pthatcher@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=7068
Review URL: https://webrtc-codereview.appspot.com/16309004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7124 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-09 21:43:15 +00:00
fbarchard@google.com
a941970d4a
Change explicit static cast from int to uint16_t to implicit cast of 0u.
...
BUG=3663
TESTED=local windows build with VS2013.
R=harryjin@google.com , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/28389004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7123 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-09 21:37:27 +00:00
brettw@chromium.org
9fe11010f7
Fix the RTC+Chromium GN build.
...
LOGGING_INSIDE_WEBRTC was being set in the inherited config, whereas in the GYP build this define is not inherited. This caused duplicate logging macros to be defined in Chrome files dependening on WebRTC targets.
Move LOGGING_INSIDE_WEBRTC to the common config (non-inherited).
TBR=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/25449004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7122 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-09 19:15:33 +00:00
fbarchard@google.com
54cf1505e2
ValidateFrame, When dumping the first 4 samples of a frame, first copy it to a temporary buffer that is zero padded, them use that.
...
BUG=3789
TESTED=drmemory out\Debug\libjingle_media_unittest.exe --gtest_catch_exceptions=0 --gtest_filter=*Validate*
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24499004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7121 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-09 18:34:53 +00:00
jiayl@webrtc.org
22406fcc9b
TurnPort should retry allocation with a new address on error STUN_ERROR_ALLOCATION_MISMATCH.
...
BUG=3570
R=juberti@webrtc.org , mallinath@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=7070
Review URL: https://webrtc-codereview.appspot.com/20999004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7120 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-09 15:44:05 +00:00