Commit Graph

2888 Commits

Author SHA1 Message Date
mflodman@webrtc.org
7c894b7cc7 Wire up CallStats to provide modules with correct RTT.
BUG=769
TEST=Manual test since there is no ViE APi to get RTT for receive channels.

Review URL: https://webrtc-codereview.appspot.com/937027

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3163 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-26 12:40:15 +00:00
henrika@webrtc.org
5ba3decc94 Ensures that we can build using VS 2012 on Windows.
See more details at https://code.google.com/p/webrtc/issues/detail?id=1146&

TBR=Niklas
BUG=1146

Review URL: https://webrtc-codereview.appspot.com/939028

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3162 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-26 09:12:02 +00:00
tina.legrand@webrtc.org
221b11af22 Pulling Opus version 1.0.1 from Chromium
BUG=issue1055

Review URL: https://webrtc-codereview.appspot.com/933024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3161 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-26 08:20:44 +00:00
andrew@webrtc.org
c3e5d3422b Add a logging_no_op.cc when enable_tracing==0.
This should hopefully fix static initializer warnings when rolling webrtc
in Chromium.

TEST=logging_unittest succeeds with enable_tracing==1 and fails appropriately with enable_tracing==0.

Review URL: https://webrtc-codereview.appspot.com/939026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3159 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-23 19:30:59 +00:00
andrew@webrtc.org
418443c531 Remove operator overloading from RTPFragmentationHeader.
Instead supply a CopyFrom() method.

TEST=vie_auto_test

Review URL: https://webrtc-codereview.appspot.com/972004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3158 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-23 19:17:23 +00:00
stefan@webrtc.org
ad7f1fefad Fixes (or at least reduces) the flakiness in the full stack test by making sure the different frame monitors are registered and deregistered in the right order. Also makes sure only local preview frames which are actually transmitted are rendered by moving the local preview rendering to an effect filter.
BUG=

Review URL: https://webrtc-codereview.appspot.com/969005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3157 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-23 11:19:29 +00:00
kjellander@webrtc.org
6ba79a88e5 Condition for DirectX variable on Windows
The directx_sdk_path GYP variable got the value $(DXSDK_DIR) on non-windows platforms which is normally an uninitialized environment variable, causing an error during GYP generation.
Putting this include within a condition for Windows resolves this.

This was only triggered when GYP_GENERATORS=ninja and not for the default on Linux (make), so the bots haven't noticed this.

BUG=none
TEST=All default trybots passing. Successfully generating projects on Linux and Mac for make and ninja (plus XCode on Mac). Successful compile on Windows without DirectX SDK installed (but with files located in third_party/directxsdk/files).

Review URL: https://webrtc-codereview.appspot.com/936031

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3156 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-23 09:41:42 +00:00
phoglund@webrtc.org
849fb8ebd2 Removed codec comparison test: it didn't work and probably never will.
The central problem is that we cannot sync the frames in the input video with the output video, which makes PSNR/SSIM go crazy. The test only appeared to succeed earlier due to a bug in the test. We can consider this a failed experiment, but we did learn a lot from it :)

BUG=550

Review URL: https://webrtc-codereview.appspot.com/969006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3155 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-23 09:21:44 +00:00
phoglund@webrtc.org
e3b2bc6c40 Will now fix old src-relative paths so we go to webrtc/ paths.
We used to write paths relative to src, e.g. starting with video_engine/ etc, but now it should be webrtc/video_engine/. This script will now get that right.

BUG=

Review URL: https://webrtc-codereview.appspot.com/970006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3154 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-23 09:09:59 +00:00
kjellander@webrtc.org
97dcf36a7b Adding Direct X SDK include directory.
This makes it possible to keep a copy of the Direct X SDK in third_party/directxsdk/files and get it automatically used instead of having to install it manually on the system.

BUG=none
TEST=Compilation with SDK files in third_party/directxsdk/files  and uninstalled Direct X SDK on Windows.
Review URL: https://webrtc-codereview.appspot.com/937028

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3153 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-23 08:54:07 +00:00
mflodman@webrtc.org
087723bc4d Updated license path in LICENSE and LICENSE_THIRD_PARTY.
Review URL: https://webrtc-codereview.appspot.com/939025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3152 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-22 12:06:21 +00:00
mflodman@webrtc.org
f89fb9dbf0 Remove ViE lint warnings that should have been caught at upload time.
TEST=cpplint.py video_engine/*

Review URL: https://webrtc-codereview.appspot.com/964018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3151 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-22 09:41:42 +00:00
mflodman@webrtc.org
1c61196095 Removed not used include.
TEST=Compiles.

Review URL: https://webrtc-codereview.appspot.com/966025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3150 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-22 09:37:27 +00:00
andrew@webrtc.org
6e76ef430d Add third_party/winsdk_samples/src to gitignore.
TBR=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/929026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3149 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-21 23:28:40 +00:00
mikhal@webrtc.org
4c4d01dd3d Setting capture stride to width
Review URL: https://webrtc-codereview.appspot.com/935021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3148 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-21 22:18:32 +00:00
andrew@webrtc.org
4b97793f91 Ensure opus_demo has a targets block.
TBR=leozwang@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/933023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3147 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-21 20:16:53 +00:00
andrew@webrtc.org
8cd18c55b8 Add winsdk_samples to provide directshow_baseclasses.
Builds locally on Windows (and passes try), and a gyp run succeeds with
include_internal_video_capture=0. This should ensure it won't impact
Chromium.

Review URL: https://webrtc-codereview.appspot.com/937026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3146 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-21 18:46:45 +00:00
leozwang@webrtc.org
cfcadab8d4 Build opus_demo
BUG=1082
TEST=trybots

With this cl we can build opus_demo.
Review URL: https://webrtc-codereview.appspot.com/936029

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3144 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-21 18:13:46 +00:00
phoglund@webrtc.org
3ec52c0689 Adding mflodman's reformat script with some fixes.
BUG=

Review URL: https://webrtc-codereview.appspot.com/966024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3143 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-21 13:28:52 +00:00
phoglund@webrtc.org
b15d285458 Reformatted most of the CPU stuff in system_wrappers.
BUG=

Review URL: https://webrtc-codereview.appspot.com/930025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3142 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-21 08:02:57 +00:00
leozwang@webrtc.org
5835adfef0 Reorganize gyp for Android
BUG=1120
TEST=trybot, local test on xoom and nexus

Message:
It turned out the last CL can only build neon code that
caused problem on Xoom.

Description:
In order to support audo-cpu-detection, I split files into two gypi files, one
contains non-neon code, antoher one ONLY contains neon specific code, so I can
apply different flags to them. Also created two build targets for each of them

We build for linux as before.

Tested on xoom and nexus S.
Review URL: https://webrtc-codereview.appspot.com/930024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3141 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-21 04:10:16 +00:00
mikhal@webrtc.org
3263a7a616 Setting correct stride for VP8 encoder
BUG=1137

Review URL: https://webrtc-codereview.appspot.com/929024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3140 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-21 00:15:19 +00:00
mikhal@webrtc.org
32b3f40b6c Adding an aligned stride test to LibYuv
Review URL: https://webrtc-codereview.appspot.com/935020

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3139 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-20 23:52:50 +00:00
tommi@webrtc.org
8187877402 Reland 3135 - Previous failure was bot flakiness.
*****

Restructure the video_capture code a bit to make room for a Media Foundation class implementation.
This change includes the following:

* Skeleton classes for a couple of base MediaFoundation classes (no code yet).  See *_mf.*.
* Renaming the DirectShow based implementation from "_windows" to "_ds".
* Move the VideoCaptureImpl::CreateDeviceInfo() method into video_capture_factory_windows.cc
  The reason for this is that that's where the other VideoCaptureImpl factory function is
  and the factory function won't be implementation specific.
* Removed use of <initguid.h> from a header file to avoid defining the same guids in multiple object files.
  (more info here: http://msdn.microsoft.com/en-us/library/windows/desktop/dd375463(v=vs.85).aspx)
* Moved a couple of global variables from the capture_delay_values_windows.h header and into
  device_info_ds.cc since that's the only file that uses those variables.
* Delete capture_delay_values_windows.h.
* Added a factory function: DeviceInfoDS::Create() that'll create the DirectShow specific implementation.

TEST=This is mostly moving code around.  The code that is added, is currently "dead". No manual testing needed.
BUG=chromium:140545
Review URL: https://webrtc-codereview.appspot.com/967008

TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/934017

TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/934018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3137 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-20 13:35:33 +00:00
tommi@webrtc.org
951b6c404a Revert 3135 - This broke the Mac bots somehow. Here's the error:
[ RUN      ] ViEStandardIntegrationTest.RunsBaseTestWithoutErrors
2012-11-20 13:06:59.625 vie_auto_test[4001:f07] An uncaught exception was raised
2012-11-20 13:06:59.625 vie_auto_test[4001:f07] Error (1000) creating CGSWindow on line 259
2012-11-20 13:06:59.670 vie_auto_test[4001:f07] (
	0   CoreFoundation                      0x9a4e912b __raiseError + 219
	1   libobjc.A.dylib                     0x95ee252e objc_exception_throw + 230
	2   CoreFoundation                      0x9a448bbb +[NSException raise:format:] + 139
	3   AppKit                              0x996b4757 _NSCreateWindowWithOpaqueShape2 + 302
	4   AppKit                              0x996b2f40 -[NSWindow _commonAwake] + 1823
	5   AppKit                              0x9966fa77 -[NSWindow _commonInitFrame:styleMask:backing:defer:] + 1652
	6   AppKit                              0x9966eb3f -[NSWindow _initContent:styleMask:backing:defer:contentView:] + 1063
	7   AppKit                              0x9966e704 -[NSWindow initWithContentRect:styleMask:backing:defer:] + 70
	8   vie_auto_test                       0x0015c232 -[TestCocoaUi createWindows:] + 338
	9   libobjc.A.dylib                     0x95eef5d3 -[NSObject performSelector:withObject:] + 70
	10  Foundation                          0x969050c0 __NSThreadPerformPerform + 395
	11  CoreFoundation                      0x9a3bf66f __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 15
	12  CoreFoundation                      0x9a3bf099 __CFRunLoopDoSources0 + 233
	13  CoreFoundation                      0x9a3e4e46 __CFRunLoopRun + 934
	14  CoreFoundation                      0x9a3e463a CFRunLoopRunSpecific + 378
	15  CoreFoundation                      0x9a3e44ab CFRunLoopRunInMode + 123
	16  Foundation                          0x9690d946 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 278
	17  vie_auto_test                       0x002e490a main + 522
	18  vie_auto_test                       0x000b1835 start + 53

*****


Restructure the video_capture code a bit to make room for a Media Foundation class implementation.
This change includes the following:

* Skeleton classes for a couple of base MediaFoundation classes (no code yet).  See *_mf.*.
* Renaming the DirectShow based implementation from "_windows" to "_ds".
* Move the VideoCaptureImpl::CreateDeviceInfo() method into video_capture_factory_windows.cc
  The reason for this is that that's where the other VideoCaptureImpl factory function is
  and the factory function won't be implementation specific.
* Removed use of <initguid.h> from a header file to avoid defining the same guids in multiple object files.
  (more info here: http://msdn.microsoft.com/en-us/library/windows/desktop/dd375463(v=vs.85).aspx)
* Moved a couple of global variables from the capture_delay_values_windows.h header and into
  device_info_ds.cc since that's the only file that uses those variables.
* Delete capture_delay_values_windows.h.
* Added a factory function: DeviceInfoDS::Create() that'll create the DirectShow specific implementation.

TEST=This is mostly moving code around.  The code that is added, is currently "dead". No manual testing needed.
BUG=chromium:140545
Review URL: https://webrtc-codereview.appspot.com/967008

TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/934017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3136 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-20 12:17:05 +00:00
tommi@webrtc.org
704eb8fa15 Restructure the video_capture code a bit to make room for a Media Foundation class implementation.
This change includes the following:

* Skeleton classes for a couple of base MediaFoundation classes (no code yet).  See *_mf.*.
* Renaming the DirectShow based implementation from "_windows" to "_ds".
* Move the VideoCaptureImpl::CreateDeviceInfo() method into video_capture_factory_windows.cc
  The reason for this is that that's where the other VideoCaptureImpl factory function is
  and the factory function won't be implementation specific.
* Removed use of <initguid.h> from a header file to avoid defining the same guids in multiple object files.
  (more info here: http://msdn.microsoft.com/en-us/library/windows/desktop/dd375463(v=vs.85).aspx)
* Moved a couple of global variables from the capture_delay_values_windows.h header and into
  device_info_ds.cc since that's the only file that uses those variables.
* Delete capture_delay_values_windows.h.
* Added a factory function: DeviceInfoDS::Create() that'll create the DirectShow specific implementation.

TEST=This is mostly moving code around.  The code that is added, is currently "dead". No manual testing needed.
BUG=chromium:140545
Review URL: https://webrtc-codereview.appspot.com/967008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3135 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-20 11:27:25 +00:00
andrew@webrtc.org
655d8f56f6 Add a kTraceTerseInfo level for non-verbose logging.
Review URL: https://webrtc-codereview.appspot.com/937023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3134 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-20 07:34:45 +00:00
andrew@webrtc.org
2009f6b236 Add Chromium's perf_test to testsupport.
Review URL: https://webrtc-codereview.appspot.com/936027

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3133 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-20 00:20:20 +00:00
mikhal@webrtc.org
0f34fd7660 Updating Memory allocation for rotation and related tests.
Review URL: https://webrtc-codereview.appspot.com/943004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3132 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-19 21:15:35 +00:00
stefan@webrtc.org
467dfe0e7c Fix possible race condition and access into an empty list.
TBR=mflodman@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/939021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3131 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-19 11:49:37 +00:00
stefan@webrtc.org
4100b0402e Move SSRC list to RemoteBitrateEstimator.
BUG=1105

Review URL: https://webrtc-codereview.appspot.com/965027

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3130 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-19 10:09:20 +00:00
tina.legrand@webrtc.org
5ac387c4d1 Allow NetEQ to use real packet durations.
This is a copy of http://review.webrtc.org/864014/

This adds a FuncDurationEst to each codec instance which estimates
the duration of a packet given the packet contents and the duration
of the previous packet. By default, this simply returns the
duration of the previous packet (which is what is currently assumed
to be the duration of all future packets). This patch also provides
an initial implementation of this function for G.711 which returns
the actual number of samples in the packet.

BUG=issue1015

Review URL: https://webrtc-codereview.appspot.com/935016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3129 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-19 08:02:55 +00:00
kjellander@webrtc.org
3662aa38f3 Revert 3123 - Roll to libyuv r496 for Android x86 fix by avoiding stdint.h
BUG=none
TEST=none
Review URL: https://webrtc-codereview.appspot.com/931012

TBR=fbarchard@google.com
Review URL: https://webrtc-codereview.appspot.com/933020

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3128 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-19 07:03:34 +00:00
wjia@webrtc.org
815653bfa4 Use cpu_features library from ndk when built with chromium.
In Chromium on Andorid, nkd provides cpu_features library so that all modules using that library can link against it to avoid function re-definition.
Review URL: https://webrtc-codereview.appspot.com/937024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3127 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-19 04:04:10 +00:00
wjia@webrtc.org
5c38d909b3 Define enable_android_opensl when built with chromium.
Review URL: https://webrtc-codereview.appspot.com/930023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3126 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-19 01:41:59 +00:00
henrike@webrtc.org
de727ab260 Fixes http://code.google.com/p/webrtc/issues/detail?id=941
BUG=941

Review URL: https://webrtc-codereview.appspot.com/966020

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3125 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-18 18:49:13 +00:00
kma@webrtc.org
55cd78cfc2 Porting ARM optimization from Android to ios.
Tested APM and iSAC in Android. Bit-exact with original versions.
Changes include removing or changing some GCC derivatives (e.g. .fnstart, .hword), instruction syntax, etc.
Review URL: https://webrtc-codereview.appspot.com/934009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3124 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-17 00:22:46 +00:00
fbarchard@google.com
2ec58dc4d1 Roll to libyuv r496 for Android x86 fix by avoiding stdint.h
BUG=none
TEST=none
Review URL: https://webrtc-codereview.appspot.com/931012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3123 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-17 00:14:47 +00:00
niklas.enbom@webrtc.org
c79505f95e Add warning comment
Review URL: https://webrtc-codereview.appspot.com/933012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3122 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-16 22:46:36 +00:00
andrew@webrtc.org
73814961a2 Add a variable for the libvpx path.
Review URL: https://webrtc-codereview.appspot.com/967007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3119 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-16 17:32:00 +00:00
tina.legrand@webrtc.org
d0acdf6e2b Fix ordered comparison warnings in the RTPtimeshift unit test
Original CL uploaded here: http://review.webrtc.org/933013/

Removing the checks if (argv[4/5] >= 0), they are not doing anything useful.

BUG=

Review URL: https://webrtc-codereview.appspot.com/933019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3118 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-16 15:34:32 +00:00
mflodman@webrtc.org
b2f474e8bb Adding ViE CallStats to keep track of call statistics. As a start, only rtt is handled.
This CL will be followed by another CL connecting the dots.

BUG=769
TEST=New unittest added.

Review URL: https://webrtc-codereview.appspot.com/968006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3117 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-16 13:57:26 +00:00
mflodman@webrtc.org
c289f9f209 Replaced remb unittest sleep with fake clock.
Review URL: https://webrtc-codereview.appspot.com/935015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3116 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-16 13:24:18 +00:00
tommi@webrtc.org
21b426d2da Revert 3111 (revert of a revert).
The trybots are succeeding and the modified code shouldn't
affect the test that failed so I suspect it was a fluke.
If this fails, I'll revert my revert so that we can
revert while we revert.
---
Revert 3105 - Don't crash the unit test host when tests fail.
Instead, just report the error, fail, and move on.

TEST=Run vie_auto_test, option=1.
    On my machine most of the tests fail for some reason
    that I'm still investigating, but the tests shouldn't
    be crashing the process which is what I'm fixing here.
Review URL: https://webrtc-codereview.appspot.com/929019

TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/936026

TBR=mikhal@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/966021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3115 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-16 09:37:08 +00:00
tommi@webrtc.org
12773eaa8c Minor cleanup of the videocapture code. No "real" code change :)
Remove declaration of a function that doesn't exist.
Remove call to GetProductId from video_capture_factory_windows that's not necessary.
This was the only dependency on device_info_windows.h outside of video_capture_windows.cc.

TEST=There's no code change, so no manual testing is required.
BUG=none
Review URL: https://webrtc-codereview.appspot.com/936025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3114 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-16 09:03:12 +00:00
marpan@webrtc.org
d14ff54de2 Removed unnecessary lines in one of the tests and changed one parameter.
Review URL: https://webrtc-codereview.appspot.com/933018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3113 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-16 01:17:00 +00:00
mikhal@webrtc.org
01c4b98f90 Revert 3105 - Don't crash the unit test host when tests fail.
Instead, just report the error, fail, and move on.

TEST=Run vie_auto_test, option=1.
    On my machine most of the tests fail for some reason
    that I'm still investigating, but the tests shouldn't
    be crashing the process which is what I'm fixing here.
Review URL: https://webrtc-codereview.appspot.com/929019

TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/936026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3111 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-15 23:38:27 +00:00
fischman@webrtc.org
37ff69d608 Point codereview.settings at the newly-created webrtc-reviews google group.
https://groups.google.com/a/webrtc.org/forum/?#!forum/webrtc-reviews

Review URL: https://webrtc-codereview.appspot.com/934016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3109 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-15 22:21:20 +00:00
andrew@webrtc.org
d72b3d6c81 Fix cpplint errors in audio_processing.h
TBR=leozwang@webrtc.org
BUG=1114

Review URL: https://webrtc-codereview.appspot.com/934015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3108 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-15 21:46:06 +00:00
leozwang@webrtc.org
f3adba499e Add Android include path so that header files can follow google style
BUG=1011
TEST=bot
Review URL: https://webrtc-codereview.appspot.com/930018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3107 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-15 18:17:40 +00:00