not per interface. This simplifies things a bit, reduces code and makes it
possible to implement reference counting (if we ever want) without the
static Delete() method. (Reference counted objects are traditionally
implicitly deleted via the last Release())
* Since the reference counting code is now simpler, there's no need for the
RefCount class so I'm removing it.
* Also removing the optional |ignoreRefCounters| variable from the VoiceEngine::Delete
method. The justification is that it's no longer used and the reason it was there
in the first place was to avoid bugs in third party code, so it's an indication that
something is wrong elsewhere.
* Fix a crash in voe_network_impl and voe_extended_test that would happen on machines with IPv6 support.
* Fix an assert (handle the case) in the extended audio tests when SetCNAME is called with a NULL pointer.
* As a side effect of this change, hopefully the footprint of VoE will be slightly smaller :)
BUG=10445 (Coverity)
Review URL: https://webrtc-codereview.appspot.com/521003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2127 4adac7df-926f-26a2-2b94-8c16560cd09d
This is a fix for coverity issues: 10446, 10445, 10444, 10443.
Although the cl is rather big, there aren't many code changes:
* Instead of an implicit vtable pointer, there is now an explicit |_data| member to access the shared data.
* We don't access the member variables of SharedData directly. There are accessors instead.
* SharedData setters that set values that must be freed, automatically free the previous value and 'addref' if required the new one.
* Lots and lots of 'rewrapping' due to search/replace after the above changes.
BUG=10446, 10445, 10444, 10443
TEST=Run all tests for VoE.
Review URL: https://webrtc-codereview.appspot.com/472009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1987 4adac7df-926f-26a2-2b94-8c16560cd09d
class VoEAudioProcessing
-API renaming:
SetEchoMetricsStatus() to SetEcMetricsStatus()
GetEchoMetricsStatus() to GetEcMetricsStatus()
since delay logging is not strictly an echo metric.
-New API:
GetEcDelayMetrics()
-Implementations
--SetEcMetricsStatus() sets same status to all EC related metrics, currently Echo Metrics and Delay Logging.
--GetEcMetricsStatus() gets an error if all EC related metrics don't have the same status.
--GetEcDelayMetrics() gets the median and standard deviation of AEC internal delay (on a block by block basis).
class VoECallReport
The changes above leads to changes in the Call Report.
-New API:
GetEcDelaySummary()
-API updates:
ResetCallReportStatistics()
WriteReportToFile()
auto_tests updates:
-Standard test, with new Call Report calls and APM calls
-Extended test, with new Call Report calls and APM calls
Review URL: http://webrtc-codereview.appspot.com/187004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@754 4adac7df-926f-26a2-2b94-8c16560cd09d
