jiayl@webrtc.org
9f8164c060
Fix two bugs in DataChannel state transition.
...
1. OnStateChange should not be fired if state is not changed.
2. RemotePeerRequestClose should be a no-op if it's already closed.
TBR=pthatcher@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/21559004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6290 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-30 21:53:17 +00:00
buildbot@webrtc.org
1678db9df6
(Auto)update libjingle 68230113-> 68244456
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6287 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-30 14:02:09 +00:00
buildbot@webrtc.org
540a2251aa
(Auto)update libjingle 68230011-> 68230113
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6281 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-30 07:40:35 +00:00
pbos@webrtc.org
35efb839ed
Implement new-API test RecvStreamWithoutRtx.
...
R=pthatcher@google.com , pthatcher@webrtc.org
BUG=1788
Review URL: https://webrtc-codereview.appspot.com/20449005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6280 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-30 07:40:04 +00:00
pbos@webrtc.org
c34bb3a886
Log default receive stream creation.
...
Log when receiving a packet that doesn't have a receiver, this way you
can tell from logs where the AddRecvStream call came from.
R=pthatcher@google.com , pthatcher@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/17459004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6279 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-30 07:38:43 +00:00
pbos@webrtc.org
198647473b
Implement and fix new-API NackIsEnabled test.
...
Required enabling NACK on receiver side which was apparently missed.
BUG=1788
R=pthatcher@google.com , pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/16499007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6278 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-30 07:35:47 +00:00
buildbot@webrtc.org
1d66be22c8
(Auto)update libjingle 68203780-> 68206793
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6277 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-29 22:54:24 +00:00
jiayl@webrtc.org
8dcd43c4f7
Make MediaSessionDescriptionFactory accept offers with UDP/TLS/RTP/SAVPF.
...
This is the first step toward switching completely to UDP/TLS/RTP/SAVPF.
BUG=2796
R=juberti@webrtc.org , pthatcher@google.com
Review URL: https://webrtc-codereview.appspot.com/13439004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6276 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-29 22:07:59 +00:00
fischman@webrtc.org
abe01dd634
AppRTCDemo(android): run in full-screen & immersive mode.
...
Also:
- Only show stats HUD on demand
- Only collect stats when HUD is showing
- Don't render solid green frame when video is not present in either direction
R=glaznev@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12639004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6275 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-29 21:46:52 +00:00
jiayl@webrtc.org
5dc51fbe50
Closes the DataChannel when the send buffer is full or on transport errors.
...
As stated in the spec.
BUG=2645
R=pthatcher@google.com , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12619004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6270 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-29 15:33:54 +00:00
jiayl@webrtc.org
001fd2d503
Fire OnRenegotiationNeeded only for the first SCTP DataChannel.
...
Subsequent DataChannels do not need renegotiation since SCTP data streams are not negotiated through SDP.
BUG=2431
R=pthatcher@google.com , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12629004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6268 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-29 15:31:11 +00:00
fischman@webrtc.org
43a1395370
AppRTCDemo(android): README updates for a shrinking envsetup.sh world.
...
There was duplicated (and out of date!) information in README relative to
getting-started so de-duped to point to getting-started as the canonical
reference.
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15589006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6265 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-28 17:29:09 +00:00
jiayl@webrtc.org
b364016cbb
Revert r6161 "Drop the DataChannel message if it's received when the channel is not open."
...
The spec does not say the DataChannel has to be open to receive a message.
TBR=pthatcher@google.com
BUG=crbug/363005
Review URL: https://webrtc-codereview.appspot.com/16569004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6264 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-28 16:37:25 +00:00
phoglund@webrtc.org
f666ecc60d
Disabling flaky libjingle tests after fixit week.
...
BUG=webrtc:3316,webrtc:3317,webrtc:3318
TBR=fischman@google.com
Review URL: https://webrtc-codereview.appspot.com/12569004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6250 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-27 08:08:00 +00:00
buildbot@webrtc.org
727ff69829
(Auto)update libjingle 67872893-> 67873348
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6244 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-23 23:20:53 +00:00
buildbot@webrtc.org
75cb3dc5f2
(Auto)update libjingle 67869540-> 67872893
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6243 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-23 23:13:35 +00:00
mallinath@webrtc.org
b445f26f24
Fixing correct UMA metric for PeerConnection enabled with IPv4 Vs IPv6.
...
BUG=N/A
TBR=jiayl@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21499007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6242 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-23 22:19:37 +00:00
fischman@webrtc.org
39eccefbde
Disable ChannelManagerTest.StartupShutdownOnUnstartedThread
...
The test is testing a scenario that shouldn't happen.
BUG=3388
TBR=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21509005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6238 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-23 17:50:38 +00:00
buildbot@webrtc.org
7aa1a4767f
(Auto)update libjingle 67848628-> 67848776
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6237 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-23 17:33:05 +00:00
fischman@webrtc.org
e5063b1733
Thread: delete racy API (Release()) and fix racy code (started()).
...
- Thread::Release() wrote a local variable on the calling thread but read it on
another thread, with no synchronization. Happily it has no non-test callers
so deleting it instead of trying to fix it (see bug for details).
- Thread::started_ similarly was racily being written to; replaced with a
running_ Event, and hid the accessor except for tests & legacy callers,
with a note about why it's a bad idea.
webrtc/base patched with:
git diff origin --relative=talk/base | patch -p1 -dwebrtc/base
followed by manual merge of 3 thunks that ran afoul of naming differences
between talk/base and webrtc/base.
BUG=3388
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14589005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6236 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-23 17:28:50 +00:00
fischman@webrtc.org
18f41b8eb4
PRESUBMIT.py: accept variants on the copyright message that are present in the codebase.
...
Example files that this makes ok instead of flagging include:
talk/base/signalthread_unittest.cc
talk/base/thread_unittest.cc
webrtc/base/signalthread_unittest.cc
webrtc/base/thread.cc
webrtc/base/thread.h
webrtc/base/thread_unittest.cc
BUG=1027
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19539006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6235 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-23 17:27:18 +00:00
pbos@webrtc.org
706152dcc9
Fix uninitialized reads in IsDefaultBrowserFirefox
...
BUG=
TEST=Local DrMemory.
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19529006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6232 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-23 14:35:48 +00:00
mallinath@webrtc.org
8e755c1ad2
Connect SignalDestroyed in AllocationSequence after TURN ports are destroyed
...
when TURN ports are using shared socket with UDP port.
This is required as AllocationSequence maintains a map of turn ports. If the
ports are destroyed without the knowledge of AllocationSequence, sequence will
try to deliver packets to the destoyed ports.
R=jiayl@webrtc.org
BUG=https://code.google.com/p/chromium/issues/detail?id=368877
Review URL: https://webrtc-codereview.appspot.com/14569007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6219 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 23:00:46 +00:00
buildbot@webrtc.org
f9f1bfbdae
(Auto)update libjingle 67686255-> 67689476
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6216 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 17:02:15 +00:00
buildbot@webrtc.org
ce4201df52
(Auto)update libjingle 67643194-> 67686255
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6214 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 16:22:51 +00:00
henrike@webrtc.org
000658a138
Revert of 6211 as it was committed despite of PRESUBMIT.py warning. The commit breaks the sync bot.
...
BUG=N/A
TBR=mcasas@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21519006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6212 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 16:01:13 +00:00
mcasas@webrtc.org
3b7e282caa
Disabling systematically failing
...
WebRtcVideoMediaChannelTest.SendVp8HdAndReceiveAdaptedVp8Vga
TBR= pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14569006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6211 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 14:25:20 +00:00
buildbot@webrtc.org
49a6a27bf0
(Auto)update libjingle 67555838-> 67643194
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6206 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 00:24:54 +00:00
tkchin@webrtc.org
1732a591e7
Add a UIView for rendering a video track.
...
RTCEAGLVideoView provides functionality to render a supplied RTCVideoTrack using OpenGLES2.
R=fischman@webrtc.org
BUG=3188
Review URL: https://webrtc-codereview.appspot.com/12489004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6192 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-19 23:26:01 +00:00
fischman@webrtc.org
40bc7779aa
talk_base: remove lock inversion between MessageQueue and MessageQueueManager.
...
Removes the concept of a MessageQueue being "active" in favor of considering all
live MQ's to be active.
(previously a MQ was active starting from the first Post to it and stopped being
active in its dtor).
BUG=3230
R=sriniv@google.com
Review URL: https://webrtc-codereview.appspot.com/21489004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6190 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-19 17:58:04 +00:00
wu@webrtc.org
cb711f77d2
Add interface to propagate audio capture timestamp to the renderer.
...
BUG=3111
R=andrew@webrtc.org , turaj@webrtc.org , xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12239004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6189 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-19 17:39:11 +00:00
pbos@webrtc.org
1e019d10b8
Fix delivery error-checking missed in r6151.
...
Gets rid of quite a bit of false-warning logging in WebRtcVideoEngine2.
BUG=3228
R=perkj@webrtc.org
TBR=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/16529004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6183 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-16 11:38:45 +00:00
buildbot@webrtc.org
6bfd6196ff
(Auto)update libjingle 67052073-> 67134648
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6174 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-15 16:15:59 +00:00
mallinath@webrtc.org
bb6201ae4b
TCP remote socket address should have both server hostname and IP address.
...
Hostname is necessary when we are creating TLS based socket, for certificate
verification.
BUG=https://code.google.com/p/chromium/issues/detail?id=306285
R=jiayl@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19489004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6165 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 22:43:05 +00:00
fischman@webrtc.org
a150bc9bbf
PeerConnection(android): allow initializing either (or neither) of {Voice,Video}Engine.
...
Enables applications that don't want to pay the init/startup cost or request
extra permissions (e.g. audio-only app, or DataChannel-only app).
BUG=3234
Review URL: https://webrtc-codereview.appspot.com/15489004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6164 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 22:00:50 +00:00
buildbot@webrtc.org
ef5a752c29
(Auto)update libjingle 67043374-> 67044055
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6163 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 21:35:19 +00:00
buildbot@webrtc.org
3e924683d4
(Auto)update libjingle 67037200-> 67043374
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6162 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 21:29:04 +00:00
jiayl@webrtc.org
4f5801494d
Drop the DataChannel message if it's received when the channel is not open.
...
It may happen when the JS has closed the channel on the signaling thread while messages are received on the worker thread and posted before the state change is pushed to the worker thread.
BUG=crbug/363005
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19469005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6161 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 20:32:35 +00:00
buildbot@webrtc.org
372701a872
(Auto)update libjingle 67023528-> 67036361
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6160 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 20:27:59 +00:00
buildbot@webrtc.org
688ed699e0
(Auto)update libjingle 67017551-> 67023528
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6158 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 18:26:09 +00:00
fischman@webrtc.org
2c98af7935
PeerConnection(Java): auto-WrapCurrentThread() when creating PeerConnectionFactory.
...
Various pieces of talk/ assume that the current Thread is ThreadManager'd
without checking this, so unconditionally wrap the caller's thread in case it
was created by Java code unbeknownst to ThreadManager.
BUG=2947
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/9419004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6154 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 17:33:32 +00:00
pbos@webrtc.org
4e545cc244
Update webrtcvideoengine2.cc to use DeliveryStatus.
...
talk/ changes corresponding to https://review.webrtc.org/12289005/ .
BUG=3228
R=perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6151 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 13:58:13 +00:00
andresp@webrtc.org
581e2172af
Fix libjingle to provide a field_trial implementation.
...
This completes https://webrtc-codereview.appspot.com/14489004/ by updating libjingle rules.
BUG=crbug/367114
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/20479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6149 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 13:12:45 +00:00
buildbot@webrtc.org
cd846dd374
(Auto)update libjingle 66924241-> 66927231
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6134 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 22:58:27 +00:00
buildbot@webrtc.org
da510c5de6
(Auto)update libjingle 66923202-> 66924241
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6132 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 22:30:56 +00:00
fischman@webrtc.org
d8af5b51c0
Deallocate the result of mach_host_self() when done with it, fixing a
...
port leak.
The port rights obtained by mach_host_self() and mach_thread_self() need
to be deallocated with mach_port_deallocate(). They consume finite
system-wide resources. This is in contrast to mach_task_self(), which is
a macro that wraps an extern global variable, and must not be
deallocated.
http://crbug.com/105513 shows the sorts of problems that can occur when
these aren't properly deallocated.
R=fischman@webrtc.org , tkchin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15469004
Patch from Mark Mentovai <mark@chromium.org>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6131 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 22:18:48 +00:00
buildbot@webrtc.org
c14f521b1b
(Auto)update libjingle 66887616-> 66900106
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6130 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:52:57 +00:00
buildbot@webrtc.org
3e01e0b16c
(Auto)update libjingle 66867790-> 66887616
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6128 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 17:54:10 +00:00
pbos@webrtc.org
b5a22b1464
Revert r6110 and r6109.
...
Effectively re-landing r6104 as well as r6108 which includes a fix to a
compile error that caused r6104 to be reverted in r6110.
BUG=
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/20459004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6119 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 11:07:01 +00:00
buildbot@webrtc.org
eaf2bd916b
(Auto)update libjingle 66813165-> 66836233
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6113 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 23:12:19 +00:00