Commit Graph

604 Commits

Author SHA1 Message Date
tommi@webrtc.org
73f98aebc6 Temporarily switch the numeric locale formatting to 'classic' while we process the signaling message.
This is to avoid running into problems with jsoncpp and parts of libjingle
where we use STL and CRT routines that refer to the global locale for formatting.
If the current locale is e.g. Spanish, then numbers will be formatted as "12,34"
and not "12.34" as some parts (not all) of jsoncpp expect.

Code I noticed where we might run into this is here (but it's likely that there are
more places):

third_party\libjingle\source\talk\p2p\base\candidate.h (preference_str)
third_party_mods\libjingle\source\talk\app\webrtc\webrtc_json.cc
third_party\jsoncpp\src\lib_json\*writer*
third_party\jsoncpp\src\lib_json\*reader*

BUG=69
TEST=Verify that the signaling messages always contain numbers formatted as "1.23" and never "1,23" even though the regional settings on the machine specify otherwise (e.g. try setting it to Spanish).
Review URL: http://webrtc-codereview.appspot.com/140007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@564 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-08 17:46:46 +00:00
stefan@webrtc.org
06e2c11703 Remove unintentional printfs
Review URL: http://webrtc-codereview.appspot.com/131018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@563 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-08 13:16:24 +00:00
stefan@webrtc.org
167328eab6 Disable libvpx partitions code for libvpx versions prior Cayuga.
Necessary for WebRTC to build with Chromium. 
Also fixes the decoder wrapper's Reset() function so that properly
reinitializes the decoder.
Review URL: http://webrtc-codereview.appspot.com/132012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@562 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-08 13:05:48 +00:00
stefan@webrtc.org
9e812fca9f Adding missing parts related to VP8 partitions
Review URL: http://webrtc-codereview.appspot.com/131017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@561 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-08 10:11:24 +00:00
stefan@webrtc.org
42ab82bf2f Disable independent partitions by default.
Review URL: http://webrtc-codereview.appspot.com/140006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@559 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-08 06:55:29 +00:00
stefan@webrtc.org
c3d891059e Adds support for VP8 partitions
This change adds support for VP8 partitions in the video jitter buffer and 
the VP8 encoder and decoder wrappers. The feature is currently disabled by
default since it requires a later version of libvpx.

With this change the jitter buffer will also start keeping track of each
packet header until decoding, and the VCMSessionInfo and VCMPacket objects 
will keep pointers into the encoded frame buffers.
Review URL: http://webrtc-codereview.appspot.com/137021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@558 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-08 06:50:28 +00:00
kma@google.com
b6fc9f1d6f optimized one spl function for AECM.
AECM test results bit-exact.
Review URL: http://webrtc-codereview.appspot.com/139012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@556 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-07 17:20:49 +00:00
stefan@webrtc.org
3bbe41aad6 Add support for a numeric table id in DataLogs.
Useful when logging in modules which have multiple instances and the logs
should be separated into different tables.
Review URL: http://webrtc-codereview.appspot.com/132003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@555 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-07 15:31:03 +00:00
henrik.lundin@webrtc.org
dd07d5932a Let VP8 decoder handle NULL codecSpecificInfo
VP8Decoder::Decode() can now handle the case when
codecSpecificInfo is NULL. Previously, it would crash.

Review URL: http://webrtc-codereview.appspot.com/135015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@554 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-07 15:21:38 +00:00
henrik.lundin@webrtc.org
ea05973e68 Fixing VCM tests for VP8
Removing asserts since the PictureID (and other parameters)
is now piped through codecSpecific. Also made sure the VCM
send callbacks (test code) copies the appropriate paramters.
Finally, enabling I420 in tests.

Review URL: http://webrtc-codereview.appspot.com/137022

git-svn-id: http://webrtc.googlecode.com/svn/trunk@553 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-07 15:20:17 +00:00
henrika@google.com
73d65513f1 Adds reference counting to the ADM.
This CL modifies the ADM interface to ensure that an external ADM
can't call Create and Destroy any longer.

It also contains some minor style nits to conform better with
the Chromium style guide.
Review URL: http://webrtc-codereview.appspot.com/133014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@552 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-07 15:11:18 +00:00
tommi@webrtc.org
a027bed377 Handle a null local renderer for times when there's no local cam.
Review URL: http://webrtc-codereview.appspot.com/138015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@545 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-07 09:52:45 +00:00
mflodman@webrtc.org
436289f622 Quick fix so ViE autotest doesn't terminate Linux windows twice on exit.
Review URL: http://webrtc-codereview.appspot.com/131016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@544 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-07 08:41:57 +00:00
perkj@webrtc.org
2d9af90116 Fix error when building Peerconnection in Chrome.
The error is due to wrong include path.
Review URL: http://webrtc-codereview.appspot.com/139016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@543 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-07 08:35:36 +00:00
perkj@google.com
e5ea75254f New Peerconnection manager implementation. Ready for review.
Review URL: http://webrtc-codereview.appspot.com/134004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@540 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-07 07:25:56 +00:00
andrew@webrtc.org
b44172dab9 Fix "braces recommended" warning in audio_conference_mixer.
Review URL: http://webrtc-codereview.appspot.com/131014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@539 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-06 18:04:32 +00:00
andrew@webrtc.org
f6478958a4 Fix "ignoring return value" in ViE tests.
Review URL: http://webrtc-codereview.appspot.com/133016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@538 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-06 16:46:25 +00:00
andrew@webrtc.org
e4c4d4f0e9 Fix "unused variable" warning in release mode.
Review URL: http://webrtc-codereview.appspot.com/131015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@537 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-06 16:31:55 +00:00
mflodman@webrtc.org
c547ed99d4 Remove ViE auto test build warning.
Review URL: http://webrtc-codereview.appspot.com/138018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@536 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-06 15:49:34 +00:00
andrew@webrtc.org
00a3ec5f1b Roll chromium 95033:98568.
Update to current dev branch revision, to remove unneeded warning noise in the Mac clang build.
Review URL: http://webrtc-codereview.appspot.com/133015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@535 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-06 15:37:20 +00:00
mflodman@webrtc.org
b69bb56741 Remove 'using namespace' from ViE autotest files.
Review URL: http://webrtc-codereview.appspot.com/138017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@534 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-06 14:12:07 +00:00
perkj@google.com
ac75cab618 Fix reference counting assert.
Change assert("teo") to assert(!"teo") so that the assert is actually triggered.
Review URL: http://webrtc-codereview.appspot.com/133018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@533 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-06 13:58:34 +00:00
henrik.lundin@webrtc.org
b361f3e19f Modify codereview.settings
Commented out lines with unassigned values. These prevented git_cl
from being used.

Review URL: http://webrtc-codereview.appspot.com/135012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@532 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-06 10:12:28 +00:00
stefan@webrtc.org
269f8a14c6 Undoing change committed in r514 since it broke bandwidth estimation
Review URL: http://webrtc-codereview.appspot.com/132011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@531 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-06 09:51:59 +00:00
andrew@webrtc.org
e0ed8b26de Fix "return value unused" warnings in voe_cmd_test release mode.
Review URL: http://webrtc-codereview.appspot.com/140001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@530 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-06 02:36:17 +00:00
andrew@webrtc.org
b01a62385f Fix "braces recommended" warning in video_engine.
Review URL: http://webrtc-codereview.appspot.com/137019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@529 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-06 02:30:54 +00:00
xians@google.com
b875349537 fixing a bug in GetPlayoutDeviceName, previously it returns name as guid.
Bug=http://code.google.com/p/webrtc/issues/detail?id=77
Test=none
Review URL: http://webrtc-codereview.appspot.com/135011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@528 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-05 12:17:30 +00:00
perkj@google.com
ea72c34fb9 Temporary add dummy implementation to RefCountModule. The reason is so that ADM and VideoCapture implementations can change to refcounted versions before forcing them.
Review URL: http://webrtc-codereview.appspot.com/139014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@527 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-05 11:11:04 +00:00
henrik.lundin@webrtc.org
1e53166569 Fix VP8 tests
These are changes that make the VP8 tests work again after the
wrapper was updated. The codec specific info is now propagated
properly through the encoder callback and into the queue struct.

Also added an fclose to get rid of a valgrind warning.
Review URL: http://webrtc-codereview.appspot.com/138011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@526 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-05 07:23:33 +00:00
leozwang@google.com
9d23ba096d Make test app work on android
Review URL: http://webrtc-codereview.appspot.com/137014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@525 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-04 03:33:44 +00:00
zakkhoyt@google.com
fb298d3783 Modified path on speex lib
Review URL: http://webrtc-codereview.appspot.com/137018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@524 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 22:06:49 +00:00
andrew@webrtc.org
413b993166 Put some table size information in one place.
Motivated by fixing an unused variable warning in release mode.
Review URL: http://webrtc-codereview.appspot.com/132007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@523 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 22:03:56 +00:00
turajs@google.com
d7a41774ce header included twice.
Review URL: http://webrtc-codereview.appspot.com/139013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@522 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 20:52:47 +00:00
stefan@webrtc.org
eb74a371c9 Matlab scripts useful for parsing the output from DataLog
parseLog.m parses DataLog files.
maxUnwrap.m unwraps number sequences, useful for unwrapping e.g. 
RTP timestamp sequences and RTP sequence numbers.
Review URL: http://webrtc-codereview.appspot.com/135006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@521 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 13:24:38 +00:00
perkj@google.com
88a0da8fde Add ref_count.h to gyp file.
Review URL: http://webrtc-codereview.appspot.com/133013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@520 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 12:51:35 +00:00
perkj@google.com
9de5917776 Add an implementation of reference count to webrtc.
Used for instantiating objects of RefCountModule.
Review URL: http://webrtc-codereview.appspot.com/135009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@519 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 12:24:51 +00:00
henrik.lundin@webrtc.org
2641fd1d19 Remove warnings in vp8_test
Most modifications are either reordering of the initializers in constructors, removed unused variables, or comparison mismatches taken care of. A few other special cases are commented.
Review URL: http://webrtc-codereview.appspot.com/132008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@518 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 12:09:07 +00:00
perkj@google.com
ef04cf4b2e Adding reference counted version of the module interface.
The reason for this is that we would like to have reference counting on the modules you can register externally with ViE and VoE.
Currently we plan to use this on the ADM, VideoCapture module and VideoRenderModule.
Review URL: http://webrtc-codereview.appspot.com/138010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@517 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 09:47:28 +00:00
mflodman@webrtc.org
563f658013 Adding to wathclist.
Review URL: http://webrtc-codereview.appspot.com/139010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@516 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 07:41:05 +00:00
wu@webrtc.org
5a15ab9e36 Move the WebRtcDeviceManager and WebRtcMediaEngine to libjingle.
Review URL: http://webrtc-codereview.appspot.com/139009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@515 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-01 23:04:52 +00:00
andrew@webrtc.org
4d905f88c6 Fix clang warnings in rtp.
Review URL: http://webrtc-codereview.appspot.com/132006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@514 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-01 19:22:27 +00:00
andrew@webrtc.org
f1f93d822e Remove warning settings more stringent than Chromium's common.gypi.
Review URL: http://webrtc-codereview.appspot.com/131012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@513 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-01 17:57:44 +00:00
andrew@webrtc.org
a80d026517 Fix clang warnings in voice engine.
Review URL: http://webrtc-codereview.appspot.com/133008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@512 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-01 17:30:09 +00:00
andrew@webrtc.org
bbd8908664 Fix clang warnings in video coding.
Review URL: http://webrtc-codereview.appspot.com/138007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@511 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-01 17:30:01 +00:00
andrew@webrtc.org
49e58da5b1 Fix release mode "unused variable" warnings in peerconnection.
Review URL: http://webrtc-codereview.appspot.com/133010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@510 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-01 17:29:43 +00:00
andrew@webrtc.org
20f74285fb Temporarily switch to Chrome's hosted libvpx copy.
Review URL: http://webrtc-codereview.appspot.com/138008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@509 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-01 17:09:16 +00:00
tommi@webrtc.org
87c546e89b Remove peerconnectionimpl_callbacks.h from libjingle.gyp.
This file has actually never existed in trunk, but the 
line in libjingle.gyp wasn't removed when we decided not
to check in the file.  (see http://webrtc-codereview.appspot.com/60008/)
Review URL: http://webrtc-codereview.appspot.com/139011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@508 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-01 15:55:15 +00:00
henrik.lundin@webrtc.org
fac55d5bb7 I've added two watchlist definitions (NetEQ and video codecs), and added myself to be notified when something changes.
Review URL: http://webrtc-codereview.appspot.com/137015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@507 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-01 10:29:13 +00:00
tommi@webrtc.org
c6e54a97a7 Update to the peerconnection sample app.
* Fixes bug where remote video wasn't renderered.


* Update the Conductor class in accordance to the latest changes in the API.
  We now process the stream add/remove callbacks asynchronously.

* When a remote peer connects to us, we now call AddStream for our local streams
  to share with the peer if we haven't already done so.  To do that, we maintain
  a set of streams we have already shared.

BUG=11
Review URL: http://webrtc-codereview.appspot.com/131011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@506 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-01 08:37:05 +00:00
tina.legrand@webrtc.org
84519ec0a2 Fixing some inconsistencies in WebRTC audio coding module. I've added setup information for all codecs which are not part of WebRTC, but possible to hook in.
Please help me review.
Henrik: review neteq_defines.h
Turaj: review all files, but the one Henrik reviews.
Zakk: FYI only.
Review URL: http://webrtc-codereview.appspot.com/138004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@505 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-01 07:47:31 +00:00