Commit Graph

1678 Commits

Author SHA1 Message Date
pwestin@webrtc.org
5e954814a8 Clanup handling of key frame requests and FIR.
Review URL: https://webrtc-codereview.appspot.com/387004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1667 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-10 12:13:12 +00:00
kjellander@webrtc.org
486a3baabd Enabling video_codecs_test_framework_integrationtests.
Since Issue 262 is now fixed.

BUG=
TEST=None.

Review URL: https://webrtc-codereview.appspot.com/388004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1662 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-10 11:00:28 +00:00
kjellander@webrtc.org
a1e9e3f0d8 Enabling rtp_rtcp_unittests since issue 268 is now fixed and commited.
BUG=
TEST=None.

Review URL: https://webrtc-codereview.appspot.com/388006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1660 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-10 10:59:18 +00:00
wu@webrtc.org
caef50310a Removing PeerConnection sample client and libjingle from webrtc.
The new PeerConnection and sample client can be found in libjingle.
http://code.google.com/p/libjingle/

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/389005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1658 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-09 19:23:17 +00:00
andrew@webrtc.org
75f1948b0e Restore AECM Coverity fix.
Add a test which would have caught the crash introduced by r1628.

BUG=274
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/388002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1657 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-09 17:16:18 +00:00
phoglund@webrtc.org
aaa76f3ba8 Rewrote network test.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/383003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1656 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-09 16:41:30 +00:00
kjellander@webrtc.org
bf0333801c Enable lcov on LinuxVideo and disable on others except Linux32DBG.
BUG=
TEST=Tested on local master.

Review URL: https://webrtc-codereview.appspot.com/394003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1655 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-09 14:56:24 +00:00
stefan@webrtc.org
4b377414f1 Fix release build errors.
TBR=mflodman
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/394005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1654 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-09 13:50:57 +00:00
xians@webrtc.org
3dbed8597e This CL makes the playout delay value thread safe.
With the patch, _sndCardPlayDelay is calculated in the DoRenderThread instead of capture thread, an capture thread only gets the _sndCardPlayDelay value.
And _sndCardPlayDelay and _sndCardRecDelay are only changed to be Atomic32 to make them to be accessed by multiple threads.


Test=None
Bug=256
Review URL: https://webrtc-codereview.appspot.com/394001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1653 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-09 13:50:48 +00:00
stefan@webrtc.org
9c84b0dc9f Fix build errors with GCC.
TBR=mflodman
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/389006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1652 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-09 13:14:04 +00:00
stefan@webrtc.org
7adab0922d This removes the knowledge of frame completeness from the FEC decoder.
Therefore, with this change a recovered packet is only considered old,
and will be removed, if more than 48 recovered packets are stored.

Packets are immediately reconstructed and sent to the jitter
buffer. Before this CL packets were processed on a frame-by-frame
basis, and all packets belonging to a frame was sent to the
jitter buffer at the same time.

The number of FEC packets is also limited to 48. An FEC packet is
removed if all protected packets have been recovered or if the
FEC packet is considered old.

Lot's of tests added.

Patch-set 2:
- Fixed rtp_fec_unittest.cc to work with the new reconstruction.
- Added reference counting of Packet to be able to keep references to them from FecPacket between different reconstruction runs.
- Rewrote the packet search to use std::set_intersection.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/379005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1651 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-09 12:34:52 +00:00
phoglund@webrtc.org
cde1c0b519 Fixed bad gtest filter.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/389004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1650 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-09 11:13:12 +00:00
kjellander@webrtc.org
cf6a295b13 Making video codecs test framework integration test execute in a reproducable fashion.
Fixed reproducable random behavior in packet_manipulator.h.
Test is now fully reproducable (runs on only one core) so much tighter limits are now set for the SSIM/PSNR values for the encoding/decoding (verified on all platforms)

BUG=
TEST=out/Debug/video_codecs_test_framework_integrationtests in Debug+Release on Linux, Mac, Windows and in Linux Valgrind.

Review URL: https://webrtc-codereview.appspot.com/381005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1649 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-09 09:01:51 +00:00
henrike@webrtc.org
d5657c2f69 Refactored files according to google style since http://review.webrtc.org/314001/ is blocked on this and formatting changes should not be done with code changes.
Review URL: https://webrtc-codereview.appspot.com/387005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1648 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 23:41:49 +00:00
andrew@webrtc.org
68da6adafe Remove WebRtc_ types.
Allows us to avoid the "cast to UWord32" Coverity coverup.

BUG=
TEST=test_fec

Review URL: https://webrtc-codereview.appspot.com/379002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1647 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 22:24:14 +00:00
wu@webrtc.org
454a27c13d The pthread_t is non-pointer type.
TBR=henrike
Review URL: https://webrtc-codereview.appspot.com/392004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1646 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 20:36:23 +00:00
henrike@webrtc.org
143abd95a3 Fixes coverity warnings in system_wrappers.
Review URL: https://webrtc-codereview.appspot.com/389003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1645 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 19:39:38 +00:00
henrike@webrtc.org
0e7c060256 Linux logs were not displaying time at ms resolution.
Review URL: https://webrtc-codereview.appspot.com/267012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1644 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 18:53:50 +00:00
wu@webrtc.org
a8084b07e3 Revert r1628 which causes the crash of voe_auto_test.
With r1628, it's possible the second memcpy got a NULL nearendClean.

TBR=bjornv
Review URL: https://webrtc-codereview.appspot.com/390005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1643 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 17:56:39 +00:00
phoglund@webrtc.org
0da6c85cfa Introduced the new Mac Release bot.
NOTE: Possibly rename slave folder on master to mac-slave-3 from mac-slave-1 to keep history. Not sure if it is a good idea.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/395001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1642 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 14:36:22 +00:00
tina.legrand@webrtc.org
13ac430bef Adding missing timestamp calculation to RTPencode.
Review URL: https://webrtc-codereview.appspot.com/392002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1641 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 13:20:36 +00:00
kjellander@webrtc.org
eaaccb7626 Enabling fixed tests and correcting error.
- video_coding_unittests on Windows
- signal_processing_unittests on Window
- audioproc_unittest for Valgrind Linux
- corrected error in LinuxVideo configuration

BUG=
TEST=Tested on local master.

Review URL: https://webrtc-codereview.appspot.com/392003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1640 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 13:18:00 +00:00
mflodman@webrtc.org
d2940f71e4 VCM::JB critsect fix.
Review URL: https://webrtc-codereview.appspot.com/390004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1639 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 12:42:56 +00:00
stefan@webrtc.org
23307f7c4b Remove frame_list.cc from Andorid.mk.
TBR=mflodman
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/390003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1638 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 10:39:13 +00:00
xians@webrtc.org
594ab3ce4b remove vie file API to take away media_file and utility modules.
This CL reduce the size of chrome in release build by 70KB.
With this patch and r1592 , sizes.py reports 92255640 bytes with webrtc, down from 92485792 bytes.
The size is 88839360 bytes without webrtc.

BR,
/SX
Review URL: https://webrtc-codereview.appspot.com/380007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1637 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 10:38:12 +00:00
tina.legrand@webrtc.org
df69775bfa Adding support for full-stereo codec.
This is an experiment, letting Celt represent a full-stereo codec.

Review URL: https://webrtc-codereview.appspot.com/379013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1636 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 10:22:21 +00:00
stefan@webrtc.org
2979461595 Refactored the jitter buffer to use std::list.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/352016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1635 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 08:58:55 +00:00
stefan@webrtc.org
7dfa883954 Disable spatial subsampling for denoiser variance estimation.
With subsampling there are sometimes quite visible trailing
artifacts.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/387002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1634 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 08:27:31 +00:00
pwestin@webrtc.org
95392e64ba Bugfix EnableIPV6 issue 255
Review URL: https://webrtc-codereview.appspot.com/378005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1633 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 08:08:37 +00:00
kjellander@webrtc.org
1970b2fcb3 Fixing uninitialized codec settings struct in test.
BUG=
TEST=video_codecs_test_framework_unittests passing in Debug+Release on Linux, Mac and Windows.

Review URL: https://webrtc-codereview.appspot.com/378004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1632 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 07:09:32 +00:00
andrew@webrtc.org
648af7423f Clean up MapSetting().
- Add assert(false) for "impossible" cases.
- Remove tests for invalid enum values.
- Modify MapError() to look the same way.

BUG=
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/386001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1631 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 01:57:29 +00:00
wu@webrtc.org
9143f774d1 Coverity fix for VideoRenderModule including issues 10084, 10226, 10267 and 10340.
Review URL: https://webrtc-codereview.appspot.com/385001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1630 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 00:14:25 +00:00
kma@webrtc.org
551fcc04ec Optimized function WebRtcSpl_DownsampleFast for ARM-NEON platform.
Review URL: https://webrtc-codereview.appspot.com/371001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1629 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 18:03:11 +00:00
bjornv@webrtc.org
236e842bca Removed memcpy of pointer to itself, triggering Valgrind warning.
BUG=272
Review URL: https://webrtc-codereview.appspot.com/389002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1628 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 17:22:44 +00:00
kma@webrtc.org
59f16ec993 Introduced ARM version of WebRtcSpl_SqrtFloor(). Function cycles reduced by ~ 30% in a real time VOE test in an android device (Nexus-S, ARMv7a).
// Fritz, I added you as a reviewer for the assembly files, just as a warm-up for future storms. :-) The assembly code was from public domain and there's little to touch.
Review URL: https://webrtc-codereview.appspot.com/369017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1627 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 17:15:15 +00:00
phoglund@webrtc.org
9d9ad88ba5 Fixed remaining warnings.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/393001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1626 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 16:16:52 +00:00
kjellander@webrtc.org
646fa2c5f2 Added Valgrind buildbot slave.
Renamed and reordered some of the bots in the configuration.

BUG=
TEST=Tested on personal build master.

Review URL: http://webrtc-codereview.appspot.com/389001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1625 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 15:51:18 +00:00
phoglund@webrtc.org
78088c2f36 Removed warnings on Windows and enabled warnings-as-errors on Windows.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/377004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1624 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 14:56:45 +00:00
niklas.enbom@webrtc.org
87885e8409 This CL will look a bit strange. Essentially I've removed sanity checks for > 1 channel and then fixed the bugs that remained. Will add testing in a separate CL.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/390001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1623 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 14:48:59 +00:00
phoglund@webrtc.org
2726cd22c9 Reconfigured which tests run on the integration test build bot.
The VoE Volume Test is flaky and is probably very hard to fix. The video auto tests are ready to be enabled, except the full stack test.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/391001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1622 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 12:13:58 +00:00
kjellander@webrtc.org
4ef5d493c7 Enabling and disabling tests
* audio_coding_module_test: enabling on Windows.
* audio_conference_mixer_unittests: enabling on Windows.
* audio_device_test_api: disabling on Mac, since this test is failing but not reporting failure. See issue 257 for more details.
* media_file_unittests: enabling on Windows.
* rtp_rtcp_unittests: enabling on Windows.
* test_bwe: enabling on Windows.
* test_fec: enabling on all platforms. See CL 369008 and 379010.
* test_support_unittests: enabling on all platforms.
* udp_transport_unittests: enabling on Windows.
* video_codecs_test_framework_unittests: adding disabled test on all platforms.
* video_codecs_test_framework_integrationtests: enabling on all platforms.
* video_processing_unittests: enabling on Windows, since issue 247 is fixed.

BUG=
TEST=Tried out on the master during after-office hours.

Review URL: http://webrtc-codereview.appspot.com/379011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1621 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 08:33:47 +00:00
bjornv@webrtc.org
530963925e Solves buffer overrun crash on Windows [issue 258].
Removed function calls not tested. Added a TODO on activating them when refactoring signal_processing.
Review URL: https://webrtc-codereview.appspot.com/379012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1620 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 08:10:46 +00:00
andrew@webrtc.org
14979ed4e6 Revert libyuv to r121.
TBR=stefan@webrtc.org
BUG=267
TEST=libyuv_unittest

Review URL: https://webrtc-codereview.appspot.com/387001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1619 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 05:13:02 +00:00
andrew@webrtc.org
2aa40aa087 Roll Chromium 114939->120526.
Dependencies:
gyp 1107->1187
libjpeg_turbo 95800->119959
jsoncpp 246->248
libyuv 121->164

Updates clang to version 3.1 (trunk 149419).

BUG=
TEST=build on Linux, Mac, Win. video_processing_unittest, libyuv_unittests, (jpeg_test doesn't work before this change), vie_auto_test.

Review URL: https://webrtc-codereview.appspot.com/386002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1618 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 04:14:58 +00:00
andrew@webrtc.org
daacee81b8 Use better reference files with audioproc_unittest.
The files are shorter (7 s) with one set provided for each sample rate.

Will be accompanied by the following set of files in the resource bundle:
far8_stereo.pcm
far16_stereo.pcm
far32_stereo.pcm
near8_stereo.pcm
near16_stereo.pcm
near32_stereo.pcm

BUG=114
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/380003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1617 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 00:01:04 +00:00
henrike@webrtc.org
2660460b89 Fixes flakyness in CPU unittest
Review URL: https://webrtc-codereview.appspot.com/377005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1616 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 23:33:54 +00:00
wu@webrtc.org
06c7dbae14 Disable flaky test AudioProcessingTest.TestVoiceActivityDetectionWithObserver.
BUG=263
TBR=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/380009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1615 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 23:13:21 +00:00
wu@webrtc.org
50099af75f Disable flaky test VideoProcessorIntegrationTest.Process5PercentPacketLoss.
BUG=262
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/379014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1614 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 22:50:48 +00:00
marpan@webrtc.org
6584e58001 Coverity fix for issues 10325,10326.
Review URL: https://webrtc-codereview.appspot.com/377001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1613 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 19:02:54 +00:00
phoglund@webrtc.org
56b85c6ba8 Reduced potential for flakiness in voice detection tests.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1612 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 18:48:33 +00:00