phoglund@webrtc.org
667eca6290
Rewrote the hardware-before-streaming test.
...
Restructured the test hierarchy somewhat - there is now a fixture for before-voe-init time and one for after-voe-init time.
Rewrote the hardware-before-streaming test.
Separated unrelated tests out from the rtp_rtcp tests.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/323009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1184 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 13:55:34 +00:00
henrik.lundin@webrtc.org
fbf5af444b
Adding a mockable wrapper class for TickTime in VCM
...
The class is called TickTimeInterface, with a fake implementation in FakeTickTime.
Review URL: http://webrtc-codereview.appspot.com/323012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1183 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 10:36:10 +00:00
stefan@webrtc.org
ef5247b5b1
Fix session_info_unittest error.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/324009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1182 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 10:25:38 +00:00
stefan@webrtc.org
0c40d3315f
Fixes an assert triggered in jitter_buffer_test and disables deblocking.
...
When deblocking is enabled the first frames can include uninitialized
memory. Disabling for now.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/320010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1181 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 09:39:30 +00:00
mflodman@webrtc.org
7991c0501f
Refactor ViEFilePlayer.
...
Types and arguments will be done in a later CL.
Review URL: http://webrtc-codereview.appspot.com/324002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1180 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 08:38:37 +00:00
mflodman@webrtc.org
e6f64835a0
Refactored ViECapturer.
...
Types and function arguments will come in a later CL.
Review URL: http://webrtc-codereview.appspot.com/322011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1179 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 08:36:01 +00:00
mflodman@webrtc.org
9a8fa4e65d
Refactored vie_manager_base.*.
...
The other files are only due to inheritance and will be refactored later. Same goes for pointer, references and function arguments.
Review URL: http://webrtc-codereview.appspot.com/318003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1178 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 08:18:42 +00:00
andrew@webrtc.org
6d609b59f3
Fix crashes due to static_instance.
...
- Initialize a needed critsect in the constructor of
UdpSocket2ManagerWindows.
- Don't return NULL when creating a static instance.
TEST=voe_auto_test on Windows.
Review URL: http://webrtc-codereview.appspot.com/324008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1177 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 02:36:33 +00:00
andrew@webrtc.org
5a9c6f26ab
Fix max size and read-only errors in Write().
...
- A size of zero is now correctly interpreted as unlimited.
- The read-only flag is correctly checked.
TBR=henrika@webrtc.org
TEST=vie_auto_test (for real this time...)
Review URL: http://webrtc-codereview.appspot.com/315007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1176 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 00:53:30 +00:00
andrew@webrtc.org
5ae19de3ec
Fix error in RtpDump::Start due to r1156.
...
- r1156 fixed a check on the _text member of FileWrapper. Turns out this
was incompatibile with the RTP dumps, which want to write both binary
and text data. Writing text data to a file open as "b" isn't actually
an error, so I simply removed the check.
- Also cleans up the interface, most notably removing all WebRtc types.
TEST=vie_auto_test
Review URL: http://webrtc-codereview.appspot.com/317005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1175 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 22:59:33 +00:00
mikhal@webrtc.org
832cacacff
video-coding: Adding a decoded state to the JB logic (JB refactor).
...
This new class stores the last decoded info, including temporal info.
Review URL: http://webrtc-codereview.appspot.com/300005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1174 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 21:15:05 +00:00
henrike@webrtc.org
65573f2922
Removed usage of the deprecated critical section constructor in rtp_rtcp.
...
Review URL: http://webrtc-codereview.appspot.com/315004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1173 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 19:17:27 +00:00
stefan@webrtc.org
f4c8286222
Pass NACK and FEC overhead rates through the ProtectionCallback to VCM.
...
These overhead rates are used by the VCM to compensate the source
coding rate for NACK and FEC.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/323003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1171 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 15:38:14 +00:00
henrik.lundin@webrtc.org
1ced840893
Fixing a nit in the unittest
...
This caused some of the build bots to fail.
Review URL: http://webrtc-codereview.appspot.com/324005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1170 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 14:59:00 +00:00
henrik.lundin@webrtc.org
eda86dc76b
Adding a LayerSync bit to VP8 RTP header
...
Updated RtpFormatVp8, ModuleRTPUtility, VP8Encoder and VP8Decoder
to support a new LayerSync ("Y") bit. Note, in VP8Encoder the bit
must be used together with a non-negative value for temporalIdx.
Fixing the plumbing between RTP module and and from VP8 wrapper.
Updating unit tests; all pass.
The new bit is yet to be used by the VP8 wrapper.
Review URL: http://webrtc-codereview.appspot.com/323008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1169 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 14:11:06 +00:00
henrik.lundin@webrtc.org
4aae0e489f
Shaping up formatting of rtp_utility_test.cc
...
Preparations for future work in this file.
Review URL: http://webrtc-codereview.appspot.com/318011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1168 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 09:15:21 +00:00
bjornv@webrtc.org
0edb25dcc9
Removed valgrind warnings in resampler_unittest.
...
Valgrind complained on uninitialized values in resampler_unittest. Added initialization of the member variable data_in_ in the tests.
Review URL: http://webrtc-codereview.appspot.com/322006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1167 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 09:06:54 +00:00
stefan@webrtc.org
076fa6e674
The second step towards a list based SessionInfo.
...
Added unittests for most of public functions of SessionInfo.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/301014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1166 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 07:54:56 +00:00
wjia@webrtc.org
c28e7980ef
exclude trace_windows.cc and trace_posix.cc when building with Chromium.
...
BUG=none
TEST=compiles
Review URL: http://webrtc-codereview.appspot.com/324004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1165 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 02:16:11 +00:00
mikhal@webrtc.org
71d6391716
libyuv: fixing a bug in RotateI420 and updating test
...
Review URL: http://webrtc-codereview.appspot.com/324003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1164 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 00:56:11 +00:00
mikhal@webrtc.org
352ade7023
video_coding: Allocating encoded buffer based on length and not size
...
Review URL: http://webrtc-codereview.appspot.com/318010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1163 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 00:54:28 +00:00
phoglund@webrtc.org
fe61bc3607
Merge branch 'master' into voe_create_test
...
Fixed broken build.
Nit fix.
Fixed style issues.
Removed accidental comment-out.
Removed test that no longer makes sense.
Rewrote hardware-before-init and rtp-rtcp-before-streaming test code to gtest.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/320009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1162 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-12 17:02:16 +00:00
phoglund@webrtc.org
6418a24795
Rewrote hardware-before-init and rtp-rtcp-before-streaming test code to gtest.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/322003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1161 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-12 16:24:23 +00:00
stefan@webrtc.org
1480f02faf
Fix VCM test build warnings on Mac with clang.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/318008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1160 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-12 13:45:59 +00:00
stefan@webrtc.org
7889a9b49a
Remove use of CriticalSectionScoped(CriticalSectionWrapper& critsect) in VCM.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/318005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1159 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-12 08:18:24 +00:00
mikhal@webrtc.org
ea71440aec
video_coding: Adding the non reference flag to the receive side logic.
...
Review URL: http://webrtc-codereview.appspot.com/323005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1157 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-12 02:29:34 +00:00
andrew@webrtc.org
114c790be7
Remove character limit in WriteText().
...
- vfprintf can be used directly here, removing the need for the interim
buffer. This change allows us to remove the artificial character limit.
- Fix bugs with _text. It wasn't actually getting set earlier, and the
check was wrong.
- Remove asserts that should use real error checks.
TEST=DataLog and VoECallReport (through voe_auto_test), the only users of WriteText().
Review URL: http://webrtc-codereview.appspot.com/323001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1156 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-10 02:33:33 +00:00
henrike@webrtc.org
2f47b5a70f
Fixes a build error when disabling trace (which is done when building with chrome flag is set).
...
Review URL: http://webrtc-codereview.appspot.com/318006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1155 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-10 00:44:47 +00:00
wjia@webrtc.org
c6b286fc04
add correct include paths for both chrome build and standalone build.
...
BUG=none
TEST=compiles
Review URL: http://webrtc-codereview.appspot.com/320008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1154 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-10 00:20:54 +00:00
andrew@webrtc.org
bbea716117
Workaround for libyuv libjingle breakage.
...
libjingle depends on ConvertFromI420. This was previously available
through vplib. libjingle still has access to the vplib header, but the
implementation is no longer built.
Fortunately, the libyuv wrapper can supply the implementation, if we
hack the signature to return to the unsigned int types. We'll remove
this once libjingle has been updated to use libyuv directly.
Also, roll libyuv to r100 which fixes a gyp warning on Windows.
TEST=build
Review URL: http://webrtc-codereview.appspot.com/323004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1151 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 19:43:12 +00:00
henrike@webrtc.org
315282c01a
Fixes a compiler warning related to dynamically allocated static memory. the fix is to leak the memory since the OS will clean it up anyways. This will not add noise to memory tools so it's ok. The issue is reported here: http://code.google.com/p/webrtc/issues/detail?id=147 .
...
Review URL: http://webrtc-codereview.appspot.com/267023
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1150 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 17:46:20 +00:00
mflodman@webrtc.org
d5651b98c5
Refactored ViEFrameProviderBase.
...
Only style changes, ointers/references and functions will come in a later CL.
vie_capturer.cc and vie_file_player.cc are only changed du to inheriting protected members from ViEFrameProviderBase.
Review URL: http://webrtc-codereview.appspot.com/324001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1148 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 15:20:58 +00:00
xians@webrtc.org
0744ee563d
Disable API tests on ALSA since the tests don't work for all the alsa devices.
...
Review URL: http://webrtc-codereview.appspot.com/317004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1147 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 14:05:29 +00:00
henrik.lundin@webrtc.org
6198624815
Remove warnings on Mac (Issue 178)
...
Remove an if-else that can never execute the else statement.
Remove double parenthesis.
BUG=http://code.google.com/p/webrtc/issues/detail?id=178
TEST=
Review URL: http://webrtc-codereview.appspot.com/318004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1146 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 13:58:17 +00:00
mflodman@webrtc.org
5cc4dc9e0c
Remove warnings in VideoEngine, capture module and render module.
...
BUG=164, 176, 180
Review URL: http://webrtc-codereview.appspot.com/303004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1145 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 10:12:57 +00:00
mflodman@webrtc.org
b19582b7dc
Add pointer constructor to CriticalSectionScoped.
...
Mainly added to simplyfy the code, e.g. when having critsect as scoped_ptr in classes.
Review URL: http://webrtc-codereview.appspot.com/302005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1144 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 10:02:16 +00:00
henrikg@webrtc.org
af225d6bf6
The change http://webrtc-codereview.appspot.com/299001 (commit 1062) does not do what it intends (exclude codecs from Chromium build). This is a fix for that. webrtc.gyp is not pulled in Chromium, hence it has no effect putting a define there. Moving it to src/build/common.gypi.
...
Review URL: http://webrtc-codereview.appspot.com/315002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1143 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 09:58:39 +00:00
mflodman@webrtc.org
5885a4162a
Refactored ViERenderer.
...
Only style changes, function and type changes will come in a later CL.
Review URL: http://webrtc-codereview.appspot.com/321001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1142 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 05:52:32 +00:00
mikhal@webrtc.org
2ab104e6be
Switching WebRtc to LibYuv.
...
General Notes:
1. In general, API structure was not modified and is based on VPLIB.
2. Modification to API: Return values are based on libyuv, i.e. 0 if ok, a negative value in case of an error (instead of length).
3. All scaling (inteprolation) is now done via the scale interface. Crop/Pad is not being used.
4. VPLIB was completely removed. All tests are now part of the libyuv unit test (significantly more comprehensive and based on gtest).
5. JPEG is yet to be implemented in LibYuv and therefore existing implementation remains.
Review URL: http://webrtc-codereview.appspot.com/258001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1140 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 02:46:22 +00:00
mikhal@webrtc.org
ffa0a9e9c9
updating libyuv to latest version (98).
...
This CL also includes some additional adaptations to the code due to the upgrade.
Review URL: http://webrtc-codereview.appspot.com/306001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1139 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 22:45:53 +00:00
mallinath@webrtc.org
7766e2a82d
- This issue raised by the chromium team when clang compiler is used. This was not an error as in this case we were accessing IPV6 address with IPV4 struct which is defined as 14 bytes in the header file, but we had the runtime check to determine the address space.
...
Now the solution is to use IPV6 structures instead of IPV4 when address space is determined.
I haven't put the new solution behind AF_INET6 flag, as i don't think it's necessary.
Review URL: http://webrtc-codereview.appspot.com/291014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1138 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 21:37:19 +00:00
andrew@webrtc.org
b0be7aa7ae
Remove deprecated OS X Core Audio APIs.
...
We no longer support the 10.4 SDK, so we can remove the weak-leaking
feature and exclusively use the added-in-10.5 APIs.
BUG=issue143
TEST=voe_auto_test
Review URL: http://webrtc-codereview.appspot.com/322001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1136 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 20:15:36 +00:00
marpan@webrtc.org
63b50f60d6
test_fec: Fix to valgrind warnings.
...
Review URL: http://webrtc-codereview.appspot.com/304002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1135 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 19:05:39 +00:00
mikhal@webrtc.org
f5ee1dc3e6
video_coding: Adding temporal layer info support to receive side
...
Review URL: http://webrtc-codereview.appspot.com/303005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1134 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 19:04:47 +00:00
xians@webrtc.org
832d7c6000
Disable typing detection for chromium since CGEventSourceKeyState is violating chromium sandbox.
...
Review URL: http://webrtc-codereview.appspot.com/320003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1132 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 16:45:46 +00:00
phoglund@webrtc.org
dd094fd6ae
Started extracting methods out of the main test.
...
Started extracting methods out of the main test, which will hopefully make us able to make the tests independent.
Merge branch 'master' into voe_split_methods
Conflicts:
src/voice_engine/main/test/auto_test/voe_extended_test.cc
src/voice_engine/main/test/auto_test/voe_extended_test.h
src/voice_engine/main/test/auto_test/voe_standard_test.cc
src/voice_engine/main/test/auto_test/voe_standard_test.h
Extracted methods out of the standard test.
Added space before inheritance colons.
Rolled back some header file changes.
Fixed long lines.
Fixed long lines.
Fixed indentation. There is nothing but whitespace changes here, except for removing some extraneous semicolons in .h files and fixing a spelling error in a comment.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/313001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1131 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 15:07:59 +00:00
henrik.lundin@webrtc.org
d03718d1e4
Use ResourcePath in NetEQ unittest
...
Review URL: http://webrtc-codereview.appspot.com/320001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1130 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 11:42:43 +00:00
mflodman@webrtc.org
d2ee5d989d
Changed sync bug introduced in refactoring.
...
Review URL: http://webrtc-codereview.appspot.com/319001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1129 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 09:25:11 +00:00
mflodman@webrtc.org
c78209c58b
Add log when transport fails to send packet.
...
Review URL: http://webrtc-codereview.appspot.com/311002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1128 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 09:22:45 +00:00
kjellander@webrtc.org
7de6e10410
Fixing compilation error on Linux 64-bit
...
Problem was introduced in http://webrtc-codereview.appspot.com/311001/ because I had projects generated with Valgrind configuration, which is more forgiving about these implicit conversions.
BUG=
TEST=Compiling in Debug+Release on Linux, Mac and Windows.
Review URL: http://webrtc-codereview.appspot.com/318002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1127 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 08:39:13 +00:00
kjellander@webrtc.org
5b97b1216f
Splitted FileHandler into FrameReader and FrameWriter classes and moved them to testsupport in test.gyp.
...
Fixed unit tests so they don't use ASSERT_DEATH since that doesn't work with Valgrind.
Fixed all Valgrind warnings except the one caused by CriticalSectionWrapper in system_wrappers.
Reworked all includes and GYP include paths to use full directory paths.
Removed util.h for logging, since it rendered warnings in Valgrind because of gflags. Replaced it with a verbose flag and a new function in video_quality_measurement.cc
BUG=
TEST=Passed test_support_unittests and video_codecs_test_framework_unittests on Linux, Mac and Windows.
Review URL: http://webrtc-codereview.appspot.com/311001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1126 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 07:42:18 +00:00
henrike@webrtc.org
441b3fe2a1
Made some global statics have function scope so that the global static count is 0 for the rtp_rtcp module.
...
Review URL: http://webrtc-codereview.appspot.com/316001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1125 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 02:03:49 +00:00
stefan@webrtc.org
cc7b649474
Add trace for the situation when the min bitrate > available bandwidth.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/312001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1123 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 13:22:06 +00:00
phoglund@webrtc.org
693240f2d9
Fixed many formatting and indentation problems in voe_auto_test.
...
Fixed indentation. There is nothing but whitespace changes here, except for removing some extraneous semicolons in .h files and fixing a spelling error in a comment.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/305004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1122 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 12:32:58 +00:00
henrik.lundin@webrtc.org
598ad06432
Fixing compiler warning in NetEQ
...
With some compiler settings, a warning was issued for NetEQ,
saying that pw16_randVec was accessed out of bounds.
This did never happen in practice, but this change makes the
compiler understand this.
Review URL: http://webrtc-codereview.appspot.com/309001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1121 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 11:52:09 +00:00
stefan@webrtc.org
b3bd1cd5f1
Fixes Valgrind warnings in the default VCM tests.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/299010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1120 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 11:48:09 +00:00
henrik.lundin@webrtc.org
bf86c33b0e
Removing OutputDebugString from rtp_rtcp module
...
This is in response to WebRTC issue 167.
BUG=http://code.google.com/p/webrtc/issues/detail?id=167
Review URL: http://webrtc-codereview.appspot.com/301013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1119 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 10:44:05 +00:00
henrik.lundin@webrtc.org
44ef3774ce
Fixing a compiler error in NetEQ
...
This error would only arise when compiling without support for
DTMF (which is not the default config).
Review URL: http://webrtc-codereview.appspot.com/310001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1118 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 10:43:25 +00:00
phoglund@webrtc.org
5b343aedcc
Added missing .h files to .gypi files so they will show up in xcode / vc projects.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/304008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1117 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 10:34:35 +00:00
stefan@webrtc.org
58927e8d8f
Disable deblocking temporarily due to Valgrind warnings.
...
Also corrects the copying of the decoded image data for frames
with odd width or height.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/307002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1116 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 08:13:31 +00:00
marpan@webrtc.org
1d34212a45
FEC: Update to packets masks (FEC generator matrix) in fec_private_tables.h
...
A set of the packet masks (up 10x10 size) are modified for the following reasons:
1) have more even column and row degree (number of 1 bits), when possible.
2) if cases where the column degree cannot be constant across source packets, placed the extra 1 bit in the first packet column (so little more protection on 1st partition), as opposed to having some ~middle source packet have the extra bit.
3) in some cases, made the mask a little more sparse/reduced the overlap.
Overall the average recovery is a little better with these masks.
Mask sizes above 10 will be updated in future changelist.
Review URL: http://webrtc-codereview.appspot.com/305001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1113 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-06 18:50:11 +00:00
kma@webrtc.org
4a8b1eaf6e
In NS, replaced a divide calculatoin by shifting, and thus saved the MIPS by 5%(ARMv7) and 10%(ARMv7-Neon). Bit is not exact with the original. Quality is similar.
...
Review URL: http://webrtc-codereview.appspot.com/298004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1112 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-06 18:04:48 +00:00
henrik.lundin@webrtc.org
b6e58eb5a1
Fix formatting of rtp_format_vp8*
...
Sorting out all lint issues and fixing indentation.
Review URL: http://webrtc-codereview.appspot.com/301011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1111 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-06 15:56:18 +00:00
stefan@webrtc.org
c7e2bffb66
Fix header/lib mismatch caused by a constant not defined for header file.
...
BUG=http://code.google.com/p/webrtc/issues/detail?id=170
TEST=
Review URL: http://webrtc-codereview.appspot.com/300008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1110 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-06 13:44:25 +00:00
phoglund@webrtc.org
048b037342
Fixed vie_auto_test shutdown race conditions.
...
Fixed a race condition crash in vie_auto_test shutdown. Certain tests did not clean up the voice engine properly which caused crashes during certain uncommon timing conditions.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/307001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1109 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-06 10:42:05 +00:00
xians@webrtc.org
eff3c8905f
this patch fixes the valgrind warnings in the adm api test for pulseaudio in linux.
...
Review URL: http://webrtc-codereview.appspot.com/301012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1108 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-06 10:02:56 +00:00
mikhal@webrtc.org
cae01010bd
libyuv unit test: adding check for fread return value
...
Review URL: http://webrtc-codereview.appspot.com/303007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1107 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-06 00:44:16 +00:00
mikhal@webrtc.org
a5e980a906
Updating jitter buffer test following latest changes.
...
Review URL: http://webrtc-codereview.appspot.com/294002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1106 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-05 18:27:31 +00:00
phoglund@webrtc.org
23e1c0a0b1
File handling in vie_auto_test now uses fileutils so input and output file end up in a good place.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/301003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1103 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-05 15:27:04 +00:00
perkj@webrtc.org
ec7759a8c4
Fix broken vie_capture_module_test on mac.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/303006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1101 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-05 12:17:10 +00:00
perkj@webrtc.org
8627adc158
Refactored Video capture Unit test to use gtest.
...
Fix Valgrind warnings on Linux.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/296009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1100 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-05 09:58:55 +00:00
stefan@webrtc.org
0ae71b9ccb
Disable temporal layers when building with Chromium.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/301010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1099 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-05 08:42:52 +00:00
henrika@webrtc.org
af71f0e5d9
Fixes two minor issues reported by the Coverty Integration Manager.
...
BUG=none
TEST=voe_auto_test
Review URL: http://webrtc-codereview.appspot.com/302002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1098 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-05 07:02:22 +00:00
andrew@webrtc.org
c9cc3750cf
Add missing system_wrappers dependency.
...
TBR=kma@webrtc.org
Review URL: http://webrtc-codereview.appspot.com/301009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1097 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-03 20:51:20 +00:00
kma@webrtc.org
b59c031660
For Android ARMv7 platforms, added a feature of dynamically detecting the existence of Neon,
...
and when it's present, switch to some functions optimized for Neon at run time.
Review URL: http://webrtc-codereview.appspot.com/268002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1096 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-03 18:34:50 +00:00
andrew@webrtc.org
ae7017d588
Fix missing dependency in audioproc.
...
TBR=bjornv@webrtc.org
Review URL: http://webrtc-codereview.appspot.com/300006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1095 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-03 01:43:29 +00:00
andrew@webrtc.org
7bf2646e4d
Make protobuf use optional.
...
- By default, disable the AudioProcessing protobuf usage in the Chromium
build. The standalone build is unaffected.
- Add a test for the AudioProcessing debug dumps.
TEST=audioproc_unittest
Review URL: http://webrtc-codereview.appspot.com/303003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1094 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-03 00:03:31 +00:00
mflodman@webrtc.org
626fbfd4cd
Correcting vie_encoder nits.
...
Review URL: http://webrtc-codereview.appspot.com/302004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1093 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 23:39:11 +00:00
perkj@webrtc.org
6b1bfd6c5e
Changed webrtc::ACMCodecDB::neteq_decoders_ to a const array.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/304003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1092 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 12:48:19 +00:00
pwestin@webrtc.org
db221d2b81
Fixes to temporal layers, Henrika please review src/common_types.h
...
Review URL: http://webrtc-codereview.appspot.com/286001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1091 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 11:31:08 +00:00
phoglund@webrtc.org
6aed73d218
Fixed release compilation error.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/298003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1090 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 11:14:12 +00:00
henrik.lundin@webrtc.org
e26aad4a9e
Disable NetEQ unittest for Windows
...
Disable NetEqDecodingTest::TestNetworkStatistics for Windows.
It was never tested for Windows. Something is causing it to
fail, probably need different set of test vectors.
Review URL: http://webrtc-codereview.appspot.com/302003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1089 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 10:27:14 +00:00
stefan@webrtc.org
9cb2b56b65
Corrected a fread verification.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/301006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1088 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 10:22:29 +00:00
phoglund@webrtc.org
b956b4856a
vie_auto_test may now be run in automated mode on all three platforms.
...
Fixed chrash bug on Mac, but there are still crash bugs since a couple weeks back. These will have to be fixed separately.
Removed dialogs from capture tests on Windows.
Removed some dead code related to answer files.
Added the last Windows fixes.
Fixed the Mac vie_auto_test runner - it will now run on Mac again. It will still crash randomly on codec and rtcp tests though.
Fixed compilation error.
Got patch to commit on Mac.
Temp commit on mac
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/292011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1087 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 10:19:27 +00:00
perkj@webrtc.org
38ca4f2953
Fix code review comments.
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1086 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 09:34:10 +00:00
perkj@webrtc.org
d3eac4158c
Fixed webrtc::perm variable.
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1085 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 09:34:01 +00:00
perkj@webrtc.org
1b72fcd27b
Fix symbol RTPFILE_VERSION.
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1084 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 09:33:51 +00:00
stefan@webrtc.org
772d70bcd2
Fix release build error.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/304005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1083 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 09:18:49 +00:00
stefan@webrtc.org
a4a88f90c4
Implemented NACK based reference picture selection.
...
This CL implements NACK based reference picture selection for VP8. A separate
class is used for keeping track of the references and managing the VP8 encode
flags. Appropriate tests have also been added.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/284002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1082 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 08:34:05 +00:00
henrike@webrtc.org
4b00560a6e
Fixes build error in rtp_rtc module introduced in r1076.
...
Review URL: http://webrtc-codereview.appspot.com/301005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1081 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 00:32:24 +00:00
punyabrata@webrtc.org
c1ed87602a
Adding some error handling functionality in the windows audio core implementation to
...
stop rendering automatically and throw a playout-error callback when RequestPlayoutData
fails
Review URL: http://webrtc-codereview.appspot.com/300003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1080 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-01 17:55:35 +00:00
mflodman@webrtc.org
c6182915a3
Fix vie_encoder.cc.
...
TBR=ajm
Review URL: http://webrtc-codereview.appspot.com/301004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1079 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-01 17:45:28 +00:00
mflodman@webrtc.org
84d17838ac
Refactored ViEEncoder.
...
Style changes + QT Metrics class from h-file to cc-file, type changes will be in another CL.
Review URL: http://webrtc-codereview.appspot.com/303001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1078 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-01 17:02:23 +00:00
kjellander@webrtc.org
5f4f69ac57
Removing sleeps from vp8_test.
...
These sleeps were remains from earlier tests that required them to work with some codecs. Removing these sleep calls cut the execution time from 90s to 30s on my machine.
Review URL: http://webrtc-codereview.appspot.com/304004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1077 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-01 15:50:04 +00:00
pwestin@webrtc.org
0644b1dc35
Introduce a mockable RtpRtcpClock interface replacing ModuleRTPUtility time functions
...
A new RtpRtcpClock interface has been added to rtp_rtcp_defines.h
and provides time facilities used by an RTP/RTCP module. Also,
NTP constants have been made public in the
webrtc::ModuleRTPUtility namespace to make implementation of
external clocks easier.
An overloaded version of CreateRtpRtcp() accepts a clock argument. By
default, if no clock is provided, the module uses the system clock
(old ModuleRTPUtility implementation).
Throughout the RTP/RTCP module code, calls to TickTime and
ModuleRTPUtility time functions have been replaced with calls to time
methods on a clock object.
The following classes take a clock object in their constructor and
hold a _clock field (either directly, or inherited from a parent):
Bitrate
ModuleRtpRtcpImpl
RTCPReceiver
RTCPSender
RTPReceiver
RTPSender
RTPSenderAudio
RTPSenderVideo
Methods from other classes that do not derive any of those and
require a time take an additional nowMS parameter, that should be
the result of calling GetTimeInMS() on a clock object.
Review URL: http://webrtc-codereview.appspot.com/268017
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1076 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-01 15:42:31 +00:00
bjornv@webrtc.org
132feb1270
Made tables static.
...
In this CL global tables have been moved to where they are actually used. If for some reason they need to be available in a larger scope we can add them again at that point.
Review URL: http://webrtc-codereview.appspot.com/303002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1075 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-01 15:40:50 +00:00
kjellander@webrtc.org
4c4b7f500f
Converting vp8_test to use fileutils and gtest
...
Review URL: http://webrtc-codereview.appspot.com/289012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1074 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-01 15:24:36 +00:00
tina.legrand@webrtc.org
f64162c335
Adding const to a number of constant tables. Setting some tables to static.
...
Patch set 2: Renaming static const tables. They no longer need the prefix WebRtc_Isac...
Review URL: http://webrtc-codereview.appspot.com/301001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1073 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-01 13:01:39 +00:00
bjornv@webrtc.org
bedabb25bf
Added const on const tables.
...
Builds on Linux.
Tommi: Can you try on Windows?
Review URL: http://webrtc-codereview.appspot.com/300002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1072 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-01 07:44:32 +00:00
henrike@webrtc.org
c2ac8953d5
Fixes Valgrind warnings in system wrappers unittest.
...
Review URL: http://webrtc-codereview.appspot.com/293006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1071 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 22:46:59 +00:00