Commit Graph

7033 Commits

Author SHA1 Message Date
henrik.lundin@webrtc.org
83317146ba Adding a new test helper RtpFileWriter and use it in RTPcat
This new helper class writes RTP packets to file in rtpdump format.
A unit test is also included.

The new test class is used while re-writing the test tool RTPcat.

BUG=2692
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/28099004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7768 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-01 11:25:04 +00:00
kjellander@webrtc.org
4796301c0e Whitespace change to force builds.
TBR=buildbot@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/30249004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7767 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-01 09:10:38 +00:00
kjellander@webrtc.org
e75f2cea5f Add FORCE_HTTPS_COMMIT_URL to codereview.settings.
This will make it possible to use a https URL when committing
to SVN from from git-svn checkouts created with 'fetch webrtc'
(i.e. from a pure Git mirror in Chrome infrastructure).

This will have effect only after
https://codereview.chromium.org/760903004/ is landed.

BUG=chromium:412012
TESTED=This CL will be committed using git cl dcommit from
a checkout created with 'fetch webrtc', combined
with depot_tools patched with https://codereview.chromium.org/760903004/

Review URL: https://webrtc-codereview.appspot.com/32569004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7766 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-01 09:09:07 +00:00
kjellander@webrtc.org
cc7755becd Whitespace change
TBR=buildbot@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/27269004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7765 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-29 16:47:53 +00:00
kjellander@webrtc.org
74499efc05 Add whitespace.txt file.
This is useful as a recommended way to trigger now builds
with a noop change.
I believe it's going to be used more frequently as we're closing
in on the Git switch, to test committing and pushing.

TBR=phoglund@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/32559004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7764 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-29 15:42:29 +00:00
tommi@webrtc.org
2c13f659c7 Add a platform specific typedef for SOCKET in the peerconnection_server example since it's not universally 'int'.
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/33439004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7763 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-28 10:37:31 +00:00
asapersson@webrtc.org
83b5200f95 Add framerate for complete received frames to histogram stats:
"WebRTC.Video.CompleteFramesReceivedPerSecond".

BUG=crbug/419657
R=mflodman@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/32089004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7762 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-28 10:17:13 +00:00
aluebs@webrtc.org
cc144deaab Make bands vector in SplittingFilter Analysis const
BUG=webrtc:3146
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/30229004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7761 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-28 00:26:27 +00:00
aluebs@webrtc.org
8789376cd3 Move ChannelBuffer class to channel_buffer file
No change in functionallity.

BUG=webrtc:3146
R=andrew@webrtc.org, bjornv@webrtc.org, kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/28109004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7760 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-27 23:40:25 +00:00
pbos@webrtc.org
d87213af49 Remove unused RtpStatistics struct.
This unused struct is basically a copy of RtcpStatistics in
webrtc/common_types.h. I expect this wasn't properly removed when that
one was added.

R=tommi@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/25239004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7758 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-27 13:48:35 +00:00
kjellander@webrtc.org
7d4e6d012c Roll chromium_revision d8c9041..309cf65
Relevant changes:
* testing/gtest 4650552..8245545
* testing/gmock 896ba0e..2976396
* third_party/boringssl 2f3ba91..69a0160
* third_party/icu: 6242e2f..dd72764
* third_party/libyuv: 5a09c3e..d204db6
* tools/gyp: b13d8f2..0a381c0

Details: d8c9041..309cf65/DEPS

Clang version was not updated in this roll.

R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/25219004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7757 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-27 10:41:04 +00:00
asapersson@webrtc.org
d952c40c7e Add receive bitrates to histogram stats:
- total bitrate ("WebRTC.Video.BitrateReceivedInKbps")
- media bitrate ("WebRTC.Video.MediaBitrateReceivedInKbps")
- rtx bitrate ("WebRTC.Video.RtxBitrateReceivedInKbps")
- padding bitrate ("WebRTC.Video.PaddingBitrateReceivedInKbps")

BUG=crbug/419657
R=mflodman@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/27189005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7756 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-27 07:38:56 +00:00
tkchin@webrtc.org
3e9ad26112 Refactor iOS AppRTC parsing code.
Moved parsing code to JSON categories for the relevant objects.
No longer prefer ISAC as audio codec.

BUG=
R=glaznev@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/31989005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7755 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-27 00:52:38 +00:00
aluebs@webrtc.org
79b9eba3ab Implement 3 band splitting filter bank by upsampling and splitting twice into 2 bands
Implemented the 3 bands splitting filter bank by:
1. Upsample by 4/3.
2. Split twice into 2 bands.
3. Discard upper most band, because it is empty anyway.

A unittest was also implemented:
1. Generate a signal from presence or absence of sine waves of different frequencies.
2. Split into 3 bands and check their presence or absence.
3. Recombine the bands.
4. Calculate delay (as it is an IIR it depends on frequency).
5. Check that the cross correlation of input and output is high enough at that delay.

BUG=webrtc:3146
R=andrew@webrtc.org, bjornv@webrtc.org, kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/31029004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7754 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-26 20:21:38 +00:00
jiayl@webrtc.org
7806d8fe40 Fix an ASSERT that fires in a browser test for renegotiation.
See https://code.google.com/p/chromium/issues/detail?id=293125#c33

BUG=crbug/293125
R=juberti@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/32429004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7753 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-26 19:58:50 +00:00
sprang@webrtc.org
a71bb6033b Revert 7750 "Don't reset sequence number for a stream on deactiv..."
> Don't reset sequence number for a stream on deactivate/reactivate.
>
> BUG=chromium:431908
> R=pbos@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/32199004

TBR=sprang@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/29099004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7752 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-26 19:33:15 +00:00
andrew@webrtc.org
a56a2c57cf Enabling building with NEON on ARM64
This patch enables NEON on ARM64 platform. Passed building both on
Android ARMv7 and Android ARM64.

BUG=3580
R=andrew@webrtc.org, jridges@masque.com

Review URL: https://webrtc-codereview.appspot.com/25069004

Patch from Zhongwei Yao <zhongwei.yao@arm.com>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7751 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-26 17:01:40 +00:00
sprang@webrtc.org
31f7a0e710 Don't reset sequence number for a stream on deactivate/reactivate.
BUG=chromium:431908
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/32199004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7750 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-26 16:55:52 +00:00
henrik.lundin@webrtc.org
91d928e737 Rename RtpFileReader::Packet to RtpPacket and move out of RtpFileReader
This is in preparation for creating a new class RtpFileWriter which
will use the same RtpPacket struct.

R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/33429004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7749 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-26 15:50:30 +00:00
perkj@webrtc.org
2faf7eea6f Revert "Revert "This adds an Android apk for running tests on the Java layer of PeerConnection.""
This reverts commit 308e7ff613.

Original cl description:

This adds an Android apk for running tests on the Java layer of PeerConnection.

The only testcase is currently the same test we run on Java standalone.
To run the test adb shell am instrument -w org.webrtc.test/android.test.InstrumentationTestRunner

BUG=4031
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/32529004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7748 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-26 07:35:37 +00:00
glaznev@webrtc.org
58edb83fd4 Add video encoder fps and bitrate statistics to
Android AppRTCDemo UI.

BUG=4045
R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/25229004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7747 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-26 00:39:42 +00:00
pbos@webrtc.org
008731868a Implement settable min/start/max bitrates in Call.
These parameters are set by the x-google-*-bitrate SDP parameters. This
is implemented on a Call level instead of per-stream like the currently
underlying VideoEngine implementation to allow this refactoring to not
reconfigure the VideoCodec at all but rather adjust bandwidth-estimator
parameters.
Also implements SetMaxSendBandwidth in WebRtcVideoEngine2 as it's a SDP
parameter and allowing it to be dynamically readjusted in Call.

R=mflodman@webrtc.org, stefan@webrtc.org
BUG=1788

Review URL: https://webrtc-codereview.appspot.com/26199004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7746 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-25 14:03:34 +00:00
pbos@webrtc.org
b951eb12c9 Add back EXPECT_TRUEs.
These shouldn't fail, but EXPECT_TRUE gives nicer error messages that
work in Release. These changes got through unreviewed in r7726.

R=stefan@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/26249004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7745 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-25 11:13:28 +00:00
pbos@webrtc.org
ba253473da Reenable GetStats test.
Also increasing start bitrate to have the test go significantly faster
on average. Hopefully an assert hit in the jitter buffer while running
this test was fixed in r7735.

R=stefan@webrtc.org
BUG=4014

Review URL: https://webrtc-codereview.appspot.com/26239004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7744 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-25 09:39:04 +00:00
glaznev@webrtc.org
dab5d92df6 Use mirror image for Android AppRTCDemo local preview.
Similar to Chrome apprtc using mirror image for camera
local preview provides better experience when device
is rotated.

R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/25209004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7741 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-24 17:31:01 +00:00
henrik.lundin@webrtc.org
03499a0e95 Add wav output capability to neteq_rtpplay
This CL makes neteq_rtpplay capable of writing to wav files as well as
pcm files. This is done through the new class OutputWavFile, which
wraps a WavWriter object in an AudioSink interface.

BUG=2692
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/32139004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7740 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-24 14:50:53 +00:00
henrik.lundin@webrtc.org
aff1751c96 Add new test for VP8 packetizer to test tight partitions
It was discovered that if remaining_bytes is an exact multiple of
max_payload_len in RtpPacketizerVp8::CalcNextSize, then the packetizer
will produce too many packets (i.e., split the payload into more
packets than needed).

This CL adds a test to trigger the problem.

BUG=4019
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24289004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7739 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-24 12:36:58 +00:00
kjellander@webrtc.org
dde19a6f60 sync_chromium.py: Check for chromium/src
Make sure the script alwyas downloads Chromium
if there's no current download. This case can happen
if a user is removing the 'src' folder but doesn't know
to remove the .last_sync_chromium file.

BUG=
TESTED=Renamed chromium/src and ran a sync keeping the .last_sync_chromium file, verified it started downloading.
TBR=iannucci@chromium.org

Review URL: https://webrtc-codereview.appspot.com/27099004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7738 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-24 10:08:03 +00:00
kjellander@webrtc.org
3398a4ac15 PRESUBMIT: Only notify GN changes for GYP files in webrtc/*
We don't maintain a BUILD.gn file for talk/ since it's a part
of Chromium:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/BUILD.gn
Because of this, it's confusing to get warnings about updating
a GYP file in talk/ from the PRESUBMIT check.

TESTED=Successsfully ran git cl presubmit with this change
applied on top of a CL containing changes in .gyp files.

R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/27189004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7737 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-24 10:05:37 +00:00
kjellander@webrtc.org
8562f23acb OWNERS: Remove tomasl@ and mallinath@
mallinath@ has left the team and tomasl@ says he doesn't
know why he's owner in webrtc/test/channel_transport

R=henrika@webrtc.org, perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/30119004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7736 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-24 10:05:05 +00:00
pbos@webrtc.org
4f16c874c6 Simplifying VideoReceiver and JitterBuffer.
Removing frame_buffers_ array and dual-receiver mechanism. Also adding
some thread annotations to VCMJitterBuffer.

R=stefan@webrtc.org
BUG=4014

Review URL: https://webrtc-codereview.appspot.com/27239004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7735 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-24 09:06:48 +00:00
pbos@webrtc.org
9334ac2d78 Use vector of CSRCs for DeliverFrame & SetCSRCs.
BUG=
R=pbos@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/28029004

Patch from Changbin Shao <changbin.shao@intel.com>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7734 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-24 08:25:50 +00:00
kjellander@webrtc.org
308e7ff613 Revert "This adds an Android apk for running tests on the Java layer of PeerConnection."
This reverts r7732

Reason: Breaks compilation on Linux:
[813/818] LINK libjingle_media_unittest
FAILED: cd ../../talk; build/build_jar.sh /usr/lib/jvm/java-7-openjdk-amd64 ../out/Debug/libjingle_peerconnection_test.jar ../out/Debug/obj/talk/libjingle_peerconnection_test_jar.gen app/webrtc/javatests/src:../out/Debug/libjingle_peerconnection.jar:../third_party/junit/junit-4.11.jar app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java app/webrtc/javatests/src/org/webrtc/PeerConnectionTestJava.java
build/build_jar.sh: Entering directory `/mnt/data/b/build/slave/linux64/build/src/talk'
app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java:46:warning: [deprecation] Assert in junit.framework has been deprecated
import static junit.framework.Assert.*;
                             ^
app/webrtc/javatests/src/org/webrtc/PeerConnectionTestJava.java:36:error: cannot find symbol
  @Test
   ^
  symbol:   class Test
  location: class PeerConnectionTestJava
app/webrtc/javatests/src/org/webrtc/PeerConnectionTestJava.java:43:error: cannot find symbol
  @Test
   ^
  symbol:   class Test
  location: class PeerConnectionTestJava
2 errors
1 warning
ninja: build stopped: subcommand failed.

TBR=perkj@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/32169004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7733 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-23 21:23:00 +00:00
perkj@webrtc.org
2751f2ab4c This adds an Android apk for running tests on the Java layer of PeerConnection.
The only testcase is currently the same test we run on Java standalone.
To run the test adb shell am instrument -w org.webrtc.test/android.test.InstrumentationTestRunner

R=kjellander@webrtc.org, phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/26219004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7732 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-23 16:00:57 +00:00
thorcarpenter@google.com
88d14f483b Remove expensive and unnecessary memory alloc for sending black frames on video
mute.

Remove old crusty is_black_ member var in webrtcvideoengine which was not adding value.

R=henrike@webrtc.org, tpsiaki@google.com

Review URL: https://webrtc-codereview.appspot.com/26229004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7731 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-22 01:04:26 +00:00
andrew@webrtc.org
1153322cf8 Build fix for MIPS Android Webview build.
Excluding optimizations to support MIPS32R6 platform for Android Webview build (see also https://code.google.com/p/webrtc/source/detail?r=7580).

R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/32459004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7729 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-21 16:28:32 +00:00
magjed@webrtc.org
bdcf38c894 cricket::VideoFrame: Refactor ConvertToRgbBuffer into base class
There is also an implementation in Chromium that can be removed if/when this lands:
content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc

R=fbarchard@google.com, pbos@webrtc.org, perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/32059004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7728 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-21 10:53:00 +00:00
kjellander@webrtc.org
ad0e71c9a3 Update mock_frame_dropper.h to use size_t
This mock was missed in the work of
https://webrtc-codereview.appspot.com/23129004 since the file
is not currently used by any test in this repo.

BUG=chromium:81439
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/25199004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7727 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-21 09:40:57 +00:00
pkasting@chromium.org
4591fbd09f Use size_t more consistently for packet/payload lengths.
See design doc at https://docs.google.com/a/chromium.org/document/d/1I6nmE9D_BmCY-IoV6MDPY2V6WYpEI-dg2apWXTfZyUI/edit?usp=sharing for more information.

This CL was reviewed and approved in pieces in the following CLs:
https://webrtc-codereview.appspot.com/24209004/
https://webrtc-codereview.appspot.com/24229004/
https://webrtc-codereview.appspot.com/24259004/
https://webrtc-codereview.appspot.com/25109004/
https://webrtc-codereview.appspot.com/26099004/
https://webrtc-codereview.appspot.com/27069004/
https://webrtc-codereview.appspot.com/27969004/
https://webrtc-codereview.appspot.com/27989004/
https://webrtc-codereview.appspot.com/29009004/
https://webrtc-codereview.appspot.com/30929004/
https://webrtc-codereview.appspot.com/30939004/
https://webrtc-codereview.appspot.com/31999004/
Committing as TBR to the original reviewers.

BUG=chromium:81439
TEST=none
TBR=pthatcher,henrik.lundin,tina.legrand,stefan,tkchin,glaznev,kjellander,perkj,mflodman,henrika,asapersson,niklas.enbom

Review URL: https://webrtc-codereview.appspot.com/23129004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7726 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-20 22:28:14 +00:00
glaznev@webrtc.org
edc6e57a92 Support loopback mode and command line execution
for Android AppRTCDemo when using WebSocket signaling.

- Add loopback support for new signaling. In loopback mode
only room connection is established, WebSocket connection is
not opened and all candidate/sdp messages are automatically
routed back.
- Fix command line support both for channek and new signaling.
Exit from application when room connection is closed and add
an option to run application for certain time period and exit.
- Plus some fixes for WebSocket signaling - support
POST (not used for now) and DELETE request to WebSocket server
and making sure that all available TURN server are used by
peer connection client.

BUG=3995,3937
R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24339004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7725 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-20 21:16:12 +00:00
henrik.lundin@webrtc.org
6ff3ac1db8 Fix problems if first packet into NetEq is rejected
This CL fixes the problem described in issue 4021. In summary, of the
very first packet coming in to NetEq gets rejected because the RTP
payload type is unknown, subsequent GetAudio calls would trigger asserts
(in debug builds). The problem was that the first_packet_ variable was
reset and new_codec_ was set, even though the packet was discarded
further down the line. Now, these variables are modified after the
packet has been verified.

BUG=4021
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/29089004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7724 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-20 14:14:49 +00:00
henrik.lundin@webrtc.org
ed91068bf1 Create a NetEq test for when the first incoming payload type is unknown
This test is currently disabled. It triggers an issue where the NetEq
will trigger asserts on subsequent GetAudio calls if the first inserted
packet is rejected, for instance since the payload type is unknown to
NetEq.

BUG=4021
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/28069004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7723 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-20 11:01:02 +00:00
asapersson@webrtc.org
049e4ece30 Change default values for CpuOveruseOptions.
Enabled method based on encode time and modified values for the low (60->55) and high threshold (90->85).

Moved DelayedEncoder to fake_encoder.h and added configuration for the delay.

R=mflodman@webrtc.org, pbos@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/30969004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7722 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-20 10:19:46 +00:00
magjed@webrtc.org
f58b455cf7 cricket::VideoAdapter: Drop frames before spending time converting/scaling, not after.
In VideoCapturer::OnFrameCaptured, we currently convert cricket::CapturedFrame to cricket::VideoFrame and then send that to VideoAdapter::AdaptFrame. AdaptFrame may then decide to drop the frame. It would be faster to drop the frame before converting to cricket::VideoFrame.

This CL refactors VideoAdapter with a new function AdaptFrameResolution that takes captured resolution as input and output adapted resolution, or 0x0 if the frame should be dropped. Using that function, frames can be dropped before any conversion takes place.

R=fbarchard@google.com, perkj@webrtc.org, tommi@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=7702

Committed: https://code.google.com/p/webrtc/source/detail?r=7707

Review URL: https://webrtc-codereview.appspot.com/29949004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7721 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-19 18:09:14 +00:00
henrik.lundin@webrtc.org
40af3a56e4 Revert "Add DCHECK to ensure that NetEq's packet buffer is not empty"
This reverts r7719. It failed to compile in Chromium.

TBR=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/30179004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7720 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-19 13:46:52 +00:00
henrik.lundin@webrtc.org
6f6ef72950 Add DCHECK to ensure that NetEq's packet buffer is not empty
This DCHECK ensures that one packet was inserted after the buffer was
flushed.

R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/30169004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7719 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-19 13:02:24 +00:00
henrika@webrtc.org
2176db343c AppRTCDemoActivity: Add a config CheckBox for enabling/disabling CPU overuse adaptation. (re-land)
This CL was incorrectly reverted in r7647 by the libjingle sync bot.

TBR=kjellander@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/32489004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7717 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-18 13:22:28 +00:00
kjellander@webrtc.org
c56814fb2d Roll chromium_revision 91f1781..d8c9041
Relevant changes:
* buildtools: c27f95b..6ea835d
* third_party/icu: d8b2a9d..6242e2f
* tools/gyp: 487c0b6..b13d8f2
* tools/swarming_client: 1f8ba35..5b827c9
Details: 91f1781..d8c9041/DEPS

Clang version was not updated in this roll, although the
-Wunused-local-typedef warning was enabled by default.

R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/26189004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7716 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-18 10:25:04 +00:00
aluebs@webrtc.org
087da13fe8 Add empty 3 band splitting filter API
This is only an empty API that will never be used. For now is 48kHz not supported in AudioProcessing. For that it needs to be added in InitializeLocked. But before the 3 band filter bank needs to be populated.

BUG=webrtc:3146
R=bjornv@webrtc.org, kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/30139004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7715 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-17 23:01:23 +00:00
pkasting@chromium.org
2656bf813f Fix ExpectedQueueTimeMs() to avoid truncation or overflow.
BUG=none
TEST=none
R=asapersson@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/30129004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7714 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-17 22:21:14 +00:00