Commit Graph

3634 Commits

Author SHA1 Message Date
stefan@webrtc.org
ccd4b2aec8 Add a default RTT to CallStats and use different values for buffered/real-time mode.
BUG=1613

Review URL: https://webrtc-codereview.appspot.com/1326007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3888 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-23 15:58:23 +00:00
pbos@webrtc.org
d25b602dc0 VP8: Avoid copying the codec struct on Reset().
BUG=

Review URL: https://webrtc-codereview.appspot.com/1319013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3887 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-23 13:08:04 +00:00
mflodman@webrtc.org
efdf778d3f BUG=1351
Propose of this CL: Close the camera properly on MacOS in order to allow other apps to use it.

Changes in this CL:
1. video_capture_qtkit_info_objc.mm _captureDevicesInfo is never released. I have found this memory leak using Instruments from XCode. The patch is releasing it in dealloc.

2. In video_capture_qtkit_objc.h:
a) _captureDeviceName is not needed. Is allocated in the class but never used.
b) I don't see the role of the  NSAutoreleasePool. also if you use it you have to release it when the class is destroyed. Otherwise you will leak memory. Libjingle has for each thread a pool on mac os.

3. In video_capture_qtkit_objc.mm
a) the camera is not stopped properly . See the changes from dealloc. NOTE : If you don't call [[_captureVideoDeviceInput device] close] other apps will not be able to use the camera since you are not closing your app

b) Removed QTCaptureDevice* videoDevice = (QTCaptureDevice*)[_captureDevices objectAtIndex:0]; I don't know why this because the desired camera is opened in setCaptureDeviceById and can be different than position 0 in the camera array. At this moment if you have two cameras and user want to pick the one on index 1 the app also locks the one on 0 .

Other changes I have done to improve (and are not in this CL):
a) I have set the FPS properly to the desired. I have succeeded to reduce the CPU with 3 % doing this. The current code for setting FPS is commented in webrtc
b) I have removed _rLock from the equation. I don't know if it's good or not but I hadn't understood what exactly we are trying to protect with this. Anyway in the current implementation is never released.

Review URL: https://webrtc-codereview.appspot.com/1097014

Patch from Silviu Caragea <silviu.cpp@gmail.com>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3886 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-23 11:57:56 +00:00
mikhal@webrtc.org
c1f243f8e7 VCM/JB: Skip to the next complete key frame
Review URL: https://webrtc-codereview.appspot.com/1317006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3885 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-22 22:24:38 +00:00
pwestin@webrtc.org
63117339dc Updated the sync module with a slow moving filter
Review URL: https://webrtc-codereview.appspot.com/1326008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3884 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-22 18:57:14 +00:00
turaj@webrtc.org
28d54ab18f Improve AV-sync when initial delay is set and NetEq has long buffer.
Review URL: https://webrtc-codereview.appspot.com/1324006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3883 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-22 18:53:35 +00:00
kjellander@webrtc.org
1b427719dc emove desktop_capture.gypi from modules.gyp
When adding this in
we started getting linking problems on the mac_asan bot due to
the empty list of source files for the library target.

Please re-add it into modules.gyp when the library has source files
to compile.

BUG=none
TEST=Passing mac_asan trybot.

Review URL: https://webrtc-codereview.appspot.com/1313009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3882 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-22 13:13:49 +00:00
mflodman@webrtc.org
7c9e992d05 Removed unused variable.
Review URL: https://webrtc-codereview.appspot.com/1320013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3881 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-22 13:05:41 +00:00
mflodman@webrtc.org
aeff4f3003 Fixing Coverity issues.
BUG=C14457, C10611

Review URL: https://webrtc-codereview.appspot.com/1320012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3880 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-22 12:41:57 +00:00
tommi@webrtc.org
8aa4a90bd9 Set mime type on device-switch.html
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3879 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-22 05:43:13 +00:00
kjellander@webrtc.org
006acc45c2 Update iOS build script to run on bots.
The script previously only executed build/gyp_chromium to
generate projects. This is not sufficient since the
supplement.gypi has not yet been created (happens in
gclient runhooks). Therefore this CL changes it to run
gclient runhooks instead (marginally slower).
Otherwise the bots would have to generate the projects
twice, which is inefficient.

Annotations are also added to make the upcoming buildbot
steps more readable when the script is running as an
annotated step.

TEST=local compilation on OS X.
BUG=none

Review URL: https://webrtc-codereview.appspot.com/1342005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3878 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-20 13:04:05 +00:00
mikhal@webrtc.org
e0e029e8cb Revert 3876
Review URL: https://webrtc-codereview.appspot.com/1341005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3877 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-19 21:11:41 +00:00
mikhal@webrtc.org
ee184b9520 VCM/Receiver: Only update render time when decoding
Review URL: https://webrtc-codereview.appspot.com/1336004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3876 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-19 19:15:47 +00:00
kjellander@webrtc.org
c41478f7eb Ensure build_demo.py run subprocesses with bash shell.
It turns out the default shell becomes /bin/sh on Lucid. By specifying the shell for subprocess.check_call we ensure bash is used.

Thanks to yujie.mao@intel.com for pointing this out.

BUG=1659
TEST=Successful build with build_demo.py both on Ubuntu Lucid and Precise.
TBR=leozwang

Review URL: https://webrtc-codereview.appspot.com/1343004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3875 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-19 11:50:42 +00:00
braveyao@webrtc.org
a39a8fec16 Add owner to Apprtc
Review URL: https://webrtc-codereview.appspot.com/1328007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3874 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-19 02:34:45 +00:00
sjlee@webrtc.org
1fea17dae4 Add the build script of the voice engine for iOS.
Review URL: https://webrtc-codereview.appspot.com/1319007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3873 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-18 23:22:02 +00:00
mikhal@webrtc.org
a73d52ca52 revert r3871
TBR= solenberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1331004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3872 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-18 20:26:28 +00:00
solenberg@webrtc.org
9756017717 - Replace the BWE_MIN and BWE_MAX macros with std::min and std::max
- Add 'virtual' to a bunch of overridden methods of RemoteBitrateEstimatorMultiStream and RemoteBitrateEstimatorSingleStream.

BUG=

Review URL: https://webrtc-codereview.appspot.com/1324005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3871 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-18 19:12:42 +00:00
solenberg@webrtc.org
d26457fdeb Apply Chromium C++ style to BitRateStats.
BUG=

Review URL: https://webrtc-codereview.appspot.com/1325006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3870 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-18 12:25:32 +00:00
mflodman@webrtc.org
65f995a3df New ViE interface.
BUG=1667

Review URL: https://webrtc-codereview.appspot.com/1113004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3869 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-18 12:02:52 +00:00
braveyao@webrtc.org
c14b728b71 Add lock to prevent possible rare race condition in Win coreAudio capture implementation.
BUG = 
TEST = voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/1320011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3868 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-18 09:32:07 +00:00
andrew@webrtc.org
ceaedc0014 Remove executable bit from dc1.html.
Review URL: https://webrtc-codereview.appspot.com/1320010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3867 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-18 01:56:07 +00:00
sergeyu@chromium.org
a0cd9182aa Add desktop_capture directory for screen and window capturers.
The screen captures will be moved from chromium to WebRTC to make it easy
to share this code with other projects. This CL adds a new directory where
the current screen capturer code will be moved to.

Review URL: https://webrtc-codereview.appspot.com/1297005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3866 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-17 18:21:42 +00:00
mikhal@webrtc.org
dbd6a6d653 Updating delay for first value
BUG=

Review URL: https://webrtc-codereview.appspot.com/1327005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3865 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-17 16:23:22 +00:00
andresp@webrtc.org
48c5882f2a Remove libvpx pre-processor conditions and conditional compile of default temporal layers files.
R=stefan@webrtc.org,marpan@webrtc.org
BUG=201

Review URL: https://webrtc-codereview.appspot.com/1323005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3864 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-17 15:31:40 +00:00
kjellander@webrtc.org
f09016744d Revert "Updating test file contents to emmastjernloef"
This reverts r3861

TEST=none
BUG=none
TBR=phoglund

Review URL: https://webrtc-codereview.appspot.com/1317005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3863 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-17 14:59:28 +00:00
hta@webrtc.org
f1bf3a00b2 A device switcher code example, with fake.
This demo shows the usage of the proposed getDeviceInfo call and its
associatied permissions model.

Review URL: https://webrtc-codereview.appspot.com/1320008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3862 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-17 14:24:21 +00:00
kjellander@webrtc.org
11959d3476 Updating test file contents to emmastjernloef
This way, we honour Emma Stjernlöf in the Stockholm office.

TEST=test_support_unittests
BUG=none

Review URL: https://webrtc-codereview.appspot.com/1320009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3861 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-17 13:58:54 +00:00
tina.legrand@webrtc.org
db11fab49e Adding Opus unit test
This CL adds a unit test for Opus, as well as new APIs for true stereo decoding (skipping master/slave approach).

BUG=

Review URL: https://webrtc-codereview.appspot.com/1222006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3860 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-17 10:39:41 +00:00
henrika@webrtc.org
4392d5f9f8 Fix for "RTP dynamic payload type 100 is reserved"
TBR=perkj
BUG=227036 (in crbug.com)

TEST=out\Debug\voe_auto_test.exe --automated --gtest_filter=Dtmf* where I
manually modified the test and used 100 as new PT (which I first verified was
already used by CN, 48000).

BUG=

Review URL: https://webrtc-codereview.appspot.com/1319010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3859 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-17 07:34:25 +00:00
turaj@webrtc.org
f1a3b4bc0c Issue 1647. Avoid unsequenced modification.
issue=1647
test=trybots,manual

Review URL: https://webrtc-codereview.appspot.com/1327004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3858 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-16 17:01:35 +00:00
pbos@webrtc.org
6e788df19e Remove vim/emacs modelines from .gypi files
BUG=1655

Review URL: https://webrtc-codereview.appspot.com/1326005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3857 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-16 12:40:34 +00:00
solenberg@webrtc.org
56b5f77a2b Add support for multiple streams to RtpPlayer:
- Tests video_rtp_play.cc, video_rtp_play_mt.cc, decode_from_storage.cc rewritten
 - rtp_player.cc/.h rewritten; added interfaces for externally setting up sinks
 - Support for reading .rtp files pulled out into rtp_file_reader namespace
 - Added support for reading .pcap (libpcap/wireshark/tcpdump) files, see pcap_file_reader

BUG=
TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/1201009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3856 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-16 10:31:56 +00:00
stefan@webrtc.org
885cd13356 Start NACKing as soon as we have the first packet of a key frame.
BUG=1605

Review URL: https://webrtc-codereview.appspot.com/1307007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3855 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-16 09:38:26 +00:00
stefan@webrtc.org
bdb9b971be Change receive statistics bitrate to be provided in bps instead of kbps.
BUG=1469

Review URL: https://webrtc-codereview.appspot.com/1326004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3854 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-16 09:02:03 +00:00
wu@webrtc.org
e44a064915 Make win_support_condition_variables_primitive global to aligned with |library|
so that once we set it to true it will remain.
Review URL: https://webrtc-codereview.appspot.com/1319006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3852 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-15 18:06:42 +00:00
turaj@webrtc.org
92d1f07551 Elevate NetEq short-term activity statistics to ACM level for logging.
Review URL: https://webrtc-codereview.appspot.com/1313004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3850 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-15 16:52:04 +00:00
kjellander@webrtc.org
4b8de90dce Disable -Wunsequenced warning in audio_coding_module
BUG=1647
TEST=Compile locally on Linux with clang enabled.
TBR=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1316005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3848 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-15 06:38:56 +00:00
kjellander@webrtc.org
f806ad23db Roll chromium_revision 182149:193311
This will among other things give us:
* Tons of updates to build/android stuff (needed to make Android NDK bots work
  in Chrome infra)
* Clang updated to 176256 (r187059)
* Support for fastbuild=2, which completely disables debug information (r191876)
* enable -Wstring-conversion when compiling with clang (r183998)
* Update ndk sysroot to API level 14 (r186254)

Detailed changelog:
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=trunk%2Fsrc%2Fbuild&range=182149%3A193311&mode=html

build/common.gypi changes:
http://src.chromium.org/viewvc/chrome/trunk/src/build/common.gypi?r1=182149&r2=193311

TEST=trybots passing
BUG=none

Review URL: https://webrtc-codereview.appspot.com/1317004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3847 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-15 05:52:57 +00:00
marpan@webrtc.org
c83b35661d Roll libvpx to 192165.
-pick up libvpx roll to 3db60c8.

TBR=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1321004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3846 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-12 21:43:48 +00:00
mikhal@webrtc.org
c2a3aa7926 Partial revert of r3844
Review URL: https://webrtc-codereview.appspot.com/1320004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3845 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-12 19:53:30 +00:00
mikhal@webrtc.org
d6bd7cd2b1 removing redundant calls to cleanframes
Review URL: https://webrtc-codereview.appspot.com/1318004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3844 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-12 17:09:51 +00:00
mflodman@webrtc.org
9f5ebb5251 Adding a payload type for RTX.
BUG=736
TEST=Modified RTP unittests.

Review URL: https://webrtc-codereview.appspot.com/1278004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3843 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-12 14:55:46 +00:00
stefan@webrtc.org
b8e7f4cc97 Change capture interface to use NTP capture time.
Move NTP functionality to Clock.

BUG=1563
TEST=trybots and vie_auto_test --automated

Review URL: https://webrtc-codereview.appspot.com/1313005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3842 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-12 11:56:23 +00:00
kjellander@webrtc.org
d35dff7664 Move to Chrome infra try server.
I'm not sure how critical it is to have the android+android_ndk try bots, as they're not yet up at http://build.chromium.org/p/tryserver.webrtc/waterfall
I have a CL for android_ndk (https://codereview.chromium.org/11896066), but I don't have a good solution for the android platform build yet.

After this is submitted, developers can still send jobs to the old try server (assuming we keep those bots over there) with:
git try -H webrtc-cb-linux-master.cbf.corp.google.com -P 9018 --bot=android,android_ndk

The default (and the only option for public users) will however be the new Chromium try server (via the SVN queue).

BUG=chromium:174594
TEST=successfully submitted a try job that was built at http://build.chromium.org/p/tryserver.webrtc/waterfall

Review URL: https://webrtc-codereview.appspot.com/1213004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3841 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-12 07:40:33 +00:00
pwestin@webrtc.org
1de01354e6 Adding playout buffer status to the voe video sync
Review URL: https://webrtc-codereview.appspot.com/1311004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3835 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-11 20:23:35 +00:00
mikhal@webrtc.org
9da751715f VCM/JB:Removing hybrid and setting a decodable state.
Review URL: https://webrtc-codereview.appspot.com/1283004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3834 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-11 18:49:13 +00:00
stefan@webrtc.org
7bc465bd21 Fix issues with incorrect wrap checks when having big buffers and high bitrate.
Introduces shared functions for timestamp and sequence number wrap checks.

BUG=1607
TESTS=trybots

Review URL: https://webrtc-codereview.appspot.com/1291005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3833 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-11 17:48:02 +00:00
stefan@webrtc.org
122d209e67 Fixes an issue where the start bitrate is stored in kbps instead of bps.
BUG=1638
TEST=trybots and vie_auto_test loopback with nack.

Review URL: https://webrtc-codereview.appspot.com/1312004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3831 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-11 17:21:40 +00:00
wu@webrtc.org
eac36b8561 Fix -Wstring-conversion warnings.
Review URL: https://webrtc-codereview.appspot.com/1299007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3830 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-11 15:37:46 +00:00