825 Commits

Author SHA1 Message Date
stefan@webrtc.org
7dfa883954 Disable spatial subsampling for denoiser variance estimation.
With subsampling there are sometimes quite visible trailing
artifacts.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/387002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1634 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 08:27:31 +00:00
pwestin@webrtc.org
95392e64ba Bugfix EnableIPV6 issue 255
Review URL: https://webrtc-codereview.appspot.com/378005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1633 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 08:08:37 +00:00
kjellander@webrtc.org
1970b2fcb3 Fixing uninitialized codec settings struct in test.
BUG=
TEST=video_codecs_test_framework_unittests passing in Debug+Release on Linux, Mac and Windows.

Review URL: https://webrtc-codereview.appspot.com/378004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1632 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 07:09:32 +00:00
andrew@webrtc.org
648af7423f Clean up MapSetting().
- Add assert(false) for "impossible" cases.
- Remove tests for invalid enum values.
- Modify MapError() to look the same way.

BUG=
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/386001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1631 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 01:57:29 +00:00
wu@webrtc.org
9143f774d1 Coverity fix for VideoRenderModule including issues 10084, 10226, 10267 and 10340.
Review URL: https://webrtc-codereview.appspot.com/385001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1630 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 00:14:25 +00:00
bjornv@webrtc.org
236e842bca Removed memcpy of pointer to itself, triggering Valgrind warning.
BUG=272
Review URL: https://webrtc-codereview.appspot.com/389002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1628 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 17:22:44 +00:00
phoglund@webrtc.org
78088c2f36 Removed warnings on Windows and enabled warnings-as-errors on Windows.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/377004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1624 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 14:56:45 +00:00
niklas.enbom@webrtc.org
87885e8409 This CL will look a bit strange. Essentially I've removed sanity checks for > 1 channel and then fixed the bugs that remained. Will add testing in a separate CL.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/390001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1623 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 14:48:59 +00:00
andrew@webrtc.org
daacee81b8 Use better reference files with audioproc_unittest.
The files are shorter (7 s) with one set provided for each sample rate.

Will be accompanied by the following set of files in the resource bundle:
far8_stereo.pcm
far16_stereo.pcm
far32_stereo.pcm
near8_stereo.pcm
near16_stereo.pcm
near32_stereo.pcm

BUG=114
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/380003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1617 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 00:01:04 +00:00
wu@webrtc.org
50099af75f Disable flaky test VideoProcessorIntegrationTest.Process5PercentPacketLoss.
BUG=262
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/379014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1614 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 22:50:48 +00:00
marpan@webrtc.org
6584e58001 Coverity fix for issues 10325,10326.
Review URL: https://webrtc-codereview.appspot.com/377001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1613 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 19:02:54 +00:00
wu@webrtc.org
13e0345b35 Fix uninitialized variable error in Relase mode.
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/377007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1611 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 16:19:15 +00:00
mflodman@webrtc.org
517e5e3846 NetEQ switch fix.
Review URL: https://webrtc-codereview.appspot.com/381006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1610 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 15:04:00 +00:00
stefan@webrtc.org
94355e0a59 Fix crash in SessionInfo::BuildSoftNackList.
BUG=259
TEST=

Review URL: https://webrtc-codereview.appspot.com/377006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1609 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 14:06:39 +00:00
mflodman@webrtc.org
a39621ee1b Disabling APM test for invalid enum values.
Review URL: https://webrtc-codereview.appspot.com/378006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1608 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 14:00:12 +00:00
mflodman@webrtc.org
ec31bc1321 Fixed APM tests.
TEST=ApmTest.*

Review URL: https://webrtc-codereview.appspot.com/380008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1607 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 12:42:45 +00:00
mflodman@webrtc.org
657b2a4965 Added return due to gcc complaints in r1604.
TBR=andrew

TEST=Bulid with clang version 3.1 (trunk 148911) and gcc.

Review URL: https://webrtc-codereview.appspot.com/384004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1606 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 11:06:01 +00:00
mflodman@webrtc.org
c80d9d9361 Removed default cases causing clang errors, -Wcovered-switch-default.
BUG=
TEST=Bulid with clang version 3.1 (trunk 148911)

Review URL: https://webrtc-codereview.appspot.com/379008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1604 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 10:11:25 +00:00
andrew@webrtc.org
4942832928 Fix "may be used uninitialized" warning.
TBR=marpan@webrtc.org
BUG=
TEST=build on Linux/Release and rtp_rtcp_unittests

Review URL: https://webrtc-codereview.appspot.com/381004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1602 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-04 05:23:51 +00:00
marpan@webrtc.org
b783a55df3 Unit test for forward_error_correction.
Review URL: https://webrtc-codereview.appspot.com/358006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1601 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-04 02:46:35 +00:00
marpan@webrtc.org
307c1ff20c Fix for issue #254: windows crash of test_fec.
Review URL: https://webrtc-codereview.appspot.com/379010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1600 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-04 02:45:22 +00:00
andrew@webrtc.org
dde977ec83 AudioFrame payload shouldn't be mutable.
This requires making Mute() non-const, which is correct anyway.

BUG=
TEST=voe_auto_test on Linux

Review URL: https://webrtc-codereview.appspot.com/376001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1599 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-03 17:47:32 +00:00
henrik.lundin@webrtc.org
683833442a Fix for warning in GCC 4.6
Upstream copy of a fix provided in http://codereview.chromium.org/9309007/.

BUG=none
TEST=neteq_unittests

Review URL: https://webrtc-codereview.appspot.com/383002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1596 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-03 12:33:50 +00:00
henrik.lundin@webrtc.org
82e1c8d0e7 Fix for issue 253
Initializing a few arrays to avoid compiler warnings under
the O3 flag.

BUG=http://code.google.com/p/webrtc/issues/detail?id=253

Review URL: https://webrtc-codereview.appspot.com/380005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1595 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-03 09:46:01 +00:00
pwestin@webrtc.org
fdf21c8c55 Removed dead version code.
Review URL: https://webrtc-codereview.appspot.com/377003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1594 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-02 12:46:58 +00:00
pwestin@webrtc.org
4ea57e5e26 Changed VP8 to follow the style guide a little bit more.
Review URL: https://webrtc-codereview.appspot.com/379003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1593 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-02 12:21:47 +00:00
stefan@webrtc.org
07b45a5dc4 Added API for getting the send-side estimated bandwidth.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/372006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1591 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-02 08:37:48 +00:00
kma@webrtc.org
de66b91274 In voice engine, added member audioFrame to classes AudioCodingModuleImpl and VoEBaseImpl,
and touched VoEBaseImpl::NeedMorePlayData and AudioCodingModuleImpl::PlayoutData10Ms(), for
performance reasons in Android platforms.
The two functions used about 6% of VoE originally. After the change, the percentage reduced
to about 0.2%.
Review URL: https://webrtc-codereview.appspot.com/379001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1589 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 18:39:44 +00:00
andrew@webrtc.org
7fe219f681 Add some additional checks for corrupt payload.
Investigation with corrupt payloads revealed a few places we could
be using stronger checks. These are not foolproof by any means, but
I figure the earlier we catch this the better.

BUG=242
TEST=loopback call with a hacked ViE to insert corrupt payloads, and vie_auto_test without the hacks.

Review URL: https://webrtc-codereview.appspot.com/369015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1585 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 02:40:37 +00:00
kma@webrtc.org
727a0a03a1 Fixed a bug in assembly code in aecm_core.c (hasn't caused a problem yet).
Did apm unit test. Bit exact.
Review URL: https://webrtc-codereview.appspot.com/366010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1583 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 00:05:22 +00:00
frkoenig@google.com
d8f58a4ab0 Cross platform build fix for SSIM (part 2)
Data alignment fix for SSIM.

WebRtc_UWord64[2] wasn't always aligned to 128 bytes, which
is necessary for _mm_store_si128.  By declaring the 
variable as __m128i it will always be 128 bytes aligned.

Related to issue 239013.
http://webrtc-codereview.appspot.com/239013/
Review URL: https://webrtc-codereview.appspot.com/375004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1582 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 17:49:38 +00:00
henrik.lundin@webrtc.org
dd478e2081 Fix for warning in GCC 4.6
Upstream copy of a fix provided in http://codereview.chromium.org/9159058/.

Review URL: https://webrtc-codereview.appspot.com/369024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1580 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 13:12:41 +00:00
stefan@webrtc.org
91c630851a Fix potential VCMReceiver crash.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/368012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1578 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 10:49:08 +00:00
marpan@webrtc.org
cdba1a836b test_fec: Reduce execution time of test, and use testsupport/fileutils.h for path of randomSeedLog file.
Review URL: https://webrtc-codereview.appspot.com/373016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1576 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 00:36:14 +00:00
andrew@webrtc.org
293d22b39b Add a new macro for bit-exact audioproc tests.
Enable bit-exact test for all fixed-point configs.

BUG=114
TEST=audioproc_unittest on all platforms.

Review URL: https://webrtc-codereview.appspot.com/369018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1575 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 22:04:26 +00:00
andrew@webrtc.org
40654039cd Use pointer-based CriticalSectionScoped().
The reference-based constructor is deprecated.

BUG=185
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/373015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1573 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 20:51:15 +00:00
kma@webrtc.org
89a100092a A minor change in function WebRtcNetEQ_PacketBufferFindLowestTimestamp for
NetEq, for performance reasons.
In Android platform, with an offline testing file, the function cycles was reduced by 25%.
This function was also reformatted.
Review URL: https://webrtc-codereview.appspot.com/367010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1571 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 15:37:33 +00:00
pwestin@webrtc.org
5dad00be52 Coverty fix: FEC unintended signed extension and resource leaks.
Review URL: https://webrtc-codereview.appspot.com/368010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1569 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 13:05:29 +00:00
mflodman@webrtc.org
d3b22c9356 Resolved X11 shared memiory leak.
BUG=248
TEST=See bug

Review URL: https://webrtc-codereview.appspot.com/367016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1568 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 09:44:28 +00:00
bjornv@webrtc.org
0c6f931420 Removed versions in module/audio_processing and common_audio/vad.
Affected vad_unittest only.
In addition changed to correct header guards.
Review URL: https://webrtc-codereview.appspot.com/367019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1567 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 09:39:08 +00:00
stefan@webrtc.org
2fd1e1e40d Add unittests for ReceiverFec.
Also added mock for RtpReceiverVideo and did appropriate changes to
allow for mocking.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1566 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 09:03:37 +00:00
pwestin@webrtc.org
04cf69a714 Coverty: cleanup CheckCSRC.
Review URL: https://webrtc-codereview.appspot.com/369014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1564 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 13:47:19 +00:00
phoglund@webrtc.org
2f7740973d Fixed C errors from GCC 4.6.
Fixed errors in .c files.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/373014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1563 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 13:44:26 +00:00
mflodman@webrtc.org
1f992807eb Fixed frame scaler bugs.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1562 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 13:42:53 +00:00
tina.legrand@webrtc.org
cbe1de9aa6 This CL solves three remaining Coverity warnings.
A few more members were left uninitialized, and one more size mismatch in a multiplication.

Review URL: https://webrtc-codereview.appspot.com/367001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1558 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 09:00:46 +00:00
mallinath@webrtc.org
a8c568f0a4 Fix external codec erase in destructor.
Review URL: https://webrtc-codereview.appspot.com/368008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1555 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-26 16:19:03 +00:00
phoglund@webrtc.org
d1a860b415 Fixed GCC 4.6 errors (mostly 'unused variable' errors and incorrect usage of EXPECT_EQ with booleans.
Fixed remaining compilation errors in release, etc.

Fixed errors from GCC 4.6 compilation.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/366008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1554 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-26 14:49:28 +00:00
andrew@webrtc.org
42ae41e5a2 Fix enumeral comparison error.
TBR=henrike
BUG=
TEST=build on Linux.

Review URL: https://webrtc-codereview.appspot.com/372007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1553 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 19:38:16 +00:00
andrew@webrtc.org
b9d7d934de Rename interface/ to include/ in audio_processing.
BUG=none
TEST=build on Linux.

Review URL: https://webrtc-codereview.appspot.com/367007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1552 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 19:21:13 +00:00
andrew@webrtc.org
24bd58e689 Properly count anonymous mixing participants.
When _amountOfMixableParticipants == 1, we skip mixing and saturation
protection. Without this fix, an anonymous participant would only be
properly counted if it was the last added.

For example, if an anonymous participant was added first, followed by
a regular participant, _amoutOfMixableParticipants would == 1 and the
regular participant would not be mixed.

BUG=issue209
TEST=New test added to voe_auto_test to verify, and used voe_cmd_test.

Review URL: https://webrtc-codereview.appspot.com/367006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1551 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 18:57:44 +00:00