Commit Graph

236 Commits

Author SHA1 Message Date
xians@webrtc.org
843c8c78ff Remove the deprecated kTraceModuleCall trace from video modules.
Review URL: https://webrtc-codereview.appspot.com/391015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1725 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-20 08:45:02 +00:00
marpan@webrtc.org
bd5648f2db Reverting 1718: failed linux video test.
TBR=stefan, andrew, marpan.
Review URL: https://webrtc-codereview.appspot.com/392018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1719 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-17 23:16:58 +00:00
marpan@webrtc.org
883e716304 Removed unused motion vector metrics from VideoContentMetrics;
also removed other related unused variables and code. 

Reset frame rate estimate in mediaOpt when frame rate reduction is decided.

Update content_metrics with frame rate and qm_resolution with frame size.
Review URL: https://webrtc-codereview.appspot.com/395007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1718 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-17 18:35:23 +00:00
stefan@webrtc.org
439be29445 Add APIs for getting receive-side estimated bandwidth and codec target rate.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/391012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1704 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-16 14:45:37 +00:00
marpan@webrtc.org
79a99de8e4 Reverting 1680: valgrind memory leak reported.
TBR=marpan
Review URL: https://webrtc-codereview.appspot.com/392011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1686 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-14 22:37:10 +00:00
marpan@webrtc.org
4e34dcbd62 Allow for spatial-downsampling without reinitializaing encoder. Change of frame size will automatically trigger new key frame in codec. This feature is set off in vie_encoder until we upgrade to the new libvpx.
Also reset frame rate estimate in mediaOpt when frame rate reduction is decided.
Review URL: https://webrtc-codereview.appspot.com/390006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1680 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-14 17:26:24 +00:00
pwestin@webrtc.org
c76c096c19 Bugfix issue 273, workaround for compiler issue.
Review URL: https://webrtc-codereview.appspot.com/392005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1675 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-13 09:56:57 +00:00
pwestin@webrtc.org
52fd98d876 Removing encoder reset. Function did not make sence.
Review URL: https://webrtc-codereview.appspot.com/391005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1674 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-13 09:03:53 +00:00
pwestin@webrtc.org
5e954814a8 Clanup handling of key frame requests and FIR.
Review URL: https://webrtc-codereview.appspot.com/387004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1667 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-10 12:13:12 +00:00
kjellander@webrtc.org
cf6a295b13 Making video codecs test framework integration test execute in a reproducable fashion.
Fixed reproducable random behavior in packet_manipulator.h.
Test is now fully reproducable (runs on only one core) so much tighter limits are now set for the SSIM/PSNR values for the encoding/decoding (verified on all platforms)

BUG=
TEST=out/Debug/video_codecs_test_framework_integrationtests in Debug+Release on Linux, Mac, Windows and in Linux Valgrind.

Review URL: https://webrtc-codereview.appspot.com/381005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1649 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-09 09:01:51 +00:00
mflodman@webrtc.org
d2940f71e4 VCM::JB critsect fix.
Review URL: https://webrtc-codereview.appspot.com/390004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1639 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 12:42:56 +00:00
stefan@webrtc.org
23307f7c4b Remove frame_list.cc from Andorid.mk.
TBR=mflodman
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/390003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1638 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 10:39:13 +00:00
stefan@webrtc.org
2979461595 Refactored the jitter buffer to use std::list.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/352016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1635 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 08:58:55 +00:00
kjellander@webrtc.org
1970b2fcb3 Fixing uninitialized codec settings struct in test.
BUG=
TEST=video_codecs_test_framework_unittests passing in Debug+Release on Linux, Mac and Windows.

Review URL: https://webrtc-codereview.appspot.com/378004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1632 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 07:09:32 +00:00
phoglund@webrtc.org
78088c2f36 Removed warnings on Windows and enabled warnings-as-errors on Windows.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/377004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1624 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-07 14:56:45 +00:00
wu@webrtc.org
50099af75f Disable flaky test VideoProcessorIntegrationTest.Process5PercentPacketLoss.
BUG=262
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/379014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1614 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 22:50:48 +00:00
marpan@webrtc.org
6584e58001 Coverity fix for issues 10325,10326.
Review URL: https://webrtc-codereview.appspot.com/377001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1613 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 19:02:54 +00:00
stefan@webrtc.org
94355e0a59 Fix crash in SessionInfo::BuildSoftNackList.
BUG=259
TEST=

Review URL: https://webrtc-codereview.appspot.com/377006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1609 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 14:06:39 +00:00
mflodman@webrtc.org
c80d9d9361 Removed default cases causing clang errors, -Wcovered-switch-default.
BUG=
TEST=Bulid with clang version 3.1 (trunk 148911)

Review URL: https://webrtc-codereview.appspot.com/379008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1604 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 10:11:25 +00:00
pwestin@webrtc.org
fdf21c8c55 Removed dead version code.
Review URL: https://webrtc-codereview.appspot.com/377003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1594 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-02 12:46:58 +00:00
pwestin@webrtc.org
4ea57e5e26 Changed VP8 to follow the style guide a little bit more.
Review URL: https://webrtc-codereview.appspot.com/379003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1593 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-02 12:21:47 +00:00
stefan@webrtc.org
91c630851a Fix potential VCMReceiver crash.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/368012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1578 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 10:49:08 +00:00
mallinath@webrtc.org
a8c568f0a4 Fix external codec erase in destructor.
Review URL: https://webrtc-codereview.appspot.com/368008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1555 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-26 16:19:03 +00:00
phoglund@webrtc.org
d1a860b415 Fixed GCC 4.6 errors (mostly 'unused variable' errors and incorrect usage of EXPECT_EQ with booleans.
Fixed remaining compilation errors in release, etc.

Fixed errors from GCC 4.6 compilation.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/366008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1554 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-26 14:49:28 +00:00
mallinath@webrtc.org
218db3de20 Iterator was invalid while removing entries from codec db maps.
Review URL: http://webrtc-codereview.appspot.com/373003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1534 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 17:11:44 +00:00
leozwang@webrtc.org
f9cd693145 Enable vp8 and videoengine on android
Review URL: https://webrtc-codereview.appspot.com/368003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1510 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 16:56:13 +00:00
stefan@webrtc.org
175fecde97 Fix clang build error.
TBR=henrik.lundin@webrtc.org
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1505 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 15:23:31 +00:00
stefan@webrtc.org
8fe03af674 Refactor to use std::list in the video rtp play tools.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/349013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1504 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 14:56:14 +00:00
stefan@webrtc.org
f27916a76a Remove use of MapWrapper in video_coding.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/344018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1498 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 14:04:13 +00:00
marpan@webrtc.org
20cd06123c For TL(temporal layers) = 2, the alt-ref frame should not be used as a reference.
Correction for the last frame in the cycle.
Review URL: https://webrtc-codereview.appspot.com/343015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1479 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 18:25:23 +00:00
henrik.lundin@webrtc.org
dcdb744eee Remove an old comment in vp8 wrapper
The operation that the comment describes was removed in r482.

Review URL: https://webrtc-codereview.appspot.com/353008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1470 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 13:06:43 +00:00
stefan@webrtc.org
8e50693736 Fixes for code analysis warnings.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/355004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1467 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 12:30:21 +00:00
pwestin@webrtc.org
5621057956 Removing unused code.
Review URL: https://webrtc-codereview.appspot.com/349008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1442 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-17 12:45:47 +00:00
stefan@webrtc.org
8ddf9a4e18 Ported more jitter buffer tests to unit tests.
BUG=
TEST=jitter_buffer_unittest

Review URL: http://webrtc-codereview.appspot.com/350009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1433 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 11:59:01 +00:00
pwestin@webrtc.org
9cbe6867e7 Removed experiment.
Review URL: http://webrtc-codereview.appspot.com/345005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1413 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 15:35:28 +00:00
stefan@webrtc.org
ad4af57abd Fixes a jitter buffer NACK bug.
If no frame has been decoded the jitter buffer might generate huge
erroneous NACK lists.

Adds a couple of new jitter buffer unittests (some ported from
jitter_buffer_test.cc).

Adds a test to the VCM robustness tests.

BUG=226
TEST=VCMRobustnessTest, TestJitterBufferFull, TestNackListFull, TestNackBeforeDecode, TestNormalOperation

Review URL: http://webrtc-codereview.appspot.com/352002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1412 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 15:16:49 +00:00
stefan@webrtc.org
cd8cea50a6 Fix decode error in NACK/FEC mode after network glitch.
Caused when recyclingframes until the next key frame to
regain frame buffers when the jitter buffer is full.

BUG=http://code.google.com/p/webrtc/issues/detail?id=225
TEST=

Review URL: http://webrtc-codereview.appspot.com/350005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1390 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 14:17:44 +00:00
stefan@webrtc.org
b07aa403b3 Fixes issue 210. Removes diff between two different arrays.
Also fixes the FrameBuffer copy constructor.

BUG=210
TEST=

Review URL: http://webrtc-codereview.appspot.com/347002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1364 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-10 11:45:05 +00:00
marpan@webrtc.org
2dad3fbe49 Media-opt: Added a filter type mode for the filtering of the received packet loss. This makes the filter selection explicit and easier to modify/test.
Removed the function UpdateLossPr(); the filter updates are done in the same function that returns the filtered loss.
Review URL: http://webrtc-codereview.appspot.com/333018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1361 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-09 18:18:36 +00:00
pwestin@webrtc.org
c450a19669 Removed Version function from all modules.
TBR=henrik_a
Review URL: http://webrtc-codereview.appspot.com/329023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1330 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 15:00:12 +00:00
kjellander@webrtc.org
cc33737a80 Changing all PSNR/SSIM calculations to use libyuv.
Removed old PSNR/SSIM implementations in:
* test/testsupport/metrics/video_metrics.cc
* src/modules/video_coding/codecs/test_framework/test.cc
The functions in video_metrics.cc is now using code in libyuv instead. Old code in test.cc is using the same functions.
The code for video_metrics.h had to be moved into a separate GYP file to avoid circular dependency error on Mac (see issue 160 for more details). The reason for this is that libyuv's unittest target depends on test_support_main.

BUG=
TEST=metrics_unittests in Debug+Release on Linux, Mac and Windows.

Review URL: http://webrtc-codereview.appspot.com/333025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1325 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 08:09:32 +00:00
mikhal@webrtc.org
cd64886a2f video_coding: Updating NACK functions naming
Review URL: http://webrtc-codereview.appspot.com/329018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1322 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 23:59:42 +00:00
mikhal@webrtc.org
77c425b976 video_coding: Checking/updating seq num for an old packet regardless of size.
Review URL: http://webrtc-codereview.appspot.com/330028

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1318 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 20:35:25 +00:00
kjellander@webrtc.org
a643d5c4ef Integration test for videoprocessor
Added temporal layers number flag for video_quality_measurement tool.
This tool now also uses webrtc::VideoCodingModule::Codec() to get its
VideoCodec struct configuration instead of filling it in manually.

Updated paths for header files to use full directory paths.

Tested in Debug+Release on Linux, Mac and Windows. Passes Valgrind memcheck on Linux.

BUG=
TEST=video_codecs_test_framework_integrationtests. Also executed out/Debug/video_quality_measurement --input_filename=resources/foreman_cif.yuv  --width=352 --height=288

Review URL: http://webrtc-codereview.appspot.com/339001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1310 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-30 14:44:07 +00:00
mikhal@webrtc.org
62665b8cd3 video_coding: Adding a unit test to the decodableState class
Review URL: http://webrtc-codereview.appspot.com/315001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1309 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-29 18:09:58 +00:00
mikhal@webrtc.org
9eeafbef3c Updating the frame buffer return value in InsertPacket: Return NoError when a packet is inserted to a frame which is being decoded.
Review URL: http://webrtc-codereview.appspot.com/330027

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1308 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-29 17:38:56 +00:00
mikhal@webrtc.org
bed34a341a video_coding: Updating seq number for old zero size packets. Updating function name to reflect zero size packets and not empty packets.
Review URL: http://webrtc-codereview.appspot.com/333009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1307 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-29 17:37:39 +00:00
stefan@webrtc.org
efd0a48c61 Add error resilient mode options to the VP8 specific VideoCodec struct.
It is useful to disable error resilience when we know we won't decode
with errors.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/329015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1305 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-29 10:12:35 +00:00
stefan@webrtc.org
39670f6aa6 Only reset the last decoded sequence number after flushing until key frame.
We can't reset the complete last decoded state when we recycle until a
key frame because that will allow any delta frame to be decoded afterwards,
and since the decoder isn't reset we will get decode errors.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/330003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1295 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-23 09:08:51 +00:00
stefan@webrtc.org
f5edb923b1 Remove unused variable.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/333016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1279 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-22 08:34:31 +00:00