Commit Graph

1169 Commits

Author SHA1 Message Date
phoglund@webrtc.org
6418a24795 Rewrote hardware-before-init and rtp-rtcp-before-streaming test code to gtest.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/322003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1161 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-12 16:24:23 +00:00
stefan@webrtc.org
1480f02faf Fix VCM test build warnings on Mac with clang.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/318008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1160 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-12 13:45:59 +00:00
stefan@webrtc.org
7889a9b49a Remove use of CriticalSectionScoped(CriticalSectionWrapper& critsect) in VCM.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/318005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1159 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-12 08:18:24 +00:00
andrew@webrtc.org
981d74ddf4 Roll libyuv to r101.
- Fixes a build error on Linux ia32.
- Fixes a gyp warning on Windows.

Review URL: http://webrtc-codereview.appspot.com/318007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1158 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-12 05:48:56 +00:00
mikhal@webrtc.org
ea71440aec video_coding: Adding the non reference flag to the receive side logic.
Review URL: http://webrtc-codereview.appspot.com/323005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1157 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-12 02:29:34 +00:00
andrew@webrtc.org
114c790be7 Remove character limit in WriteText().
- vfprintf can be used directly here, removing the need for the interim
  buffer. This change allows us to remove the artificial character limit.
- Fix bugs with _text. It wasn't actually getting set earlier, and the
  check was wrong.
- Remove asserts that should use real error checks.

TEST=DataLog and VoECallReport (through voe_auto_test), the only users of WriteText().

Review URL: http://webrtc-codereview.appspot.com/323001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1156 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-10 02:33:33 +00:00
henrike@webrtc.org
2f47b5a70f Fixes a build error when disabling trace (which is done when building with chrome flag is set).
Review URL: http://webrtc-codereview.appspot.com/318006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1155 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-10 00:44:47 +00:00
wjia@webrtc.org
c6b286fc04 add correct include paths for both chrome build and standalone build.
BUG=none
TEST=compiles
Review URL: http://webrtc-codereview.appspot.com/320008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1154 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-10 00:20:54 +00:00
andrew@webrtc.org
6073de6632 Fix libjingle Win source paths in peerconnection.
TBR=tommi@webrtc.org
TEST=Windows build

Review URL: http://webrtc-codereview.appspot.com/322005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1153 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 22:52:21 +00:00
andrew@webrtc.org
5410ef866d Rolling back to libyuv r98.
r99 breaks the 32-bit build.

TBR=mikhal@webrtc.org

Review URL: http://webrtc-codereview.appspot.com/321007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1152 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 22:25:14 +00:00
andrew@webrtc.org
bbea716117 Workaround for libyuv libjingle breakage.
libjingle depends on ConvertFromI420. This was previously available
through vplib. libjingle still has access to the vplib header, but the
implementation is no longer built.

Fortunately, the libyuv wrapper can supply the implementation, if we
hack the signature to return to the unsigned int types. We'll remove
this once libjingle has been updated to use libyuv directly.

Also, roll libyuv to r100 which fixes a gyp warning on Windows.

TEST=build

Review URL: http://webrtc-codereview.appspot.com/323004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1151 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 19:43:12 +00:00
henrike@webrtc.org
315282c01a Fixes a compiler warning related to dynamically allocated static memory. the fix is to leak the memory since the OS will clean it up anyways. This will not add noise to memory tools so it's ok. The issue is reported here: http://code.google.com/p/webrtc/issues/detail?id=147.
Review URL: http://webrtc-codereview.appspot.com/267023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1150 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 17:46:20 +00:00
kjellander@webrtc.org
480352ecf7 Fixing paths to Video engine Android.mk files.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/320006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1149 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 15:45:23 +00:00
mflodman@webrtc.org
d5651b98c5 Refactored ViEFrameProviderBase.
Only style changes, ointers/references and functions will come in a later CL.

vie_capturer.cc and vie_file_player.cc are only changed du to inheriting protected members from ViEFrameProviderBase.

Review URL: http://webrtc-codereview.appspot.com/324001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1148 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 15:20:58 +00:00
xians@webrtc.org
0744ee563d Disable API tests on ALSA since the tests don't work for all the alsa devices.
Review URL: http://webrtc-codereview.appspot.com/317004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1147 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 14:05:29 +00:00
henrik.lundin@webrtc.org
6198624815 Remove warnings on Mac (Issue 178)
Remove an if-else that can never execute the else statement.
Remove double parenthesis.

BUG=http://code.google.com/p/webrtc/issues/detail?id=178
TEST=

Review URL: http://webrtc-codereview.appspot.com/318004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1146 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 13:58:17 +00:00
mflodman@webrtc.org
5cc4dc9e0c Remove warnings in VideoEngine, capture module and render module.
BUG=164, 176, 180

Review URL: http://webrtc-codereview.appspot.com/303004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1145 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 10:12:57 +00:00
mflodman@webrtc.org
b19582b7dc Add pointer constructor to CriticalSectionScoped.
Mainly added to simplyfy the code, e.g. when having critsect as scoped_ptr in classes.

Review URL: http://webrtc-codereview.appspot.com/302005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1144 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 10:02:16 +00:00
henrikg@webrtc.org
af225d6bf6 The change http://webrtc-codereview.appspot.com/299001 (commit 1062) does not do what it intends (exclude codecs from Chromium build). This is a fix for that. webrtc.gyp is not pulled in Chromium, hence it has no effect putting a define there. Moving it to src/build/common.gypi.
Review URL: http://webrtc-codereview.appspot.com/315002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1143 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 09:58:39 +00:00
mflodman@webrtc.org
5885a4162a Refactored ViERenderer.
Only style changes, function and type changes will come in a later CL.

Review URL: http://webrtc-codereview.appspot.com/321001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1142 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 05:52:32 +00:00
andrew@webrtc.org
7fb5d46d3a Give peerconnection its own gyp and disable.
r1140 broke the libjingle revision we're pulling. The fix in libjingle
is pending; rather than reverting r1140, this temporarily disables
peerconnection in the default build.

TBR=tommi@webrtc.org
TEST=build

Review URL: http://webrtc-codereview.appspot.com/323002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1141 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 03:31:41 +00:00
mikhal@webrtc.org
2ab104e6be Switching WebRtc to LibYuv.
General Notes:
1. In general, API structure was not modified and is based on VPLIB. 
2. Modification to API: Return values are based on libyuv, i.e. 0 if ok, a negative value in case of an error (instead of length). 
3. All scaling (inteprolation) is now done via the scale interface. Crop/Pad is not being used.
4. VPLIB was completely removed. All tests are now part of the libyuv unit test (significantly more comprehensive and based on gtest).   
5. JPEG is yet to be implemented in LibYuv and therefore existing implementation remains.
Review URL: http://webrtc-codereview.appspot.com/258001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1140 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 02:46:22 +00:00
mikhal@webrtc.org
ffa0a9e9c9 updating libyuv to latest version (98).
This CL also includes some additional adaptations to the code due to the upgrade. 
Review URL: http://webrtc-codereview.appspot.com/306001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1139 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 22:45:53 +00:00
mallinath@webrtc.org
7766e2a82d - This issue raised by the chromium team when clang compiler is used. This was not an error as in this case we were accessing IPV6 address with IPV4 struct which is defined as 14 bytes in the header file, but we had the runtime check to determine the address space.
Now the solution is to use IPV6 structures instead of IPV4 when address space is determined.

I haven't put the new solution behind AF_INET6 flag, as i don't think it's necessary. 
Review URL: http://webrtc-codereview.appspot.com/291014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1138 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 21:37:19 +00:00
andrew@webrtc.org
c853aa1735 Swap colheaders for textdata in parseLog.m.
- colheaders doesn't appear in the struct returned from importdata for me.
- Add a new error check for empty/malformed files.

Review URL: http://webrtc-codereview.appspot.com/318001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1137 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 20:56:53 +00:00
andrew@webrtc.org
b0be7aa7ae Remove deprecated OS X Core Audio APIs.
We no longer support the 10.4 SDK, so we can remove the weak-leaking
feature and exclusively use the added-in-10.5 APIs.

BUG=issue143
TEST=voe_auto_test

Review URL: http://webrtc-codereview.appspot.com/322001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1136 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 20:15:36 +00:00
marpan@webrtc.org
63b50f60d6 test_fec: Fix to valgrind warnings.
Review URL: http://webrtc-codereview.appspot.com/304002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1135 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 19:05:39 +00:00
mikhal@webrtc.org
f5ee1dc3e6 video_coding: Adding temporal layer info support to receive side
Review URL: http://webrtc-codereview.appspot.com/303005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1134 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 19:04:47 +00:00
xians@webrtc.org
832d7c6000 Disable typing detection for chromium since CGEventSourceKeyState is violating chromium sandbox.
Review URL: http://webrtc-codereview.appspot.com/320003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1132 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 16:45:46 +00:00
phoglund@webrtc.org
dd094fd6ae Started extracting methods out of the main test.
Started extracting methods out of the main test, which will hopefully make us able to make the tests independent.

Merge branch 'master' into voe_split_methods

Conflicts:
	src/voice_engine/main/test/auto_test/voe_extended_test.cc
	src/voice_engine/main/test/auto_test/voe_extended_test.h
	src/voice_engine/main/test/auto_test/voe_standard_test.cc
	src/voice_engine/main/test/auto_test/voe_standard_test.h

Extracted methods out of the standard test.

Added space before inheritance colons.

Rolled back some header file changes.

Fixed long lines.

Fixed long lines.

Fixed indentation. There is nothing but whitespace changes here, except for removing some extraneous semicolons in .h files and fixing a spelling error in a comment.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/313001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1131 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 15:07:59 +00:00
henrik.lundin@webrtc.org
d03718d1e4 Use ResourcePath in NetEQ unittest
Review URL: http://webrtc-codereview.appspot.com/320001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1130 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 11:42:43 +00:00
mflodman@webrtc.org
d2ee5d989d Changed sync bug introduced in refactoring.
Review URL: http://webrtc-codereview.appspot.com/319001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1129 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 09:25:11 +00:00
mflodman@webrtc.org
c78209c58b Add log when transport fails to send packet.
Review URL: http://webrtc-codereview.appspot.com/311002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1128 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 09:22:45 +00:00
kjellander@webrtc.org
7de6e10410 Fixing compilation error on Linux 64-bit
Problem was introduced in http://webrtc-codereview.appspot.com/311001/ because I had projects generated with Valgrind configuration, which is more forgiving about these implicit conversions.

BUG=
TEST=Compiling in Debug+Release on Linux, Mac and Windows.

Review URL: http://webrtc-codereview.appspot.com/318002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1127 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 08:39:13 +00:00
kjellander@webrtc.org
5b97b1216f Splitted FileHandler into FrameReader and FrameWriter classes and moved them to testsupport in test.gyp.
Fixed unit tests so they don't use ASSERT_DEATH since that doesn't work with Valgrind.

Fixed all Valgrind warnings except the one caused by CriticalSectionWrapper in system_wrappers.

Reworked all includes and GYP include paths to use full directory paths.

Removed util.h for logging, since it rendered warnings in Valgrind because of gflags. Replaced it with a verbose flag and a new function in video_quality_measurement.cc

BUG=
TEST=Passed test_support_unittests and video_codecs_test_framework_unittests on Linux, Mac and Windows.

Review URL: http://webrtc-codereview.appspot.com/311001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1126 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 07:42:18 +00:00
henrike@webrtc.org
441b3fe2a1 Made some global statics have function scope so that the global static count is 0 for the rtp_rtcp module.
Review URL: http://webrtc-codereview.appspot.com/316001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1125 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 02:03:49 +00:00
kjellander@webrtc.org
80b2661dc6 Fixing invalid check for existing file.
Review URL: http://webrtc-codereview.appspot.com/313002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1124 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 18:50:17 +00:00
stefan@webrtc.org
cc7b649474 Add trace for the situation when the min bitrate > available bandwidth.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/312001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1123 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 13:22:06 +00:00
phoglund@webrtc.org
693240f2d9 Fixed many formatting and indentation problems in voe_auto_test.
Fixed indentation. There is nothing but whitespace changes here, except for removing some extraneous semicolons in .h files and fixing a spelling error in a comment.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/305004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1122 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 12:32:58 +00:00
henrik.lundin@webrtc.org
598ad06432 Fixing compiler warning in NetEQ
With some compiler settings, a warning was issued for NetEQ,
saying that pw16_randVec was accessed out of bounds.
This did never happen in practice, but this change makes the
compiler understand this.

Review URL: http://webrtc-codereview.appspot.com/309001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1121 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 11:52:09 +00:00
stefan@webrtc.org
b3bd1cd5f1 Fixes Valgrind warnings in the default VCM tests.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/299010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1120 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 11:48:09 +00:00
henrik.lundin@webrtc.org
bf86c33b0e Removing OutputDebugString from rtp_rtcp module
This is in response to WebRTC issue 167.

BUG=http://code.google.com/p/webrtc/issues/detail?id=167

Review URL: http://webrtc-codereview.appspot.com/301013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1119 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 10:44:05 +00:00
henrik.lundin@webrtc.org
44ef3774ce Fixing a compiler error in NetEQ
This error would only arise when compiling without support for
DTMF (which is not the default config).

Review URL: http://webrtc-codereview.appspot.com/310001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1118 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 10:43:25 +00:00
phoglund@webrtc.org
5b343aedcc Added missing .h files to .gypi files so they will show up in xcode / vc projects.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/304008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1117 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 10:34:35 +00:00
stefan@webrtc.org
58927e8d8f Disable deblocking temporarily due to Valgrind warnings.
Also corrects the copying of the decoded image data for frames
with odd width or height.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/307002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1116 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 08:13:31 +00:00
andrew@webrtc.org
ca583bf7c7 Fix typo in build_files rule.
TBR=leozwang@webrtc.org
TEST=watchlist.py

Review URL: http://webrtc-codereview.appspot.com/299011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1115 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-06 19:53:48 +00:00
andrew@webrtc.org
498ae7868f Add build_files WATCHLIST.
TEST=watchlist.py

Review URL: http://webrtc-codereview.appspot.com/298005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1114 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-06 19:48:05 +00:00
marpan@webrtc.org
1d34212a45 FEC: Update to packets masks (FEC generator matrix) in fec_private_tables.h
A set of the packet masks (up 10x10 size) are modified for the following reasons:

1) have more even column and row degree (number of 1 bits), when possible.

2) if cases where the column degree cannot be constant across source packets, placed the extra 1 bit in the first packet column (so little more protection on 1st partition), as opposed to having some ~middle source packet have the extra bit.

3) in some cases, made the mask a little more sparse/reduced the overlap.

Overall the average recovery is a little better with these masks.

Mask sizes above 10 will be updated in future changelist.
Review URL: http://webrtc-codereview.appspot.com/305001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1113 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-06 18:50:11 +00:00
kma@webrtc.org
4a8b1eaf6e In NS, replaced a divide calculatoin by shifting, and thus saved the MIPS by 5%(ARMv7) and 10%(ARMv7-Neon). Bit is not exact with the original. Quality is similar.
Review URL: http://webrtc-codereview.appspot.com/298004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1112 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-06 18:04:48 +00:00
henrik.lundin@webrtc.org
b6e58eb5a1 Fix formatting of rtp_format_vp8*
Sorting out all lint issues and fixing indentation.

Review URL: http://webrtc-codereview.appspot.com/301011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1111 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-06 15:56:18 +00:00