Commit Graph

98 Commits

Author SHA1 Message Date
buildbot@webrtc.org
f1adbeedb4 (Auto)update libjingle 68562943-> 68571194
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6333 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-04 21:57:16 +00:00
jiayl@webrtc.org
8a09af3f67 Fix the build error from OpenSSLStreamAdapter::SSLVerifyCallback
TBR=pthatcher@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/17639004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6296 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-30 23:24:08 +00:00
jiayl@webrtc.org
0163674f99 Make OpenSSLStreamAdapter verify the leaf certificate digest for chained certificates.
It used to compre a parent certificate's digest against the SDP fingerprint and caused connection failure.

BUG=3383
R=bemasc@webrtc.org, juberti@webrtc.org, rsleevi@chromium.org

Review URL: https://webrtc-codereview.appspot.com/17589005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6294 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-30 23:14:08 +00:00
phoglund@webrtc.org
f666ecc60d Disabling flaky libjingle tests after fixit week.
BUG=webrtc:3316,webrtc:3317,webrtc:3318
TBR=fischman@google.com

Review URL: https://webrtc-codereview.appspot.com/12569004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6250 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-27 08:08:00 +00:00
fischman@webrtc.org
e5063b1733 Thread: delete racy API (Release()) and fix racy code (started()).
- Thread::Release() wrote a local variable on the calling thread but read it on
  another thread, with no synchronization.  Happily it has no non-test callers
  so deleting it instead of trying to fix it (see bug for details).
- Thread::started_ similarly was racily being written to; replaced with a
  running_ Event, and hid the accessor except for tests & legacy callers,
  with a note about why it's a bad idea.

webrtc/base patched with:
git diff origin --relative=talk/base | patch -p1 -dwebrtc/base
followed by manual merge of 3 thunks that ran afoul of naming differences
between talk/base and webrtc/base.

BUG=3388
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14589005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6236 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-23 17:28:50 +00:00
pbos@webrtc.org
706152dcc9 Fix uninitialized reads in IsDefaultBrowserFirefox
BUG=
TEST=Local DrMemory.
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19529006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6232 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-23 14:35:48 +00:00
buildbot@webrtc.org
f9f1bfbdae (Auto)update libjingle 67686255-> 67689476
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6216 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 17:02:15 +00:00
fischman@webrtc.org
40bc7779aa talk_base: remove lock inversion between MessageQueue and MessageQueueManager.
Removes the concept of a MessageQueue being "active" in favor of considering all
live MQ's to be active.
(previously a MQ was active starting from the first Post to it and stopped being
active in its dtor).

BUG=3230
R=sriniv@google.com

Review URL: https://webrtc-codereview.appspot.com/21489004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6190 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-19 17:58:04 +00:00
buildbot@webrtc.org
ef5a752c29 (Auto)update libjingle 67043374-> 67044055
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6163 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 21:35:19 +00:00
buildbot@webrtc.org
372701a872 (Auto)update libjingle 67023528-> 67036361
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6160 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 20:27:59 +00:00
fischman@webrtc.org
d8af5b51c0 Deallocate the result of mach_host_self() when done with it, fixing a
port leak.

The port rights obtained by mach_host_self() and mach_thread_self() need
to be deallocated with mach_port_deallocate(). They consume finite
system-wide resources. This is in contrast to mach_task_self(), which is
a macro that wraps an extern global variable, and must not be
deallocated.

http://crbug.com/105513 shows the sorts of problems that can occur when
these aren't properly deallocated.

R=fischman@webrtc.org, tkchin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15469004

Patch from Mark Mentovai <mark@chromium.org>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6131 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 22:18:48 +00:00
buildbot@webrtc.org
cc06c75f28 (Auto)update libjingle 66100938-> 66106643
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6046 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-02 18:51:11 +00:00
fischman@webrtc.org
a86c42c424 libjingle_unittest now compiles and passes on iOS! (reland of r5986)
Example run from cmd-line:
ninja -C out_ios/Debug-iphoneos libjingle_unittest && \
  ~/src/ios-deploy/ios-deploy -d -u -v -b \
    ~/src/wr/trunk/out_ios/Debug-iphoneos/libjingle_unittest.app

Note that the test's use of signals means that lldb will break in the middle
of the suite.  To ignore these signals tell lldb:

pro hand -p true -s false -n false SIGINT
pro hand -p true -s false -n false SIGTERM
continue

BUG=3241
R=kjellander@webrtc.org, tkchin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/21369004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6025 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-29 18:37:29 +00:00
buildbot@webrtc.org
681f787cc4 (Auto)update libjingle 65752960-> 65813736
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6023 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-29 17:55:26 +00:00
kjellander@webrtc.org
7d825e9b2c Revert "libjingle_unittest now compiles and passes on iOS!"
This reverts commit r5986 as it fails compilation on Mac
(non-iOS). The failure was not discovered on the commitbots
since they don't clobber their builds.

BUG=3241
TBR=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19399004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5997 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-28 12:50:47 +00:00
fischman@webrtc.org
95cd1551f8 libjingle_unittest now compiles and passes on iOS!
Example run from cmd-line:
ninja -C out_ios/Debug-iphoneos libjingle_unittest && ~/src/ios-deploy/ios-deploy -d -u -v -b ~/src/wr/trunk/out_ios/Debug-iphoneos/libjingle_unittest.app
Note that the test's use of signals means that lldb will break in the middle of the suite.  To ignore these signals tell lldb:

pro hand -p true -s false -n false SIGINT
pro hand -p true -s false -n false SIGTERM
continue

BUG=3241
R=noahric@google.com, tkchin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12229004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5986 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-25 23:59:56 +00:00
buildbot@webrtc.org
504fc89f36 (Auto)update libjingle 65394435-> 65417850
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5961 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-23 03:23:19 +00:00
henrike@webrtc.org
f824fde36f (Auto)update libjingle 64326665-> 64585415
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5864 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-08 22:13:01 +00:00
henrike@webrtc.org
74a7c482b9 Removes unused thread causing compiler warnings.
BUG=N/A
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/11369004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5859 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-07 20:49:34 +00:00
henrike@webrtc.org
09b0c10eed Talk: fixes warning: local variable is initialized but not referenced due to only using the variable in question for asserts.
BUG=N/A
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/11249004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5848 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-04 22:33:34 +00:00
henrike@webrtc.org
f5bebd40f3 (Auto)update libjingle 64247466-> 64326665
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5845 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-04 18:39:07 +00:00
andrew@webrtc.org
a5586b50e5 Protect ENABLE_PROFILING to fix profiling=1.
Chromium defines ENABLE_PROFILING under the gyp flag profiling=1. This
corrects the resulting mulitple defintion error:
../../talk/base/profiler.h:61:9: error: 'ENABLE_PROFILING' macro redefined [-Werror]
#define ENABLE_PROFILING

and allows us to use profiling=1 in standalone builds.

TESTED=build passes with profiling=1
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10829004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5804 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-27 22:44:13 +00:00
henrike@webrtc.org
b0ecc1c6fb (Auto)update libjingle 63777286-> 63837929
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5797 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-26 22:44:28 +00:00
sergeyu@chromium.org
e42b8ab129 Cleanups in libjingle to make it compile with chromium_code=1
Fixed all warnings that show up when compiling libjingle
in chromium with compiling with chromium_code=1.
chromium_code=1 enables various warnings that are off by
default. Most changes are for unused variables and consts.

R=pthatcher@google.com, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9699004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5769 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-25 00:31:35 +00:00
wu@webrtc.org
1e6cb2c5d2 (Auto)update libjingle 63560528-> 63648983
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5762 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-24 17:01:50 +00:00
henrike@webrtc.org
5e83c65aee (Auto)update libjingle 63493960-> 63503990
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5743 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-20 22:33:30 +00:00
henrike@webrtc.org
c7bec8484b (Auto)update libjingle 62948689-> 63019975
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5689 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-12 19:53:43 +00:00
pbos@webrtc.org
371243dfa3 Remove std:: prefixes from C functions in talk/.
std::memcpy -> memcpy for instance. This change was motivated by a
compile report complaining that std::rand() was used instead of rand(),
probably with a stdlib.h include instead of cstdlib. Use of C functions
without the std:: prefix is a lot more common, so removing std:: to
address this.

BUG=
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9559004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5657 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-07 15:22:04 +00:00
jiayl@webrtc.org
80bbf4c312 Enable test SSLStreamAdapterTestDTLS.TestDTLSConnectWithSmallMtu since it does not fail anymore.
BUG=2712
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9279004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5633 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-03 18:41:27 +00:00
henrike@webrtc.org
b8395ebe14 (Auto)update libjingle 62293974-> 62364298
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5623 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-28 21:57:22 +00:00
henrike@webrtc.org
704bf9ebec (Auto)update libjingle 62063505-> 62278774
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5617 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-27 17:52:04 +00:00
henrike@webrtc.org
91cbaa477c (Auto)update libjingle 61966318-> 62063505
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5602 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-24 16:51:32 +00:00
henrike@webrtc.org
d43aa9de7a Update libjingle 61901702->61966318
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5596 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-21 23:43:24 +00:00
henrike@webrtc.org
a7b981843f Unrevert 5590 "description"(=(Auto)update libjingle 61834300->61901702).
BUG=N/A
R=xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9009004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5595 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-21 15:51:43 +00:00
xians@webrtc.org
ef2215110c Revert 5590 "description"
> description

TBR=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8949006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5593 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-21 10:31:29 +00:00
henrike@webrtc.org
2643805a20 description
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5590 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-20 22:32:53 +00:00
henrike@webrtc.org
571df2dca9 Update libjingle 61759961->61834300
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5580 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-19 23:04:26 +00:00
henrike@webrtc.org
5cf3e8f0f0 (Auto)update libjingle $LAST_P10_REVISION-> $NEW_P10_REVISION
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5572 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-18 22:28:52 +00:00
mallinath@webrtc.org
92fdfebedd Update talk to 61699344.
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8809004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5560 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-17 18:49:41 +00:00
henrike@webrtc.org
b8c254abd6 (Auto)update libjingle 61549749-> 61608469
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5555 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-14 23:38:45 +00:00
mallinath@webrtc.org
385857dfd4 Update talk to 61549749.
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8709004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5549 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-14 00:56:12 +00:00
wu@webrtc.org
b9a088b920 Update talk to 61538839.
TBR=mallinath

Review URL: https://webrtc-codereview.appspot.com/8669005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5548 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-13 23:18:49 +00:00
wu@webrtc.org
0de29504ab Revert 5545 "Update libjingle to 61514460"
> Update libjingle to 61514460
> 
> TBR=tommi@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/8649004

TBR=xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8669004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5547 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-13 19:54:28 +00:00
xians@webrtc.org
e749c9ebdb Update libjingle to 61514460
TBR=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8649004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5545 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-13 15:09:40 +00:00
wjia@webrtc.org
dd82fa726c Revert 5516 "Thread annotation of talk_base::CriticalSection."
r5516 failed compilation on builds with enable_webrtc=0.

> Thread annotation of talk_base::CriticalSection.
> 
> Also enabling -Wthread-safety in talk/build/common.gypi for clang on
> Linux. Thread annotations are compile-time checks that for instance
> certain locks are held before accessing a value.
> 
> BUG=
> TEST=Local GUARDED_BY() annotations.
> R=andresp@webrtc.org, fischman@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/8189004

TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8409004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5523 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-10 23:20:15 +00:00
pbos@webrtc.org
0a7085ffc2 Thread annotation of talk_base::CriticalSection.
Also enabling -Wthread-safety in talk/build/common.gypi for clang on
Linux. Thread annotations are compile-time checks that for instance
certain locks are held before accessing a value.

BUG=
TEST=Local GUARDED_BY() annotations.
R=andresp@webrtc.org, fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8189004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5516 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-10 13:58:37 +00:00
sergeyu@chromium.org
cc685acbdf Disable AsyncInvokeTest.CancelInvoker test
Test is flaky.

BUG=b/12944358
TBR=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8289004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5508 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-08 19:59:00 +00:00
sergeyu@chromium.org
0178810659 Don't use LOG() in callback.h
Because chromium is compiled with a different version of logging macros
defined in logging.h that header cannot be used in headers that can
also included from chromium code. Removed LOG_F(LS_WARNING) from
callback.h . That issue would block this code from being rolled in
chromium.

R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8279004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5507 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-08 03:18:03 +00:00
sergeyu@chromium.org
9cf037b831 Update libjingle to 61168196
R=mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8139004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5502 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-07 19:03:26 +00:00
mallinath@webrtc.org
67ee6b9a62 Update talk to 60923971
Review URL: https://webrtc-codereview.appspot.com/7909004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5475 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-03 16:57:16 +00:00