andrew@webrtc.org
81cf5e4752
Move test to src/test.
...
- Refer to top-level directories by <(DEPTH), e.g. <(DEPTH)/testing.
- Remove now unneeded third_party_root.
TBR=henrike@webrtc.org
BUG=none
TEST=trybots
Review URL: https://webrtc-codereview.appspot.com/669007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2446 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-27 01:41:54 +00:00
henrike@webrtc.org
643be71700
Adds variable for third party directory.
...
BUG=348
TEST=Manual testing in Chrome and WebRTC workspace.
Review URL: https://webrtc-codereview.appspot.com/674005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2439 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-06-25 10:48:58 +00:00
leozwang@webrtc.org
e7e64e3468
Fix compilation errors on ChromeOS
...
Description:
This cl fixes two compilation errors on ChromeOS/ARM, it could
also be reproduced by gcc 4.5+.
I also add comments about error message and how I solve them.
BUG=webrtc issue 554
TEST=try bots and build on chromeos arm
Review URL: https://webrtc-codereview.appspot.com/611006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2327 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-30 16:46:09 +00:00
mflodman@webrtc.org
6af9594d71
Added gyp variable to include/exclude all tests.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/597004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2292 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-24 13:23:35 +00:00
hta@webrtc.org
3a698651d7
Coverity issue 14317 (uninitialized status may influence execution flow)
...
Solution: restructure the flow when AquireSocket fails
BUG=coverity:14317
TEST=trybot
Review URL: https://webrtc-codereview.appspot.com/573006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2252 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-16 14:28:52 +00:00
hta@webrtc.org
d429086f62
Deleted udp_socket_windows and all references to it.
...
This fixes a couple of Coverity issues, and doesn't impact any tested
platforms.
BUG=Coverity:14423
TEST=trybots
Review URL: https://webrtc-codereview.appspot.com/564012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2247 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-16 09:32:14 +00:00
hta@webrtc.org
93116ba4fc
Added an unittest for udp_socket_wrapper.
...
This involves checking what the reasonable call sequences for deleting a
socket is; documented the API for this by making the destructor protected.
Checked out that the behaviour of undeleted sockets is inconsistent across
platforms, and changed the udp_socket_manager_unittest accordingly.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/578007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2236 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-14 16:03:37 +00:00
phoglund@webrtc.org
7eadad6d95
Fixed valgrind errors so the fuzz test can be run under valgrind.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/576008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2228 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-11 07:36:53 +00:00
hta@webrtc.org
9cc186405f
Removed CleanUp call in Windows, since I couldn't find a call to it.
...
This solves Coverity issue 14424 by deleting the code.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/579005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2194 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 11:40:06 +00:00
pwestin@webrtc.org
e9727cdbaa
Fixed some memory leaks.
...
Review URL: https://webrtc-codereview.appspot.com/558004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2165 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-03 11:32:25 +00:00
mflodman@webrtc.org
1868780c81
Disabled UnremovedSocketsGetCollectedAtManagerDeletion in UdpSocketManager unittest.
...
TBR= hta@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/520004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2122 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-26 06:40:00 +00:00
hta@webrtc.org
ad929899c7
Tests for udp_socket_manager.
...
These tests basically check that socket allocation does not leak memory.
BUG=
TEST=unittested, ran under valgrind.
Review URL: https://webrtc-codereview.appspot.com/519003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2118 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-25 14:06:50 +00:00
hta@webrtc.org
bf9f469a13
Lifetime management for UdpSocketManager
...
Make tests use Create/Destroy *or* new/delete for UdpSocketManager.
Move responsibility for calling Destroy on UdpSocketManager from transport
destructor to transport Destroy function.
This all ends up in not leaking memory in InitializeSourcePorts test.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/512001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2091 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 13:19:30 +00:00
phoglund@webrtc.org
bb77000123
Added a virtual destructor to get the test to compile on all platforms.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/507003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2082 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 13:03:12 +00:00
hta@webrtc.org
bbd6b561cf
Memory leak fix: Deleting a factory
...
Also expanded some documentation.
Bug found by Valgrind bot.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/507002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2080 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 09:51:26 +00:00
hta@webrtc.org
0abe535e16
Refactored udp_transport to take socket manager as dependency injection
...
This avoids having to deal with the socket manager in the unittest.
Extended tests to cover one case where sockets got allocated.
BUG=
TEST=unittest
Review URL: https://webrtc-codereview.appspot.com/496001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2078 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 08:23:16 +00:00
tommi@webrtc.org
e84373c38f
Atomic32Wrapper -> Atomic32
...
This change does the following:
* Remove the Atomic32Wrapper and AtomicImpl classes and provide the Atomic32
implementation directly via platform specific source files.
* Move/rename/delete all source files accordingly
* The atomic value itself is now volatile. Previously it was only the pointer to
the memory that was volatile, but not the actual value.
* No additional heap allocations are now done for the atomic value.
In a follow up cl I plan to start using Atomic32 in the RefCount class in order
to fix issues reported by Coverity.
Review URL: https://webrtc-codereview.appspot.com/490004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2065 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 14:28:45 +00:00
tommi@webrtc.org
7ab51497a7
Remove usage of Atomic32Wrapper from a few places.
...
In these places, it doesn't make much sense to use an atomic variable we were using
Atomic32Wrapper::operator= anyway (which does not use atomic operations).
Review URL: https://webrtc-codereview.appspot.com/492005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2042 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 13:33:28 +00:00
hta@webrtc.org
52c0fec34c
Added UDP socket factory function to UdpTransportImpl constructor
...
This is a refactoring in preparation for creating small unit tests for the
udp_transport module.
BUG=
TEST=unittest
Review URL: https://webrtc-codereview.appspot.com/482004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2041 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 12:39:04 +00:00
xians@webrtc.org
aef0a61117
webrtc: OTHER_CPLUSPLUSFLAGS should be a list, not a string.
...
Review URL: https://webrtc-codereview.appspot.com/492007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2028 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 09:57:16 +00:00
andrew@webrtc.org
e713fd0eee
Enable the "unused variable" warning on Windows.
...
- Break out direct_show_base_classes to its own gyp file to have it
treated as third party code.
- Fix the resulting warnings (courtesy of Tommi).
BUG=
TEST=build on Windows (vie_auto_test currently failing at HEAD)
Review URL: https://webrtc-codereview.appspot.com/489001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2000 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-10 07:13:46 +00:00
pwestin@webrtc.org
1f569222b2
Clean up coverity warnings.
...
Review URL: https://webrtc-codereview.appspot.com/456003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1928 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-23 09:04:16 +00:00
leozwang@webrtc.org
f5516240ad
Prepare future change of WebRtc_Word8 in udp module
...
Review URL: https://webrtc-codereview.appspot.com/439007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1870 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-09 22:07:18 +00:00
leozwang@webrtc.org
07c68b9c9d
Correct wrong usage of WebRtc_Word8 in rtp and udp module
...
BUG=http://code.google.com/p/webrtc/issues/detail?id=311&sort=-id
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/418001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1798 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-29 16:09:51 +00:00
niklas.enbom@webrtc.org
7cb0c240cb
Trying to free up hellner from review work, since he mainly works in libJingle.
...
Review URL: https://webrtc-codereview.appspot.com/392020
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1734 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-21 13:58:58 +00:00
xians@webrtc.org
57fb09ac18
Remove the deprecated kTraceModuleCall trace from udp transport module.
...
Review URL: https://webrtc-codereview.appspot.com/395011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1723 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-20 08:38:21 +00:00
henrike@webrtc.org
05e0601160
Fixes coverity warnings in the udp_transport module.
...
BUG=Coverity warnings.
TEST=N/A.
Review URL: https://webrtc-codereview.appspot.com/392012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1696 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-15 19:43:51 +00:00
pwestin@webrtc.org
95392e64ba
Bugfix EnableIPV6 issue 255
...
Review URL: https://webrtc-codereview.appspot.com/378005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1633 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 08:08:37 +00:00
kjellander@webrtc.org
7f3c724e12
Renaming 47 files from .cpp to .cc
...
In addition to our naming guidelines, this will cause these files to get parsed by Sonar, and to make searching/grepping the source using file extensions easier in the future.
BUG=
TEST=Compiling on Linux.
Review URL: http://webrtc-codereview.appspot.com/348005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1405 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 10:23:41 +00:00
pwestin@webrtc.org
c450a19669
Removed Version function from all modules.
...
TBR=henrik_a
Review URL: http://webrtc-codereview.appspot.com/329023
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1330 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 15:00:12 +00:00
pwestin@webrtc.org
093ffad26b
Removed unused function messing up the symbols.
...
Review URL: http://webrtc-codereview.appspot.com/336006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1283 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-22 09:48:48 +00:00
andrew@webrtc.org
697bc43b67
Restore item deletions in Windows UDP.
...
TEST=voe_auto_test on Windows.
Review URL: http://webrtc-codereview.appspot.com/331013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1275 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-21 19:58:11 +00:00
andrew@webrtc.org
71571c5446
Remove unneeded variables from windows UDP.
...
TEST=build on Windows.
Review URL: http://webrtc-codereview.appspot.com/329013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1274 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-21 18:30:59 +00:00
mallinath@webrtc.org
03532b5f41
Fixing the double delete problem in UdpSocket2ManagerWindow. PopFront deletes the items, to there is no need to delete item explicitly.
...
Review URL: http://webrtc-codereview.appspot.com/333014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1268 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-21 15:36:44 +00:00
henrike@webrtc.org
7136990a3f
Removed usage of the deprecated critical section constructor in udp_transport.
...
Review URL: http://webrtc-codereview.appspot.com/321005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1211 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 19:17:28 +00:00
andrew@webrtc.org
59ccd5c71f
Rename _windows.h -> _win.h in system_wrappers.
...
- Also rename _dummy -> no_op which states its purpose more clearly.
- Always use exclusion lists (i.e. sources! instead of sources)
TEST=builds and passes system_wrapper_unittest on Linux, Mac, Win
Review URL: http://webrtc-codereview.appspot.com/317007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1199 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 00:17:43 +00:00
andrew@webrtc.org
6d609b59f3
Fix crashes due to static_instance.
...
- Initialize a needed critsect in the constructor of
UdpSocket2ManagerWindows.
- Don't return NULL when creating a static instance.
TEST=voe_auto_test on Windows.
Review URL: http://webrtc-codereview.appspot.com/324008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1177 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 02:36:33 +00:00
henrike@webrtc.org
315282c01a
Fixes a compiler warning related to dynamically allocated static memory. the fix is to leak the memory since the OS will clean it up anyways. This will not add noise to memory tools so it's ok. The issue is reported here: http://code.google.com/p/webrtc/issues/detail?id=147 .
...
Review URL: http://webrtc-codereview.appspot.com/267023
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1150 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 17:46:20 +00:00
mallinath@webrtc.org
7766e2a82d
- This issue raised by the chromium team when clang compiler is used. This was not an error as in this case we were accessing IPV6 address with IPV4 struct which is defined as 14 bytes in the header file, but we had the runtime check to determine the address space.
...
Now the solution is to use IPV6 structures instead of IPV4 when address space is determined.
I haven't put the new solution behind AF_INET6 flag, as i don't think it's necessary.
Review URL: http://webrtc-codereview.appspot.com/291014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1138 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 21:37:19 +00:00
kjellander@webrtc.org
d492f72e43
Added empty unit tests to get code coverage measured.
...
In order to get code coverage recorded, there must be an executing test that is linked to the code to measure.
These projects are currently not showing up in the code coverage.
Review URL: http://webrtc-codereview.appspot.com/293002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1010 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-24 07:20:00 +00:00
henrike@webrtc.org
bf54ef9bb7
Removed code under a non-existing define.
...
Review URL: http://webrtc-codereview.appspot.com/193006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@706 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-06 18:14:25 +00:00
xians@google.com
d3185fe219
refactor the gyp file to gypi file.
...
Basically, the gypi file is a copy of gyp file, but has some difference on the
path of the dependencies.
Review URL: http://webrtc-codereview.appspot.com/137020
git-svn-id: http://webrtc.googlecode.com/svn/trunk@581 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-12 12:24:39 +00:00
andrew@webrtc.org
8910f278c5
Switch to webrtc.org accounts (for those which exist).
...
Review URL: http://webrtc-codereview.appspot.com/97010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@342 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-10 05:16:31 +00:00
leozwang@google.com
79835d1bd3
Clean up Android.mk
...
Review URL: http://webrtc-codereview.appspot.com/92014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@315 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-05 21:01:02 +00:00
mallinath@google.com
df11c11cf2
Review URL: http://webrtc-codereview.appspot.com/97002
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@291 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-02 22:42:23 +00:00
leozwang@google.com
56f4eb2b28
Replace ANDROID with WEBRTC_ANDROID
...
Review URL: http://webrtc-codereview.appspot.com/89012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@290 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-02 22:24:43 +00:00
ajm@google.com
b5c49ff8af
Rename all files/classes shared by Linux and Mac to Posix.
...
Besides being a good idea in general, this lets us use the good chromium_code==1 warning settings on Mac and Windows. Straight rename except for a change to use os_posix in the gyp files.
Review URL: http://webrtc-codereview.appspot.com/88011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@282 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-01 17:04:04 +00:00
vikasmarwaha@google.com
210d9fa08b
incorrect return value after bind failure
...
Review URL: http://webrtc-codereview.appspot.com/97001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@276 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-29 22:29:15 +00:00
niklase@google.com
470e71d364
git-svn-id: http://webrtc.googlecode.com/svn/trunk@156 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-07 08:21:25 +00:00