Commit Graph

48 Commits

Author SHA1 Message Date
andrew@webrtc.org
6a85b17a0a Potential fix for crash after Mac sleep.
When a Mac goes to sleep, the OS pauses the IO threads. If a
subsequent StopSend/Playout happens, we time out waiting for the IO
threads, but didn't ensure they were shut down.

BUG=
TEST=voe_cmd_test, voe_auto_test

Review URL: http://webrtc-codereview.appspot.com/269013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@949 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-15 16:23:41 +00:00
andrew@webrtc.org
0db7dc6e18 Add file-playing channels to voe_cmd_test.
Fix file reading and writing.

TEST=voe_cmd_test

Review URL: http://webrtc-codereview.appspot.com/279001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@938 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-13 01:34:05 +00:00
braveyao@webrtc.org
1f6d740571 This CL is about to manually reset the ShutdownRenderEvent at StopPlayout().
It could happen that if you want to restart playout, the new sponsored Render thread would catch this event
if the previous Render thread quits before this event is set.
With this modification, the device plugging out/in during talking would be supported well.
Review URL: http://webrtc-codereview.appspot.com/248002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@839 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-28 21:30:30 +00:00
henrika@webrtc.org
bdb55c806f This CL is an attempt to remove a crash we can see when closing down VoiceEgine.
It can happen that the capture thread tries to access an invalid object after StopPlayout has been called.

I have also extended the usage of the new ScopedCOMInitializer to all threads. See this step as code cleanup.
Review URL: http://webrtc-codereview.appspot.com/239014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@813 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-25 11:03:28 +00:00
henrika@webrtc.org
a6c23357c0 Solves crash in ADM API unit test for Core Audio on Windows
Review URL: http://webrtc-codereview.appspot.com/244009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@812 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-25 08:31:33 +00:00
henrika@webrtc.org
5423bc2d0b Adds correct absolute paths to all input files in ADM functional unit tests.
Files are now read and played out correctly.
Review URL: http://webrtc-codereview.appspot.com/246006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@811 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-25 08:24:20 +00:00
henrika@webrtc.org
bf478faebb Ensures that ADM unit tests builds on all platforms.
Review URL: http://webrtc-codereview.appspot.com/240009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@800 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-24 10:31:02 +00:00
henrika@webrtc.org
cedbb036d1 [Issue 101] Solves memory leak on Windows
git-svn-id: http://webrtc.googlecode.com/svn/trunk@784 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-20 12:11:45 +00:00
andrew@webrtc.org
b2d4921f3b Remove trailing whitespace in AudioDevice.
(That I introduced...)
Review URL: http://webrtc-codereview.appspot.com/198002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@703 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-06 16:34:36 +00:00
leozwang@google.com
522f42bb80 Add kPlatformAndroid to platform check function
Review URL: http://webrtc-codereview.appspot.com/161002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@622 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-19 17:39:05 +00:00
andrew@webrtc.org
b524f441d0 Correct some comment spelling errors. Skipping review.
Review URL: http://webrtc-codereview.appspot.com/144002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@594 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-13 18:04:30 +00:00
andrew@webrtc.org
a3c6d61c44 Integrate the built-in WASAPI AEC DMO to VoE.
Review URL: http://webrtc-codereview.appspot.com/108006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@592 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-13 17:17:49 +00:00
xians@google.com
d3185fe219 refactor the gyp file to gypi file.
Basically, the gypi file is a copy of gyp file, but has some difference on the
path of the dependencies.
Review URL: http://webrtc-codereview.appspot.com/137020

git-svn-id: http://webrtc.googlecode.com/svn/trunk@581 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-12 12:24:39 +00:00
henrika@google.com
73d65513f1 Adds reference counting to the ADM.
This CL modifies the ADM interface to ensure that an external ADM
can't call Create and Destroy any longer.

It also contains some minor style nits to conform better with
the Chromium style guide.
Review URL: http://webrtc-codereview.appspot.com/133014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@552 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-07 15:11:18 +00:00
punyabrata@google.com
eba8c32840 Resolving a race condition issue related to using shared devices
(e.g. usb headsets) where we were not stopped the shared callback
until both StopPlayout() and StopRecording() are called. Google
internal bugid 4478351
Review URL: http://webrtc-codereview.appspot.com/130001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@489 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 14:32:22 +00:00
xians@google.com
e74a9ea303 AudioDeviceUtility::WaitForKey() pulls two characters if the first one is a newline, but discards the final value.
The current code assigns that second value to a local variable, which generates a set-but-unused warning on gcc 4.6.0. Instead, cast the result away.

I also refactor the code a bit by adding the right indentation and removing empty lines.

Bug=http://code.google.com/p/webrtc/issues/detail?id=53
Test=none
Review URL: http://webrtc-codereview.appspot.com/135005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@486 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 08:27:02 +00:00
xians@google.com
932096c84f Porting gtalk alsa impl from depot to webrtc
Review URL: http://webrtc-codereview.appspot.com/123002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@484 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-30 07:41:55 +00:00
xians@webrtc.org
c57f9c38ad Using IAudioEndpointVolume in IsSpeakerMuteAvailable and IsMicrophoneMuteAvailable to be consistent with SpeakerMute and MicrophoneMute APIs.
Review URL: http://webrtc-codereview.appspot.com/112007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@458 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-26 12:28:33 +00:00
frkoenig@google.com
cf36b2aa9b Match new[] / delete []
Quiet valgrind warnings by correctly matching 
new[] with delete[].
Review URL: http://webrtc-codereview.appspot.com/126005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@437 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 15:48:47 +00:00
xians@webrtc.org
9d64705dea The method AudioDeviceWindowsWave::RecProc can use uninitialized variables t1 and t2.
This results in an exception in debug mode and unpredictable behavior in release mode.

The problem is at line 3514:

        // Calculate processing time
        consumedTime = (int)(t2.QuadPart-t1.QuadPart);

Bug=http://code.google.com/p/webrtc/issues/detail?id=42
Test=none
Review URL: http://webrtc-codereview.appspot.com/121002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@419 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 09:14:56 +00:00
punyabrata@webrtc.org
5895ea1573 Fixes volume problem controls, happening with some Logitech headsets. Originally submitted as gips p4 depot CL 38122.
Review URL: http://webrtc-codereview.appspot.com/116008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@418 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-22 22:46:38 +00:00
punyabrata@google.com
9695e75fbd Resolve a crash related to pulseAudio where we need to check if
pa_context_get_source_info_by_name/pa_context_get_sink_info_by_name 
has early failure and returns NULL,then to avoid WaitForOperationCompletion
from crashing, paOperation must be checked to ensure it is not NULL.

Please note that ::WaitForOperationCompletion( ) is a void function
therefore returning without any error code if paOperation is indeed NULL

Google internal bug id [4356730]
Review URL: http://webrtc-codereview.appspot.com/122003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@417 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-22 22:35:14 +00:00
punyabrata@webrtc.org
7049389794 Fixes volume problem controls, happening with some Logitech headset [from gips P4 depot CL 38122]
Review URL: http://webrtc-codereview.appspot.com/108004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@389 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-17 00:15:52 +00:00
punyabrata@webrtc.org
7bd857bc99 Apple Airfoil audio casting software crash resolution [Google Internal buglist id: 4444985]
Review URL: http://webrtc-codereview.appspot.com/109001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@387 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-17 00:01:05 +00:00
xians@google.com
0134facd53 Get rid of the ADM test warnings.
Review URL: http://webrtc-codereview.appspot.com/116001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@375 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-16 09:30:51 +00:00
xians@google.com
bf5d2ba8fb This CL will exclude the built-in ADM when building with chromium.
When building with chromium, we use dummy ADM for all the platforms.
Review URL: http://webrtc-codereview.appspot.com/108001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@373 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-16 07:44:19 +00:00
xians@google.com
3ab5d5f4d0 This patch just gets rid of the rest of warnings on voe_auto_test and adm.
Trivial changes.
Review URL: http://webrtc-codereview.appspot.com/111001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@364 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-15 11:07:54 +00:00
leozwang@google.com
4033e1245d Change folder name from Android to android
Review URL: http://webrtc-codereview.appspot.com/106002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@358 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-12 15:54:48 +00:00
leozwang@google.com
911e36c525 Also change folder name in audio_device test
Review URL: http://webrtc-codereview.appspot.com/105002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@351 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-11 17:04:26 +00:00
xians@google.com
0fe2627e6f adding audio_device_utility_mac.cc, which was misssing from previous CL.
Review URL: http://webrtc-codereview.appspot.com/106001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@349 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-11 14:32:40 +00:00
xians@google.com
77f66051e8 delete old folders
Review URL: http://webrtc-codereview.appspot.com/105001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@348 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-11 13:58:34 +00:00
xians@google.com
68efa21abc This CL refactor the audio_device.gyp to make use of the chromiurm _os suffix filter.
This CL looks big, but most of the changes are only renaming. I hope it is all right for you.

Changes include:
rename source/Windows to source/win
rename source/Linux to linux
rename source/Mac to source/mac

Also rename some files to  follow chromium standard, for examples:
from alsasymboltable.cc to alsasymboltable_linux.cc
from alsasymboltable.h to alsasymboltable_linux.h
from audio_device_linux_alsa.cc to audio_device_alsa_linux.cc
from audio_device_linux_alsa.h to audio_device_alsa_linux.h
...etc

Modified files:
audio_device.gyp and audio_device_impl.cc : 
adapt to the new file names.

Test=none
Bug=none
Review URL: http://webrtc-codereview.appspot.com/91017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@347 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-11 12:41:56 +00:00
andrew@webrtc.org
8910f278c5 Switch to webrtc.org accounts (for those which exist).
Review URL: http://webrtc-codereview.appspot.com/97010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@342 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-10 05:16:31 +00:00
leozwang@google.com
79835d1bd3 Clean up Android.mk
Review URL: http://webrtc-codereview.appspot.com/92014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@315 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-05 21:01:02 +00:00
xians@google.com
7fa20c3880 exclude both audio_device_test_api and audio_device_test_func test targets from building with chromium.
Review URL: http://webrtc-codereview.appspot.com/97006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@308 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-05 12:04:30 +00:00
xians@google.com
3d292f1649 this CL will strip the test targets from building with chromium.
Review URL: http://webrtc-codereview.appspot.com/99004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@307 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-05 08:32:13 +00:00
xians@google.com
88bd440ef6 Removing the "initialized after" warnings.
This CL tweat the order of the initialization in the constructor to
adapt to the order of declaration of the members.
Review URL: http://webrtc-codereview.appspot.com/92007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@301 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-04 15:33:30 +00:00
ajm@google.com
02f8bbdbb7 Update the Android Makefile to use the new Dummy file.
Review URL: http://webrtc-codereview.appspot.com/93011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@280 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-01 16:13:23 +00:00
ajm@google.com
e89f6b5574 Create an empty device utility dummy, in order to stop using _linux suffixed files on non-Linux OSes.
Besides being a good idea in general, this lets us use the good chromium_code==1 warning settings on Mac and Windows. (chromium_code automatically excludes _linux suffixed files on non-Linux.)
Review URL: http://webrtc-codereview.appspot.com/93010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@272 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-29 18:03:57 +00:00
wjia@google.com
647aa16f0d exclude pulse audio when building with Chromium.
BUG=none
TEST=local
Review URL: http://webrtc-codereview.appspot.com/91001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@240 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-21 20:45:31 +00:00
ronghuawu@google.com
44fe667d86 Fixes for the chromium build ARM and some old x86 platform:
1) Removed SSE2 for ARM in aec.gyp.
2) Removed the re-definition of DISALLOW_COPY_AND_ASSIGN in latebindingsymboltable.h.
3) SSE2 not always supported in some old x86 platform.
Review URL: http://webrtc-codereview.appspot.com/80002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@224 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-18 16:13:23 +00:00
zakkhoyt@google.com
5e26663904 Porting GTalk bugs:
* http://b/issue?id=4442213
* http://b/issue?id=4354351
Review URL: http://webrtc-codereview.appspot.com/71003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@216 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-15 18:21:34 +00:00
leozwang@google.com
39f205195f Change android sound card implementation name from native to OpenSLES
Review URL: http://webrtc-codereview.appspot.com/74003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@214 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-15 16:29:40 +00:00
leozwang@google.com
02c00aa1d2 Use include path relates to include
Review URL: http://webrtc-codereview.appspot.com/66004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@210 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-14 18:44:34 +00:00
zakkhoyt@google.com
630504fddf Reverting svn changes. Moving to gcl system.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@202 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-13 20:06:58 +00:00
zakkhoyt@google.com
81f76937f4 Porting GTalk bug fixes to WebRTC:
* http://b/issue?id=4442213
* http://b/issue?id=4354351



git-svn-id: http://webrtc.googlecode.com/svn/trunk@201 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-13 19:39:38 +00:00
henrika@google.com
807c04d377 Ensures that all test files in VoE and ADM are read from
the new /test/data-folders.
Review URL: http://webrtc-codereview.appspot.com/55005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@178 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-07 14:10:34 +00:00
niklase@google.com
470e71d364 git-svn-id: http://webrtc.googlecode.com/svn/trunk@156 4adac7df-926f-26a2-2b94-8c16560cd09d 2011-07-07 08:21:25 +00:00