Commit Graph

2033 Commits

Author SHA1 Message Date
hta@webrtc.org
0abe535e16 Refactored udp_transport to take socket manager as dependency injection
This avoids having to deal with the socket manager in the unittest.

Extended tests to cover one case where sockets got allocated.

BUG=
TEST=unittest

Review URL: https://webrtc-codereview.appspot.com/496001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2078 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 08:23:16 +00:00
kjellander@webrtc.org
4e645ee783 Improved error message when capture device is missing.
With this patch the test stops when it doesn't find a camera instead of crashing with a large hard-to-read stack trace.

BUG=None
TEST=vie_auto_test --automated in Debug+Release on lin, mac, win

Review URL: https://webrtc-codereview.appspot.com/497003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2077 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 08:10:37 +00:00
andrew@webrtc.org
b61f1fa675 Reset slave when switching to a stereo codec.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/494003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2073 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 01:10:14 +00:00
leozwang@webrtc.org
00a8dbb0ec Change Watchlist
Review URL: https://webrtc-codereview.appspot.com/503001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2072 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 18:09:23 +00:00
tommi@webrtc.org
f4c80fc6cb Switch the other android build over to android_posix.cc and not android_linux.cc.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2070 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 15:41:33 +00:00
tommi@webrtc.org
9018c9f548 Fix androidndk build take two.
TBR=xians

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2069 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 15:38:10 +00:00
tommi@webrtc.org
3db5cb7438 Fix AndroidNDK build.
TBR=xians

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2068 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 15:29:08 +00:00
tommi@webrtc.org
3d48b09bb4 Fix android build.
TBR=kjellander

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2067 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 15:07:11 +00:00
kjellander@webrtc.org
0cac8be82c Fixing e-mail notification for buildbot master
BUG=None
TEST=None (same config works on try master)

Review URL: https://webrtc-codereview.appspot.com/501001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2066 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 15:05:53 +00:00
tommi@webrtc.org
e84373c38f Atomic32Wrapper -> Atomic32
This change does the following:

* Remove the Atomic32Wrapper and AtomicImpl classes and provide the Atomic32
  implementation directly via platform specific source files.
* Move/rename/delete all source files accordingly
* The atomic value itself is now volatile. Previously it was only the pointer to
  the memory that was volatile, but not the actual value.
* No additional heap allocations are now done for the atomic value.

In a follow up cl I plan to start using Atomic32 in the RefCount class in order
to fix issues reported by Coverity.
Review URL: https://webrtc-codereview.appspot.com/490004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2065 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 14:28:45 +00:00
pwestin@webrtc.org
1cd1162c7a Break out of send side bandwidth estimation and controll.
Review URL: https://webrtc-codereview.appspot.com/490010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2064 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 12:13:52 +00:00
pwestin@webrtc.org
b2bd1e05f8 Bugfix too many initialize for RTP module
Review URL: https://webrtc-codereview.appspot.com/497002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2063 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 12:01:47 +00:00
kjellander@webrtc.org
76643d7c62 Enabling fastbuild in GYP define.
The fastbuild flag means debug symbols are not generated. This has no
impact on our tests as long as we don't need to debug with the built
binaries, i.e. is perfect for the buildbots. Compilation is 30% faster
or more.

BUG=None
TEST=Tested on local master and linux, mac and win slaves.

Review URL: https://webrtc-codereview.appspot.com/499001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2062 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 07:30:39 +00:00
asapersson@webrtc.org
a768970bac Parse out ssrcs in REMB message (needed for ViCE) .
Review URL: https://webrtc-codereview.appspot.com/486003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2061 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-19 07:01:29 +00:00
tina.legrand@webrtc.org
faa0ab85d7 NetEQ stereo sync
This CL allows NetEQ to do expand at startup, to make master and slave always go in sync. Before it could happen that master did merge, while slave performed an expand, leading to sync-problems between the channels.

Updating DEPS for new reference files for unittest.

BUG=410
TEST=neteq_unittests

Review URL: https://webrtc-codereview.appspot.com/487005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2055 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 17:59:53 +00:00
leozwang@webrtc.org
22082e74cb Enable iSAC_FIX on android
BUG=
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/490009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2054 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 16:52:00 +00:00
leozwang@webrtc.org
16f6bb35b6 Fix a minor compilation error on android
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/479014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2053 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 16:49:06 +00:00
marpan@webrtc.org
efd01fd354 Removing unused code from QMVideoSettingsCallback.
This code is not needed as of the change in r1950.
Review URL: https://webrtc-codereview.appspot.com/492010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2052 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 15:56:34 +00:00
kjellander@webrtc.org
82d85aeb39 All errors are now printed to stderr instead of stdout.
This will make them easier to detect when running as a cron job.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/482005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2050 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 09:47:39 +00:00
bjornv@webrtc.org
4ade5506eb Delay Estimator Unit tests
This CL includes unit tests to verify correct behavior of the delay estimator used in AEC and AECM.

Tested with audioproc_unittest

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/491009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2049 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 09:42:16 +00:00
bjornv@webrtc.org
2e729762c7 New _CreateBinaryDelayEstimator() and removed _history_size()
Changed create function to match malloc() in functionality.
Removed unused function.

Tested with audioproc_unittest

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/491010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2048 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 08:30:29 +00:00
bjornv@webrtc.org
180f83f8e2 File name change to follow style
A unit test should end with *_unittest.* Otherwise the test itself will be evaluated for line coverage.

Tested with audioproc_unittest

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/493008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2045 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-18 07:01:10 +00:00
andrew@webrtc.org
1bc98bc873 Remove erroneous error trace.
It appears this trace is informational, not an error.
Discovered in a plugin log from a ChromeOS device. Just
decided to remove it.

BUG=http://code.google.com/p/chromium-os/issues/detail?id=29356
TEST=build on Linux

Review URL: https://webrtc-codereview.appspot.com/479012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2043 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 20:10:47 +00:00
tommi@webrtc.org
7ab51497a7 Remove usage of Atomic32Wrapper from a few places.
In these places, it doesn't make much sense to use an atomic variable we were using
Atomic32Wrapper::operator= anyway (which does not use atomic operations).
Review URL: https://webrtc-codereview.appspot.com/492005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2042 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 13:33:28 +00:00
hta@webrtc.org
52c0fec34c Added UDP socket factory function to UdpTransportImpl constructor
This is a refactoring in preparation for creating small unit tests for the
udp_transport module.

BUG=
TEST=unittest

Review URL: https://webrtc-codereview.appspot.com/482004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2041 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 12:39:04 +00:00
phoglund@webrtc.org
c3eb178a0d Will now filter chrome-triggered builds.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/492009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2040 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 11:23:35 +00:00
phoglund@webrtc.org
c440d56e92 Rewired the oath2 symlink and updated tgrid_parser to the new Build Bot version's tgrid syntax.
Added back the gviz_api to the tools deps - will remove it from the main project DEPS in a different patch. Rewired those symlinks too.

Made the build status loader algorithm more scalable. It read in the whole database on each load which is probably unsustainable in the long run. Also, it will now forget bots that have offline for more than ~5 revisions.

Fixed a bug in the coverage tracker.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/486002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2039 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 08:49:10 +00:00
andrew@webrtc.org
336d52d817 Roll Chromium 122775:132375 (current Canary).
Hijacking the gyp inside_chromium_build finally came back to bite us.
Chrome started using it to control the path to the gold linker, which
broke our build. This change removes use of inside_chromium_build from
WebRTC.

If peerconnection rolls past this point, libjingle.gyp will need to be updated.

BUG=
TEST=build on Linux, Mac, Win

Review URL: https://webrtc-codereview.appspot.com/493007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2038 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-17 01:19:27 +00:00
marpan@webrtc.org
3e2e7038e6 VPM: Allow for option to compute the content metrics every nth frame.
Review URL: https://webrtc-codereview.appspot.com/492006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2034 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 15:58:14 +00:00
kjellander@webrtc.org
050f212881 Updating clean script for new buildbot configurations.
BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/485008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2033 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 14:41:11 +00:00
kjellander@webrtc.org
3629a3cc0e Updating master.cfg for updated Mac bot names. This CL completes the changes made in http://webrtc-codereview.appspot.com/493006/ to get the Mac bots back online.
BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/492008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2032 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 14:34:23 +00:00
kjellander@webrtc.org
5f853620de Updated Mac hostnames due to network changes.
BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/493006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2031 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 14:14:46 +00:00
mflodman@webrtc.org
b1fbf016b5 Added timestamp logs, i.e. only tracing.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/482001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2030 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 12:58:49 +00:00
mflodman@webrtc.org
3c611fd4fd Removed NetEQ Test compile error.
BUG=443
TEST=Compiles using clang version 3.1 (trunk 153589)

Review URL: https://webrtc-codereview.appspot.com/493005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2029 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 10:57:27 +00:00
xians@webrtc.org
aef0a61117 webrtc: OTHER_CPLUSPLUSFLAGS should be a list, not a string.
Review URL: https://webrtc-codereview.appspot.com/492007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2028 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 09:57:16 +00:00
bjornv@webrtc.org
bfda85f2ee Safe handling of invalid inputs in delay_estimator.
The delay_estimator crash on invalid create inputs when running new unit tests. This can't occur on a higher level unless corresponding enum and defines are incorrectly changed.

The create and free functions are now more like malloc() and free() in design. The complete change to that will be done in a seperate CL.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/492003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2027 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-16 07:28:29 +00:00
phoglund@webrtc.org
0ea088f92e Turned off Windows diagnostics.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/491005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2026 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-13 12:22:12 +00:00
phoglund@webrtc.org
a36a4bb340 Disabled flaky voe tests.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/491007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2025 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-13 10:11:15 +00:00
kjellander@webrtc.org
04d452e968 Fixing issues due to Buildbot 0.8.4p1 upgrade.
BUG=None
TEST=Tested with local edits on buildmaster and try master.

Review URL: https://webrtc-codereview.appspot.com/490007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2024 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-13 09:17:05 +00:00
stefan@webrtc.org
9784512bf3 Fix coverity warning and possible memory leak.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/493004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2023 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-13 07:47:05 +00:00
stefan@webrtc.org
c4892bca3d Disable libyuv MirrorTest due to crashes on Linux 32 bit.
See http://code.google.com/p/webrtc/issues/detail?id=335 for more info.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/487003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2017 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 13:26:22 +00:00
stefan@webrtc.org
5d2514a1f7 Revert 2013 - Upgrade libyuv to r235.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/493003

TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/491008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2016 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 12:55:44 +00:00
mflodman@webrtc.org
a014ecc049 Changed CriticalSectionScoped constructor usage for ADM.
Only search and replace for the input to the constructor, no other changes.

BUG=184
TEST=Compiles on all platforms.

Review URL: https://webrtc-codereview.appspot.com/483001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2015 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 12:15:51 +00:00
bjornv@webrtc.org
7056908774 System delay unit tests
Added a system delay test class. Noticed I don't need the ApmTest class at all, which simplified the implementation.

Start at patch set 3. The others are not complete.

BUG=None
TEST=

Review URL: https://webrtc-codereview.appspot.com/475003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2014 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 12:13:50 +00:00
stefan@webrtc.org
6803fe883f Upgrade libyuv to r235.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/493003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2013 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 12:01:32 +00:00
tina.legrand@webrtc.org
16b6b90a82 Split of stereo packets moved
In this CL I have rewritten the way we handle stereo packets in VoE.
Before this change we split the packets in the RTP module and added two packets to ACM, one for the left channel and one for the right. This lead to timing problems caused when a different thread called RecOut in between the two calls to add stereo packet to ACM. (RecOut is called to pull audio data, decode packets, on the receiving side).

While doing the change I also took the opportunity to changed some functions so that the data stream is uint8 everywhere.

The list of files in this CL is long, but should be fairly easy to review. It is difficult to see what has been changed  in some of the tests, but I can explain offline.

Reviewers:
Björn - /src/modules/audio_coding
Patrik - /src/modules/rtp_rtcp
Patrik -/src/modules/utility
Henrik A - /src/voice_engine

BUG=410
TEST=voe_cmd_test

Review URL: https://webrtc-codereview.appspot.com/473003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2012 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 11:02:38 +00:00
pwestin@webrtc.org
ce33035dee Cleanup encode call.
Review URL: https://webrtc-codereview.appspot.com/491003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2011 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 06:59:14 +00:00
kjellander@webrtc.org
f1e020ec99 Cleanup script using Python instead of rm command.
BUG=None
TEST=Ran the script on all platforms and a Linux master+slave build.

Review URL: https://webrtc-codereview.appspot.com/479008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2010 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 06:18:10 +00:00
kjellander@webrtc.org
a96eead975 Updating Windows debug try slave hostname
BUG=None
TEST=None needed.

Review URL: https://webrtc-codereview.appspot.com/492004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2009 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 06:16:50 +00:00
kma@webrtc.org
33ced9cc99 Same code change from issue 428004, with uint corrected to uint32_t in WebRtcSpl_MaxAbsValueW32, for a MAC compiler error.
Review URL: https://webrtc-codereview.appspot.com/472006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2008 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-11 17:40:40 +00:00