generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
2,303 Commits 1 Branch 0 Tags 108 MiB
538f0ab96f
Commit Graph

1731 Commits

Author SHA1 Message Date
niklas.enbom@webrtc.org
ee646c37d4 I know this is ugly, but it helps a lot to quickly update webRTC in Chrome and libJingle. 
Review URL: https://webrtc-codereview.appspot.com/596004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2290 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 11:41:02 +00:00
pwestin@webrtc.org
2d1fc9bf17 Added critical section to prevent race. 
Review URL: https://webrtc-codereview.appspot.com/595004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2289 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 11:28:31 +00:00
pwestin@webrtc.org
5c3a400fae Re-added ChangeUniqueId temporary for chrome. 
Review URL: https://webrtc-codereview.appspot.com/594004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2287 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 09:52:19 +00:00
andrew@webrtc.org
7fbfc4ce79 Use correct variable in trace. 
TBR=leozwang@webrtc.org
TEST=build

Review URL: https://webrtc-codereview.appspot.com/593004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2284 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 22:22:36 +00:00
andrew@webrtc.org
f98b6cc10e Remove noise during build on Win32 
TBR=niklas.enbom@webrtc.org
BUG=chromium:126483

Review URL: https://webrtc-codereview.appspot.com/590006
Patch from Scott Graham <scottmg@chromium.org>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2283 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 18:49:47 +00:00
hta@webrtc.org
40300131dc No more TSAN errors on start_stop 
A very pedestrian approach to making TSAN stop complaining about the state variables: Wrap them in a critical section.
More creative approaches can be considered.

(not sure if diffbase works here, but...)
DIFFBASE=583008

BUG=webrtc:300
TEST=

Review URL: https://webrtc-codereview.appspot.com/584008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2282 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 15:49:48 +00:00
turaj@webrtc.org
ea0aa13aa8 I haven't done any refactoring here. 
Resolve coverity warnings.

14240, 14241.

In ACM:
- NULL pointer sanity checks corrected.

Tested with trybots.

BUG=None
TEST=None
Review URL: https://webrtc-codereview.appspot.com/571012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2281 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 15:43:51 +00:00
andrew@webrtc.org
9dc45dad1b Move trunk/test/data -> trunk/data 
BUG=
TEST=all trybot test failures passed locally

Review URL: https://webrtc-codereview.appspot.com/583007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2280 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 15:39:01 +00:00
hta@webrtc.org
1484ac07cb Replaced 2 time functions with thread-safe equivalents 
This does not fix bug 544, but changes where it reports issues.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/578008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2279 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 15:39:17 +00:00
stefan@webrtc.org
78d8d99180 Fixes the vp8_test on Linux. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/579015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2277 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 14:18:56 +00:00
bjornv@webrtc.org
cb0a86e913 VAD refactoring: Added function for repeated code. 
Added WeightedAverage() to calculate global mean. This removes hard coded Gaussian model size and repeated code.

Tested with vad_unittests, audioproc_unittest and trybots.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/571006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2275 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 07:56:51 +00:00
andrew@webrtc.org
a1a34d675f Avoid flakiness by skipping more output verification. 
- Add a SCOPED_TRACE in case it flakes out again.
- The test doesn't need to be very long, so shorten it to save the bots some time.

TBR=henrike@webrtc.org
BUG=
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/588006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2273 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 00:45:00 +00:00
hta@webrtc.org
6ed617be22 Fixing memory leak error in test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/571013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2272 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 16:55:16 +00:00
marpan@webrtc.org
747cd87da1 FEC: For multi-frame FEC, allow for the size of the code to be increased, 
under certain conditions. This generally improves the FEC recovery for 
     bursty loss under medium-high protection level.
Review URL: https://webrtc-codereview.appspot.com/566012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2271 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 16:50:00 +00:00
hta@webrtc.org
e1919f41b7 Unittest for thread_wrapper. 
Added an explanation of the state variables of posix, wrote a simple test.
This might help in fixing the TSAN issue with thread.

BUG=webrtc:300
TEST=

Review URL: https://webrtc-codereview.appspot.com/583008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2270 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 15:57:34 +00:00
pwestin@webrtc.org
0d71c1cfe0 Cleanup code. 
Review URL: https://webrtc-codereview.appspot.com/569021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2269 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 14:23:25 +00:00
astor@webrtc.org
e231c61ba7 Style guide reformatting of overuse_detector.{h,cc} 
Review URL: https://webrtc-codereview.appspot.com/575006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2268 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 12:24:00 +00:00
mflodman@webrtc.org
7597a85bc4 Changed merge-name. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/584007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2266 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 08:32:20 +00:00
andrew@webrtc.org
294be77c2e Permit mixing mono and stereo streams. 
Add mixing tests based on older ones from the extended tests.

BUG=issue534
TEST=manual, voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/576014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2265 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-22 03:28:41 +00:00
pwestin@webrtc.org
b2179c20f0 Bugfix issue 533. Client does not handle NACK or PLI requests received from far end if a RTCP report from it has not been processed when RFC 5506 is enabled. 
Review URL: https://webrtc-codereview.appspot.com/569020

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2263 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-21 12:00:49 +00:00
stefan@webrtc.org
1bca6d2437 Fixes coverity warnings. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/566014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2262 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-21 07:42:12 +00:00
andrew@webrtc.org
b3bea2eb3e Fix build errors on OS X Lion. 
TBR=henrika@webrtc.org
TEST=build on Lion, trybots
Review URL: https://webrtc-codereview.appspot.com/583005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2261 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-18 19:02:42 +00:00
leozwang@webrtc.org
e3ba738ba3 Set OpenGL as the default renderer 
Description:
This cl sets OpenGL as the default renderer which is widely used and should
be test first

BUG=
TEST=test on android
Review URL: https://webrtc-codereview.appspot.com/573007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2260 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-18 17:07:49 +00:00
leozwang@webrtc.org
ada5db4e75 Enable aecm neon optimized code in android build 
Description:
This CL is a follow up of http://review.webrtc.org/575008/ and r2241.
Because of r2243, r2241 is messed up and reverted, I'm going to commit it again.
This is exact same to the last patch in 575008, just want to inform you and have
your double check before I commit it.

The original description
This cl enables cpu detection and aecm optimized code in android build.

BUG=
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/568006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2259 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-18 16:48:45 +00:00
phoglund@webrtc.org
1ad477de3e Added a bit flip fuzz test to the voice engine. 
Extracted encryption classes to a new test library.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/564009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2256 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-18 08:02:37 +00:00
leozwang@webrtc.org
00c07e66a7 Fix a random crash because of NULL point 
Description:
This cl fixes NULL point crash problem which was not detected runtime.
Also, small reformats are added too.

BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/579009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2254 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-16 16:57:28 +00:00
leozwang@webrtc.org
4d7d23cde4 Refactor OpenGL Code 
Description:
This CL refactored OpenGL java code. Most of code referenced sample code.
And bug-fix and reformats are added into this cl too.

BUG=
TEST=build and test on android
Review URL: https://webrtc-codereview.appspot.com/583004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2253 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-16 16:57:15 +00:00
hta@webrtc.org
3a698651d7 Coverity issue 14317 (uninitialized status may influence execution flow) 
Solution: restructure the flow when AquireSocket fails

BUG=coverity:14317
TEST=trybot

Review URL: https://webrtc-codereview.appspot.com/573006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2252 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-16 14:28:52 +00:00
kjellander@webrtc.org
7e4a72a78a Revert 2241 - Enable aecm neon optimized code in android build 
Description:
This cl enables cpu detection and aecm optimized code in android build.

BUG=
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/575008

TBR=leozwang@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/566013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2249 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-16 11:49:45 +00:00
kjellander@webrtc.org
0290a7a827 Revert 2243 - Re-enable embedding svn revision into code 
Description:
By using a python scription, this cl tries to get svn revision properly. It
current support git-svn and svn, if it fails, "n/a" will be defined as
svn revision.


BUG=500
TEST= test cases: w/o svn, w/o git-svn. test platforms, linux/windows. Passed all trybots.
Review URL: https://webrtc-codereview.appspot.com/564010

TBR=leozwang@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/577008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2248 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-16 11:39:14 +00:00
hta@webrtc.org
d429086f62 Deleted udp_socket_windows and all references to it. 
This fixes a couple of Coverity issues, and doesn't impact any tested
platforms.

BUG=Coverity:14423
TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/564012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2247 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-16 09:32:14 +00:00
tina.legrand@webrtc.org
86da94ea69 Remove functions for unregistering decoder 
This cl removes unused functions in the ACMGenericCodec class.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/568005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2245 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-16 07:11:53 +00:00
leozwang@webrtc.org
d2d54c72b6 Improve WebRTCDemo 
Description:
This cl basically bring video and audio alive and add couple features to
existing demo application,
1. Remove "stats" tab, add on screen stats display
2. Add a button to select surfaceview or opengl render
Also some reformat and minor bug-fixes are included

BUG=
TEST=build on android
Review URL: https://webrtc-codereview.appspot.com/579010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2244 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-16 03:18:23 +00:00
leozwang@webrtc.org
f6e27f5e03 Re-enable embedding svn revision into code 
Description:
By using a python scription, this cl tries to get svn revision properly. It
current support git-svn and svn, if it fails, "n/a" will be defined as
svn revision.


BUG=500
TEST= test cases: w/o svn, w/o git-svn. test platforms, linux/windows. Passed all trybots.
Review URL: https://webrtc-codereview.appspot.com/564010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2243 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-15 19:25:37 +00:00
kma@webrtc.org
f1ccdb9fb5 Aligned video buffer to 32 bytes boundary, when using vpx_img_alloc() in vp8. 
Review URL: https://webrtc-codereview.appspot.com/570009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2242 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-15 18:16:46 +00:00
leozwang@webrtc.org
fe742200d5 Enable aecm neon optimized code in android build 
Description:
This cl enables cpu detection and aecm optimized code in android build.

BUG=
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/575008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2241 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-15 16:11:24 +00:00
marpan@webrtc.org
cf2cd7e4c4 Enable VP8 deblocker. 
Review URL: https://webrtc-codereview.appspot.com/569011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2237 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-14 16:50:36 +00:00
hta@webrtc.org
93116ba4fc Added an unittest for udp_socket_wrapper. 
This involves checking what the reasonable call sequences for deleting a
socket is; documented the API for this by making the destructor protected.
Checked out that the behaviour of undeleted sockets is inconsistent across
platforms, and changed the udp_socket_manager_unittest accordingly.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/578007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2236 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-14 16:03:37 +00:00
kma@webrtc.org
4e7840d943 Revert 2233 - Aligned video buffer to 32 bytes boundary, when using vpx_img_alloc() in vp8. 
M    vp8.cc



TBR=kma@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/579013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2234 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-11 18:16:35 +00:00
kma@webrtc.org
6d47c08e14 Aligned video buffer to 32 bytes boundary, when using vpx_img_alloc() in vp8. 
M    vp8.cc



git-svn-id: http://webrtc.googlecode.com/svn/trunk@2233 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-11 17:29:59 +00:00
pwestin@webrtc.org
2853dde520 Refactor the internal API to the rtp/rtcp module. 
Combination of previous CLs in revisions 2211, 2212, 2214, 2215, 2216.
Review URL: https://webrtc-codereview.appspot.com/570008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2231 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-11 11:08:54 +00:00
phoglund@webrtc.org
5dbe568417 Disabled flaky tests. Standard tests will no longer run within extended tests. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/578006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2230 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-11 08:59:11 +00:00
bjornv@webrtc.org
61d0745e86 Resolve coverity warnings. 
14050, 14051, 14243, 14314

In APM:
- Uninitialized variable initialized.
- NULL pointer sanity checks corrected.

Tested with trybots and audioproc_unittest.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/571009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2229 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-11 07:51:44 +00:00
phoglund@webrtc.org
7eadad6d95 Fixed valgrind errors so the fuzz test can be run under valgrind. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/576008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2228 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-11 07:36:53 +00:00
turaj@webrtc.org
3c383abd27 Revert 2211 - Refactor the internal API to the rtp/rtcp module. 
Review URL: https://webrtc-codereview.appspot.com/568004

A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/563011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2226 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 23:01:04 +00:00
turaj@webrtc.org
980d6be535 Revert 2212 - Bug fix 
Review URL: https://webrtc-codereview.appspot.com/576009

A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/575009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2225 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 22:57:21 +00:00
turaj@webrtc.org
449b525453 Revert 2214 - Bugfix 
A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

TBR
Review URL: https://webrtc-codereview.appspot.com/570007

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/571010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2223 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 22:54:39 +00:00
turaj@webrtc.org
f02ee061ab Revert 2215 - Fixed destroy order. 
A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

TBR
Review URL: https://webrtc-codereview.appspot.com/564007

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/562008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2222 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 22:53:33 +00:00
turaj@webrtc.org
f448ccd16c Revert 2216 - Fix for receive only channels. 
A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.

TBR
Review URL: https://webrtc-codereview.appspot.com/564008

TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/579011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2221 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 22:52:19 +00:00
leozwang@webrtc.org
8aaf31d14f Create makefile for video engine 
Description:
This build.xml will enable video engine build on android by ant. As we discussed before,
in order to make video engine build based on current webrtc file structure which is not
normal, I created this customized build.xml which is based on build.xml in android SDK.

BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/571008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2219 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 18:16:27 +00:00
leozwang@webrtc.org
f29d3fa177 Fix vp8 complexity parameter on android 
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/575007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2217 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 18:12:01 +00:00
pwestin@webrtc.org
a69634aa92 Fix for receive only channels. 
TBR
Review URL: https://webrtc-codereview.appspot.com/564008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2216 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 16:17:05 +00:00
pwestin@webrtc.org
c309c7c52b Fixed destroy order. 
TBR
Review URL: https://webrtc-codereview.appspot.com/564007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2215 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 15:49:45 +00:00
pwestin@webrtc.org
fd3fef514b Bugfix 
TBR
Review URL: https://webrtc-codereview.appspot.com/570007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2214 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 15:14:41 +00:00
pwestin@webrtc.org
e1c97a2723 Bug fix 
Review URL: https://webrtc-codereview.appspot.com/576009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2212 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 13:55:23 +00:00
pwestin@webrtc.org
0774838f3d Refactor the internal API to the rtp/rtcp module. 
Review URL: https://webrtc-codereview.appspot.com/568004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2211 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 12:33:50 +00:00
bjornv@webrtc.org
cd54e56d72 Delay estimation performance test. 
Added a test to verify estimation performance. Tested with audioproc_unittest and trybots.

BUG=issue435
TEST=None

Review URL: https://webrtc-codereview.appspot.com/569006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2209 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-10 07:41:23 +00:00
andrew@webrtc.org
270e9db039 Clarify the impact of disabling VAD on DTX. 
TBR=henrika@webrtc.org
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/566009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2207 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-09 19:09:03 +00:00
leozwang@webrtc.org
b213cd55ef Remove bitmap implementation from surfaceview render 
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/571004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2205 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-09 18:24:39 +00:00
leozwang@webrtc.org
de6a6b40fa Rename ViEAndroidDemo to WebRTCDemo 
Desription:
This CL will change VideoEngine application name to ViEAndroidDemo. This
is the first step to refactor videoengine test application on android.

"ViE" is not a proper name because the app also supports audio. And it's good
to put WebRTC in application name.

BUG=
TEST=build on all trybots
Review URL: https://webrtc-codereview.appspot.com/576006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2204 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-09 15:23:52 +00:00
niklas.enbom@webrtc.org
f6edfeff63 Adding one parameter to typing detection tuning 
Review URL: https://webrtc-codereview.appspot.com/569009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2203 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-09 13:16:12 +00:00
leozwang@webrtc.org
9f49af9cea Add libbitrate_controller which is introduced recently 
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/571007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2202 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-09 04:46:24 +00:00
leozwang@webrtc.org
d63cf71413 Fix broken build because gyp doesn't filter out platform specific file with suffixes of .c 
BUG=
TEST=test on all trybots, failed only on win_rel for weird error.
Review URL: https://webrtc-codereview.appspot.com/563009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2200 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 21:33:04 +00:00
andrew@webrtc.org
710eac763a Update DEPS comment and remove tabs from common.gypi. 
TBR=wu@webrtc.org
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/575005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2198 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 18:00:57 +00:00
andrew@webrtc.org
22f6f85fcc Remove redundant initialization. 
TBR=xians@webrtc.org
BUG=6140661
TEST=build on Linux

Review URL: https://webrtc-codereview.appspot.com/576005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2197 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 17:18:28 +00:00
andrew@webrtc.org
e59a0aca6a Fix AudioFrame types. 
volume_ is not set anywhere so I'm removing it.

BUG=
TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/556004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2196 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 17:12:40 +00:00
leozwang@webrtc.org
f5fe1000de Enable cpu auto detection and ns optimized code on android 
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/547006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2195 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 15:20:02 +00:00
hta@webrtc.org
9cc186405f Removed CleanUp call in Windows, since I couldn't find a call to it. 
This solves Coverity issue 14424 by deleting the code.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/579005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2194 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 11:40:06 +00:00
mflodman@webrtc.org
e553031580 Refactore base, Capture, Codec and Custom Call parts of autotest. The CL doesn't contain any real functional changes, only style changes, cast changes and changing reference to pointer as input argument to functions. 
Custome call still doesn't pass cpplint, but I'll take that in another CL to not change the structure in the style change CL.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/523001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2193 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 10:38:36 +00:00
braveyao@webrtc.org
113f851cc3 Merge Chromium issue 95797 into WebRTC. 
Bug = 450
Test = Manual test
Review URL: https://webrtc-codereview.appspot.com/551004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2192 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 09:28:39 +00:00
pwestin@webrtc.org
7415f371ac Revert VP8 Deblocker. 
Review URL: https://webrtc-codereview.appspot.com/563007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2191 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 09:06:31 +00:00
pwestin@webrtc.org
5019c9583c Enable VP8 deblocker. 
Review URL: https://webrtc-codereview.appspot.com/578004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2190 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 08:40:28 +00:00
andrew@webrtc.org
589673f1cb Fix volume setting while not playing on PulseAudio. 
We now only set the volume when starting playout if the user has called
SetSpeakerVolume while we weren't playing. This now also ensures it will
actually get set to what the user requested rather than being overridden
by a default value.

Add tests to voe_auto_test.

BUG=6140661
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/566006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2188 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-07 21:42:49 +00:00
leozwang@webrtc.org
20a05cd778 Disable WEBRTC_SVNREVISION 
Description:
This CL will temporally define WEBRTC_SVNREVISION as "n/a" because it
could break Chromium if svn is not installed.
The long term solution is a have a script that could deal with it, and
have it support git-svn which is used by most developers.

BUG=496
TEST=build on Linux
Review URL: https://webrtc-codereview.appspot.com/569007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2187 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-07 21:16:33 +00:00
turaj@webrtc.org
fe4cfa7e5e Hi Tina, 
I have uploaded this patch for your review. I have done an extensive test to be sure that removing of tables does not create any problem. 

The test file, is called test_lpc.c which requires a hack to standard iSAC. The test computes LPC coefficients, then encodes and decodes with old and new (size-reduced) tables. It compares the results is all steps. I have ran the test over large set of files, more then 51 hours of audio, and there was no error. 

I tried to do no formatting so the review to be easier, but I know it can be a tricky CL. Hopefully, the test file helps you to be more confident on the CL. 

Thanks,... Turaj  

In this change list the LPC tables associated with mode 1 & 2 are remoded, and necessary cahnges are made to other files. 

The only model allowed is model number 0. Therefore, this CL breaks compatibility with iSAC released prior to 2.4.3. To avoid changing the bit-stream, we still keep the model number in the bit-stream. 

entropy_coding.c is cleaned up, especially encoding of LAR had KLT transform of LPC gains which are removed now. 
Review URL: https://webrtc-codereview.appspot.com/548004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2186 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-07 20:36:22 +00:00
leozwang@webrtc.org
d46fe7034b Two bug fixs in android surface render 
Descritption:
This CL addresses two issues in android surface view render,
1. Uninitlized class members _javaByteBufferObj and _directBuffer which
   could cause crash.
2. Using ConvertI420ToRGB565. We should use high level libyuv apis
   to help libyuv maintainer.

BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/566005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2185 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-07 20:29:43 +00:00
braveyao@webrtc.org
ba0f9fe10b Trival fix to voe_auto_test according to the main source codes 
BUG = NULL
TEST = voe_auto_test
Review URL: https://webrtc-codereview.appspot.com/554004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2184 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-07 10:06:43 +00:00
phoglund@webrtc.org
f5657efd31 Rolled back r2177 since it breaks vie_auto_test. 
I'm not sure what is the right thing to do here. That would probably be to call Release() the right amount of times and ensuring that the last call returns 0 (e.g. all references have been released), but I'll leave it up to the CL author to investigate that.

TBR=elham@webrtc.org
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/569005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2183 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-07 07:59:32 +00:00
andrew@webrtc.org
07bf9a07f5 Add test to verify identical input channels result in identical output channels. 
BUG=issue411
TEST=audioproc_unittest, trybots

Review URL: https://webrtc-codereview.appspot.com/553009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2182 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-05 00:32:00 +00:00
leozwang@webrtc.org
329fcbba29 Reduce PSNR because I420ToARGB888 return lowers number on windows 
TBR=stefan, marpan

BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/562005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2178 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-04 21:31:22 +00:00
elham@webrtc.org
c2f8832a32 Fix for FileTest failure in vie_auto_test 
Review URL: https://webrtc-codereview.appspot.com/570004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2177 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-04 21:17:30 +00:00
leozwang@webrtc.org
1ea25b4c3d Change PSNR for I420ToARGB888 and I420ToRGB565 
TBR=stefan, marpan

BUG=
TEST=test on linux
Review URL: https://webrtc-codereview.appspot.com/569004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2176 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-04 17:55:57 +00:00
leozwang@webrtc.org
83958dfe06 Add ARGB and RGB565 unit test 
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/563004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2175 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-04 17:07:45 +00:00
leozwang@webrtc.org
3ebff4c2e9 Add ConvertToARGB and enable RGB565 
Review URL: https://webrtc-codereview.appspot.com/566004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2174 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-04 17:07:30 +00:00
leozwang@webrtc.org
e62fec2285 Bug fix and refactor video capture code on android 
BUG=
TEST=test on android
Review URL: https://webrtc-codereview.appspot.com/541009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2173 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-04 17:06:32 +00:00
hta@webrtc.org
b6f2417f37 Renamed all _test.cc files to _unittest.cc, to conform to convention 
for webrtc.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/560004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2172 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-04 08:13:57 +00:00
leozwang@webrtc.org
8b6f749b0a Rewrite makefile to link with stl statically 
By doing this way, webrtc.so doesn't depend on stlport_shared

BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/546005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2170 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-03 16:07:15 +00:00
hta@webrtc.org
54536bb6d4 Refactoring of the TMMBRSet class, giving it a reasonably tight interface. 
The CL also fixes a number of line length and tab issues in touched files.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/553005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2168 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-03 14:07:23 +00:00
pwestin@webrtc.org
3bc38c86e8 Fix color enhancement test. 
Review URL: https://webrtc-codereview.appspot.com/553007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2167 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-03 13:15:35 +00:00
pwestin@webrtc.org
209442a560 Missing file 
Review URL: https://webrtc-codereview.appspot.com/556005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2166 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-03 11:36:06 +00:00
pwestin@webrtc.org
e9727cdbaa Fixed some memory leaks. 
Review URL: https://webrtc-codereview.appspot.com/558004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2165 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-03 11:32:25 +00:00
andrew@webrtc.org
63a509858d Rename AudioFrame members. 
BUG=
TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/542005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2164 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-02 23:56:37 +00:00
leozwang@webrtc.org
7fdb909339 Reformat and add more debug info into ViESurfaceRenderer 
BUG=
TEST=test on android
Review URL: https://webrtc-codereview.appspot.com/546004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2163 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-02 16:45:55 +00:00
bjornv@webrtc.org
b286bfb13e VAD refactoring: Replaced hard coded array sizes with enum. 
Further replaced hard coded calculations with a for loop for better understanding.

Tested with vad_unittests and audioproc_unittest.

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/519002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2162 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-02 12:14:57 +00:00
hta@webrtc.org
404843e6e5 Timeout tests for TMMBR 
Added a test that injects 3 packets and then times out.

Rewrote the packet construction in test to use a builder format.
This makes tests a lot more readable.

Odd behaviour of timeout found; documented as test.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/553004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2161 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-02 09:56:45 +00:00
hta@webrtc.org
3c0df7d376 Fixed a build break: I'd forgotten to remove a DELETE statement. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/555004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2160 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-02 08:22:21 +00:00
hta@webrtc.org
47059b5dfb Adds unit tests for RTCP receiver, focusing on TMMBR handling. 
This is the first part of a plan:

- Get basic unit tests for rtcp_receiver.
- Get an unit test for some code inside rtcp_receiver
  that touches the TMMBRSet class in hard-to-decipher ways
  (rtcp_receiver_help, GetTMMBRSet function, use of memmove()).
- Refactor the TMMBRSet class.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/547005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2159 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-02 07:46:22 +00:00
phoglund@webrtc.org
719dba7e79 Further cleaned up voe_standard_test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/522003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2157 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-02 07:32:37 +00:00
andrew@webrtc.org
ecac9b721e Add tests for downmixing and no processing. 
BUG=issue419
TEST=audioproc_unittest

Review URL: https://webrtc-codereview.appspot.com/532001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2154 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-02 00:04:10 +00:00
leozwang@webrtc.org
63ea5ef5da Regenerate jni files and bring audio alive 
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/550004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2153 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-01 22:13:49 +00:00
andrew@webrtc.org
d5548f5d04 Disable clang Chrome plugins on all platforms. 
(Will fix Linux-clang bot).

TBR=wu@webrtc.org
BUG=issue163
TEST=build on Linux-clang

Review URL: https://webrtc-codereview.appspot.com/545005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2152 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-01 21:39:34 +00:00
leozwang@webrtc.org
85b089a0ca Fix ConvertI420ToRGB565 bug 
BUG=
TEST=test on android
Review URL: https://webrtc-codereview.appspot.com/541005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2150 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-30 17:59:08 +00:00
leozwang@webrtc.org
e7ac5fde72 Minor changes to remove dead code in opensl es 
BUG=
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/539004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2149 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-30 14:42:17 +00:00
hta@webrtc.org
65a4e4ed56 Minor refactoring: RTCPReceiver::BoundingSet 
Remove ability to modify a pointer argument.

Added a test for transmitting a non-empty TMMBN

BUG=
TEST=unittest

Review URL: https://webrtc-codereview.appspot.com/542004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2148 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-30 11:23:41 +00:00
hta@webrtc.org
c2d985257b untabify 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2145 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-30 08:25:10 +00:00
hta@webrtc.org
9d54cd12ab TMMBN sender test passes, fixed receiver flag bug 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2144 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-30 08:24:55 +00:00
andrew@webrtc.org
5c0c18d823 Fix coverity issues in ACM. 
Fixes: Big parameter passed by value (PASS_BY_VALUE)
Passing parameter codec of size 52 bytes by value.

BUG=
TEST=audio_coding_module_tests, trybots

Review URL: https://webrtc-codereview.appspot.com/529002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2142 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-27 17:06:48 +00:00
andrew@webrtc.org
a88cb6fce0 Add HighPassFilter and StereoChannelSwapping tests. 
BUG=issue451
TEST=voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/531001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2141 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-27 17:00:20 +00:00
marpan@webrtc.org
2d0223286b VPM: fix to coverity issues 10255-10258 (unintended sign extension). 
Review URL: https://webrtc-codereview.appspot.com/532002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2140 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-27 15:56:02 +00:00
phoglund@webrtc.org
ca08c41701 Replacing virtual camera on linux video bot: adaptings tests accordingly. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/537001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2139 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-27 12:38:17 +00:00
pwestin@webrtc.org
b1313aac7c Fix missing h file change. 
Review URL: https://webrtc-codereview.appspot.com/535001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2136 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-27 05:42:05 +00:00
pwestin@webrtc.org
49888ce428 Breaking out send side bitrate controll cont. 
Review URL: https://webrtc-codereview.appspot.com/475004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2135 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-27 05:25:53 +00:00
mallinath@webrtc.org
e611619f60 Fixing the header file path in gypi file. 
BUG=473
Review URL: https://webrtc-codereview.appspot.com/529001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2134 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-26 23:03:15 +00:00
andrew@webrtc.org
9c4f6a5ff9 Add an AudioFrameOperations unittest. 
Additionally, reformat audio_frame_operations to Goog style.

BUG=issue451
TEST=voice_engine_unittests

Review URL: https://webrtc-codereview.appspot.com/528001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2133 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-26 22:32:03 +00:00
tommi@webrtc.org
e49d908baf Fix how we were using TbInterfaces and disallow operator=() and the copy constructor. 
The reason is that this will cause a crash:

TbInterfaces foo = TbInterfaces("blah");


It relies on the generated copy constructor (or assignment operator), which copies the
pointer values from a temporary object.  After |foo| in this case has been initialized
with values from the temporary object, the temp goes out of scope and is deleted.
The result is that |foo| has been initialized with pointers do a deleted object.

Also fixing expectations for the return value of VoE Release() calls after I checked
in my change that makes the VoiceEngine per-object ref counted and not per-interface.
Review URL: https://webrtc-codereview.appspot.com/509005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2128 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-26 17:05:32 +00:00
tommi@webrtc.org
a990e122c4 * Change the reference counting implementation for VoE to be per object and 
not per interface. This simplifies things a bit, reduces code and makes it
  possible to implement reference counting (if we ever want) without the
  static Delete() method.  (Reference counted objects are traditionally
  implicitly deleted via the last Release())

* Since the reference counting code is now simpler, there's no need for the
  RefCount class so I'm removing it.

* Also removing the optional |ignoreRefCounters| variable from the VoiceEngine::Delete
  method.  The justification is that it's no longer used and the reason it was there
  in the first place was to avoid bugs in third party code, so it's an indication that
  something is wrong elsewhere.

* Fix a crash in voe_network_impl and voe_extended_test that would happen on machines with IPv6 support.

* Fix an assert (handle the case) in the extended audio tests when SetCNAME is called with a NULL pointer.

* As a side effect of this change, hopefully the footprint of VoE will be slightly smaller :)

BUG=10445 (Coverity)
Review URL: https://webrtc-codereview.appspot.com/521003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2127 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-26 15:28:22 +00:00
phoglund@webrtc.org
497fb4fda9 Fixed vie_auto_test on mac so it will exit when the test completes instead of hanging like it used to. 
Also applied an old patch I had which rewrites the window handling to do ui stuff on the main thread instead of the worker thread, which as far as I know is a very bad idea.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/502001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2126 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-26 12:58:02 +00:00
tina.legrand@webrtc.org
bc1b43b297 Refactoring of audio_coding_module_impl 
First patch set: pure formatting.

Review URL: https://webrtc-codereview.appspot.com/522001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2125 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-26 08:53:45 +00:00
tina.legrand@webrtc.org
a6ecd1ebb5 Refactoring one of the ACM tests: TestStereo, to follow the style guide. 
(First patch: formatting the test file)

TEST=audio_coding_module_test

Review URL: https://webrtc-codereview.appspot.com/507001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2124 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-26 07:54:30 +00:00
mflodman@webrtc.org
1868780c81 Disabled UnremovedSocketsGetCollectedAtManagerDeletion in UdpSocketManager unittest. 
TBR= hta@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/520004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2122 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-26 06:40:00 +00:00
andrew@webrtc.org
1c7bfe02f7 Fail silently when swapping mono. 
TBR=tina.legrand@webrtc.org
BUG=issue451
TEST=forthcoming unittest

Review URL: https://webrtc-codereview.appspot.com/527003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2121 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-26 00:20:28 +00:00
hta@webrtc.org
ad929899c7 Tests for udp_socket_manager. 
These tests basically check that socket allocation does not leak memory.

BUG=
TEST=unittested, ran under valgrind.

Review URL: https://webrtc-codereview.appspot.com/519003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2118 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-25 14:06:50 +00:00
asapersson@webrtc.org
d18dd6dc7e Made OnPacketLossStatisticsUpdate function virtual (needed for ViCE). 
Review URL: https://webrtc-codereview.appspot.com/520002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2115 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-25 07:19:02 +00:00
andrew@webrtc.org
02d7174722 Add API to swap stereo channels. 
BUG=issue451
TEST=manually with voe_cmd_test, using stereo and mono codecs

Review URL: https://webrtc-codereview.appspot.com/519001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2106 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-24 19:47:00 +00:00
andrew@webrtc.org
369166a179 Add API for disabling the high pass filter. 
BUG=issue419
TEST=manually with voe_cmd_test

Review URL: https://webrtc-codereview.appspot.com/509003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2105 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-24 18:38:03 +00:00
leozwang@webrtc.org
48a5df6481 Embed svn revision number into code 
BUG=
TEST=build on linux
Review URL: https://webrtc-codereview.appspot.com/516001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2104 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-24 14:50:50 +00:00
elham@webrtc.org
5f49dba1a1 Hi Magnus, I added some of the changes that you suggested before. Let me know what you think. 
Review URL: https://webrtc-codereview.appspot.com/507004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2101 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-23 21:24:02 +00:00
andrew@webrtc.org
4e423b3b1e Handle master/slave timestamp wrap. 
BUG=issue410
TEST=neteq_unittests, audio_coding_module_test

Review URL: https://webrtc-codereview.appspot.com/506001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2098 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-23 18:59:00 +00:00
vikasmarwaha@webrtc.org
99ac3f7be5 Fixed trunacated trace problem in WebRTC. http://b.corp.google.com/issue?id=5607856 
Review URL: https://webrtc-codereview.appspot.com/508004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2096 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-23 17:04:35 +00:00
pwestin@webrtc.org
ddab60be56 Wire up pading. 
Review URL: https://webrtc-codereview.appspot.com/509002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2094 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-23 14:52:15 +00:00
bjornv@webrtc.org
11654c2344 VAD refactoring: Local variable name changes 
Changes tested with vad_unittests and audioproc_unittest

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/485004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2093 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-23 14:50:11 +00:00
mflodman@webrtc.org
5284d6e905 Minor change to trigger REMB packets in RTCP RR if there is no sending channel. 
BUG=
TEST=video_engine_core_unittest

Review URL: https://webrtc-codereview.appspot.com/508007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2092 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-23 13:22:26 +00:00
hta@webrtc.org
bf9f469a13 Lifetime management for UdpSocketManager 
Make tests use Create/Destroy *or* new/delete for UdpSocketManager.
Move responsibility for calling Destroy on UdpSocketManager from transport
destructor to transport Destroy function.

This all ends up in not leaking memory in InitializeSourcePorts test.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/512001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2091 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-23 13:19:30 +00:00
asapersson@webrtc.org
92591adc67 Fixes link issues in google3 (change by tomasl). 
Review URL: https://webrtc-codereview.appspot.com/509001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2090 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-23 13:10:55 +00:00
asapersson@webrtc.org
83ed0a4359 Try to resend next packet in nack list even if previous packet is not found. 
Review URL: https://webrtc-codereview.appspot.com/515001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2089 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-23 12:43:05 +00:00
pwestin@webrtc.org
fcbbe1f341 Removed unused callback code from video coding test. 
Review URL: https://webrtc-codereview.appspot.com/504003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2086 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-23 08:33:18 +00:00
pwestin@webrtc.org
a2cd732139 Fix for calling OnNetworkChanged too often. 
Review URL: https://webrtc-codereview.appspot.com/508006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2085 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-23 08:32:47 +00:00
marpan@webrtc.org
88ad06b999 VCM: Added condition(s) for setting FEC protection factor to zero at low bitrates. 
Review URL: https://webrtc-codereview.appspot.com/494001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2084 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-20 16:05:24 +00:00
asapersson@webrtc.org
63a34f4f29 Fix in SendPadData. Do not increase sequence number if packet is "empty" and not sent. 
Review URL: https://webrtc-codereview.appspot.com/508001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2083 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-20 13:20:27 +00:00
phoglund@webrtc.org
bb77000123 Added a virtual destructor to get the test to compile on all platforms. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/507003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2082 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-20 13:03:12 +00:00
phoglund@webrtc.org
b73f01e7fd Removed some obviously dead stuff from voe_auto_test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/495001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2081 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-20 10:59:31 +00:00
hta@webrtc.org
bbd6b561cf Memory leak fix: Deleting a factory 
Also expanded some documentation.
Bug found by Valgrind bot.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/507002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2080 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-20 09:51:26 +00:00
bjornv@webrtc.org
bcde776340 Changed Delay Estimator create call 
Unit tests updated and runs.
Change made w.r.t. issue 441.

BUG=Issue441
TEST=None

Review URL: https://webrtc-codereview.appspot.com/498001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2079 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-20 09:35:20 +00:00
hta@webrtc.org
0abe535e16 Refactored udp_transport to take socket manager as dependency injection 
This avoids having to deal with the socket manager in the unittest.

Extended tests to cover one case where sockets got allocated.

BUG=
TEST=unittest

Review URL: https://webrtc-codereview.appspot.com/496001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2078 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-20 08:23:16 +00:00
kjellander@webrtc.org
4e645ee783 Improved error message when capture device is missing. 
With this patch the test stops when it doesn't find a camera instead of crashing with a large hard-to-read stack trace.

BUG=None
TEST=vie_auto_test --automated in Debug+Release on lin, mac, win

Review URL: https://webrtc-codereview.appspot.com/497003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2077 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-20 08:10:37 +00:00
andrew@webrtc.org
b61f1fa675 Reset slave when switching to a stereo codec. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/494003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2073 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-20 01:10:14 +00:00
tommi@webrtc.org
f4c80fc6cb Switch the other android build over to android_posix.cc and not android_linux.cc. 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2070 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-19 15:41:33 +00:00
tommi@webrtc.org
9018c9f548 Fix androidndk build take two. 
TBR=xians

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2069 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-19 15:38:10 +00:00
tommi@webrtc.org
3db5cb7438 Fix AndroidNDK build. 
TBR=xians

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2068 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-19 15:29:08 +00:00
tommi@webrtc.org
3d48b09bb4 Fix android build. 
TBR=kjellander

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2067 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-19 15:07:11 +00:00
tommi@webrtc.org
e84373c38f Atomic32Wrapper -> Atomic32 
This change does the following:

* Remove the Atomic32Wrapper and AtomicImpl classes and provide the Atomic32
  implementation directly via platform specific source files.
* Move/rename/delete all source files accordingly
* The atomic value itself is now volatile. Previously it was only the pointer to
  the memory that was volatile, but not the actual value.
* No additional heap allocations are now done for the atomic value.

In a follow up cl I plan to start using Atomic32 in the RefCount class in order
to fix issues reported by Coverity.
Review URL: https://webrtc-codereview.appspot.com/490004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2065 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-19 14:28:45 +00:00
pwestin@webrtc.org
1cd1162c7a Break out of send side bandwidth estimation and controll. 
Review URL: https://webrtc-codereview.appspot.com/490010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2064 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-19 12:13:52 +00:00
pwestin@webrtc.org
b2bd1e05f8 Bugfix too many initialize for RTP module 
Review URL: https://webrtc-codereview.appspot.com/497002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2063 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-19 12:01:47 +00:00
asapersson@webrtc.org
a768970bac Parse out ssrcs in REMB message (needed for ViCE) . 
Review URL: https://webrtc-codereview.appspot.com/486003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2061 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-19 07:01:29 +00:00
tina.legrand@webrtc.org
faa0ab85d7 NetEQ stereo sync 
This CL allows NetEQ to do expand at startup, to make master and slave always go in sync. Before it could happen that master did merge, while slave performed an expand, leading to sync-problems between the channels.

Updating DEPS for new reference files for unittest.

BUG=410
TEST=neteq_unittests

Review URL: https://webrtc-codereview.appspot.com/487005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2055 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-18 17:59:53 +00:00
leozwang@webrtc.org
22082e74cb Enable iSAC_FIX on android 
BUG=
TEST=build on all platforms
Review URL: https://webrtc-codereview.appspot.com/490009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2054 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-18 16:52:00 +00:00
leozwang@webrtc.org
16f6bb35b6 Fix a minor compilation error on android 
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/479014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2053 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-18 16:49:06 +00:00
marpan@webrtc.org
efd01fd354 Removing unused code from QMVideoSettingsCallback. 
This code is not needed as of the change in r1950.
Review URL: https://webrtc-codereview.appspot.com/492010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2052 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-18 15:56:34 +00:00
bjornv@webrtc.org
4ade5506eb Delay Estimator Unit tests 
This CL includes unit tests to verify correct behavior of the delay estimator used in AEC and AECM.

Tested with audioproc_unittest

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/491009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2049 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-18 09:42:16 +00:00
bjornv@webrtc.org
2e729762c7 New _CreateBinaryDelayEstimator() and removed _history_size() 
Changed create function to match malloc() in functionality.
Removed unused function.

Tested with audioproc_unittest

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/491010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2048 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-18 08:30:29 +00:00
bjornv@webrtc.org
180f83f8e2 File name change to follow style 
A unit test should end with *_unittest.* Otherwise the test itself will be evaluated for line coverage.

Tested with audioproc_unittest

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/493008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2045 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-18 07:01:10 +00:00
andrew@webrtc.org
1bc98bc873 Remove erroneous error trace. 
It appears this trace is informational, not an error.
Discovered in a plugin log from a ChromeOS device. Just
decided to remove it.

BUG=http://code.google.com/p/chromium-os/issues/detail?id=29356
TEST=build on Linux

Review URL: https://webrtc-codereview.appspot.com/479012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2043 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-17 20:10:47 +00:00
tommi@webrtc.org
7ab51497a7 Remove usage of Atomic32Wrapper from a few places. 
In these places, it doesn't make much sense to use an atomic variable we were using
Atomic32Wrapper::operator= anyway (which does not use atomic operations).
Review URL: https://webrtc-codereview.appspot.com/492005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2042 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-17 13:33:28 +00:00
hta@webrtc.org
52c0fec34c Added UDP socket factory function to UdpTransportImpl constructor 
This is a refactoring in preparation for creating small unit tests for the
udp_transport module.

BUG=
TEST=unittest

Review URL: https://webrtc-codereview.appspot.com/482004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2041 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-17 12:39:04 +00:00
marpan@webrtc.org
3e2e7038e6 VPM: Allow for option to compute the content metrics every nth frame. 
Review URL: https://webrtc-codereview.appspot.com/492006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2034 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-16 15:58:14 +00:00
mflodman@webrtc.org
b1fbf016b5 Added timestamp logs, i.e. only tracing. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/482001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2030 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-16 12:58:49 +00:00
mflodman@webrtc.org
3c611fd4fd Removed NetEQ Test compile error. 
BUG=443
TEST=Compiles using clang version 3.1 (trunk 153589)

Review URL: https://webrtc-codereview.appspot.com/493005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2029 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-16 10:57:27 +00:00
xians@webrtc.org
aef0a61117 webrtc: OTHER_CPLUSPLUSFLAGS should be a list, not a string. 
Review URL: https://webrtc-codereview.appspot.com/492007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2028 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-16 09:57:16 +00:00
bjornv@webrtc.org
bfda85f2ee Safe handling of invalid inputs in delay_estimator. 
The delay_estimator crash on invalid create inputs when running new unit tests. This can't occur on a higher level unless corresponding enum and defines are incorrectly changed.

The create and free functions are now more like malloc() and free() in design. The complete change to that will be done in a seperate CL.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/492003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2027 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-16 07:28:29 +00:00
phoglund@webrtc.org
a36a4bb340 Disabled flaky voe tests. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/491007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2025 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-13 10:11:15 +00:00
stefan@webrtc.org
9784512bf3 Fix coverity warning and possible memory leak. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/493004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2023 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-13 07:47:05 +00:00
stefan@webrtc.org
c4892bca3d Disable libyuv MirrorTest due to crashes on Linux 32 bit. 
See http://code.google.com/p/webrtc/issues/detail?id=335 for more info.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/487003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2017 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-12 13:26:22 +00:00
mflodman@webrtc.org
a014ecc049 Changed CriticalSectionScoped constructor usage for ADM. 
Only search and replace for the input to the constructor, no other changes.

BUG=184
TEST=Compiles on all platforms.

Review URL: https://webrtc-codereview.appspot.com/483001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2015 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-12 12:15:51 +00:00
bjornv@webrtc.org
7056908774 System delay unit tests 
Added a system delay test class. Noticed I don't need the ApmTest class at all, which simplified the implementation.

Start at patch set 3. The others are not complete.

BUG=None
TEST=

Review URL: https://webrtc-codereview.appspot.com/475003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2014 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-12 12:13:50 +00:00
tina.legrand@webrtc.org
16b6b90a82 Split of stereo packets moved 
In this CL I have rewritten the way we handle stereo packets in VoE.
Before this change we split the packets in the RTP module and added two packets to ACM, one for the left channel and one for the right. This lead to timing problems caused when a different thread called RecOut in between the two calls to add stereo packet to ACM. (RecOut is called to pull audio data, decode packets, on the receiving side).

While doing the change I also took the opportunity to changed some functions so that the data stream is uint8 everywhere.

The list of files in this CL is long, but should be fairly easy to review. It is difficult to see what has been changed  in some of the tests, but I can explain offline.

Reviewers:
Björn - /src/modules/audio_coding
Patrik - /src/modules/rtp_rtcp
Patrik -/src/modules/utility
Henrik A - /src/voice_engine

BUG=410
TEST=voe_cmd_test

Review URL: https://webrtc-codereview.appspot.com/473003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2012 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-12 11:02:38 +00:00
pwestin@webrtc.org
ce33035dee Cleanup encode call. 
Review URL: https://webrtc-codereview.appspot.com/491003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2011 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-12 06:59:14 +00:00
kma@webrtc.org
33ced9cc99 Same code change from issue 428004, with uint corrected to uint32_t in WebRtcSpl_MaxAbsValueW32, for a MAC compiler error. 
Review URL: https://webrtc-codereview.appspot.com/472006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2008 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-11 17:40:40 +00:00
phoglund@webrtc.org
e1bbdb488e Rewrote external media test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/482002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2007 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-11 14:15:48 +00:00
braveyao@webrtc.org
efbdec0542 Minor fix to severl image path in vie_win_test 
BUG = NULL
TEST = Manual test with vie_win_test
Review URL: https://webrtc-codereview.appspot.com/479007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2006 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-11 10:24:18 +00:00
stefan@webrtc.org
c35f5ced92 Enable multi-frame FEC by default for temporal layers <= 2. For two temporal layers we currently only protect the base layer. 
This also introduces zero column insertion into packet masks when some sequence numbers deliberately haven't been given to the FEC generator.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/477001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2005 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-11 07:42:25 +00:00
cd@webrtc.org
85b4a1b715 Special version of 'bitrv2' when len is 128: 
* 5.5% AEC overall speedup for the straight C path.
* 8.6% AEC overall speedup for the SSE2 path.
Review URL: https://webrtc-codereview.appspot.com/480001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2004 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-10 21:25:17 +00:00
wu@webrtc.org
5d8c102899 Move those calls that may fail out of the ctor to Init function. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/491002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2003 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-10 16:54:05 +00:00
leozwang@webrtc.org
91ed80e5c3 Correct wrong trace level 
Review URL: https://webrtc-codereview.appspot.com/487002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2002 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-10 14:42:20 +00:00
tommi@webrtc.org
98ad0ff1b0 Move the COMPILE_ASSERT macro to its own header file. 
TEST=n/a
BUG=none
Review URL: https://webrtc-codereview.appspot.com/492002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2001 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-10 11:53:07 +00:00
andrew@webrtc.org
e713fd0eee Enable the "unused variable" warning on Windows. 
- Break out direct_show_base_classes to its own gyp file to have it
  treated as third party code.
- Fix the resulting warnings (courtesy of Tommi).

BUG=
TEST=build on Windows (vie_auto_test currently failing at HEAD)

Review URL: https://webrtc-codereview.appspot.com/489001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2000 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-10 07:13:46 +00:00
wu@webrtc.org
96b3017b33 When GetEncoder or SetSendCodec failed, we should clean up and return error. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/490001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1995 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-06 19:49:28 +00:00
wu@webrtc.org
78075451ed Don't return fail if the denoising is already enabled/disabled. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/488001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1994 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-06 01:01:16 +00:00
andrew@webrtc.org
231f5d0d25 Remove missing VAD file from source list. 
BUG=
TEST=gyp run on Windows and build.
TBR=bjornv@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/479003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1993 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-06 01:00:06 +00:00
phoglund@webrtc.org
a1facdcf0f Re-enabled video sync tests (new attempt). 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/478001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1992 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-05 16:59:01 +00:00
bjornv@webrtc.org
2273f325b2 VAD refactoring: Code style changes of local function. 
Changes applied to local GmmProbability():
* Replaced shift macros with shift operations
* Indentation and braces
* Removed redundant code
* Removed unnecessary type casts
* Name changes
* Adjusted comments

Tested with vad_unittests and audioproc_unittest

BUG=None
TEST=None

Review URL: https://webrtc-codereview.appspot.com/475002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1991 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-05 10:22:02 +00:00
pwestin@webrtc.org
cac787842c New attempt to cleanup TMMBR. 
Review URL: https://webrtc-codereview.appspot.com/472007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1990 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-05 08:30:10 +00:00
cd@webrtc.org
70ed0a6f91 No casting and call lower precision trigonometric functions: 
* 2.2% AEC overall speedup for the straight C path.
* 2.4% AEC overall speedup for the SSE2 path.
Review URL: https://webrtc-codereview.appspot.com/477002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1989 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-05 00:38:55 +00:00
leozwang@webrtc.org
f3dc22f7d1 Reformat android related code 
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/472004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1988 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-04 17:15:42 +00:00
tommi@webrtc.org
851becd00c Remove public virtual voe::SharedData inheritance. 
This is a fix for coverity issues: 10446, 10445, 10444, 10443.

Although the cl is rather big, there aren't many code changes:

* Instead of an implicit vtable pointer, there is now an explicit |_data| member to access the shared data.
* We don't access the member variables of SharedData directly.  There are accessors instead.
* SharedData setters that set values that must be freed, automatically free the previous value and 'addref' if required the new one.
* Lots and lots of 'rewrapping' due to search/replace after the above changes.

BUG=10446, 10445, 10444, 10443
TEST=Run all tests for VoE.
Review URL: https://webrtc-codereview.appspot.com/472009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1987 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-04 14:57:19 +00:00
pwestin@webrtc.org
ae19720982 Fixed assert strings where string literals are used as booleans. 
Review URL: https://webrtc-codereview.appspot.com/473002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1986 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-04 14:43:54 +00:00
pwestin@webrtc.org
27fe1b702e Added compile time support for direct tracing. 
Review URL: https://webrtc-codereview.appspot.com/469006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1985 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-04 08:08:30 +00:00
niklas.enbom@webrtc.org
06e722ae77 Adding parameter setting for typing detection 
Review URL: https://webrtc-codereview.appspot.com/476001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1984 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-04 07:44:27 +00:00
phoglund@webrtc.org
afc39731dc Rewrote NetEQ stats test. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/466002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1982 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-03 23:09:42 +00:00
leozwang@webrtc.org
0dc8efe6e6 Fix wrong data type in ReadWavHeader 
BUG=409
TEST=media file unit test
Review URL: https://webrtc-codereview.appspot.com/474001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1980 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-03 15:11:01 +00:00
henrika@webrtc.org
afedb637df Revert 1974 - Optimizations on several SPL min max operations in ARM, and refactoring in C. 
Touched C and assembly functions are tested with a new unit test which is not in the code base yet.
Review URL: https://webrtc-codereview.appspot.com/428004

TBR=kma@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/475001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1975 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-02 07:12:08 +00:00